@lmzhen/dsh-evolution-review 0.3.43 → 0.3.45

package/lib/index.js

@@ -22,10 +22,32 @@ const Config = z.object({
 	reviewMessageChars: z.number().min(1).default(2e3),
 	reviewMaxDepth: z.number().min(1).default(1),
 	reviewProvider: z.string(),
-	skillReviewTrigger: z.string().default(DEFAULT_SKILL_REVIEW_TRIGGER),
+	skillReviewTrigger: z.union([
+		z.const("cadence"),
+		z.const("completion"),
+		z.const("both")
+	]).default(DEFAULT_SKILL_REVIEW_TRIGGER),
 	reviewWakeInject: z.boolean().default(true),
 	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS)
 });
+/** V8-01 (0.3.45): the review subagent's structured-output contract. The
+* `subagents.start` outputSchema is RAW JSON Schema validated by
+* assertObjectJsonSchema (upstream dsh-tools json-schema.ts — SCHEMA_TYPES
+* has no 'json'; 'json' is a defineTool-author DSL-only value). The arrays
+* deliberately use `{ type: 'array' }` with NO items node — absent items
+* accepts any JSON item (upstream semantics, json-schema.ts "Item schema
+* (type: 'array' only); absent accepts any JSON item"), and plan-validator
+* owns the per-op structure proof. The whitelist contract test (review.spec
+* V8-01) forbids a DSL value slipping back in. */
+const REVIEW_OUTPUT_SCHEMA = {
+	type: "object",
+	additionalProperties: false,
+	properties: {
+		memoryOps: { type: "array" },
+		skillOps: { type: "array" },
+		summary: { type: "string" }
+	}
+};
 let statelessReviewStateWarned = false;
 /**
 * G3.1 (0.3.23): clamp the numeric review config at assembly so a 0/negative/
@@ -247,21 +269,7 @@ function apply(ctx, rawConfig) {
 				agentOptions,
 				persona: reviewPrompt(kind, "plan"),
 				toolFilter: { allow: [...config.reviewToolAllow] },
-				outputSchema: {
-					type: "object",
-					additionalProperties: false,
-					properties: {
-						memoryOps: {
-							type: "array",
-							items: { type: "json" }
-						},
-						skillOps: {
-							type: "array",
-							items: { type: "json" }
-						},
-						summary: { type: "string" }
-					}
-				}
+				outputSchema: REVIEW_OUTPUT_SCHEMA
 			});
 			try {
 				const result = await run.result;
@@ -495,6 +503,10 @@ function apply(ctx, rawConfig) {
 		turnStarts.clear();
 		cumulativeToolCalls.clear();
 		completionInjected.clear();
+		pendingCadenceReviews.clear();
+		pendingCadenceWarned.clear();
+		skipNextCadenceFire.clear();
+		cadenceResetWarned.clear();
 	}, "dsh-evolution-review.cleanup");
 }
 /** Completion-channel decision: task finished normally AND the session is proven long. */
@@ -612,4 +624,4 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 	].join("\n");
 }
 //#endregion
-export { Config, apply, clampReviewConfig, filterUnreadSkillOps, inject, name, shouldCompletionReview, sweepDeadSessionEntries };
+export { Config, REVIEW_OUTPUT_SCHEMA, apply, clampReviewConfig, filterUnreadSkillOps, inject, name, shouldCompletionReview, sweepDeadSessionEntries };

package/lib/types/index.d.ts

@@ -29,7 +29,9 @@ export interface Config {
     /** LLM provider for review subagents. Omit to inherit the deployment default route. */
     reviewProvider?: string;
     /** Skill-review trigger: cadence (interval) | completion (once after a proven-long task) | both. */
-    skillReviewTrigger?: string;
+    /** Which channel runs the end-of-conversation summary: the cadence latch
+     * ('cadence'), the long-session completion gate ('completion'), or both. */
+    skillReviewTrigger?: 'cadence' | 'completion' | 'both';
     /** Cumulative session tool calls before a session counts as proven-long for the completion channel. */
     skillReviewCompletionMinToolCalls?: number;
     /** 0.3.40: deliver the deferred review with a WAKING inject for a summary the
@@ -39,6 +41,30 @@ export interface Config {
     reviewWakeInject?: boolean;
 }
 export declare const Config: z<Config>;
+/** V8-01 (0.3.45): the review subagent's structured-output contract. The
+ * `subagents.start` outputSchema is RAW JSON Schema validated by
+ * assertObjectJsonSchema (upstream dsh-tools json-schema.ts — SCHEMA_TYPES
+ * has no 'json'; 'json' is a defineTool-author DSL-only value). The arrays
+ * deliberately use `{ type: 'array' }` with NO items node — absent items
+ * accepts any JSON item (upstream semantics, json-schema.ts "Item schema
+ * (type: 'array' only); absent accepts any JSON item"), and plan-validator
+ * owns the per-op structure proof. The whitelist contract test (review.spec
+ * V8-01) forbids a DSL value slipping back in. */
+export declare const REVIEW_OUTPUT_SCHEMA: {
+    readonly type: "object";
+    readonly additionalProperties: false;
+    readonly properties: {
+        readonly memoryOps: {
+            readonly type: "array";
+        };
+        readonly skillOps: {
+            readonly type: "array";
+        };
+        readonly summary: {
+            readonly type: "string";
+        };
+    };
+};
 /**
  * G3.1 (0.3.23): clamp the numeric review config at assembly so a 0/negative/
  * NaN/±Infinity value falls back to the package default instead of folding as a

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.43",
+  "version": "0.3.45",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.43",
-    "@lmzhen/dsh-evolution-core": "^0.3.43",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.43"
+    "@lmzhen/dsh-evolution-approval": "^0.3.45",
+    "@lmzhen/dsh-evolution-core": "^0.3.45",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.45"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.43",
-    "@lmzhen/dsh-evolution-policy": "^0.3.43"
+    "@lmzhen/dsh-evolution-state": "^0.3.45",
+    "@lmzhen/dsh-evolution-policy": "^0.3.45"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.43",
-    "@lmzhen/dsh-evolution-core": "^0.3.43",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.43",
-    "@lmzhen/dsh-evolution-state": "^0.3.43"
+    "@lmzhen/dsh-evolution-approval": "^0.3.45",
+    "@lmzhen/dsh-evolution-core": "^0.3.45",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.45",
+    "@lmzhen/dsh-evolution-state": "^0.3.45"
   }
 }