@lmzhen/dsh-evolution-review 0.3.42 → 0.3.44

package/README.md

@@ -34,3 +34,10 @@ Independent of request-prefix construction. This package does not alter the asse
 `reviewProvider` selects the LLM provider for review subagents. When omitted, the subagent inherits the deployment default route instead of a hardcoded provider name. Model selection stays on the policy (`memoryReviewModel` / `skillReviewModel`).
 
 `reviewTimeoutMs` bounds each review subagent run (an `AbortSignal.timeout`; `0` aborts immediately). `executionTimeoutMs` is a leftover declaration and is **not consumed** — it is kept only as a code comment and has no effect; configure `reviewTimeoutMs` instead.
+
+### Review delivery contract (0.3.38-0.3.42)
+
+- **Both channels execute at conversation end only** (a `turn/end` with `reason.kind === 'completed'`): a cadence threshold fire mid-task merely latches the kind — no subagent spawn, no inject. The flush runs BEFORE the latch block (the completing turn may itself be a threshold-firing turn). `reviewMode` (`'subagent'` default / `'inject'`) selects how the flush delivers; the explicit `'inject'` mode's historical "immediate on threshold" contract was superseded in 0.3.39 — both modes are end-of-conversation.
+- **`skillReviewTrigger`** (default `'cadence'`): `'cadence'` runs one end-of-conversation review from the cadence latch; `'completion'` uses the separate long-session completion gate (session-cumulative tool-call threshold); `'both'` enables both (note: with the deferred cadence execution the `'both'` combination would inject a second task-complete prompt at the same boundary — prefer `'cadence'`).
+- **`reviewWakeInject`** (default `true`): deliveries use `agent.followup` (next-turn + wake — the model starts processing immediately) instead of the non-waking `agent.inject` (which waits for the next driver wake). The host falls back to `inject` when it has no followup or the option is `false`. The woken turn's own cadence fire is suppressed once (an injected review prompt alone must not re-trigger a review under `interval=1`); a restart clears the queue, so the loop cannot survive it.
+- **Counting window = injection-to-injection**: the `turnsSinceMemory`/`turnsSinceSkill` counters are monotonic across threshold fires (`resetOnFire: false`) and are zeroed at the flush delivery — a continued conversation starts a fresh segment from the injection. A threshold fire on the completing turn is caught by the flush (`pendingKind = latch ?? kind`). All deliveries (review prompt AND result notices) share the same waking channel; a failed counter-reset persist warns once per session (a stateful reload may re-deliver).

package/lib/index.js

@@ -22,7 +22,11 @@ const Config = z.object({
 	reviewMessageChars: z.number().min(1).default(2e3),
 	reviewMaxDepth: z.number().min(1).default(1),
 	reviewProvider: z.string(),
-	skillReviewTrigger: z.string().default(DEFAULT_SKILL_REVIEW_TRIGGER),
+	skillReviewTrigger: z.union([
+		z.const("cadence"),
+		z.const("completion"),
+		z.const("both")
+	]).default(DEFAULT_SKILL_REVIEW_TRIGGER),
 	reviewWakeInject: z.boolean().default(true),
 	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS)
 });
@@ -495,6 +499,10 @@ function apply(ctx, rawConfig) {
 		turnStarts.clear();
 		cumulativeToolCalls.clear();
 		completionInjected.clear();
+		pendingCadenceReviews.clear();
+		pendingCadenceWarned.clear();
+		skipNextCadenceFire.clear();
+		cadenceResetWarned.clear();
 	}, "dsh-evolution-review.cleanup");
 }
 /** Completion-channel decision: task finished normally AND the session is proven long. */

package/lib/types/index.d.ts

@@ -29,7 +29,9 @@ export interface Config {
     /** LLM provider for review subagents. Omit to inherit the deployment default route. */
     reviewProvider?: string;
     /** Skill-review trigger: cadence (interval) | completion (once after a proven-long task) | both. */
-    skillReviewTrigger?: string;
+    /** Which channel runs the end-of-conversation summary: the cadence latch
+     * ('cadence'), the long-session completion gate ('completion'), or both. */
+    skillReviewTrigger?: 'cadence' | 'completion' | 'both';
     /** Cumulative session tool calls before a session counts as proven-long for the completion channel. */
     skillReviewCompletionMinToolCalls?: number;
     /** 0.3.40: deliver the deferred review with a WAKING inject for a summary the

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.42",
+  "version": "0.3.44",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.42",
-    "@lmzhen/dsh-evolution-core": "^0.3.42",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.42"
+    "@lmzhen/dsh-evolution-approval": "^0.3.44",
+    "@lmzhen/dsh-evolution-core": "^0.3.44",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.44"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.42",
-    "@lmzhen/dsh-evolution-policy": "^0.3.42"
+    "@lmzhen/dsh-evolution-state": "^0.3.44",
+    "@lmzhen/dsh-evolution-policy": "^0.3.44"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.42",
-    "@lmzhen/dsh-evolution-core": "^0.3.42",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.42",
-    "@lmzhen/dsh-evolution-state": "^0.3.42"
+    "@lmzhen/dsh-evolution-approval": "^0.3.44",
+    "@lmzhen/dsh-evolution-core": "^0.3.44",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.44",
+    "@lmzhen/dsh-evolution-state": "^0.3.44"
   }
 }