@lmzhen/dsh-evolution-review 0.3.39 → 0.3.41

package/lib/index.js

@@ -23,6 +23,7 @@ const Config = z.object({
 	reviewMaxDepth: z.number().min(1).default(1),
 	reviewProvider: z.string(),
 	skillReviewTrigger: z.string().default(DEFAULT_SKILL_REVIEW_TRIGGER),
+	reviewWakeInject: z.boolean().default(true),
 	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS)
 });
 let statelessReviewStateWarned = false;
@@ -64,18 +65,20 @@ function apply(ctx, rawConfig) {
 	const completionInjected = /* @__PURE__ */ new Set();
 	const pendingCadenceReviews = /* @__PURE__ */ new Map();
 	const pendingCadenceWarned = /* @__PURE__ */ new Set();
+	const skipNextCadenceFire = /* @__PURE__ */ new Map();
 	let reviewInFlight = false;
 	const policy = () => ctx.get("evolutionPolicy")?.get();
 	ctx.on("session/event", (session, event) => {
 		if (event.type === "turn/start") turnStarts.set(session.id, session.seq - 1);
 		if (event.type !== "turn/end") return;
-		if (turnStarts.size >= COUNTER_SWEEP_THRESHOLD || cumulativeToolCalls.size >= COUNTER_SWEEP_THRESHOLD || completionInjected.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceReviews.size >= COUNTER_SWEEP_THRESHOLD) {
+		if (turnStarts.size >= COUNTER_SWEEP_THRESHOLD || cumulativeToolCalls.size >= COUNTER_SWEEP_THRESHOLD || completionInjected.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceReviews.size >= COUNTER_SWEEP_THRESHOLD || skipNextCadenceFire.size >= COUNTER_SWEEP_THRESHOLD) {
 			const isAlive = (id) => ctx.agents.get(id) !== void 0;
 			sweepDeadSessionEntries(turnStarts, isAlive);
 			sweepDeadSessionEntries(cumulativeToolCalls, isAlive);
 			sweepDeadSessionEntries(completionInjected, isAlive);
 			sweepDeadSessionEntries(pendingCadenceReviews, isAlive);
 			sweepDeadSessionEntries(pendingCadenceWarned, isAlive);
+			sweepDeadSessionEntries(skipNextCadenceFire, isAlive);
 		}
 		onTurnEnd(session, event);
 	});
@@ -109,33 +112,45 @@ function apply(ctx, rawConfig) {
 			lastTurn: -1
 		};
 		const snapshot = policy();
-		const kind = advanceReview(state, event.data.turn, signal, {
+		const skipFire = skipNextCadenceFire.get(session.id) ?? false;
+		if (skipFire) skipNextCadenceFire.delete(session.id);
+		const rawKind = advanceReview(state, event.data.turn, signal, {
 			memoryInterval: snapshot?.reviewMemoryInterval ?? config.memoryInterval,
 			skillInterval: snapshot?.reviewSkillInterval ?? config.skillInterval,
 			substantiveMinToolCalls: snapshot?.substantiveMinToolCalls ?? 3,
 			substantiveMinUserChars: snapshot?.substantiveMinUserChars ?? 200,
-			substantiveMinAgentChars: snapshot?.substantiveMinAgentChars ?? 500
+			substantiveMinAgentChars: snapshot?.substantiveMinAgentChars ?? 500,
+			resetOnFire: false
 		});
+		const kind = skipFire ? null : rawKind;
 		await stateService?.saveReviewState(session.id, state);
 		const cumulative = (cumulativeToolCalls.get(session.id) ?? 0) + signal.toolCalls;
 		cumulativeToolCalls.set(session.id, cumulative);
+		const deliverReview = (text) => {
+			const message = createUserMessage({
+				content: [{
+					type: "text",
+					text
+				}],
+				source: {
+					kind: "plugin",
+					plugin: "dsh-evolution-review",
+					form: "notice",
+					summary: "auto-review"
+				}
+			});
+			const followup = agent.followup;
+			if (config.reviewWakeInject && typeof followup === "function") {
+				followup(message);
+				skipNextCadenceFire.set(session.id, true);
+			} else agent.inject(message);
+		};
 		if (event.data.reason.kind === "completed") {
-			const pendingKind = pendingCadenceReviews.get(session.id);
+			const pendingKind = pendingCadenceReviews.get(session.id) ?? kind ?? void 0;
 			if (pendingKind !== void 0) {
 				pendingCadenceReviews.delete(session.id);
 				if ((policy()?.reviewMode ?? config.reviewMode) === "inject") try {
-					agent.inject(createUserMessage({
-						content: [{
-							type: "text",
-							text: reviewPrompt(pendingKind)
-						}],
-						source: {
-							kind: "plugin",
-							plugin: "dsh-evolution-review",
-							form: "notice",
-							summary: "auto-review"
-						}
-					}));
+					deliverReview(reviewPrompt(pendingKind));
 				} catch (injectError) {
 					ctx.logger.warn(`dsh-evolution-review: deferred review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
 				}
@@ -147,24 +162,16 @@ function apply(ctx, rawConfig) {
 					assistantChars: signal.assistantChars
 				});
 				else try {
-					agent.inject(createUserMessage({
-						content: [{
-							type: "text",
-							text: reviewPrompt(pendingKind)
-						}],
-						source: {
-							kind: "plugin",
-							plugin: "dsh-evolution-review",
-							form: "notice",
-							summary: "auto-review"
-						}
-					}));
+					deliverReview(reviewPrompt(pendingKind));
 				} catch (injectError) {
 					ctx.logger.warn(`dsh-evolution-review: deferred review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
 				}
+				state.turnsSinceMemory = 0;
+				state.turnsSinceSkill = 0;
+				await stateService?.saveReviewState(session.id, state);
 			}
 		}
-		if (kind) {
+		if (kind && event.data.reason.kind !== "completed") {
 			pendingCadenceReviews.set(session.id, kind);
 			if (!pendingCadenceWarned.has(session.id)) {
 				pendingCadenceWarned.add(session.id);
@@ -267,7 +274,7 @@ function apply(ctx, rawConfig) {
 				});
 				const acceptedSkillOps = validation.accepted.skillOps ?? [];
 				const skippedUnread = filterUnreadSkillOps(acceptedSkillOps, new Set([...collectReadSkillNames(session), ...childReads]));
-				const executed = await executePlan(validation.accepted, session.id);
+				const executed = await executePlan(validation.accepted, session);
 				const actions = executed.actions;
 				const evidenceQuotes = [...validation.accepted.memoryOps ?? [], ...acceptedSkillOps].reduce((total, op) => total + (Array.isArray(op.evidence) ? op.evidence.length : 0), 0);
 				if (actions.length > 0) {
@@ -345,7 +352,8 @@ function apply(ctx, rawConfig) {
 			reviewInFlight = false;
 		}
 	}
-	async function executePlan(plan, sessionId) {
+	async function executePlan(plan, session) {
+		const sessionId = session?.id;
 		const memory = ctx.get("memory");
 		const approval = ctx.get("evolutionApproval");
 		const origins = resolveOrigins(void 0, true);
@@ -361,7 +369,7 @@ function apply(ctx, rawConfig) {
 					facts: op.facts ?? op.content,
 					old_text: op.old_text
 				};
-				const result = approval ? await runApproved("memory", `memory ${normalized.target} ${normalized.action}`, normalized, normalized) : await memory?.applyBatch(normalized.target, [normalized]);
+				const result = approval ? await runApproved("memory", `memory ${normalized.target} ${normalized.action}`, normalized, normalized, session) : await memory?.applyBatch(normalized.target, [normalized]);
 				if (result?.ok) actions.push("Memory updated");
 				else {
 					ok = false;
@@ -378,7 +386,7 @@ function apply(ctx, rawConfig) {
 					operation: args,
 					origin: origins.library
 				};
-				const result = approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillDirect(args);
+				const result = approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs, session) : await executeSkillDirect(args);
 				if (result?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
 				else {
 					ok = false;
@@ -401,7 +409,7 @@ function apply(ctx, rawConfig) {
 				aborted: reason
 			};
 		}
-		async function runApproved(kind, summary, stored, runnerArgs) {
+		async function runApproved(kind, summary, stored, runnerArgs, approvalSession) {
 			if (!approval) return void 0;
 			if (approval.isEnabled === true && !approval.hasRunner(kind)) {
 				ctx.logger.warn(`dsh-evolution-review: approval enabled but no replay runner registered for kind "${kind}" - skipping write (${summary})`);
@@ -415,7 +423,8 @@ function apply(ctx, rawConfig) {
 				summary,
 				args: stored,
 				origin: origins.approval,
-				...sessionId ? { sessionId } : {}
+				...sessionId ? { sessionId } : {},
+				...approvalSession ? { session: approvalSession } : {}
 			});
 			if (decision.action === "staged") return {
 				ok: false,

package/lib/types/index.d.ts

@@ -32,6 +32,11 @@ export interface Config {
     skillReviewTrigger?: string;
     /** Cumulative session tool calls before a session counts as proven-long for the completion channel. */
     skillReviewCompletionMinToolCalls?: number;
+    /** 0.3.40: deliver the deferred review with a WAKING inject for a summary the
+     * model starts immediately (agent.followup — same send() queue, wakeup bit
+     * differs). Default true; false degrades to the non-waking inject (the
+     * summary then waits for the next driver wake). */
+    reviewWakeInject?: boolean;
 }
 export declare const Config: z<Config>;
 /**

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.39",
+  "version": "0.3.41",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.39",
-    "@lmzhen/dsh-evolution-core": "^0.3.39",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.39"
+    "@lmzhen/dsh-evolution-approval": "^0.3.41",
+    "@lmzhen/dsh-evolution-core": "^0.3.41",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.41"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.39",
-    "@lmzhen/dsh-evolution-policy": "^0.3.39"
+    "@lmzhen/dsh-evolution-state": "^0.3.41",
+    "@lmzhen/dsh-evolution-policy": "^0.3.41"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.39",
-    "@lmzhen/dsh-evolution-core": "^0.3.39",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.39",
-    "@lmzhen/dsh-evolution-state": "^0.3.39"
+    "@lmzhen/dsh-evolution-approval": "^0.3.41",
+    "@lmzhen/dsh-evolution-core": "^0.3.41",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.41",
+    "@lmzhen/dsh-evolution-state": "^0.3.41"
   }
 }