@lmzhen/dsh-evolution-review 0.3.29 → 0.3.31

package/lib/index.js

@@ -207,7 +207,11 @@ function apply(ctx, rawConfig) {
 			try {
 				const result = await run.result;
 				if (!result.structured) {
-					ctx.emit("evolution/review-error", { sessionId: session.id });
+					try {
+						ctx.emit("evolution/review-error", { sessionId: session.id });
+					} catch (emitError) {
+						ctx.logger.warn(`dsh-evolution-review: review-error emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
+					}
 					ctx.logger.warn("dsh-evolution-review: review subagent returned no structured plan");
 					return false;
 				}
@@ -247,16 +251,23 @@ function apply(ctx, rawConfig) {
 						ctx.logger.warn(`dsh-evolution-review: result notice inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
 					}
 				}
-				ctx.emit("evolution/plan-applied", {
-					sessionId: session.id,
-					planId: randomUUID(),
-					policyFingerprint,
-					memoryApplied: actions.filter((action) => action.startsWith("Memory")).length,
-					skillApplied: actions.filter((action) => action.startsWith("Skill ")).length,
-					rejectedOps: validation.rejected.length + skippedUnread,
-					evidenceQuotes,
-					estimatedInputChars: reviewText.length
-				});
+				try {
+					ctx.emit("evolution/plan-applied", {
+						sessionId: session.id,
+						planId: randomUUID(),
+						policyFingerprint,
+						memoryApplied: actions.filter((action) => action.startsWith("Memory")).length,
+						skillApplied: actions.filter((action) => action.startsWith("Skill ")).length,
+						rejectedOps: validation.rejected.length + skippedUnread,
+						executionFailures: executed.failedOps.length,
+						...executed.aborted !== void 0 ? { executionError: executed.aborted } : {},
+						...executed.failedOps[0] !== void 0 && executed.aborted === void 0 ? { executionError: executed.failedOps[0] } : {},
+						evidenceQuotes,
+						estimatedInputChars: reviewText.length
+					});
+				} catch (emitError) {
+					ctx.logger.warn(`dsh-evolution-review: plan-applied emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
+				}
 				return true;
 			} finally {
 				try {
@@ -277,6 +288,7 @@ function apply(ctx, rawConfig) {
 		const approval = ctx.get("evolutionApproval");
 		const origins = resolveOrigins(void 0, true);
 		const actions = [];
+		const failedOps = [];
 		let ok = true;
 		try {
 			for (const op of plan.memoryOps ?? []) {
@@ -287,8 +299,12 @@ function apply(ctx, rawConfig) {
 					facts: op.facts ?? op.content,
 					old_text: op.old_text
 				};
-				if ((approval ? await runApproved("memory", `memory ${normalized.target} ${normalized.action}`, normalized, normalized) : await memory?.applyBatch(normalized.target, [normalized]))?.ok) actions.push("Memory updated");
-				else ok = false;
+				const result = approval ? await runApproved("memory", `memory ${normalized.target} ${normalized.action}`, normalized, normalized) : await memory?.applyBatch(normalized.target, [normalized]);
+				if (result?.ok) actions.push("Memory updated");
+				else {
+					ok = false;
+					failedOps.push(`memory ${normalized.action} ${normalized.target}: ${result?.message ?? "service unavailable"}`);
+				}
 			}
 			for (const op of plan.skillOps ?? []) {
 				if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) continue;
@@ -300,18 +316,27 @@ function apply(ctx, rawConfig) {
 					operation: args,
 					origin: origins.library
 				};
-				if ((approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillDirect(args))?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
-				else ok = false;
+				const result = approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillDirect(args);
+				if (result?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
+				else {
+					ok = false;
+					failedOps.push(`skill ${op.action ?? "patch"} ${op.name}: ${result?.message ?? "service unavailable"}`);
+				}
 			}
+			if (failedOps.length > 0) ctx.logger.warn(`dsh-evolution-review: executePlan ${actions.length === 0 ? "no op landed" : `${actions.length} op(s) landed, ${failedOps.length} failed`}: ${failedOps.join("; ")}`);
 			return {
 				actions,
-				ok
+				ok,
+				failedOps
 			};
 		} catch (error) {
-			ctx.logger.warn(`dsh-evolution-review: executePlan aborted mid-way after ${actions.length} ops landed: ${error instanceof Error ? error.message : String(error)}`);
+			const reason = error instanceof Error ? error.message : String(error);
+			ctx.logger.warn(`dsh-evolution-review: executePlan aborted mid-way after ${actions.length} ops landed: ${reason}`);
 			return {
 				actions,
-				ok: false
+				ok: false,
+				failedOps,
+				aborted: reason
 			};
 		}
 		async function runApproved(kind, summary, stored, runnerArgs) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.29",
+  "version": "0.3.31",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.29",
-    "@lmzhen/dsh-evolution-core": "^0.3.29",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.29"
+    "@lmzhen/dsh-evolution-approval": "^0.3.31",
+    "@lmzhen/dsh-evolution-core": "^0.3.31",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.31"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.29",
-    "@lmzhen/dsh-evolution-policy": "^0.3.29"
+    "@lmzhen/dsh-evolution-state": "^0.3.31",
+    "@lmzhen/dsh-evolution-policy": "^0.3.31"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.29",
-    "@lmzhen/dsh-evolution-core": "^0.3.29",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.29",
-    "@lmzhen/dsh-evolution-state": "^0.3.29"
+    "@lmzhen/dsh-evolution-approval": "^0.3.31",
+    "@lmzhen/dsh-evolution-core": "^0.3.31",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.31",
+    "@lmzhen/dsh-evolution-state": "^0.3.31"
   }
 }