@lmzhen/dsh-evolution-review 0.3.27 → 0.3.28

package/README.md

@@ -32,3 +32,5 @@ Independent of request-prefix construction. This package does not alter the asse
 ## Configuration
 
 `reviewProvider` selects the LLM provider for review subagents. When omitted, the subagent inherits the deployment default route instead of a hardcoded provider name. Model selection stays on the policy (`memoryReviewModel` / `skillReviewModel`).
+
+`reviewTimeoutMs` bounds each review subagent run (an `AbortSignal.timeout`; `0` aborts immediately). `executionTimeoutMs` is a leftover declaration and is **not consumed** — it is kept only as a code comment and has no effect; configure `reviewTimeoutMs` instead.

package/lib/index.js

@@ -138,18 +138,24 @@ function apply(ctx, rawConfig) {
 		if (completionInjected.has(session.id)) return;
 		if (!shouldCompletionReview(event.data.reason, cumulative, config.skillReviewCompletionMinToolCalls)) return;
 		completionInjected.add(session.id);
-		agent.inject(createUserMessage({
-			content: [{
-				type: "text",
-				text: COMPLETION_SKILL_REVIEW_PROMPT
-			}],
-			source: {
-				kind: "plugin",
-				plugin: "dsh-evolution-review",
-				form: "notice",
-				summary: "completion review"
-			}
-		}));
+		try {
+			agent.inject(createUserMessage({
+				content: [{
+					type: "text",
+					text: COMPLETION_SKILL_REVIEW_PROMPT
+				}],
+				source: {
+					kind: "plugin",
+					plugin: "dsh-evolution-review",
+					form: "notice",
+					summary: "completion review"
+				}
+			}));
+		} catch (injectError) {
+			completionInjected.delete(session.id);
+			ctx.logger.warn(`dsh-evolution-review: completion review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
+			return;
+		}
 		ctx.emit("evolution/review-scheduled", {
 			sessionId: session.id,
 			kind: "skill",
@@ -272,34 +278,42 @@ function apply(ctx, rawConfig) {
 		const origins = resolveOrigins(void 0, true);
 		const actions = [];
 		let ok = true;
-		for (const op of plan.memoryOps ?? []) {
-			if (!Array.isArray(op.evidence) || op.evidence.length === 0) continue;
-			const normalized = {
-				target: op.target === "user" ? "user" : "memory",
-				action: op.action ?? "add",
-				facts: op.facts ?? op.content,
-				old_text: op.old_text
-			};
-			if ((approval ? await runApproved("memory", `memory ${normalized.target} ${normalized.action}`, normalized, normalized) : await memory?.applyBatch(normalized.target, [normalized]))?.ok) actions.push("Memory updated");
-			else ok = false;
-		}
-		for (const op of plan.skillOps ?? []) {
-			if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) continue;
-			const args = {
-				...op,
-				evidence: op.evidence
+		try {
+			for (const op of plan.memoryOps ?? []) {
+				if (!Array.isArray(op.evidence) || op.evidence.length === 0) continue;
+				const normalized = {
+					target: op.target === "user" ? "user" : "memory",
+					action: op.action ?? "add",
+					facts: op.facts ?? op.content,
+					old_text: op.old_text
+				};
+				if ((approval ? await runApproved("memory", `memory ${normalized.target} ${normalized.action}`, normalized, normalized) : await memory?.applyBatch(normalized.target, [normalized]))?.ok) actions.push("Memory updated");
+				else ok = false;
+			}
+			for (const op of plan.skillOps ?? []) {
+				if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) continue;
+				const args = {
+					...op,
+					evidence: op.evidence
+				};
+				const runnerArgs = {
+					operation: args,
+					origin: origins.library
+				};
+				if ((approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillDirect(args))?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
+				else ok = false;
+			}
+			return {
+				actions,
+				ok
 			};
-			const runnerArgs = {
-				operation: args,
-				origin: origins.library
+		} catch (error) {
+			ctx.logger.warn(`dsh-evolution-review: executePlan aborted mid-way after ${actions.length} ops landed: ${error instanceof Error ? error.message : String(error)}`);
+			return {
+				actions,
+				ok: false
 			};
-			if ((approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillDirect(args))?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
-			else ok = false;
 		}
-		return {
-			actions,
-			ok
-		};
 		async function runApproved(kind, summary, stored, runnerArgs) {
 			if (!approval) return void 0;
 			if (approval.isEnabled === true && !approval.hasRunner(kind)) {
@@ -511,4 +525,4 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 	].join("\n");
 }
 //#endregion
-export { Config, apply, filterUnreadSkillOps, inject, name, shouldCompletionReview, sweepDeadSessionEntries };
+export { Config, apply, clampReviewConfig, filterUnreadSkillOps, inject, name, shouldCompletionReview, sweepDeadSessionEntries };

package/lib/types/index.d.ts

@@ -34,6 +34,18 @@ export interface Config {
     skillReviewCompletionMinToolCalls?: number;
 }
 export declare const Config: z<Config>;
+/**
+ * G3.1 (0.3.23): clamp the numeric review config at assembly so a 0/negative/
+ * NaN/±Infinity value falls back to the package default instead of folding as a
+ * "disabled" special value (a 0 interval would fire a review every turn; NaN
+ * folds as NaN into the cadence/timeout). The schema `.min(1)` guards the
+ * loader path; this clamp also covers NaN/±Infinity (which schemastery lets a
+ * bare number schema through) and direct construction. `reviewMaxDepth` clamps
+ * to at least 1 because 0 is the historical 0.3.1 maximum-depth defect (a 0
+ * rejects the spawn outright). Warn once when a user-supplied value had to be
+ * corrected.
+ */
+export declare function clampReviewConfig(rawConfig: Config, ctx: Context): Required<Config>;
 export declare function apply(ctx: Context, rawConfig: Config): void;
 /** Completion-channel decision: task finished normally AND the session is proven long. */
 export declare function shouldCompletionReview(reason: {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.27",
+  "version": "0.3.28",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.27",
-    "@lmzhen/dsh-evolution-core": "^0.3.27",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.27"
+    "@lmzhen/dsh-evolution-approval": "^0.3.28",
+    "@lmzhen/dsh-evolution-core": "^0.3.28",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.28"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.27",
-    "@lmzhen/dsh-evolution-policy": "^0.3.27"
+    "@lmzhen/dsh-evolution-state": "^0.3.28",
+    "@lmzhen/dsh-evolution-policy": "^0.3.28"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.27",
-    "@lmzhen/dsh-evolution-core": "^0.3.27",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.27",
-    "@lmzhen/dsh-evolution-state": "^0.3.27"
+    "@lmzhen/dsh-evolution-approval": "^0.3.28",
+    "@lmzhen/dsh-evolution-core": "^0.3.28",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.28",
+    "@lmzhen/dsh-evolution-state": "^0.3.28"
   }
 }