@lmzhen/dsh-evolution-review 0.3.23 → 0.3.25

package/README.md

@@ -26,6 +26,8 @@ Independent of request-prefix construction. This package does not alter the asse
 - The review request text is redacted for credential-shaped patterns before it reaches the subagent, but redaction is pattern-based and best-effort, not a security boundary.
 - Read-before-write tracks only reads through the `skill` tool. `skill_manage` has no per-skill read action (`list`/`review` are whole-library, not targeted at one name), so a skill that was only listed via `skill_manage` is not marked as read — a background review may still reject a patch to it until it is actually loaded.
 - The completion-channel counters (`cumulativeToolCalls` / `completionInjected`) are in-memory only. A process restart resets them, which is accepted behavior: the completion review is a one-per-session post-task adaptation and a restart is treated as a fresh conversation boundary. The cadence state (`turnsSinceMemory` / `turnsSinceSkill`) is persisted via `ReviewState` and survives restart.
+- `evolution/review-scheduled` and `evolution/review-error` are emitted for platform/user wiring only — this family has no in-repo production `ctx.on` consumer for them. They are declared externally owned (the platform side wires consumption), which matches the `EXEMPT_ORPHANS` set in `scripts/verify-event-pairing.mjs`.
+- When the `evolution-state` service is not mounted, the memory/skill cadence state is not persisted and every turn restarts from a clean `{ turnsSinceMemory: 0, turnsSinceSkill: 0 }` baseline — the review schedule is stateless and re-decided each turn rather than accumulating across the conversation. The loss is surfaced once per process as a logger warning at the first turn/end.
 
 ## Configuration
 

package/lib/index.js

@@ -1,7 +1,7 @@
 import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, clampedNumber, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/index.js
 /**
@@ -13,21 +13,52 @@ const inject = ["agents"];
 const Config = z.object({
 	reviewEnabled: z.boolean().default(true),
 	reviewMode: z.union([z.const("subagent"), z.const("inject")]).default("subagent"),
-	memoryInterval: z.number().default(DEFAULT_REVIEW_MEMORY_INTERVAL),
-	skillInterval: z.number().default(DEFAULT_REVIEW_SKILL_INTERVAL),
+	memoryInterval: z.number().min(1).default(DEFAULT_REVIEW_MEMORY_INTERVAL),
+	skillInterval: z.number().min(1).default(DEFAULT_REVIEW_SKILL_INTERVAL),
 	reviewToolAllow: z.array(z.string()).default(["skill"]),
-	reviewTimeoutMs: z.number().default(12e4),
-	executionTimeoutMs: z.number().default(3e4),
-	reviewContextMessages: z.number().default(60),
-	reviewMessageChars: z.number().default(2e3),
-	reviewMaxDepth: z.number().default(1),
+	reviewTimeoutMs: z.number().min(1).default(12e4),
+	executionTimeoutMs: z.number().min(1).default(3e4),
+	reviewContextMessages: z.number().min(1).default(60),
+	reviewMessageChars: z.number().min(1).default(2e3),
+	reviewMaxDepth: z.number().min(1).default(1),
 	reviewProvider: z.string(),
 	skillReviewTrigger: z.string().default(DEFAULT_SKILL_REVIEW_TRIGGER),
-	skillReviewCompletionMinToolCalls: z.number().default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS)
+	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS)
 });
+let statelessReviewStateWarned = false;
+/**
+* G3.1 (0.3.23): clamp the numeric review config at assembly so a 0/negative/
+* NaN/±Infinity value falls back to the package default instead of folding as a
+* "disabled" special value (a 0 interval would fire a review every turn; NaN
+* folds as NaN into the cadence/timeout). The schema `.min(1)` guards the
+* loader path; this clamp also covers NaN/±Infinity (which schemastery lets a
+* bare number schema through) and direct construction. `reviewMaxDepth` clamps
+* to at least 1 because 0 is the historical 0.3.1 maximum-depth defect (a 0
+* rejects the spawn outright). Warn once when a user-supplied value had to be
+* corrected.
+*/
+function clampReviewConfig(rawConfig, ctx) {
+	const clamped = [];
+	const field = (name, value, fallback, min) => {
+		const result = clampedNumber(value, fallback, { min });
+		if (value !== void 0 && result !== value) clamped.push(name);
+		return result;
+	};
+	const config = Object.assign({}, rawConfig, {
+		memoryInterval: field("memoryInterval", rawConfig.memoryInterval, DEFAULT_REVIEW_MEMORY_INTERVAL, 1),
+		skillInterval: field("skillInterval", rawConfig.skillInterval, DEFAULT_REVIEW_SKILL_INTERVAL, 1),
+		reviewTimeoutMs: field("reviewTimeoutMs", rawConfig.reviewTimeoutMs, 12e4, 1),
+		reviewContextMessages: field("reviewContextMessages", rawConfig.reviewContextMessages, 60, 1),
+		reviewMessageChars: field("reviewMessageChars", rawConfig.reviewMessageChars, 2e3, 1),
+		reviewMaxDepth: field("reviewMaxDepth", rawConfig.reviewMaxDepth, 1, 1),
+		skillReviewCompletionMinToolCalls: field("skillReviewCompletionMinToolCalls", rawConfig.skillReviewCompletionMinToolCalls, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, 1)
+	});
+	if (clamped.length > 0) ctx.logger.warn(`dsh-evolution-review: ${clamped.join(", ")} provided an invalid value; falling back to the default`);
+	return config;
+}
 function apply(ctx, rawConfig) {
 	if (!verifyPromptBundle(PROMPT_BUNDLE)) throw new Error("dsh-evolution prompt bundle integrity check failed; refusing to schedule review work");
-	const config = rawConfig;
+	const config = clampReviewConfig(rawConfig, ctx);
 	const turnStarts = /* @__PURE__ */ new Map();
 	const cumulativeToolCalls = /* @__PURE__ */ new Map();
 	const completionInjected = /* @__PURE__ */ new Set();
@@ -60,6 +91,10 @@ function apply(ctx, rawConfig) {
 		const signal = foldTurn(session, turnStarts.get(session.id) ?? Math.max(0, session.seq - 1));
 		turnStarts.delete(session.id);
 		const stateService = ctx.get("evolutionState");
+		if (!stateService && !statelessReviewStateWarned) {
+			statelessReviewStateWarned = true;
+			ctx.logger.warn("dsh-evolution-review: evolution-state service not mounted — memory/skill review cadence is not persisted and resets every turn (see README Known Limitations).");
+		}
 		const state = await stateService?.loadReviewState(session.id) ?? {
 			turnsSinceMemory: 0,
 			turnsSinceSkill: 0,
@@ -103,13 +138,6 @@ function apply(ctx, rawConfig) {
 		if (completionInjected.has(session.id)) return;
 		if (!shouldCompletionReview(event.data.reason, cumulative, config.skillReviewCompletionMinToolCalls)) return;
 		completionInjected.add(session.id);
-		ctx.emit("evolution/review-scheduled", {
-			sessionId: session.id,
-			kind: "skill",
-			toolCalls: signal.toolCalls,
-			userChars: signal.userChars,
-			assistantChars: signal.assistantChars
-		});
 		agent.inject(createUserMessage({
 			content: [{
 				type: "text",
@@ -122,6 +150,13 @@ function apply(ctx, rawConfig) {
 				summary: "completion review"
 			}
 		}));
+		ctx.emit("evolution/review-scheduled", {
+			sessionId: session.id,
+			kind: "skill",
+			toolCalls: signal.toolCalls,
+			userChars: signal.userChars,
+			assistantChars: signal.assistantChars
+		});
 	}
 	async function trySubagentReview(session, agent, kind, signal) {
 		if ((policy()?.reviewMode ?? config.reviewMode) === "inject") return false;
@@ -186,6 +221,26 @@ function apply(ctx, rawConfig) {
 				const executed = await executePlan(validation.accepted, session.id);
 				const actions = executed.actions;
 				const evidenceQuotes = [...validation.accepted.memoryOps ?? [], ...acceptedSkillOps].reduce((total, op) => total + (Array.isArray(op.evidence) ? op.evidence.length : 0), 0);
+				if (actions.length > 0) {
+					const applied = actions.join(" · ");
+					const note = executed.ok ? "" : "\n部分操作失败。以下操作已应用，请勿重复执行。";
+					try {
+						agent.inject(createUserMessage({
+							content: [{
+								type: "text",
+								text: `💾 Self-improvement review: ${applied}${note}`
+							}],
+							source: {
+								kind: "plugin",
+								plugin: "dsh-evolution-review",
+								form: "notice",
+								summary: "self-improvement review"
+							}
+						}));
+					} catch (injectError) {
+						ctx.logger.warn(`dsh-evolution-review: result notice inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
+					}
+				}
 				ctx.emit("evolution/plan-applied", {
 					sessionId: session.id,
 					planId: randomUUID(),
@@ -196,22 +251,6 @@ function apply(ctx, rawConfig) {
 					evidenceQuotes,
 					estimatedInputChars: reviewText.length
 				});
-				if (actions.length > 0) {
-					const applied = actions.join(" · ");
-					const note = executed.ok ? "" : "\n部分操作失败。以下操作已应用，请勿重复执行。";
-					agent.inject(createUserMessage({
-						content: [{
-							type: "text",
-							text: `💾 Self-improvement review: ${applied}${note}`
-						}],
-						source: {
-							kind: "plugin",
-							plugin: "dsh-evolution-review",
-							form: "notice",
-							summary: "self-improvement review"
-						}
-					}));
-				}
 				return true;
 			} finally {
 				try {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.23",
+  "version": "0.3.25",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.23",
-    "@lmzhen/dsh-evolution-core": "^0.3.23",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.23"
+    "@lmzhen/dsh-evolution-approval": "^0.3.25",
+    "@lmzhen/dsh-evolution-core": "^0.3.25",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.25"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.23",
-    "@lmzhen/dsh-evolution-policy": "^0.3.23"
+    "@lmzhen/dsh-evolution-state": "^0.3.25",
+    "@lmzhen/dsh-evolution-policy": "^0.3.25"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.23",
-    "@lmzhen/dsh-evolution-core": "^0.3.23",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.23",
-    "@lmzhen/dsh-evolution-state": "^0.3.23"
+    "@lmzhen/dsh-evolution-approval": "^0.3.25",
+    "@lmzhen/dsh-evolution-core": "^0.3.25",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.25",
+    "@lmzhen/dsh-evolution-state": "^0.3.25"
   }
 }