@lmzhen/dsh-evolution-review 0.17.1 → 0.18.1

package/README.md

@@ -13,6 +13,7 @@ own, and the delivery mode lives on the `evolution-policy` row, not here.
 
 ## Known limitations
 
+- **The autonomous write leg does not pass `tools.guard`.** `executePlan` calls the service seam directly (`memory.applyBatch`, `library.*`), so the guard `evolution-threat` installs on the TOOL channel never sees these writes (`grep "tools.execute(" src` = 0 by design). The scan still happens one layer down: `MemoryStore` and `SkillLibrary` refuse threat-shaped payloads at the write point through core's own pattern table, which is the same table the guard consumes. A deployment that wants the tool channel's guard wording on a plan write should route it through a tool — nothing in the plan path claims that coverage.
 - The review's model/context routing below applies to `reviewMode: 'subagent'` (opt-in since 0.3.74); in the default `'inject'` mode the review runs on the parent agent's model inside the parent thread.
 - Review subagents are spawned with the plain `skill` tool only (`reviewToolAllow` default and the host/preset config both = `[skill]`: the DSH tool catalog has no `skill_search`/`skill_load` discovery pair, so the Hermes-lineage Anchored Standard `skill_search`/`skill_load` allow-list does not exist here).
 - Review subagents run as `spawn` children on the deployment default preset rather than inheriting the parent agent's composition (`fork`): a fork child is always promoted by the Anchored Standard bootstrap and its narrowed resident catalog would drop the plain `skill` tool from the review allow-list.

package/lib/index.js

@@ -2,7 +2,7 @@ import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
 import { SessionId } from "@deepseek-ai/dsh-session";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, clampedNumber, clearReviewChannel, contentHash, evolutionIoAdapter, filterUnreadSkillOps, filterUnreadSkillOps as filterUnreadSkillOps$1, markReviewChannel, newSkillLibrary, paramRowId, policyStageLimits, readDispatchSignal, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, sessionEvidenceIndex, sessionReadNames, sessionTurnSignals, sweepReviewChannelSessions, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, clampOnce, clearReviewChannel, contentHash, evolutionIoAdapter, filterUnreadSkillOps, filterUnreadSkillOps as filterUnreadSkillOps$1, foldUntrustedLines, markReviewChannel, newSkillLibrary, paramRowId, payloadText, pickWithPolicy, policyStageLimits, readDispatchSignal, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, sessionEvidenceIndex, sessionReadNames, sessionTurnSignals, sweepReviewChannelSessions, userSetKeys, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 /**
 * Whether a message is a notice this plugin delivered, judged only by durable source fields.
@@ -15,7 +15,8 @@ import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 function isReviewNotice(message) {
 	const source = message.source;
 	if (source?.form !== "notice") return false;
-	return source.kind === "evolution-review" || source.kind === "plugin:dsh-evolution-review";
+	if (source.kind !== "evolution-review" && source.kind !== "plugin:dsh-evolution-review") return false;
+	return source.summary === void 0 || !source.summary.startsWith("self-improvement review");
 }
 /**
 * Fold one inbox event into the session's outstanding notice.
@@ -115,6 +116,23 @@ var SessionScopedState = class {
 * Background review orchestration: signal gate → one-shot subagent → trusted plan execution.
 * @module @lmzhen/dsh-evolution-review
 */
+/** Emit one `evolution/review-scheduled` inside its OWN protection domain (V8-03, V5-19③/F-334).
+*
+* Every delivery path must enter that domain, and five hand-copied try/emit/catch blocks had
+* already drifted twice: V24-15 had to add the emit to two injection paths that never had it, and
+* V25-02 fixed a cross-session attribution bug that lived in one of the copies. The fields, the
+* channel and the domain now travel together.
+* @param ctx - the plugin context the event is emitted on.
+* @param event - the payload. `sessionId` is the session the review was scheduled FOR — on the
+* deferred drain that is the entry's session, never the in-flight review's.
+*/
+function emitReviewScheduled(ctx, event) {
+	try {
+		ctx.emit("evolution/review-scheduled", event);
+	} catch (emitError) {
+		ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
+	}
+}
 /** S2-6 (FLOW1-1): the settle-grace margin a subagent handle gets beyond its
 * own deadline before the review abandons it. As the dispose watchdog's WHOLE
 * budget it is capped by the review timeout so a short (test) budget stays
@@ -176,37 +194,6 @@ const REVIEW_OUTPUT_SCHEMA = {
 */
 const cadenceSummary = (kind) => `auto-review:${kind}`;
 /**
-* G3.1 (0.3.23): clamp one numeric review knob so a 0/negative/NaN/±Infinity value
-* falls back to the package default instead of folding as a "disabled" special value
-* (a 0 interval would fire a review every turn; NaN folds as NaN into the
-* cadence/timeout). The schema `.min(1)` guards the loader path; this clamp also
-* covers NaN/±Infinity (which schemastery lets a bare number schema through) and
-* programmatic assembly. `reviewMaxDepth` clamps to at least 1 because 0 is the
-* historical 0.3.1 maximum-depth defect (a 0 rejects the spawn outright). The warning
-* fires once per key: a live field is read at every use, so an assembly-time list
-* would repeat on each read.
-* @param warned - the keys this caller already warned about.
-* @param warn - the warning sink.
-* @param name - the config key, for the warning.
-* @param value - the value as supplied, or its volatile reference.
-* @param fallback - the package default a corrected value falls back to.
-* @param min - the smallest value the engine can act on.
-* @param max - the largest value the carrier can hold, when bounded.
-* @returns the value the engine may use.
-*/
-function clampField(warned, warn, name, value, fallback, min, max) {
-	const current = typeof value === "object" ? value.get() : value;
-	const result = clampedNumber(current, fallback, max === void 0 ? { min } : {
-		min,
-		max
-	});
-	if (current !== void 0 && result !== current && !warned.has(name)) {
-		warned.add(name);
-		warn(`${name} provided an invalid value; falling back to the default`);
-	}
-	return result;
-}
-/**
 * The DEPLOYMENT layer of this row, clamped once at assembly: the restart-only
 * numerics (registry tier E2) whose consumers read them from this snapshot. The
 * seven E3 keys are NOT resolved here — they are live (G1 §8.3), and
@@ -220,7 +207,7 @@ function clampReviewConfig(rawConfig, ctx) {
 	const warn = (message) => {
 		ctx.logger.warn("dsh-evolution-review: " + message);
 	};
-	const field = (name, value, fallback, min, max) => clampField(warned, warn, name, value, fallback, min, max);
+	const field = (name, value, fallback, min, max) => clampOnce(warned, warn, name, value, fallback, min, max);
 	return Object.assign({}, rawConfig, {
 		reviewTimeoutMs: field("reviewTimeoutMs", rawConfig.reviewTimeoutMs, DEFAULT_REVIEW_TIMEOUT_MS, 1, MAX_TIMER_DELAY_MS),
 		reviewContextMessages: field("reviewContextMessages", rawConfig.reviewContextMessages, DEFAULT_REVIEW_CONTEXT_MESSAGES, 1),
@@ -244,10 +231,10 @@ function policySnapshotOf(source) {
 function resolveReviewRowSettings(rawConfig, warn) {
 	const warned = /* @__PURE__ */ new Set();
 	return {
-		reviewSkillInterval: clampField(warned, warn, "reviewSkillInterval", rawConfig.reviewSkillInterval?.get() ?? rawConfig.skillInterval, DEFAULT_REVIEW_SKILL_INTERVAL, 1),
-		reviewMemoryInterval: clampField(warned, warn, "reviewMemoryInterval", rawConfig.reviewMemoryInterval?.get() ?? rawConfig.memoryInterval, DEFAULT_REVIEW_MEMORY_INTERVAL, 1),
+		reviewSkillInterval: clampOnce(warned, warn, "reviewSkillInterval", rawConfig.reviewSkillInterval?.get() ?? rawConfig.skillInterval, DEFAULT_REVIEW_SKILL_INTERVAL, 1),
+		reviewMemoryInterval: clampOnce(warned, warn, "reviewMemoryInterval", rawConfig.reviewMemoryInterval?.get() ?? rawConfig.memoryInterval, DEFAULT_REVIEW_MEMORY_INTERVAL, 1),
 		skillReviewTrigger: rawConfig.skillReviewTrigger?.get() ?? DEFAULT_SKILL_REVIEW_TRIGGER,
-		skillReviewCompletionMinToolCalls: clampField(warned, warn, "skillReviewCompletionMinToolCalls", rawConfig.skillReviewCompletionMinToolCalls, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, 1),
+		skillReviewCompletionMinToolCalls: clampOnce(warned, warn, "skillReviewCompletionMinToolCalls", rawConfig.skillReviewCompletionMinToolCalls, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, 1),
 		reviewEnabled: rawConfig.reviewEnabled?.get() ?? true,
 		reviewMode: rawConfig.reviewMode?.get() ?? "inject",
 		reviewWakeInject: rawConfig.reviewWakeInject?.get() ?? true
@@ -257,7 +244,7 @@ function apply(ctx, rawConfig = {}) {
 	ctx.inject(["settings"], (injected) => {
 		const settings = injected.settings;
 		if (typeof settings?.configure !== "function") return;
-		const disposer = settings.configure({ auto: false });
+		const disposer = settings.configure({ auto: false }, ctx.fiber);
 		if (typeof disposer === "function") ctx.effect(() => disposer, "dsh-evolution-review: settings presentation");
 	});
 	if (!verifyPromptBundle(PROMPT_BUNDLE)) throw new Error("dsh-evolution prompt bundle integrity check failed; refusing to schedule review work");
@@ -285,25 +272,11 @@ function apply(ctx, rawConfig = {}) {
 	const rowSettings = () => resolveReviewRowSettings(rawConfig, (message) => {
 		ctx.logger.warn("dsh-evolution-review: " + message);
 	});
-	/**
-	* The keys the user set in this row's namespace (G1 §8.4-A). This is the ONLY
-	* remaining read of the settings user layer, and it reads KEY NAMES, never values:
-	* the platform resolves the user layer into the row's live fields, so the value
-	* comes from `rowSettings()`.
-	* @returns the keys present in this row's user layer.
-	*/
-	const userSetKeys = () => {
-		const entry = ctx.get("settings")?.describe?.({ redactSecrets: false }).find((item) => item.ns === paramRowId("evolution-review"));
-		return new Set(Object.keys(entry?.user ?? {}));
-	};
 	const params = () => {
 		const row = rowSettings();
-		const userSet = userSetKeys();
+		const userSet = userSetKeys(ctx, paramRowId("evolution-review"));
 		const snapshot = policy();
-		const pick = (key) => {
-			if (userSet.has(key)) return row[key];
-			return snapshot?.[key] ?? row[key];
-		};
+		const pick = (key) => pickWithPolicy(userSet, row, snapshot, key);
 		const mode = () => {
 			if (userSet.has("reviewMode")) return row.reviewMode;
 			return snapshot?.reviewMode ?? row.reviewMode;
@@ -335,7 +308,7 @@ function apply(ctx, rawConfig = {}) {
 		["reviewMode", void 0],
 		["reviewMemoryInterval", "memoryInterval"],
 		["reviewSkillInterval", "skillInterval"]
-	].filter(([id, alias]) => !userSetKeys().has(id) && rowSupplied(id, alias)).map(([id]) => id);
+	].filter(([id, alias]) => !userSetKeys(ctx, paramRowId("evolution-review")).has(id) && rowSupplied(id, alias)).map(([id]) => id);
 	if (shadowedRowFields.length > 0) {
 		let shadowWarned = false;
 		const warnShadowed = () => {
@@ -367,7 +340,7 @@ function apply(ctx, rawConfig = {}) {
 			return;
 		}
 		if (event.type !== "turn/end") return;
-		if (cumulativeToolCalls.size >= COUNTER_SWEEP_THRESHOLD || dispatchDigest.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceWarned.size >= COUNTER_SWEEP_THRESHOLD || cumulativeToolCalls.size >= COUNTER_SWEEP_THRESHOLD || completionInjected.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceReviews.size >= COUNTER_SWEEP_THRESHOLD || cadenceResetWarned.size >= COUNTER_SWEEP_THRESHOLD || pendingReviewNotices.size >= COUNTER_SWEEP_THRESHOLD) {
+		if (cumulativeToolCalls.size >= COUNTER_SWEEP_THRESHOLD || dispatchDigest.size >= COUNTER_SWEEP_THRESHOLD || completionInjected.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceReviews.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceWarned.size >= COUNTER_SWEEP_THRESHOLD || cadenceResetWarned.size >= COUNTER_SWEEP_THRESHOLD || pendingReviewNotices.size >= COUNTER_SWEEP_THRESHOLD) {
 			const isAlive = (id) => ctx.agents.get(id) !== void 0;
 			sweepDeadSessionEntries(cumulativeToolCalls, isAlive);
 			sweepDeadSessionEntries(dispatchDigest, isAlive);
@@ -503,33 +476,25 @@ function apply(ctx, rawConfig = {}) {
 						pendingCadenceReviews.set(session.id, pendingKind);
 						return;
 					}
-					try {
-						ctx.emit("evolution/review-scheduled", {
+					emitReviewScheduled(ctx, {
+						sessionId: session.id,
+						kind: pendingKind,
+						toolCalls: signal.toolCalls,
+						userChars: signal.userChars,
+						assistantChars: signal.assistantChars,
+						channel: "inject"
+					});
+				} else {
+					const reviewOutcome = await trySubagentReview(session, agent, pendingKind, signal);
+					if (reviewOutcome === true) {
+						emitReviewScheduled(ctx, {
 							sessionId: session.id,
 							kind: pendingKind,
 							toolCalls: signal.toolCalls,
 							userChars: signal.userChars,
 							assistantChars: signal.assistantChars,
-							channel: "inject"
+							channel: "subagent"
 						});
-					} catch (emitError) {
-						ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
-					}
-				} else {
-					const reviewOutcome = await trySubagentReview(session, agent, pendingKind, signal);
-					if (reviewOutcome === true) {
-						try {
-							ctx.emit("evolution/review-scheduled", {
-								sessionId: session.id,
-								kind: pendingKind,
-								toolCalls: signal.toolCalls,
-								userChars: signal.userChars,
-								assistantChars: signal.assistantChars,
-								channel: "subagent"
-							});
-						} catch (emitError) {
-							ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
-						}
 						await settleNotice(session.id, "subagent-flush");
 					} else if (reviewOutcome === "dropped") {
 						pendingCadenceReviews.set(session.id, pendingKind);
@@ -539,18 +504,14 @@ function apply(ctx, rawConfig = {}) {
 							pendingCadenceReviews.set(session.id, pendingKind);
 							return;
 						}
-						try {
-							ctx.emit("evolution/review-scheduled", {
-								sessionId: session.id,
-								kind: pendingKind,
-								toolCalls: signal.toolCalls,
-								userChars: signal.userChars,
-								assistantChars: signal.assistantChars,
-								channel: "inject"
-							});
-						} catch (emitError) {
-							ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
-						}
+						emitReviewScheduled(ctx, {
+							sessionId: session.id,
+							kind: pendingKind,
+							toolCalls: signal.toolCalls,
+							userChars: signal.userChars,
+							assistantChars: signal.assistantChars,
+							channel: "inject"
+						});
 					}
 				}
 				return;
@@ -590,18 +551,14 @@ function apply(ctx, rawConfig = {}) {
 			completionInjected.delete(session.id);
 			return;
 		}
-		try {
-			ctx.emit("evolution/review-scheduled", {
-				sessionId: session.id,
-				kind: "skill",
-				toolCalls: signal.toolCalls,
-				userChars: signal.userChars,
-				assistantChars: signal.assistantChars,
-				channel: "completion"
-			});
-		} catch (emitError) {
-			ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
-		}
+		emitReviewScheduled(ctx, {
+			sessionId: session.id,
+			kind: "skill",
+			toolCalls: signal.toolCalls,
+			userChars: signal.userChars,
+			assistantChars: signal.assistantChars,
+			channel: "completion"
+		});
 	}
 	/** V7-03 (0.3.42): shared waking delivery — review prompts AND result
 	* notices go through the same followup-first channel (skip the woken turn's
@@ -734,6 +691,18 @@ function apply(ctx, rawConfig = {}) {
 			reject(error instanceof Error ? error : new Error(String(error)));
 		});
 	});
+	/**
+	* T3-09/A37: the ONE abort channel for this fiber's long work.
+	*
+	* The review's two legs (the review subagent, and the write leg that executes its plan) were
+	* bounded only by their own timeouts, so an unloaded or HMR-replaced fiber kept running — and the
+	* write leg kept WRITING — while the replacement instance knew nothing about it (its single-flight
+	* flag and min-idle window do not cover a run that no longer belongs to any live fiber). The
+	* disposer below aborts this controller; the subagent leg merges it with its own deadline through
+	* `AbortSignal.any` (the shape evolution-maintenance's scan already uses) and the write leg checks
+	* it at every op boundary — before the first op, so an aborted fiber lands nothing.
+	*/
+	const fiberAbort = new AbortController();
 	const withTimeout = (promise, ms, label) => new Promise((resolve, reject) => {
 		const timer = setTimeout(() => {
 			reject(/* @__PURE__ */ new Error(`dsh-evolution-review: ${label} timed out after ${ms}ms`));
@@ -818,7 +787,7 @@ function apply(ctx, rawConfig = {}) {
 					text: reviewText
 				}],
 				parent: agent,
-				signal: AbortSignal.timeout(config.reviewTimeoutMs),
+				signal: AbortSignal.any([AbortSignal.timeout(config.reviewTimeoutMs), fiberAbort.signal]),
 				maxDepth: config.reviewMaxDepth,
 				agentOptions,
 				persona: reviewPrompt(kind, "plan"),
@@ -887,7 +856,7 @@ function apply(ctx, rawConfig = {}) {
 				};
 				let executed;
 				try {
-					executed = await withTimeout(executePlan(validation.accepted, session, noteLanded, preRunHashes), config.reviewTimeoutMs, "review plan execution");
+					executed = await withTimeout(executePlan(validation.accepted, session, noteLanded, preRunHashes, fiberAbort.signal), config.reviewTimeoutMs, "review plan execution");
 				} catch (error) {
 					deadlineMissed = true;
 					emitApplied({
@@ -943,22 +912,18 @@ function apply(ctx, rawConfig = {}) {
 					else pendingCadenceReviews.set(entrySession, waitingKind);
 					continue;
 				}
-				try {
-					ctx.emit("evolution/review-scheduled", {
-						sessionId: entrySession,
-						kind: waitingKind,
-						toolCalls: entryCounts.toolCalls,
-						userChars: entryCounts.userChars,
-						assistantChars: entryCounts.assistantChars,
-						channel
-					});
-				} catch (emitError) {
-					ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
-				}
+				emitReviewScheduled(ctx, {
+					sessionId: entrySession,
+					kind: waitingKind,
+					toolCalls: entryCounts.toolCalls,
+					userChars: entryCounts.userChars,
+					assistantChars: entryCounts.assistantChars,
+					channel
+				});
 			}
 		}
 	}
-	async function executePlan(plan, session, onLanded, preRunHashes) {
+	async function executePlan(plan, session, onLanded, preRunHashes, signal) {
 		const sessionId = session?.id;
 		const memory = ctx.get("memory");
 		const approval = ctx.get("evolutionApproval");
@@ -976,6 +941,16 @@ function apply(ctx, rawConfig = {}) {
 		let ok = true;
 		try {
 			for (const op of plan.memoryOps ?? []) {
+				if (signal?.aborted === true) {
+					const reason = "the review was unloaded mid-plan";
+					ctx.logger.warn(`dsh-evolution-review: executePlan stopped at an op boundary after ${actions.length} op(s): ${reason}`);
+					return {
+						actions,
+						ok: false,
+						failedOps,
+						aborted: reason
+					};
+				}
 				if (!Array.isArray(op.evidence) || op.evidence.length === 0) {
 					ok = false;
 					failedOps.push(`memory ${op.action ?? "add"} ${op.target}: missing evidence (defense-in-depth rejection)`);
@@ -984,7 +959,7 @@ function apply(ctx, rawConfig = {}) {
 				const normalized = {
 					target: op.target === "user" ? "user" : "memory",
 					action: op.action ?? "add",
-					facts: op.facts ?? op.content,
+					facts: payloadText(op),
 					old_text: op.old_text
 				};
 				const result = approval ? await runApproved("memory", `memory ${normalized.target} ${normalized.action}`, normalized, normalized, session) : await memory?.applyBatch(normalized.target, [normalized]);
@@ -997,6 +972,16 @@ function apply(ctx, rawConfig = {}) {
 				}
 			}
 			for (const op of plan.skillOps ?? []) {
+				if (signal?.aborted === true) {
+					const reason = "the review was unloaded mid-plan";
+					ctx.logger.warn(`dsh-evolution-review: executePlan stopped at an op boundary after ${actions.length} op(s): ${reason}`);
+					return {
+						actions,
+						ok: false,
+						failedOps,
+						aborted: reason
+					};
+				}
 				if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) {
 					ok = false;
 					failedOps.push(`skill ${op.action ?? "patch"} ${op.name ?? "<unnamed>"}: missing evidence or name (defense-in-depth rejection)`);
@@ -1093,7 +1078,7 @@ function apply(ctx, rawConfig = {}) {
 				if (!memory?.applyBatch) return void 0;
 				return await memory.applyBatch(op.target === "user" ? "user" : "memory", [{
 					action: op.action ?? "add",
-					facts: op.facts ?? op.content,
+					facts: payloadText(op),
 					old_text: op.old_text
 				}]);
 			}
@@ -1185,6 +1170,7 @@ function apply(ctx, rawConfig = {}) {
 		}
 	}
 	ctx.effect(() => () => {
+		fiberAbort.abort();
 		sessionState.dispose();
 	}, "dsh-evolution-review.cleanup");
 }
@@ -1340,8 +1326,8 @@ function renderToolResultLine(data, identity) {
 		output = "";
 		failed = false;
 	}
-	const head = identity === void 0 ? "" : `${identity.name} ${identity.argsRaw.slice(0, 200)} → `;
-	return `[result]${failed ? " [ERROR]" : ""} ${head}${output.slice(0, 500)}`;
+	const head = identity === void 0 ? "" : `${foldUntrustedLines(identity.name, 0)} ${foldUntrustedLines(identity.argsRaw, 200)} → `;
+	return `[result]${failed ? " [ERROR]" : ""} ${head}${foldUntrustedLines(output, 500)}`;
 }
 /** Text of a PTC settle `content` payload (the logged ContentBlock list):
 * text blocks and plain strings joined, anything else skipped. */
@@ -1375,10 +1361,10 @@ function textOfPersistedBlock(block) {
 }
 function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars, dispatchTail = []) {
 	const messages = [];
-	const surface = session.deriveMessages();
-	for (const message of surface.slice(-maxMessages)) if (message.role === "user" || message.role === "assistant") {
+	const eligible = session.deriveMessages().filter((message) => message.role === "user" || message.role === "assistant").slice(-maxMessages);
+	for (const message of eligible) {
 		const text = message.content.map(textOfPersistedBlock).join(" ").trim();
-		if (text) messages.push(`${message.role.toUpperCase()}: ${text.slice(0, maxMessageChars)}`);
+		if (text) messages.push(`${message.role.toUpperCase()}: ${foldUntrustedLines(text, maxMessageChars)}`);
 	}
 	const toolLines = [];
 	const events = dispatchTail;
@@ -1412,7 +1398,7 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars,
 		if (opened === null || openedCallIds.has(opened.callId)) continue;
 		openedCallIds.add(opened.callId);
 		const argsRaw = typeof opened.arguments === "string" ? opened.arguments : JSON.stringify(opened.arguments ?? {});
-		toolLines.push(`[call] ${opened.name} ${argsRaw.slice(0, 500)}`);
+		toolLines.push(`[call] ${foldUntrustedLines(opened.name, 0)} ${foldUntrustedLines(argsRaw, 500)}`);
 	}
 	toolLines.reverse();
 	return [

package/lib/types/index.d.ts

@@ -42,10 +42,10 @@ export interface Config {
      * the policy snapshot like the memory cadence. */
     reviewSkillInterval?: Volatile<number | undefined>;
     /** Deprecated alias of `reviewMemoryInterval` (G0/S0.3): still readable,
-     * refused by writes; removed 0.7.0. */
+     * refused by writes; removal was planned for 0.7.0 and is deferred (the alias still ships — see the package README). */
     memoryInterval?: number;
     /** Deprecated alias of `reviewSkillInterval` (G0/S0.3): still readable,
-     * refused by writes; removed 0.7.0. */
+     * refused by writes; removal was planned for 0.7.0 and is deferred (the alias still ships — see the package README). */
     skillInterval?: number;
     /**
      * Tools the one-shot review subagent may use. Only actually-existing tools

package/lib/types/review-notice.d.ts

@@ -31,12 +31,20 @@ export declare const REVIEW_NOTICE_KIND = "evolution-review";
  * belonged to would be delivered a second time.
  */
 export declare const REVIEW_NOTICE_LEGACY_KIND = "plugin:dsh-evolution-review";
+/** T3-01/A29: the summary every RESULT notification carries ("what the review did"). A result notice
+ * is NOT a review prompt: it occupies no window and must never refuse the next cadence flush — but it
+ * shares the kind AND the form (the platform types `form` as the literal 'notice'), so this summary is
+ * the only field that tells the two apart, for new notices and for the ones an older build persisted. */
+export declare const REVIEW_RESULT_SUMMARY = "self-improvement review";
 /** The subset of a platform message this module reads. */
 export interface NoticeMessage {
     readonly id: string;
     readonly source?: {
         readonly kind?: string;
         readonly form?: string;
+        /** Present on both shapes this plugin delivers (a prompt and a result notice); the result
+         * summary is what identifies a LEGACY result notice, see {@link REVIEW_RESULT_SUMMARY}. */
+        readonly summary?: string;
     } | undefined;
 }
 /** One delivered notice that has not settled yet. */

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.17.1",
+  "version": "0.18.1",
   "publishConfig": {
     "access": "public"
   },
@@ -26,10 +26,10 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.17.1",
-    "@lmzhen/dsh-evolution-core": "^0.17.1",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.17.1"
+    "@deepseek-ai/schemastery": "^3.18.4",
+    "@lmzhen/dsh-evolution-approval": "^0.18.1",
+    "@lmzhen/dsh-evolution-core": "^0.18.1",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.18.1"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -37,8 +37,8 @@
     "@deepseek-ai/dsh-llm": "^0.2.0-rc.1",
     "@deepseek-ai/dsh-session": "^0.2.0-rc.1",
     "@deepseek-ai/dsh-tools": "^0.2.0-rc.1",
-    "@lmzhen/dsh-evolution-state": "^0.17.1",
-    "@lmzhen/dsh-evolution-policy": "^0.17.1"
+    "@lmzhen/dsh-evolution-state": "^0.18.1",
+    "@lmzhen/dsh-evolution-policy": "^0.18.1"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.2.0-rc.1",
@@ -48,10 +48,10 @@
     "@deepseek-ai/dsh-session-persistence": "^0.2.0-rc.1",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.2.0-rc.1",
     "@deepseek-ai/dsh-tools": "^0.2.0-rc.1",
-    "@lmzhen/dsh-evolution-approval": "^0.17.1",
-    "@lmzhen/dsh-evolution-core": "^0.17.1",
-    "@lmzhen/dsh-evolution-curator": "^0.17.1",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.17.1",
-    "@lmzhen/dsh-evolution-state": "^0.17.1"
+    "@lmzhen/dsh-evolution-approval": "^0.18.1",
+    "@lmzhen/dsh-evolution-core": "^0.18.1",
+    "@lmzhen/dsh-evolution-curator": "^0.18.1",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.18.1",
+    "@lmzhen/dsh-evolution-state": "^0.18.1"
   }
 }