@lmzhen/dsh-evolution-review 0.1.0-rc.41 → 0.1.0-rc.43

package/lib/index.js

@@ -64,6 +64,12 @@ function apply(ctx, rawConfig) {
 	ctx.on("session/event", (session, event) => {
 		if (event.type === "turn/start") turnStarts.set(session.id, session.seq - 1);
 		if (event.type !== "turn/end") return;
+		if (turnStarts.size >= 128 || cumulativeToolCalls.size >= 128 || completionInjected.size >= 128) {
+			const isAlive = (id) => ctx.agents.get(id) !== void 0;
+			sweepDeadSessionEntries(turnStarts, isAlive);
+			sweepDeadSessionEntries(cumulativeToolCalls, isAlive);
+			sweepDeadSessionEntries(completionInjected, isAlive);
+		}
 		onTurnEnd(session, event);
 	});
 	async function onTurnEnd(session, event) {
@@ -91,7 +97,8 @@ function apply(ctx, rawConfig) {
 		const cumulative = (cumulativeToolCalls.get(session.id) ?? 0) + signal.toolCalls;
 		cumulativeToolCalls.set(session.id, cumulative);
 		if (kind) {
-			session.append("evolution/review-scheduled", {
+			ctx.emit("evolution/review-scheduled", {
+				sessionId: session.id,
 				kind,
 				toolCalls: signal.toolCalls,
 				userChars: signal.userChars,
@@ -116,7 +123,8 @@ function apply(ctx, rawConfig) {
 		if (completionInjected.has(session.id)) return;
 		if (!shouldCompletionReview(event.data.reason, cumulative, config.skillReviewCompletionMinToolCalls)) return;
 		completionInjected.add(session.id);
-		session.append("evolution/review-scheduled", {
+		ctx.emit("evolution/review-scheduled", {
+			sessionId: session.id,
 			kind: "skill",
 			toolCalls: signal.toolCalls,
 			userChars: signal.userChars,
@@ -173,48 +181,55 @@ function apply(ctx, rawConfig) {
 					}
 				}
 			});
-			const childReads = run.localAgent ? collectReadSkillNames(run.localAgent.session) : /* @__PURE__ */ new Set();
-			const result = await run.result;
-			await run.dispose();
-			if (!result.structured) return true;
-			const snapshot = policy();
-			const plan = result.structured;
-			const policyFingerprint = fingerprintPolicy(snapshot);
-			const validation = validateEvolutionPlan(plan, {
-				sessionSeq: session.seq - 1,
-				maxOpsPerPlan: snapshot?.maxOpsPerPlan ?? DEFAULT_MAX_OPS_PER_PLAN,
-				protectedSkillNames: new Set(snapshot?.protectedSkillNames ?? []),
-				maxMemoryChars: snapshot?.memoryChars ?? DEFAULT_MEMORY_CHAR_LIMIT,
-				maxUserChars: snapshot?.userChars ?? DEFAULT_USER_CHAR_LIMIT,
-				maxSkillContentChars: snapshot?.skillContentChars ?? DEFAULT_SKILL_CONTENT_CHARS
-			});
-			const acceptedSkillOps = validation.accepted.skillOps ?? [];
-			const skippedUnread = filterUnreadSkillOps(acceptedSkillOps, new Set([...collectReadSkillNames(session), ...childReads]));
-			validation.accepted.skillOps = acceptedSkillOps;
-			const actions = await executePlan(validation.accepted);
-			const evidenceQuotes = [...validation.accepted.memoryOps ?? [], ...acceptedSkillOps].reduce((total, op) => total + (Array.isArray(op.evidence) ? op.evidence.length : 0), 0);
-			session.append("evolution/plan-applied", {
-				planId: randomUUID(),
-				policyFingerprint,
-				memoryApplied: actions.filter((action) => action.startsWith("Memory")).length,
-				skillApplied: actions.filter((action) => action.startsWith("Skill ")).length,
-				rejectedOps: validation.rejected.length + skippedUnread,
-				evidenceQuotes,
-				estimatedInputChars: reviewText.length
-			});
-			if (actions.length > 0) agent.inject(createUserMessage({
-				content: [{
-					type: "text",
-					text: `💾 Self-improvement review: ${actions.join(" · ")}`
-				}],
-				source: {
-					kind: "plugin",
-					plugin: "dsh-evolution-review",
-					form: "notice",
-					summary: "self-improvement review"
+			try {
+				const childReads = run.localAgent ? collectReadSkillNames(run.localAgent.session) : /* @__PURE__ */ new Set();
+				const result = await run.result;
+				if (!result.structured) return true;
+				const snapshot = policy();
+				const plan = result.structured;
+				const policyFingerprint = fingerprintPolicy(snapshot);
+				const validation = validateEvolutionPlan(plan, {
+					sessionSeq: session.seq - 1,
+					maxOpsPerPlan: snapshot?.maxOpsPerPlan ?? DEFAULT_MAX_OPS_PER_PLAN,
+					protectedSkillNames: new Set(snapshot?.protectedSkillNames ?? []),
+					maxMemoryChars: snapshot?.memoryChars ?? DEFAULT_MEMORY_CHAR_LIMIT,
+					maxUserChars: snapshot?.userChars ?? DEFAULT_USER_CHAR_LIMIT,
+					maxSkillContentChars: snapshot?.skillContentChars ?? DEFAULT_SKILL_CONTENT_CHARS
+				});
+				const acceptedSkillOps = validation.accepted.skillOps ?? [];
+				const skippedUnread = filterUnreadSkillOps(acceptedSkillOps, new Set([...collectReadSkillNames(session), ...childReads]));
+				const actions = await executePlan(validation.accepted);
+				const evidenceQuotes = [...validation.accepted.memoryOps ?? [], ...acceptedSkillOps].reduce((total, op) => total + (Array.isArray(op.evidence) ? op.evidence.length : 0), 0);
+				ctx.emit("evolution/plan-applied", {
+					sessionId: session.id,
+					planId: randomUUID(),
+					policyFingerprint,
+					memoryApplied: actions.filter((action) => action.startsWith("Memory")).length,
+					skillApplied: actions.filter((action) => action.startsWith("Skill ")).length,
+					rejectedOps: validation.rejected.length + skippedUnread,
+					evidenceQuotes,
+					estimatedInputChars: reviewText.length
+				});
+				if (actions.length > 0) agent.inject(createUserMessage({
+					content: [{
+						type: "text",
+						text: `💾 Self-improvement review: ${actions.join(" · ")}`
+					}],
+					source: {
+						kind: "plugin",
+						plugin: "dsh-evolution-review",
+						form: "notice",
+						summary: "self-improvement review"
+					}
+				}));
+				return true;
+			} finally {
+				try {
+					await run.dispose();
+				} catch (disposeError) {
+					ctx.logger.warn(`dsh-evolution-review: subagent dispose failed: ${disposeError instanceof Error ? disposeError.message : String(disposeError)}`);
 				}
-			}));
-			return true;
+			}
 		} catch (error) {
 			ctx.logger.warn(`dsh-evolution-review: subagent review failed: ${error instanceof Error ? error.message : String(error)}`);
 			return false;
@@ -349,6 +364,23 @@ function collectReadSkillNames(session) {
 	}
 	return names;
 }
+/** Map/set size that triggers a dead-session counter sweep (bounded, not a hard cap). */
+const COUNTER_SWEEP_THRESHOLD = 128;
+/**
+* Remove every entry whose session is no longer live (rc.42 audit P1-10):
+* `turnStarts` / `cumulativeToolCalls` / `completionInjected` are keyed by
+* SessionId with no platform session-end hook to prune against, so they grew
+* unbounded over a long-lived host. Works for maps and sets; returns the
+* number of removed entries.
+*/
+function sweepDeadSessionEntries(entries, isAlive) {
+	let removed = 0;
+	for (const id of [...entries.keys()]) if (!isAlive(id)) {
+		entries.delete(id);
+		removed += 1;
+	}
+	return removed;
+}
 /**
 * Drop mutating ops whose target was not read this session, in place.
 * Create is exempt (no read required to author a new skill). Covers the same
@@ -418,4 +450,4 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 	].join("\n");
 }
 //#endregion
-export { Config, apply, collectReadSkillNames, filterUnreadSkillOps, inject, name, shouldCompletionReview };
+export { COUNTER_SWEEP_THRESHOLD, Config, apply, collectReadSkillNames, filterUnreadSkillOps, inject, name, shouldCompletionReview, sweepDeadSessionEntries };

package/lib/types/index.d.ts

@@ -38,6 +38,16 @@ export declare function shouldCompletionReview(reason: {
 } | undefined, sessionToolCalls: number, minToolCalls: number): boolean;
 /** Skill names this session loaded (read-before-write source for the background review). */
 export declare function collectReadSkillNames(session: Session): Set<string>;
+/** Map/set size that triggers a dead-session counter sweep (bounded, not a hard cap). */
+export declare const COUNTER_SWEEP_THRESHOLD = 128;
+/**
+ * Remove every entry whose session is no longer live (rc.42 audit P1-10):
+ * `turnStarts` / `cumulativeToolCalls` / `completionInjected` are keyed by
+ * SessionId with no platform session-end hook to prune against, so they grew
+ * unbounded over a long-lived host. Works for maps and sets; returns the
+ * number of removed entries.
+ */
+export declare function sweepDeadSessionEntries<K>(entries: Map<K, unknown> | Set<K>, isAlive: (id: K) => boolean): number;
 /**
  * Drop mutating ops whose target was not read this session, in place.
  * Create is exempt (no read required to author a new skill). Covers the same

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.1.0-rc.41",
+  "version": "0.1.0-rc.43",
   "publishConfig": {
     "access": "public"
   },
@@ -33,8 +33,8 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.41",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.41"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.43",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.43"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -43,7 +43,7 @@
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.41"
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.43"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.0-rc.6",
@@ -51,9 +51,11 @@
     "@deepseek-ai/dsh-invariants": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
+    "@deepseek-ai/dsh-session-persistence": "^0.1.0-rc.6",
+    "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.41",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.41",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.41"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.43",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.43",
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.43"
   }
 }