@lmzhen/dsh-evolution-review 0.1.0-rc.4 → 0.1.0-rc.6

package/README.md

@@ -21,4 +21,10 @@ Independent of request-prefix construction. This package does not alter the asse
 ## Known Limitations and Deferred Work
 
 
-- - Review subagents inherit the host preset; Anchored Standard deployments rely on the default `skill_search`/`skill_load` allow-list.
+- Review subagents inherit the host preset; Anchored Standard deployments rely on the default `skill_search`/`skill_load` allow-list.
+- Review subagents run as `spawn` children on the deployment default preset rather than inheriting the parent agent's composition (`fork`): a fork child is always promoted by the Anchored Standard bootstrap and its narrowed resident catalog would drop the plain `skill` tool from the review allow-list.
+- The review request text is redacted for credential-shaped patterns before it reaches the subagent, but redaction is pattern-based and best-effort, not a security boundary.
+
+## Configuration
+
+`reviewProvider` selects the LLM provider for review subagents. When omitted, the subagent inherits the deployment default route instead of a hardcoded provider name. Model selection stays on the policy (`memoryReviewModel` / `skillReviewModel`).

package/lib/index.js

@@ -3,6 +3,35 @@ import z from "@deepseek-ai/schemastery";
 import { CallId, createUserMessage } from "@deepseek-ai/dsh-llm";
 import { PROMPT_BUNDLE, advanceReview, foldTurn, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
+//#region lib/types/redact.js
+/**
+* Review-input redaction. Review/curator subagents are the one place where a
+* cross-session conversation snapshot leaves the owning session's context, so
+* credential-shaped text is masked before it is sent. Redaction is best-effort
+* and conservative: it targets well-known secret shapes and inline
+* assignment patterns, never wholesale content.
+*/
+const SECRET_PATTERNS = [
+	["openai-style key", /sk-[A-Za-z0-9_-]{16,}/g],
+	["aws access key", /AKIA[0-9A-Z]{16}/g],
+	["github token", /gh[pousr]_[A-Za-z0-9]{20,}/g],
+	["gitlab token", /glpat-[A-Za-z0-9_-]{16,}/g],
+	["slack token", /xox[baprs]-[A-Za-z0-9-]{10,}/g],
+	["jwt", /eyJ[A-Za-z0-9_-]{8,}\.[A-Za-z0-9_-]{8,}\.[A-Za-z0-9_-]{8,}/g],
+	["bearer credential", /Bearer [A-Za-z0-9._~+/=\-]{16,}/g],
+	["inline assignment", /(\b(?:token|api[_-]?key|secret|password|passwd)\b[\s]*[:=][\s]*[\"\x27]?)([A-Z0-9._~+/=\-]{12,})/gi]
+];
+/**
+* Mask credential-shaped text in a review request.
+* @param text - the assembled review request text.
+* @returns the text with matched secrets replaced by `<redacted>`.
+*/
+function redactReviewSecrets(text) {
+	let out = text;
+	for (const [, pattern] of SECRET_PATTERNS) out = out.replace(pattern, (_match, p1) => p1 === void 0 ? "<redacted>" : `${p1}<redacted>`);
+	return out;
+}
+//#endregion
 //#region lib/types/index.js
 /**
 * Background review orchestration: signal gate → one-shot subagent → trusted plan execution.
@@ -24,7 +53,8 @@ const Config = z.object({
 	executionTimeoutMs: z.number().default(3e4),
 	reviewContextMessages: z.number().default(60),
 	reviewMessageChars: z.number().default(2e3),
-	reviewMaxDepth: z.number().default(0)
+	reviewMaxDepth: z.number().default(0),
+	reviewProvider: z.string()
 });
 function apply(ctx, rawConfig) {
 	if (!verifyPromptBundle(PROMPT_BUNDLE)) throw new Error("dsh-evolution prompt bundle integrity check failed; refusing to schedule review work");
@@ -79,7 +109,9 @@ function apply(ctx, rawConfig) {
 		try {
 			const routingPolicy = ctx.get("evolutionPolicy");
 			const model = kind === "memory" ? routingPolicy?.get().memoryReviewModel ?? "deepseek-v4-flash" : routingPolicy?.get().skillReviewModel ?? "deepseek-v4-pro";
-			const reviewText = buildReviewRequest(session, kind, signal, config.reviewContextMessages, config.reviewMessageChars);
+			const reviewText = redactReviewSecrets(buildReviewRequest(session, kind, signal, config.reviewContextMessages, config.reviewMessageChars));
+			const agentOptions = { model };
+			if (config.reviewProvider) agentOptions.provider = config.reviewProvider;
 			const run = await subagents.start("spawn", {
 				label: "dsh-evolution-review",
 				prompt: [{
@@ -89,10 +121,7 @@ function apply(ctx, rawConfig) {
 				parent: agent,
 				signal: AbortSignal.timeout(config.reviewTimeoutMs),
 				maxDepth: config.reviewMaxDepth,
-				agentOptions: {
-					provider: "deepseek-official",
-					model
-				},
+				agentOptions,
 				persona: reviewPrompt(kind),
 				toolFilter: { allow: [...config.reviewToolAllow] },
 				outputSchema: {

package/lib/types/index.d.ts

@@ -18,6 +18,8 @@ export interface Config {
     reviewContextMessages?: number;
     reviewMessageChars?: number;
     reviewMaxDepth?: number;
+    /** LLM provider for review subagents. Omit to inherit the deployment default route. */
+    reviewProvider?: string;
 }
 export declare const Config: z<Config>;
 export declare function apply(ctx: Context, rawConfig: Config): void;

package/lib/types/redact.d.ts

@@ -0,0 +1,14 @@
+/**
+ * Review-input redaction. Review/curator subagents are the one place where a
+ * cross-session conversation snapshot leaves the owning session's context, so
+ * credential-shaped text is masked before it is sent. Redaction is best-effort
+ * and conservative: it targets well-known secret shapes and inline
+ * assignment patterns, never wholesale content.
+ */
+/**
+ * Mask credential-shaped text in a review request.
+ * @param text - the assembled review request text.
+ * @returns the text with matched secrets replaced by `<redacted>`.
+ */
+export declare function redactReviewSecrets(text: string): string;
+//# sourceMappingURL=redact.d.ts.map

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.1.0-rc.4",
+  "version": "0.1.0-rc.6",
   "publishConfig": {
     "access": "public"
   },
@@ -33,8 +33,8 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.4",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.4"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.6",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.6"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -43,7 +43,7 @@
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.4"
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.6"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.0-rc.6",
@@ -52,8 +52,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.4",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.4",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.4"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.6",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.6",
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.6"
   }
 }