@lmzhen/dsh-evolution-review 0.1.0-rc.28 → 0.1.0-rc.29

package/lib/index.js

@@ -1,7 +1,7 @@
 import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
-import { CallId, createUserMessage } from "@deepseek-ai/dsh-llm";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, PROMPT_BUNDLE, advanceReview, foldTurn, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { createUserMessage } from "@deepseek-ai/dsh-llm";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, PROMPT_BUNDLE, SkillLibrary, advanceReview, evolutionIoAdapter, foldTurn, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/redact.js
 /**
@@ -92,6 +92,8 @@ function apply(ctx, rawConfig) {
 			substantiveMinAgentChars: snapshot?.substantiveMinAgentChars ?? 500
 		});
 		await stateService?.saveReviewState(session.id, state);
+		const cumulative = (cumulativeToolCalls.get(session.id) ?? 0) + signal.toolCalls;
+		cumulativeToolCalls.set(session.id, cumulative);
 		if (kind) {
 			session.append("evolution/review-scheduled", {
 				kind,
@@ -116,8 +118,6 @@ function apply(ctx, rawConfig) {
 		const trigger = config.skillReviewTrigger;
 		if (trigger !== "completion" && trigger !== "both") return;
 		if (completionInjected.has(session.id)) return;
-		const cumulative = (cumulativeToolCalls.get(session.id) ?? 0) + signal.toolCalls;
-		cumulativeToolCalls.set(session.id, cumulative);
 		if (!shouldCompletionReview(event.data.reason, cumulative, config.skillReviewCompletionMinToolCalls)) return;
 		completionInjected.add(session.id);
 		session.append("evolution/review-scheduled", {
@@ -194,7 +194,7 @@ function apply(ctx, rawConfig) {
 			const acceptedSkillOps = validation.accepted.skillOps ?? [];
 			const skippedUnread = filterUnreadSkillOps(acceptedSkillOps, collectReadSkillNames(session));
 			validation.accepted.skillOps = acceptedSkillOps;
-			const actions = await executePlan(validation.accepted, agent);
+			const actions = await executePlan(validation.accepted);
 			const evidenceQuotes = [...validation.accepted.memoryOps ?? [], ...acceptedSkillOps].reduce((total, op) => total + (Array.isArray(op.evidence) ? op.evidence.length : 0), 0);
 			session.append("evolution/plan-applied", {
 				planId: randomUUID(),
@@ -223,7 +223,7 @@ function apply(ctx, rawConfig) {
 			return false;
 		}
 	}
-	async function executePlan(plan, parent) {
+	async function executePlan(plan) {
 		const memory = ctx.get("memory");
 		const approval = ctx.get("evolutionApproval");
 		const actions = [];
@@ -247,7 +247,7 @@ function apply(ctx, rawConfig) {
 				operation: args,
 				origin: "background_review"
 			};
-			if ((approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillTool(parent, args))?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
+			if ((approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillDirect(args))?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
 		}
 		return actions;
 		async function runApproved(kind, summary, stored, runnerArgs) {
@@ -264,19 +264,32 @@ function apply(ctx, rawConfig) {
 			};
 			return await approval.run(kind, runnerArgs);
 		}
-		async function executeSkillTool(agent, args) {
-			return (await ctx.tools.execute({
-				callId: CallId(`evolution-${randomUUID()}`),
-				name: "skill_manage",
-				arguments: args,
-				agent,
-				signal: AbortSignal.timeout(config.executionTimeoutMs)
-			})).isError ? {
+		/**
+		* Approval-disabled path: execute the skill op through SkillLibrary with an
+		* EXPLICIT background_review origin. Going through ctx.tools.execute would
+		* make tool-skill-manage infer origin from the parent agent's header
+		* (not 'subagent'), silently escaping the .hermes-managed marker and the
+		* pinned write guard.
+		*/
+		async function executeSkillDirect(skillArgs) {
+			const io = ctx.get("evolutionIo");
+			if (!io) return {
+				ok: false,
+				message: "evolution-io service not mounted"
+			};
+			const library = new SkillLibrary(void 0, evolutionIoAdapter(() => io.provider()));
+			const op = skillArgs;
+			const name = op.name ?? "";
+			const origin = "background_review";
+			if (op.action === "create") return await library.create(name, op.content ?? "", origin);
+			if (op.action === "edit" || op.action === "update") return await library.update(name, op.content ?? "", origin);
+			if (op.action === "patch") return await library.patch(name, op.old_string ?? "", op.new_string ?? "", op.file_path ?? "", false, origin);
+			if (op.action === "delete") return await library.archive(name, op.absorbed_into ? { absorbedInto: op.absorbed_into } : {});
+			if (op.action === "write_file") return await library.writeSupportFile(name, op.file_path ?? "", op.file_content ?? op.content ?? "", origin);
+			if (op.action === "remove_file") return await library.removeSupportFile(name, op.file_path ?? "", origin);
+			return {
 				ok: false,
-				message: "skill_manage execution failed"
-			} : {
-				ok: true,
-				message: "skill_manage executed"
+				message: `Unknown skill action "${op.action ?? ""}"`
 			};
 		}
 	}
@@ -322,6 +335,7 @@ function filterUnreadSkillOps(ops, readNames) {
 		"edit",
 		"update",
 		"patch",
+		"delete",
 		"write_file",
 		"remove_file"
 	];

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.1.0-rc.28",
+  "version": "0.1.0-rc.29",
   "publishConfig": {
     "access": "public"
   },
@@ -33,8 +33,8 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.28",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.28"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.29",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.29"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -43,7 +43,7 @@
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.28"
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.29"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.0-rc.6",
@@ -52,8 +52,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.28",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.28",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.28"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.29",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.29",
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.29"
   }
 }