@lmzhen/dsh-evolution-review 0.1.0-rc.13 → 0.1.0-rc.15

package/lib/index.js

@@ -1,7 +1,7 @@
 import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { CallId, createUserMessage } from "@deepseek-ai/dsh-llm";
-import { DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, PROMPT_BUNDLE, advanceReview, foldTurn, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, PROMPT_BUNDLE, advanceReview, foldTurn, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/redact.js
 /**
@@ -54,12 +54,16 @@ const Config = z.object({
 	reviewContextMessages: z.number().default(60),
 	reviewMessageChars: z.number().default(2e3),
 	reviewMaxDepth: z.number().default(0),
-	reviewProvider: z.string()
+	reviewProvider: z.string(),
+	skillReviewTrigger: z.string().default(DEFAULT_SKILL_REVIEW_TRIGGER),
+	skillReviewCompletionMinToolCalls: z.number().default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS)
 });
 function apply(ctx, rawConfig) {
 	if (!verifyPromptBundle(PROMPT_BUNDLE)) throw new Error("dsh-evolution prompt bundle integrity check failed; refusing to schedule review work");
 	const config = rawConfig;
 	const turnStarts = /* @__PURE__ */ new Map();
+	const cumulativeToolCalls = /* @__PURE__ */ new Map();
+	const completionInjected = /* @__PURE__ */ new Set();
 	const policy = () => ctx.get("evolutionPolicy")?.get();
 	ctx.on("session/event", (session, event) => {
 		if (event.type === "turn/start") turnStarts.set(session.id, session.seq - 1);
@@ -88,17 +92,38 @@ function apply(ctx, rawConfig) {
 			substantiveMinAgentChars: snapshot?.substantiveMinAgentChars ?? 500
 		});
 		await stateService?.saveReviewState(session.id, state);
-		if (!kind) return;
-		if (!await trySubagentReview(session, agent, kind, signal)) agent.inject(createUserMessage({
+		if (kind) {
+			if (!await trySubagentReview(session, agent, kind, signal)) agent.inject(createUserMessage({
+				content: [{
+					type: "text",
+					text: reviewPrompt(kind)
+				}],
+				source: {
+					kind: "plugin",
+					plugin: "dsh-evolution-review",
+					form: "notice",
+					summary: "auto-review"
+				}
+			}));
+			return;
+		}
+		const trigger = config.skillReviewTrigger;
+		if (trigger !== "completion" && trigger !== "both") return;
+		if (completionInjected.has(session.id)) return;
+		const cumulative = (cumulativeToolCalls.get(session.id) ?? 0) + signal.toolCalls;
+		cumulativeToolCalls.set(session.id, cumulative);
+		if (!shouldCompletionReview(event.data.reason, cumulative, config.skillReviewCompletionMinToolCalls)) return;
+		completionInjected.add(session.id);
+		agent.inject(createUserMessage({
 			content: [{
 				type: "text",
-				text: reviewPrompt(kind)
+				text: COMPLETION_SKILL_REVIEW_PROMPT
 			}],
 			source: {
 				kind: "plugin",
 				plugin: "dsh-evolution-review",
 				form: "notice",
-				summary: "auto-review"
+				summary: "completion review"
 			}
 		}));
 	}
@@ -154,14 +179,17 @@ function apply(ctx, rawConfig) {
 				maxUserChars: snapshot?.userChars ?? 1375,
 				maxSkillContentChars: snapshot?.skillContentChars ?? 1e5
 			});
+			const acceptedSkillOps = validation.accepted.skillOps ?? [];
+			const skippedUnread = filterUnreadSkillOps(acceptedSkillOps, collectReadSkillNames(session));
+			validation.accepted.skillOps = acceptedSkillOps;
 			const actions = await executePlan(validation.accepted, agent);
-			const evidenceQuotes = [...validation.accepted.memoryOps ?? [], ...validation.accepted.skillOps ?? []].reduce((total, op) => total + (Array.isArray(op.evidence) ? op.evidence.length : 0), 0);
+			const evidenceQuotes = [...validation.accepted.memoryOps ?? [], ...acceptedSkillOps].reduce((total, op) => total + (Array.isArray(op.evidence) ? op.evidence.length : 0), 0);
 			session.append("evolution/plan-applied", {
 				planId: randomUUID(),
 				policyFingerprint,
 				memoryApplied: actions.filter((action) => action.startsWith("Memory")).length,
 				skillApplied: actions.filter((action) => action.startsWith("Skill ")).length,
-				rejectedOps: validation.rejected.length,
+				rejectedOps: validation.rejected.length + skippedUnread,
 				evidenceQuotes,
 				estimatedInputChars: reviewText.length
 			});
@@ -203,10 +231,11 @@ function apply(ctx, rawConfig) {
 				...op,
 				evidence: op.evidence
 			};
-			if ((approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, {
+			const runnerArgs = {
 				operation: args,
 				origin: "background_review"
-			}, args) : await executeSkillTool(parent, args))?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
+			};
+			if ((approval ? await runApproved("skill", `skill ${op.action ?? "patch"} ${op.name}`, runnerArgs, runnerArgs) : await executeSkillTool(parent, args))?.ok) actions.push(`Skill ${op.name} ${op.action ?? "patch"}`);
 		}
 		return actions;
 		async function runApproved(kind, summary, stored, runnerArgs) {
@@ -241,8 +270,50 @@ function apply(ctx, rawConfig) {
 	}
 	ctx.effect(() => () => {
 		turnStarts.clear();
+		cumulativeToolCalls.clear();
+		completionInjected.clear();
 	}, "dsh-evolution-review.cleanup");
 }
+/** Completion-channel decision: task finished normally AND the session is proven long. */
+function shouldCompletionReview(reason, sessionToolCalls, minToolCalls) {
+	return reason?.kind === "completed" && sessionToolCalls >= minToolCalls;
+}
+/** Skill names this session loaded (read-before-write source for the background review). */
+function collectReadSkillNames(session) {
+	const names = /* @__PURE__ */ new Set();
+	for (const event of session.events) {
+		if (event.type !== "tool/call") continue;
+		if (event.data.name !== "skill" && event.data.name !== "skill_load") continue;
+		const raw = event.data.arguments;
+		let parsed = {};
+		if (typeof raw === "string") try {
+			parsed = JSON.parse(raw);
+		} catch {
+			continue;
+		}
+		else parsed = raw ?? {};
+		const name = typeof parsed.name === "string" ? parsed.name : typeof parsed.skill === "string" ? parsed.skill : "";
+		if (name) names.add(name);
+	}
+	return names;
+}
+/**
+* Drop patch/update ops whose target was not read this session, in place.
+* Create is exempt (no read required to author a new skill). Returns the count
+* of dropped ops so the plan event can report them as rejected.
+*/
+function filterUnreadSkillOps(ops, readNames) {
+	let dropped = 0;
+	for (let index = ops.length - 1; index >= 0; index -= 1) {
+		const op = ops[index];
+		if (!op) continue;
+		if ((op.action === "patch" || op.action === "update") && op.name && !readNames.has(op.name)) {
+			ops.splice(index, 1);
+			dropped += 1;
+		}
+	}
+	return dropped;
+}
 function fingerprintPolicy(snapshot) {
 	try {
 		return createHash("sha256").update(JSON.stringify(snapshot)).digest("hex").slice(0, 12);
@@ -266,4 +337,4 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 	].join("\n");
 }
 //#endregion
-export { Config, apply, inject, name };
+export { Config, apply, collectReadSkillNames, filterUnreadSkillOps, inject, name, shouldCompletionReview };

package/lib/types/index.d.ts

@@ -4,6 +4,7 @@
  */
 import type { Context } from '@deepseek-ai/cordis';
 import z from '@deepseek-ai/schemastery';
+import type { Session } from '@deepseek-ai/dsh-session';
 export declare const name = "evolution-review";
 export declare const inject: string[];
 export interface Config {
@@ -20,7 +21,26 @@ export interface Config {
     reviewMaxDepth?: number;
     /** LLM provider for review subagents. Omit to inherit the deployment default route. */
     reviewProvider?: string;
+    /** Skill-review trigger: cadence (interval) | completion (once after a proven-long task) | both. */
+    skillReviewTrigger?: string;
+    /** Cumulative session tool calls before a session counts as proven-long for the completion channel. */
+    skillReviewCompletionMinToolCalls?: number;
 }
 export declare const Config: z<Config>;
 export declare function apply(ctx: Context, rawConfig: Config): void;
+/** Completion-channel decision: task finished normally AND the session is proven long. */
+export declare function shouldCompletionReview(reason: {
+    kind?: string;
+} | undefined, sessionToolCalls: number, minToolCalls: number): boolean;
+/** Skill names this session loaded (read-before-write source for the background review). */
+export declare function collectReadSkillNames(session: Session): Set<string>;
+/**
+ * Drop patch/update ops whose target was not read this session, in place.
+ * Create is exempt (no read required to author a new skill). Returns the count
+ * of dropped ops so the plan event can report them as rejected.
+ */
+export declare function filterUnreadSkillOps(ops: Array<{
+    action?: string;
+    name?: string;
+}>, readNames: ReadonlySet<string>): number;
 //# sourceMappingURL=index.d.ts.map

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.1.0-rc.13",
+  "version": "0.1.0-rc.15",
   "publishConfig": {
     "access": "public"
   },
@@ -33,8 +33,8 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.13",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.13"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.15",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.15"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -43,7 +43,7 @@
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.13"
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.15"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.0-rc.6",
@@ -52,8 +52,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.13",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.13",
-    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.13"
+    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.15",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.1.0-rc.15",
+    "@lmzhen/dsh-evolution-state": "^0.1.0-rc.15"
   }
 }