@lmzhen/dsh-evolution-learning-graph 0.3.61 → 0.3.63

package/README.md

@@ -10,7 +10,7 @@ Memory node ids carry a trailing snapshot token (`memory:<source>:<index>:<snaps
 
 Memory→skill edges are word-level, not substring: the entry is tokenized on non-letter/digit/hyphen runs and a skill name links only when it is a whole token. This prevents a skill named `run` from linking the words `running`/`grunt`.
 
-`graph edit`/`graph delete` of a skill node route through the evolution approval seam when it is mounted (soft-probed; the write executes directly when it is absent). Each approved/executed edit bumps the skill's patch counter and a delete archives it, matching `skill_manage` — including the no-op gate: an edit whose content is byte-equivalent to the current file (`noop`) writes nothing and does not bump the patch counter, exactly as `skill_manage` treats an unchanged update/patch. The command invocation's session rides the approval request (v12 N1), so a `never`-policy session stages nothing instead of deriving every graph write as foreground.
+`graph edit`/`graph delete` route through the evolution approval seam when it is mounted (soft-probed; the write executes directly when it is absent) — for BOTH skill nodes and memory nodes (P2-6, v15; memory staged args mirror the `memory` tool runner's replay shape). Before staging, the seam's `hasRunner` is checked (P2-7, v15): with approval enabled, a session policy that is not `never`, and the write actually staging (foreground stages per approval `stageForeground`; subagent origins always stage), a missing replay runner's row (tool-skill-manage / tool-memory) refuses the write; allow-direct combinations execute unchanged instead of creating a pending record no approver could replay. Each approved/executed edit bumps the skill's patch counter and a delete archives it, matching `skill_manage` — including the no-op gate: an edit whose content is byte-equivalent to the current file (`noop`) writes nothing and does not bump the patch counter, exactly as `skill_manage` treats an unchanged update/patch. The command invocation's session rides the approval request (v12 N1), so a `never`-policy session stages nothing instead of deriving every graph write as foreground.
 
 ## Model Experience
 

package/lib/index.js

@@ -255,12 +255,14 @@ function apply(ctx, rawConfig = {}) {
 					const memoryEntries = await memory.read("memory");
 					const userEntries = await memory.read("user");
 					const skills = withSkills();
+					const names = [...usageMap.keys()];
+					const contents = await Promise.all(names.map((name) => skills.read(name)));
 					const related = /* @__PURE__ */ new Map();
-					for (const name of usageMap.keys()) {
-						const content = await skills.read(name);
-						if (content === null) continue;
+					names.forEach((name, index) => {
+						const content = contents[index];
+						if (content === null || content === void 0) return;
 						related.set(name, relatedSkillNames(content, name));
-					}
+					});
 					const graph = buildLearningGraph(usageMap, memoryEntries, userEntries, related);
 					const nodeBlock = capRenderedLines(graph.nodes.map((node) => renderNodeLine(node)));
 					const edgeBlock = capRenderedLines(graph.edges.map((edge) => edge.from + " --" + edge.type + "--> " + edge.to));
@@ -287,9 +289,12 @@ function apply(ctx, rawConfig = {}) {
 					if (parsed === null) return err(`Invalid node id "${id}". Skill names or memory:<source>:<index> expected.`);
 					if (parsed.kind === "skill") {
 						const approval = ctx.get("evolutionApproval");
+						const origins = resolveOrigins(session?.header?.origin);
 						if (approval) {
-							const origins = resolveOrigins(session?.header?.origin);
-							const sessionPolicy = effectiveSessionPolicy(ctx, session);
+							const sessionPolicyEdit = effectiveSessionPolicy(ctx, session);
+							const stagesForeground = approval.stageForeground !== false;
+							if (approval.isEnabled !== false && sessionPolicyEdit !== "never" && (origins.approval === "background_review" || stagesForeground) && !approval.hasRunner("skill")) return err("Graph skill write cannot be staged: no skill replay runner is registered — mount the tool-skill-manage row (evolution-agent preset) or disable evolution-approval.");
+							const sessionPolicy = sessionPolicyEdit;
 							const decision = await approval.request({
 								kind: "skill",
 								summary: `graph edit ${parsed.name}`,
@@ -309,12 +314,35 @@ function apply(ctx, rawConfig = {}) {
 							});
 							if (decision.action === "staged") return ok(decision.message);
 						}
-						const result = await withSkills().update(parsed.name, content, "foreground");
+						const result = await withSkills().update(parsed.name, content, origins.library);
 						if (result.ok && result.noop !== true) await usageService.record?.(parsed.name, "patch");
 						return result.ok ? ok(result.message) : err(result.message);
 					}
 					const check = readMemoryIndex(parsed, await memory.read(parsed.source));
 					if (!check.ok) return err(check.message ?? "Memory index check failed.");
+					const memoryApproval = ctx.get("evolutionApproval");
+					if (memoryApproval) {
+						const originsM = resolveOrigins(session?.header?.origin);
+						const sessionPolicyM = effectiveSessionPolicy(ctx, session);
+						if (memoryApproval.isEnabled !== false && sessionPolicyM !== "never" && (originsM.approval === "background_review" || memoryApproval.stageForeground !== false) && !memoryApproval.hasRunner("memory")) return err("Graph memory write cannot be staged: no memory replay runner is registered — mount the tool-memory row (evolution-host/evolution-all bundle) or disable evolution-approval.");
+						const decision = await memoryApproval.request({
+							kind: "memory",
+							summary: `graph edit memory:${parsed.source}:${parsed.index}`,
+							args: {
+								target: parsed.source,
+								operations: [{
+									action: "replace",
+									old_text: check.entry ?? "",
+									facts: content
+								}]
+							},
+							origin: originsM.approval,
+							...session?.id ? { sessionId: session.id } : {},
+							...session ? { session } : {},
+							...sessionPolicyM !== void 0 ? { sessionPolicy: sessionPolicyM } : {}
+						});
+						if (decision.action === "staged") return ok(decision.message);
+					}
 					const result = await memory.applyBatch(parsed.source, [{
 						action: "replace",
 						old_text: check.entry ?? "",
@@ -330,6 +358,7 @@ function apply(ctx, rawConfig = {}) {
 						if (approval) {
 							const origins = resolveOrigins(session?.header?.origin);
 							const sessionPolicy = effectiveSessionPolicy(ctx, session);
+							if (approval.isEnabled !== false && sessionPolicy !== "never" && (origins.approval === "background_review" || approval.stageForeground !== false) && !approval.hasRunner("skill")) return err("Graph skill delete cannot be staged: no skill replay runner is registered — mount the tool-skill-manage row (evolution-agent preset) or disable evolution-approval.");
 							const decision = await approval.request({
 								kind: "skill",
 								summary: `graph delete ${parsed.name}`,
@@ -354,6 +383,28 @@ function apply(ctx, rawConfig = {}) {
 					}
 					const check = readMemoryIndex(parsed, await memory.read(parsed.source));
 					if (!check.ok) return err(check.message ?? "Memory index check failed.");
+					const memoryApproval = ctx.get("evolutionApproval");
+					if (memoryApproval) {
+						const origins = resolveOrigins(session?.header?.origin);
+						const sessionPolicy = effectiveSessionPolicy(ctx, session);
+						if (memoryApproval.isEnabled !== false && sessionPolicy !== "never" && (origins.approval === "background_review" || memoryApproval.stageForeground !== false) && !memoryApproval.hasRunner("memory")) return err("Graph memory delete cannot be staged: no memory replay runner is registered — mount the tool-memory row (evolution-host/evolution-all bundle) or disable evolution-approval.");
+						const decision = await memoryApproval.request({
+							kind: "memory",
+							summary: `graph delete memory:${parsed.source}:${parsed.index}`,
+							args: {
+								target: parsed.source,
+								operations: [{
+									action: "remove",
+									old_text: check.entry ?? ""
+								}]
+							},
+							origin: origins.approval,
+							...session?.id ? { sessionId: session.id } : {},
+							...session ? { session } : {},
+							...sessionPolicy !== void 0 ? { sessionPolicy } : {}
+						});
+						if (decision.action === "staged") return ok(decision.message);
+					}
 					const result = await memory.applyBatch(parsed.source, [{
 						action: "remove",
 						old_text: check.entry ?? ""

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-learning-graph",
   "description": "Learning graph over skills and memory (community build)",
-  "version": "0.3.61",
+  "version": "0.3.63",
   "publishConfig": {
     "access": "public"
   },
@@ -31,8 +31,8 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.61",
-    "@lmzhen/dsh-evolution-core": "^0.3.61"
+    "@lmzhen/dsh-evolution-approval": "^0.3.63",
+    "@lmzhen/dsh-evolution-core": "^0.3.63"
   },
   "peerDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",