@lmzhen/dsh-evolution-feedback 0.3.82 → 0.4.0

package/README.md

@@ -1,27 +1,27 @@
-# @deepseek-ai/dsh-evolution-feedback
+# @lmzhen/dsh-evolution-feedback
 
-Feedback-to-quality scoring for self-evolution
+Feedback-to-quality scoring: durable through `ctx.evolutionIo`; skill feedback feeds the
+FEEDBACK-OWNED `feedback_score`/`feedback_warn` pair.
 
-## Model Experience
+## Model surface
 
-### Indirect model surface
+- **Model-visible:** nothing of its own: the usage-record readers own it.
+- **Prompt prefix / KV cache:** unchanged by this package: family-level rules single-sourced in `packages/README.md` §"Model-visible prompt prefix and the KV cache".
+- **Mount it?** yes — the `evolution-feedback` row, `evolution-host`/`evolution-all`/`evolution-preset`.
 
-#### What the model sees
+## Configuration
 
-`@deepseek-ai/dsh-evolution-feedback` registers no direct prompt or tool schema itself. Model-visible effects are owned by the packages that consume this service.
+- `qualityWarnThreshold` (default `-0.25`): score below which the pair flips to warned.
+- `path`: boot-cache path; `''` means `$DSH_HOME/evolution/feedback.json` (the event log is not affected).
 
-#### Token effect
+## Known limitations
 
-Zero direct token effect from this package; consumers add any model-visible tokens.
-
-#### KV Cache effect
-
-Independent of request-prefix construction. This package does not alter the assembled prompt or tool list.
-
-## Known Limitations and Deferred Work
+- Lifecycle and scope views read `quality_warn || feedback_warn`, so negative feedback shortens the stale window even though the curator recomputes `quality_warn`.
 
+**Runtime invariant:** No companion is published. The platform auto-assembles nothing and the family mounts no `<pkg>/invariant` cordis row, so a companion here would never execute (v37 S2.1 / I-3).
 
-- Persists through the IO seam; quality propagation into skill usage requires the `skillUsage` service.
-- P1-1 (v15): feedback writes the FEEDBACK-OWNED `feedback_score`/`feedback_warn` usage fields. The lifecycle engine and the scope view read the union `quality_warn || feedback_warn`, so a negative feedback shortens the stale window even though the curator's six-factor run always recomputes `quality_warn` itself.
+## Notes and history
 
-**Runtime invariant:** No companion is published. The platform auto-assembles nothing and the family mounts no `<pkg>/invariant` cordis row, so a companion here would never execute (v37 S2.1 / I-3).
+- Persists through the IO seam; quality propagation into skill usage requires BOTH the `skillUsage` service and a mounted IO backend: with no `evolutionIo` the push returns before touching the persistent usage sidecar (S4.6), so an optimistic in-memory score never lands there unconfirmed.
+- The in-memory-wins window of a log refold is the IN-FLIGHT append window only, counted PER TARGET (two appends for one target in flight at once both stay protected, and the no-io path never enters it): a settled target folds from the log truth, so another process sharing `DSH_HOME` is not overwritten by this process's stale record (S1.4).
+- P1-1 (v15): feedback writes the FEEDBACK-OWNED `feedback_score`/`feedback_warn` usage fields.

package/lib/index.js

@@ -57,6 +57,21 @@ var EvolutionFeedback = class EvolutionFeedback {
 	* unpersisted note there, and reverting to it resurrects a value the log
 	* never held). Seeded from the fold truth, updated on successful appends. */
 	durableNote = /* @__PURE__ */ new Map();
+	/** PLAN S1.4 (2026-09-16): targets with a feedback append still IN FLIGHT,
+	* split by table, as a COUNT per target. record() increments before queueing
+	* the append and the append task decrements when it settles (landed or rolled
+	* back, finally), dropping the entry only at ZERO — the count covers exactly
+	* the optimistic window rc.66 meant to protect, including two appends for the
+	* same target in flight at once (review C-P2-1: a per-target boolean marker
+	* was cleared by the first settle, so a merge between the two appends folded
+	* the second append's increment away). restore() lets memory win ONLY for these targets — a settled
+	* target folds from the log truth, so another process's feedback for the
+	* same target (audit P1-3) is never overwritten by this process's stale
+	* record. */
+	pendingAppends = {
+		skills: /* @__PURE__ */ new Map(),
+		sessions: /* @__PURE__ */ new Map()
+	};
 	/** P2-32 (v11): process-level bound — every feedbacked session would
 	* otherwise keep one entry for the whole process lifetime (a name + note
 	* string per session); cap this map and drop the earliest-INSERTED entry on
@@ -85,6 +100,14 @@ var EvolutionFeedback = class EvolutionFeedback {
 	attachIo(io) {
 		this.io = io;
 	}
+	/** PLAN S4.6 (2026-09-16): whether a durable backend is attached — the
+	* plugin's quality push (`apply`) consults this before writing the
+	* feedback pair into the skill-usage sidecar. Same no-io posture as
+	* `record`/`refold`: without `ctx.evolutionIo` (when mounted) nothing may
+	* turn the optimistic in-memory aggregate into a durable side effect. */
+	get durable() {
+		return this.io !== void 0 && !!this.eventsPath;
+	}
 	/** V5-32 posture applied to the read side (C-events-dispatch-1, v43): an
 	* event a repeated read keeps reporting must not warn on each read —
 	* `refold()` calls `restore()` before every quality push. Shares the bounded
@@ -133,14 +156,23 @@ var EvolutionFeedback = class EvolutionFeedback {
 			const floor = events[0]?.seq ?? 0;
 			const usableCache = cache && cache.lastSeq >= floor - 1 ? cache : null;
 			const truth = usableCache ? foldWithDelta(usableCache, events, this.warn) : foldFeedbackState(events, this.warn);
+			const pickPending = (mode) => {
+				const picked = {};
+				for (const [target, inFlight] of this.pendingAppends[mode]) {
+					if (inFlight <= 0) continue;
+					const record = this.state[mode][target];
+					if (record) picked[target] = record;
+				}
+				return picked;
+			};
 			this.state = {
 				skills: {
 					...truth.skills,
-					...this.state.skills
+					...pickPending("skills")
 				},
 				sessions: {
 					...truth.sessions,
-					...this.state.sessions
+					...pickPending("sessions")
 				}
 			};
 			const skillEntries = Object.entries(truth.skills);
@@ -204,6 +236,8 @@ var EvolutionFeedback = class EvolutionFeedback {
 		const recordIo = this.io;
 		const eventsPath = this.eventsPath;
 		if (!recordIo || !eventsPath) return;
+		const pending = this.pendingAppends[mode];
+		pending.set(target, (pending.get(target) ?? 0) + 1);
 		this.mutate(async () => {
 			try {
 				const seq = await appendEvolutionEvent(recordIo, eventsPath, {
@@ -244,6 +278,10 @@ var EvolutionFeedback = class EvolutionFeedback {
 					this.warn(message);
 				}
 				if (rollback) this.onRollback?.(target, kind);
+			} finally {
+				const remaining = (pending.get(target) ?? 1) - 1;
+				if (remaining > 0) pending.set(target, remaining);
+				else pending.delete(target);
 			}
 		});
 	}
@@ -617,6 +655,7 @@ function apply(ctx, rawConfig = {}) {
 		const skillUsage = skillCtx.skillUsage;
 		const pushQuality = (target, kind) => {
 			if (kind !== "skill") return;
+			if (!feedback.durable) return;
 			feedback.refold().then(() => {
 				const score = feedback.score(target, "skill");
 				const warn = score < qualityWarnThreshold;

package/lib/types/index.d.ts

@@ -50,6 +50,18 @@ export declare class EvolutionFeedback {
      * unpersisted note there, and reverting to it resurrects a value the log
      * never held). Seeded from the fold truth, updated on successful appends. */
     private readonly durableNote;
+    /** PLAN S1.4 (2026-09-16): targets with a feedback append still IN FLIGHT,
+     * split by table, as a COUNT per target. record() increments before queueing
+     * the append and the append task decrements when it settles (landed or rolled
+     * back, finally), dropping the entry only at ZERO — the count covers exactly
+     * the optimistic window rc.66 meant to protect, including two appends for the
+     * same target in flight at once (review C-P2-1: a per-target boolean marker
+     * was cleared by the first settle, so a merge between the two appends folded
+     * the second append's increment away). restore() lets memory win ONLY for these targets — a settled
+     * target folds from the log truth, so another process's feedback for the
+     * same target (audit P1-3) is never overwritten by this process's stale
+     * record. */
+    private readonly pendingAppends;
     /** P2-32 (v11): process-level bound — every feedbacked session would
      * otherwise keep one entry for the whole process lifetime (a name + note
      * string per session); cap this map and drop the earliest-INSERTED entry on
@@ -71,6 +83,12 @@ export declare class EvolutionFeedback {
     constructor(io?: IoLike, home?: string, pathOverride?: string, warn?: (message: string) => void);
     /** Bind the evolution IO backend after construction (S6.4 deferred binding). */
     attachIo(io: IoLike): void;
+    /** PLAN S4.6 (2026-09-16): whether a durable backend is attached — the
+     * plugin's quality push (`apply`) consults this before writing the
+     * feedback pair into the skill-usage sidecar. Same no-io posture as
+     * `record`/`refold`: without `ctx.evolutionIo` (when mounted) nothing may
+     * turn the optimistic in-memory aggregate into a durable side effect. */
+    get durable(): boolean;
     /** V5-32 posture applied to the read side (C-events-dispatch-1, v43): an
      * event a repeated read keeps reporting must not warn on each read —
      * `refold()` calls `restore()` before every quality push. Shares the bounded

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-feedback",
   "description": "Feedback-to-quality scoring for self-evolution (community build)",
-  "version": "0.3.82",
+  "version": "0.4.0",
   "publishConfig": {
     "access": "public"
   },
@@ -27,16 +27,16 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.3.82"
+    "@lmzhen/dsh-evolution-core": "^0.4.0"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
-    "@lmzhen/dsh-evolution-io": "^0.3.82",
-    "@lmzhen/dsh-skill-usage": "^0.3.82"
+    "@lmzhen/dsh-evolution-io": "^0.4.0",
+    "@lmzhen/dsh-skill-usage": "^0.4.0"
   },
   "devDependencies": {
-    "@lmzhen/dsh-evolution-io": "^0.3.82",
-    "@lmzhen/dsh-evolution-io-node": "^0.3.82",
-    "@lmzhen/dsh-skill-usage": "^0.3.82"
+    "@lmzhen/dsh-evolution-io": "^0.4.0",
+    "@lmzhen/dsh-evolution-io-node": "^0.4.0",
+    "@lmzhen/dsh-skill-usage": "^0.4.0"
   }
 }