@lmzhen/dsh-evolution-feedback 0.3.70 → 0.3.72

package/lib/index.js

@@ -1,5 +1,5 @@
 import z from "@deepseek-ai/schemastery";
-import { EVENT_LOG_VERSION, appendEvolutionEvent, clampedNumber, eventsFile, evolutionIoAdapter, evolutionRoot, listEventArchives, parseEvolutionEvents, readEvolutionTimeline, transactIo } from "@lmzhen/dsh-evolution-core";
+import { EVENT_LOG_VERSION, appendEvolutionEvent, clampedNumber, eventsFile, evolutionEventPayloadIssue, evolutionIoAdapter, evolutionRoot, listEventArchives, parseEvolutionEvents, readEvolutionTimeline, transactIo } from "@lmzhen/dsh-evolution-core";
 import { join } from "node:path";
 //#region lib/types/index.js
 /**
@@ -90,14 +90,15 @@ var EvolutionFeedback = class EvolutionFeedback {
 		await this.mutate(async () => {
 			const rawEvents = await io.readText(eventsPath);
 			const archiveNames = await listEventArchives(io, eventsPath);
+			const rawCache = await io.readText(path);
 			if ((rawEvents === null || rawEvents.trim() === "") && archiveNames.length === 0) {
-				const aggregate = parseAggregate(await io.readText(path), this.warn);
+				const aggregate = parseAggregate(rawCache, this.warn);
 				if (aggregate) try {
-					await migrateFeedbackEvents(io, eventsPath, aggregate);
+					await migrateFeedbackEvents(io, eventsPath, aggregate, this.warn);
 				} catch {}
 			}
-			const { events } = await readEvolutionTimeline(io, eventsPath);
-			const cache = parseCache(await io.readText(path), this.warn);
+			const { events } = await readEvolutionTimeline(io, eventsPath, archiveNames);
+			const cache = parseCache(rawCache, this.warn);
 			const maxSeq = events.reduce((max, event) => Math.max(max, event.seq), 0);
 			const floor = events[0]?.seq ?? 0;
 			const usableCache = cache && cache.lastSeq >= floor - 1 ? cache : null;
@@ -222,6 +223,14 @@ var EvolutionFeedback = class EvolutionFeedback {
 		if (total === 0) return 0;
 		return (record.positive - record.negative) / total;
 	}
+	/**
+	* Deep-copy view of the live aggregate.
+	*
+	* OPT-26 (2026-09): `@internal` — test-support API, NO production consumer
+	* in the family (mirrors the explicit posture of evolution-replay's
+	* `plansSnapshot()`). External consumers should read the rendered
+	* score/warn surfaces instead of relying on this shape.
+	*/
 	snapshot() {
 		const copyRecords = (table) => {
 			const out = {};
@@ -294,8 +303,13 @@ function containsLegacySequence(existing, expected) {
 * and race-safe (the search runs inside the same transact). Exported for the
 * migration-race regression test.
 */
-async function migrateFeedbackEvents(io, eventsPath, aggregate) {
+async function migrateFeedbackEvents(io, eventsPath, aggregate, warn = () => {}) {
 	const expected = synthesizeFeedbackEvents(aggregate);
+	const refused = expected.filter((event) => evolutionEventPayloadIssue(event) !== null);
+	if (refused.length > 0) {
+		warn(`evolution-feedback: migration refused ${refused.length} synthesized event(s) that the event log's payload gate rejects (types: ${[...new Set(refused.map((event) => event.type))].join(", ")}) — history starts empty instead of writing an unreadable log`);
+		return;
+	}
 	await transactIo(io, eventsPath, (current) => {
 		const existing = parseEvolutionEvents(current);
 		if (containsLegacySequence(existing, expected)) return Promise.resolve(current);
@@ -367,12 +381,28 @@ function parseCache(raw, warn = () => {}) {
 /** Per-record numeric-domain validation (S6.4): a record whose `positive` or
 * `negative` is not a finite number >= 0, or whose `lastNote` is not a string,
 * would fold as NaN into the usage aggregate — skip it with a warn instead of
-* corrupting the state. A record with no valid count is dropped entirely. */
+* corrupting the state. A record with no valid count is dropped entirely.
+* OPT-25 (2026-09): a count ABOVE `MAX_MIGRATED_EVENTS_PER_RECORD` is now
+* CLAMPED here with a warn, symmetric with the migration reader's clamp (same
+* file, same threat model — V24-05 covered the migration side only). Before,
+* a poisoned boot-cache count folded as-is into every downstream decision;
+* the clamp bounds the skew to the same ceiling migration accepts. */
 function sanitizeCacheRecords(input, kind, warn) {
 	const out = {};
 	for (const [target, value] of Object.entries(input)) {
 		const record = sanitizeFeedbackRecord(value, target, kind, warn);
-		if (record) out[target] = record;
+		if (record) {
+			let clamped;
+			if (record.positive > MAX_MIGRATED_EVENTS_PER_RECORD || record.negative > MAX_MIGRATED_EVENTS_PER_RECORD) {
+				warn(`evolution-feedback: cache record for ${kind} "${target}" exceeds the clamp ceiling (${MAX_MIGRATED_EVENTS_PER_RECORD}) — clamping like the migration reader`);
+				clamped = {
+					positive: Math.min(record.positive, MAX_MIGRATED_EVENTS_PER_RECORD),
+					negative: Math.min(record.negative, MAX_MIGRATED_EVENTS_PER_RECORD),
+					...record.lastNote !== void 0 ? { lastNote: record.lastNote } : {}
+				};
+			}
+			out[target] = clamped ?? record;
+		}
 	}
 	return out;
 }

package/lib/types/index.d.ts

@@ -98,6 +98,14 @@ export declare class EvolutionFeedback {
     refold(): Promise<void>;
     record(target: string, rating: 'positive' | 'negative', note?: string, kind?: 'skill' | 'session'): void;
     score(target: string, kind?: 'skill' | 'session'): number;
+    /**
+     * Deep-copy view of the live aggregate.
+     *
+     * OPT-26 (2026-09): `@internal` — test-support API, NO production consumer
+     * in the family (mirrors the explicit posture of evolution-replay's
+     * `plansSnapshot()`). External consumers should read the rendered
+     * score/warn surfaces instead of relying on this shape.
+     */
     snapshot(): FeedbackState;
     /** Await the pending record-task chain (unload safety; rc.66). */
     waitIdle(): Promise<unknown>;
@@ -116,7 +124,7 @@ export declare class EvolutionFeedback {
  * and race-safe (the search runs inside the same transact). Exported for the
  * migration-race regression test.
  */
-export declare function migrateFeedbackEvents(io: IoLike, eventsPath: string, aggregate: FeedbackState): Promise<void>;
+export declare function migrateFeedbackEvents(io: IoLike, eventsPath: string, aggregate: FeedbackState, warn?: (message: string) => void): Promise<void>;
 export declare const name = "evolution-feedback";
 export interface Config {
     /** Score below which the FEEDBACK pair flips to warned (P1-1, v15: written

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-feedback",
   "description": "Feedback-to-quality scoring for self-evolution (community build)",
-  "version": "0.3.70",
+  "version": "0.3.72",
   "publishConfig": {
     "access": "public"
   },
@@ -31,18 +31,18 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.3.70"
+    "@lmzhen/dsh-evolution-core": "^0.3.72"
   },
   "peerDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.5-rc.2",
     "@deepseek-ai/cordis": "^4.0.1",
-    "@lmzhen/dsh-evolution-io": "^0.3.70",
-    "@lmzhen/dsh-skill-usage": "^0.3.70"
+    "@lmzhen/dsh-evolution-io": "^0.3.72",
+    "@lmzhen/dsh-skill-usage": "^0.3.72"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.3.70",
-    "@lmzhen/dsh-evolution-io-node": "^0.3.70",
-    "@lmzhen/dsh-skill-usage": "^0.3.70"
+    "@lmzhen/dsh-evolution-io": "^0.3.72",
+    "@lmzhen/dsh-evolution-io-node": "^0.3.72",
+    "@lmzhen/dsh-skill-usage": "^0.3.72"
   }
 }