@lmzhen/dsh-evolution-feedback 0.3.62 → 0.3.64

package/README.md

@@ -22,3 +22,4 @@ Independent of request-prefix construction. This package does not alter the asse
 
 
 - Persists through the IO seam; quality propagation into skill usage requires the `skillUsage` service.
+- P1-1 (v15): feedback writes the FEEDBACK-OWNED `feedback_score`/`feedback_warn` usage fields. The lifecycle engine and the scope view read the union `quality_warn || feedback_warn`, so a negative feedback shortens the stale window even though the curator's six-factor run always recomputes `quality_warn` itself.

package/lib/index.js

@@ -6,8 +6,15 @@ import { join } from "node:path";
 * Feedback-to-quality scoring for self-evolution.
 *
 * Feedback is durable through `ctx.evolutionIo` (when mounted) and skill
-* feedback feeds `quality_score` / `quality_warn` on the usage record, so
-* curator decisions can consume it deterministically.
+* feedback feeds the FEEDBACK-OWNED `feedback_score` / `feedback_warn` pair on
+* the usage record. P1-1 (v15): this package used to write
+* `quality_score`/`quality_warn` — but the curator's six-factor `scoreTree`
+* overwrote those fields on every run BEFORE the lifecycle engine read them,
+* so the advertised "curator decisions consume feedback deterministically"
+* channel was dead. The lifecycle engine and the scope view now read the
+* union `quality_warn || feedback_warn`, and the curator never writes the
+* feedback pair (field-ownership contract on `UsageRecord` in
+* evolution-core/usage.ts).
 *
 * Persistence (rc.68): the EVENTS LOG (`evolution/events.json`, via
 * `evolution-core/evolution-events.ts`) is the single source of truth —
@@ -123,6 +130,18 @@ var EvolutionFeedback = class EvolutionFeedback {
 			} catch {}
 		});
 	}
+	/** External-producer contract (审计 B-4, v18): nothing inside the family
+	* calls `record` — the upstream `/feedback` command only appends a
+	* `feedback/record` session event carrying free text, which cannot be mapped
+	* to a (target, rating) pair without inventing semantics. A host that wants
+	* feedback-driven curation wires its own command/event to this method; the
+	* curator's union read (`feedback_warn`) then shortens the stale window.
+	* `feedback.spec.ts` pins that channel end to end.
+	* @param target - skill name or session id the rating belongs to.
+	* @param rating - `positive` or `negative`; other values are refused.
+	* @param note - optional free-text note carried into the durable event.
+	* @param kind - `skill` (default `session`) selects the score table.
+	*/
 	record(target, rating, note, kind = "session") {
 		const mode = kind === "skill" ? "skills" : "sessions";
 		const table = this.state[mode];
@@ -187,9 +206,14 @@ var EvolutionFeedback = class EvolutionFeedback {
 		return (record.positive - record.negative) / total;
 	}
 	snapshot() {
+		const copyRecords = (table) => {
+			const out = {};
+			for (const [key, record] of Object.entries(table)) out[key] = { ...record };
+			return out;
+		};
 		return {
-			skills: { ...this.state.skills },
-			sessions: { ...this.state.sessions }
+			skills: copyRecords(this.state.skills),
+			sessions: copyRecords(this.state.sessions)
 		};
 	}
 	/** Await the pending record-task chain (unload safety; rc.66). */
@@ -360,6 +384,10 @@ function foldWithDelta(cache, events, warn = () => {}) {
 }
 function applyFeedbackEvent(state, event, warn = () => {}) {
 	if (event.type !== "feedback") return;
+	if (event.kind !== "skill" && event.kind !== "session") {
+		warn(`evolution-feedback: skipping feedback event with invalid kind: ${String(event.kind)}`);
+		return;
+	}
 	if (event.rating !== "positive" && event.rating !== "negative") {
 		warn(`evolution-feedback: skipping feedback event with invalid rating: ${String(event.rating)}`);
 		return;
@@ -458,7 +486,7 @@ function apply(ctx, rawConfig = {}) {
 			if (kind !== "skill") return;
 			const score = feedback.score(target, "skill");
 			const warn = score < qualityWarnThreshold;
-			skillUsage.setQuality(target, score, warn).catch((error) => {
+			skillUsage.setFeedbackQuality(target, score, warn).catch((error) => {
 				skillCtx.logger.warn(error);
 			});
 		};

package/lib/types/index.d.ts

@@ -2,8 +2,15 @@
  * Feedback-to-quality scoring for self-evolution.
  *
  * Feedback is durable through `ctx.evolutionIo` (when mounted) and skill
- * feedback feeds `quality_score` / `quality_warn` on the usage record, so
- * curator decisions can consume it deterministically.
+ * feedback feeds the FEEDBACK-OWNED `feedback_score` / `feedback_warn` pair on
+ * the usage record. P1-1 (v15): this package used to write
+ * `quality_score`/`quality_warn` — but the curator's six-factor `scoreTree`
+ * overwrote those fields on every run BEFORE the lifecycle engine read them,
+ * so the advertised "curator decisions consume feedback deterministically"
+ * channel was dead. The lifecycle engine and the scope view now read the
+ * union `quality_warn || feedback_warn`, and the curator never writes the
+ * feedback pair (field-ownership contract on `UsageRecord` in
+ * evolution-core/usage.ts).
  *
  * Persistence (rc.68): the EVENTS LOG (`evolution/events.json`, via
  * `evolution-core/evolution-events.ts`) is the single source of truth —
@@ -63,6 +70,18 @@ export declare class EvolutionFeedback {
     private noteKey;
     private mutate;
     restore(io: IoLike): Promise<void>;
+    /** External-producer contract (审计 B-4, v18): nothing inside the family
+     * calls `record` — the upstream `/feedback` command only appends a
+     * `feedback/record` session event carrying free text, which cannot be mapped
+     * to a (target, rating) pair without inventing semantics. A host that wants
+     * feedback-driven curation wires its own command/event to this method; the
+     * curator's union read (`feedback_warn`) then shortens the stale window.
+     * `feedback.spec.ts` pins that channel end to end.
+     * @param target - skill name or session id the rating belongs to.
+     * @param rating - `positive` or `negative`; other values are refused.
+     * @param note - optional free-text note carried into the durable event.
+     * @param kind - `skill` (default `session`) selects the score table.
+     */
     record(target: string, rating: 'positive' | 'negative', note?: string, kind?: 'skill' | 'session'): void;
     score(target: string, kind?: 'skill' | 'session'): number;
     snapshot(): FeedbackState;
@@ -86,7 +105,9 @@ export declare class EvolutionFeedback {
 export declare function migrateFeedbackEvents(io: IoLike, eventsPath: string, aggregate: FeedbackState): Promise<void>;
 export declare const name = "evolution-feedback";
 export interface Config {
-    /** Score below which curator receives quality_warn for a skill. */
+    /** Score below which the FEEDBACK pair flips to warned (P1-1, v15: written
+     * to `feedback_score`/`feedback_warn`; the lifecycle engine reads the union
+     * with the curator-owned `quality_warn`). */
     qualityWarnThreshold?: number;
     /** Explicit boot-cache file path; empty derives $DSH_HOME/evolution/feedback.json.
      * The event log always stays at $DSH_HOME/evolution/events.json (derived from

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-feedback",
   "description": "Feedback-to-quality scoring for self-evolution (community build)",
-  "version": "0.3.62",
+  "version": "0.3.64",
   "publishConfig": {
     "access": "public"
   },
@@ -31,18 +31,18 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.3.62"
+    "@lmzhen/dsh-evolution-core": "^0.3.64"
   },
   "peerDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/cordis": "^4.0.1",
-    "@lmzhen/dsh-evolution-io": "^0.3.62",
-    "@lmzhen/dsh-skill-usage": "^0.3.62"
+    "@lmzhen/dsh-evolution-io": "^0.3.64",
+    "@lmzhen/dsh-skill-usage": "^0.3.64"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.3.62",
-    "@lmzhen/dsh-evolution-io-node": "^0.3.62",
-    "@lmzhen/dsh-skill-usage": "^0.3.62"
+    "@lmzhen/dsh-evolution-io": "^0.3.64",
+    "@lmzhen/dsh-evolution-io-node": "^0.3.64",
+    "@lmzhen/dsh-skill-usage": "^0.3.64"
   }
 }