@lmzhen/dsh-evolution-feedback 0.3.27 → 0.3.28

package/README.md

@@ -21,4 +21,4 @@ Independent of request-prefix construction. This package does not alter the asse
 ## Known Limitations and Deferred Work
 
 
-- - Persists through the IO seam; quality propagation into skill usage requires the `skillUsage` service.
+- Persists through the IO seam; quality propagation into skill usage requires the `skillUsage` service.

package/lib/index.js

@@ -33,6 +33,12 @@ var EvolutionFeedback = class {
 	eventsPath;
 	io;
 	warn;
+	/** V4-41 (F-324): the last note per target CONFIRMED on the event log. The
+	* in-memory `lastNote` is optimistic; a failed append must roll back to this,
+	* never to the in-memory `previousNote` (an earlier failed call can leave an
+	* unpersisted note there, and reverting to it resurrects a value the log
+	* never held). Seeded from the fold truth, updated on successful appends. */
+	durableNote = /* @__PURE__ */ new Map();
 	constructor(io, home = evolutionRoot(), pathOverride, warn = () => {}) {
 		this.path = pathOverride ?? join(home, "evolution", "feedback.json");
 		this.eventsPath = eventsFile(home);
@@ -43,6 +49,10 @@ var EvolutionFeedback = class {
 	attachIo(io) {
 		this.io = io;
 	}
+	/** Durable-note map key (V4-41): a target shares one record per mode. */
+	noteKey(mode, target) {
+		return `${mode}\u0000${target}`;
+	}
 	mutate(task) {
 		const run = this.chain.then(task, task);
 		this.chain = run.then(() => void 0, () => void 0);
@@ -77,6 +87,8 @@ var EvolutionFeedback = class {
 					...this.state.sessions
 				}
 			};
+			for (const [target, record] of Object.entries(truth.skills)) this.durableNote.set(this.noteKey("skills", target), record.lastNote);
+			for (const [target, record] of Object.entries(truth.sessions)) this.durableNote.set(this.noteKey("sessions", target), record.lastNote);
 			if (maxSeq > 0 && (!cache || cache.lastSeq < maxSeq)) try {
 				await io.writeText(path, JSON.stringify({
 					version: CACHE_VERSION,
@@ -93,7 +105,6 @@ var EvolutionFeedback = class {
 			positive: 0,
 			negative: 0
 		};
-		const previousNote = current.lastNote;
 		current[rating] += 1;
 		if (note !== void 0) current.lastNote = note;
 		table[target] = current;
@@ -102,22 +113,28 @@ var EvolutionFeedback = class {
 		if (!recordIo || !eventsPath) return;
 		this.mutate(async () => {
 			try {
-				if (await appendEvolutionEvent(recordIo, eventsPath, {
+				const seq = await appendEvolutionEvent(recordIo, eventsPath, {
 					type: "feedback",
 					target,
 					kind,
 					rating,
 					note
-				}) % CACHE_SNAP_EVERY === 0) await this.writeCacheNow();
+				});
+				if (note !== void 0) this.durableNote.set(this.noteKey(mode, target), note);
+				if (seq % CACHE_SNAP_EVERY === 0) await this.writeCacheNow();
 			} catch (error) {
 				const rollback = table[target];
 				if (rollback) {
 					rollback[rating] -= 1;
 					if (note !== void 0) {
-						if (rollback.lastNote === note) if (previousNote === void 0) delete rollback.lastNote;
-						else rollback.lastNote = previousNote;
+						if (rollback.lastNote === note) {
+							const durable = this.durableNote.get(this.noteKey(mode, target));
+							if (durable === void 0) delete rollback.lastNote;
+							else rollback.lastNote = durable;
+						}
 					}
 				}
+				this.warn(`evolution-feedback: failed to append feedback event for ${kind} "${target}": ${error instanceof Error ? error.message : String(error)}`);
 			}
 		});
 	}

package/lib/types/index.d.ts

@@ -37,9 +37,17 @@ export declare class EvolutionFeedback {
     private readonly eventsPath?;
     private io;
     private warn;
+    /** V4-41 (F-324): the last note per target CONFIRMED on the event log. The
+     * in-memory `lastNote` is optimistic; a failed append must roll back to this,
+     * never to the in-memory `previousNote` (an earlier failed call can leave an
+     * unpersisted note there, and reverting to it resurrects a value the log
+     * never held). Seeded from the fold truth, updated on successful appends. */
+    private readonly durableNote;
     constructor(io?: IoLike, home?: string, pathOverride?: string, warn?: (message: string) => void);
     /** Bind the evolution IO backend after construction (S6.4 deferred binding). */
     attachIo(io: IoLike): void;
+    /** Durable-note map key (V4-41): a target shares one record per mode. */
+    private noteKey;
     private mutate;
     restore(io: IoLike): Promise<void>;
     record(target: string, rating: 'positive' | 'negative', note?: string, kind?: 'skill' | 'session'): void;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-feedback",
   "description": "Feedback-to-quality scoring for self-evolution (community build)",
-  "version": "0.3.27",
+  "version": "0.3.28",
   "publishConfig": {
     "access": "public"
   },
@@ -31,18 +31,18 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.3.27"
+    "@lmzhen/dsh-evolution-core": "^0.3.28"
   },
   "peerDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/cordis": "^4.0.1",
-    "@lmzhen/dsh-evolution-io": "^0.3.27",
-    "@lmzhen/dsh-skill-usage": "^0.3.27"
+    "@lmzhen/dsh-evolution-io": "^0.3.28",
+    "@lmzhen/dsh-skill-usage": "^0.3.28"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.3.27",
-    "@lmzhen/dsh-evolution-io-node": "^0.3.27",
-    "@lmzhen/dsh-skill-usage": "^0.3.27"
+    "@lmzhen/dsh-evolution-io": "^0.3.28",
+    "@lmzhen/dsh-evolution-io-node": "^0.3.28",
+    "@lmzhen/dsh-skill-usage": "^0.3.28"
   }
 }