@lmzhen/dsh-evolution-feedback 0.1.0-rc.65 → 0.1.0-rc.67

package/lib/index.js

@@ -65,7 +65,7 @@ function evolutionIoAdapter(provider) {
 * changes semantically: the bundle digest is the fail-closed signal for
 * review workers, so a stale id across deployments must be distinguishable.
 */
-const PROMPT_BUNDLE_ID = "dsh-evolution@6";
+const PROMPT_BUNDLE_ID = "dsh-evolution@7";
 const MEMORY_REVIEW_PROMPT = `[Auto-review — Memory]
 Review the conversation above and consider saving to memory if appropriate.
 
@@ -86,6 +86,8 @@ Signals to look for (any one of these warrants action):
   • Non-trivial technique, fix, workaround, debugging path, or tool-usage pattern emerged that a future session would benefit from. Capture it.
   • A skill that got loaded or consulted this session turned out to be wrong, missing a step, or outdated. Patch it NOW.
 
+Read-before-write (enforced by this channel): update, patch, delete, or write support files ONLY into skills you loaded or read in THIS session — ops on unread skills are dropped; CREATE of a brand-new umbrella is the only exception.
+
 Preference order — prefer the earliest action that fits, but do pick one when a signal above fired:
   1. UPDATE A CURRENTLY-LOADED SKILL. Look back through the conversation for skills the user loaded or you read. If any of them covers the territory of the new learning, PATCH that one first. It is the skill that was in play, so it's the right one to extend.
   2. UPDATE AN EXISTING UMBRELLA. If no loaded skill fits but an existing class-level skill does, patch it. Add a subsection, a pitfall, or broaden a trigger.
@@ -133,6 +135,8 @@ Signals that warrant a skill update (any one is enough):
   • Non-trivial technique, fix, workaround, or debugging path emerged.
   • A skill that was loaded or consulted turned out wrong, missing, or outdated — patch it now.
 
+Read-before-write (enforced by this channel): update, patch, delete, or write support files ONLY into skills you loaded or read in THIS session — ops on unread skills are dropped; CREATE of a brand-new umbrella is the only exception.
+
 Preference order for skills — pick the earliest that fits:
   1. UPDATE A CURRENTLY-LOADED SKILL. Check what skills were loaded or read in the conversation. If one of them covers the learning, PATCH it first. It was in play; it's the right place.
   2. UPDATE AN EXISTING UMBRELLA. Patch it.
@@ -240,12 +244,12 @@ function sha256(text) {
 function createPromptBundle(prompts) {
 	const canonical = JSON.stringify({
 		id: PROMPT_BUNDLE_ID,
-		version: 6,
+		version: 7,
 		prompts: Object.fromEntries(Object.entries(prompts).sort())
 	});
 	return Object.freeze({
 		id: PROMPT_BUNDLE_ID,
-		version: 6,
+		version: 7,
 		prompts: Object.freeze({ ...prompts }),
 		sha256: sha256(canonical)
 	});
@@ -281,8 +285,10 @@ var EvolutionFeedback = class {
 	};
 	chain = Promise.resolve();
 	path;
+	io;
 	constructor(io, home = process.env.DSH_HOME ?? join(homedir(), ".dsh"), pathOverride) {
 		if (io) this.path = pathOverride ?? join(home, "evolution", "feedback.json");
+		this.io = io;
 	}
 	mutate(task) {
 		const run = this.chain.then(task, task);
@@ -311,7 +317,8 @@ var EvolutionFeedback = class {
 		});
 	}
 	record(target, rating, note, kind = "session", io) {
-		const table = kind === "skill" ? this.state.skills : this.state.sessions;
+		const mode = kind === "skill" ? "skills" : "sessions";
+		const table = this.state[mode];
 		const current = table[target] ?? {
 			positive: 0,
 			negative: 0
@@ -319,7 +326,31 @@ var EvolutionFeedback = class {
 		current[rating] += 1;
 		if (note !== void 0) current.lastNote = note;
 		table[target] = current;
-		if (io && this.path) this.flush(io);
+		const recordIo = io ?? this.io;
+		const path = this.path;
+		if (!recordIo || !path) return;
+		this.mutate(async () => {
+			try {
+				await transactIo(recordIo, path, (raw) => {
+					if (raw !== null) try {
+						JSON.parse(raw);
+					} catch {
+						return Promise.resolve(raw);
+					}
+					const diskState = parseState(raw);
+					const diskTable = diskState[mode];
+					const diskRec = diskTable[target] ?? {
+						positive: 0,
+						negative: 0
+					};
+					diskRec[rating] += 1;
+					if (note !== void 0) diskRec.lastNote = note;
+					diskTable[target] = diskRec;
+					this.state = diskState;
+					return Promise.resolve(JSON.stringify(diskState, null, 2));
+				});
+			} catch (error) {}
+		});
 	}
 	score(target, kind = "session") {
 		const record = (kind === "skill" ? this.state.skills : this.state.sessions)[target];
@@ -334,16 +365,9 @@ var EvolutionFeedback = class {
 			sessions: { ...this.state.sessions }
 		};
 	}
-	async flush(io) {
-		const path = this.path;
-		if (!path || !io) return;
-		await this.mutate(async () => {
-			await transactIo(io, path, (current) => {
-				const merged = mergeStates(parseState(current), this.state);
-				this.state = merged;
-				return Promise.resolve(JSON.stringify(merged, null, 2));
-			});
-		});
+	/** Await the pending record-task chain (unload safety; rc.66). */
+	waitIdle() {
+		return this.chain;
 	}
 };
 /** Parse a raw feedback sidecar; malformed reads as empty (best-effort). */
@@ -365,25 +389,6 @@ function parseState(raw) {
 		};
 	}
 }
-/** Deep-merge two feedback states: union by target; in-memory values win on
-* conflict. NOTE (v3 audit P3 reviewed): additive counting was rejected — a
-* restart merge (restore+flush) would double-count the same records, and a
-* stateless JSON sidecar cannot distinguish "two processes incrementing the
-* same target" from "the same record seen twice". Cross-process same-target
-* increments stay a documented limitation; an append-only event log would be
-* the real fix. */
-function mergeStates(disk, memory) {
-	return {
-		skills: {
-			...disk.skills,
-			...memory.skills
-		},
-		sessions: {
-			...disk.sessions,
-			...memory.sessions
-		}
-	};
-}
 const name = "evolution-feedback";
 const Config = z.object({
 	qualityWarnThreshold: z.number().default(-.25),
@@ -412,8 +417,8 @@ function apply(ctx, rawConfig = {}) {
 		};
 	}
 	ctx.effect(() => () => {
-		if (io) return feedback.flush(io);
-	}, "evolution-feedback.flush");
+		return feedback.waitIdle();
+	}, "evolution-feedback.records");
 }
 //#endregion
 export { Config, EvolutionFeedback, apply, name };

package/lib/types/index.d.ts

@@ -28,13 +28,15 @@ export declare class EvolutionFeedback {
     private state;
     private chain;
     private readonly path?;
+    private readonly io;
     constructor(io?: IoLike, home?: string, pathOverride?: string);
     private mutate;
     restore(io: IoLike): Promise<void>;
     record(target: string, rating: 'positive' | 'negative', note?: string, kind?: 'skill' | 'session', io?: IoLike): void;
     score(target: string, kind?: 'skill' | 'session'): number;
     snapshot(): FeedbackState;
-    flush(io?: IoLike): Promise<void>;
+    /** Await the pending record-task chain (unload safety; rc.66). */
+    waitIdle(): Promise<unknown>;
 }
 export declare const name = "evolution-feedback";
 export interface Config {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-feedback",
   "description": "Feedback-to-quality scoring for self-evolution (community build)",
-  "version": "0.1.0-rc.65",
+  "version": "0.1.0-rc.67",
   "publishConfig": {
     "access": "public"
   },
@@ -37,13 +37,13 @@
   "peerDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/cordis": "^4.0.1",
-    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.65",
-    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.65"
+    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.67",
+    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.67"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.65",
-    "@lmzhen/dsh-evolution-io-node": "^0.1.0-rc.65",
-    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.65"
+    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.67",
+    "@lmzhen/dsh-evolution-io-node": "^0.1.0-rc.67",
+    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.67"
   }
 }