@lmzhen/dsh-evolution-feedback 0.1.0-rc.65 → 0.1.0-rc.66

package/lib/index.js

@@ -281,8 +281,10 @@ var EvolutionFeedback = class {
 	};
 	chain = Promise.resolve();
 	path;
+	io;
 	constructor(io, home = process.env.DSH_HOME ?? join(homedir(), ".dsh"), pathOverride) {
 		if (io) this.path = pathOverride ?? join(home, "evolution", "feedback.json");
+		this.io = io;
 	}
 	mutate(task) {
 		const run = this.chain.then(task, task);
@@ -311,7 +313,8 @@ var EvolutionFeedback = class {
 		});
 	}
 	record(target, rating, note, kind = "session", io) {
-		const table = kind === "skill" ? this.state.skills : this.state.sessions;
+		const mode = kind === "skill" ? "skills" : "sessions";
+		const table = this.state[mode];
 		const current = table[target] ?? {
 			positive: 0,
 			negative: 0
@@ -319,7 +322,31 @@ var EvolutionFeedback = class {
 		current[rating] += 1;
 		if (note !== void 0) current.lastNote = note;
 		table[target] = current;
-		if (io && this.path) this.flush(io);
+		const recordIo = io ?? this.io;
+		const path = this.path;
+		if (!recordIo || !path) return;
+		this.mutate(async () => {
+			try {
+				await transactIo(recordIo, path, (raw) => {
+					if (raw !== null) try {
+						JSON.parse(raw);
+					} catch {
+						return Promise.resolve(raw);
+					}
+					const diskState = parseState(raw);
+					const diskTable = diskState[mode];
+					const diskRec = diskTable[target] ?? {
+						positive: 0,
+						negative: 0
+					};
+					diskRec[rating] += 1;
+					if (note !== void 0) diskRec.lastNote = note;
+					diskTable[target] = diskRec;
+					this.state = diskState;
+					return Promise.resolve(JSON.stringify(diskState, null, 2));
+				});
+			} catch (error) {}
+		});
 	}
 	score(target, kind = "session") {
 		const record = (kind === "skill" ? this.state.skills : this.state.sessions)[target];
@@ -334,16 +361,9 @@ var EvolutionFeedback = class {
 			sessions: { ...this.state.sessions }
 		};
 	}
-	async flush(io) {
-		const path = this.path;
-		if (!path || !io) return;
-		await this.mutate(async () => {
-			await transactIo(io, path, (current) => {
-				const merged = mergeStates(parseState(current), this.state);
-				this.state = merged;
-				return Promise.resolve(JSON.stringify(merged, null, 2));
-			});
-		});
+	/** Await the pending record-task chain (unload safety; rc.66). */
+	waitIdle() {
+		return this.chain;
 	}
 };
 /** Parse a raw feedback sidecar; malformed reads as empty (best-effort). */
@@ -365,25 +385,6 @@ function parseState(raw) {
 		};
 	}
 }
-/** Deep-merge two feedback states: union by target; in-memory values win on
-* conflict. NOTE (v3 audit P3 reviewed): additive counting was rejected — a
-* restart merge (restore+flush) would double-count the same records, and a
-* stateless JSON sidecar cannot distinguish "two processes incrementing the
-* same target" from "the same record seen twice". Cross-process same-target
-* increments stay a documented limitation; an append-only event log would be
-* the real fix. */
-function mergeStates(disk, memory) {
-	return {
-		skills: {
-			...disk.skills,
-			...memory.skills
-		},
-		sessions: {
-			...disk.sessions,
-			...memory.sessions
-		}
-	};
-}
 const name = "evolution-feedback";
 const Config = z.object({
 	qualityWarnThreshold: z.number().default(-.25),
@@ -412,8 +413,8 @@ function apply(ctx, rawConfig = {}) {
 		};
 	}
 	ctx.effect(() => () => {
-		if (io) return feedback.flush(io);
-	}, "evolution-feedback.flush");
+		return feedback.waitIdle();
+	}, "evolution-feedback.records");
 }
 //#endregion
 export { Config, EvolutionFeedback, apply, name };

package/lib/types/index.d.ts

@@ -28,13 +28,15 @@ export declare class EvolutionFeedback {
     private state;
     private chain;
     private readonly path?;
+    private readonly io;
     constructor(io?: IoLike, home?: string, pathOverride?: string);
     private mutate;
     restore(io: IoLike): Promise<void>;
     record(target: string, rating: 'positive' | 'negative', note?: string, kind?: 'skill' | 'session', io?: IoLike): void;
     score(target: string, kind?: 'skill' | 'session'): number;
     snapshot(): FeedbackState;
-    flush(io?: IoLike): Promise<void>;
+    /** Await the pending record-task chain (unload safety; rc.66). */
+    waitIdle(): Promise<unknown>;
 }
 export declare const name = "evolution-feedback";
 export interface Config {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-feedback",
   "description": "Feedback-to-quality scoring for self-evolution (community build)",
-  "version": "0.1.0-rc.65",
+  "version": "0.1.0-rc.66",
   "publishConfig": {
     "access": "public"
   },
@@ -37,13 +37,13 @@
   "peerDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/cordis": "^4.0.1",
-    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.65",
-    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.65"
+    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.66",
+    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.66"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.65",
-    "@lmzhen/dsh-evolution-io-node": "^0.1.0-rc.65",
-    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.65"
+    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.66",
+    "@lmzhen/dsh-evolution-io-node": "^0.1.0-rc.66",
+    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.66"
   }
 }