@lmzhen/dsh-evolution-core 0.3.38 → 0.3.40

package/lib/index.js

@@ -647,7 +647,12 @@ const MAX_SKILL_FILE_BYTES = 1048576;
 const DEFAULT_REVIEW_MEMORY_INTERVAL = 10;
 const DEFAULT_REVIEW_SKILL_INTERVAL = 10;
 /** Skill-review completion channel trigger mode: 'cadence' | 'completion' | 'both'. */
-const DEFAULT_SKILL_REVIEW_TRIGGER = "both";
+/** Skill-review completion channel trigger mode: 'cadence' | 'completion' | 'both'.
+* 0.3.39 (V6-53 follow-up): default is 'cadence' — since 0.3.38 the cadence
+* channel's review is executed at conversation END (deferred), so 'both' would
+* inject a second (task-complete) prompt at the same boundary; the cadence
+* deferral alone IS the end-of-conversation summary. */
+const DEFAULT_SKILL_REVIEW_TRIGGER = "cadence";
 /** Cumulative session tool calls before a session counts as "proven long" for the completion channel. */
 const DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS = 20;
 const DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS = 3;
@@ -2821,17 +2826,20 @@ function advanceReview(state, turn, signal, config) {
 	state.turnsSinceSkill += signal.skillSignal ? 1 : Math.max(1, signal.toolCalls);
 	const memoryDue = state.turnsSinceMemory >= config.memoryInterval;
 	const skillDue = state.turnsSinceSkill >= config.skillInterval;
-	if (memoryDue && skillDue) {
+	const zero = () => {
 		state.turnsSinceMemory = 0;
 		state.turnsSinceSkill = 0;
+	};
+	if (memoryDue && skillDue) {
+		if (config.resetOnFire !== false) zero();
 		return "combined";
 	}
 	if (memoryDue) {
-		state.turnsSinceMemory = 0;
+		if (config.resetOnFire !== false) state.turnsSinceMemory = 0;
 		return "memory";
 	}
 	if (skillDue) {
-		state.turnsSinceSkill = 0;
+		if (config.resetOnFire !== false) state.turnsSinceSkill = 0;
 		return "skill";
 	}
 	return null;

package/lib/types/constants.d.ts

@@ -34,7 +34,12 @@ export declare const MAX_SKILL_FILE_BYTES = 1048576;
 export declare const DEFAULT_REVIEW_MEMORY_INTERVAL = 10;
 export declare const DEFAULT_REVIEW_SKILL_INTERVAL = 10;
 /** Skill-review completion channel trigger mode: 'cadence' | 'completion' | 'both'. */
-export declare const DEFAULT_SKILL_REVIEW_TRIGGER: "both";
+/** Skill-review completion channel trigger mode: 'cadence' | 'completion' | 'both'.
+ * 0.3.39 (V6-53 follow-up): default is 'cadence' — since 0.3.38 the cadence
+ * channel's review is executed at conversation END (deferred), so 'both' would
+ * inject a second (task-complete) prompt at the same boundary; the cadence
+ * deferral alone IS the end-of-conversation summary. */
+export declare const DEFAULT_SKILL_REVIEW_TRIGGER: "cadence";
 /** Cumulative session tool calls before a session counts as "proven long" for the completion channel. */
 export declare const DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS = 20;
 export declare const DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS = 3;

package/lib/types/signals.d.ts

@@ -13,6 +13,12 @@ export interface SignalConfig {
     substantiveMinToolCalls: number;
     substantiveMinUserChars: number;
     substantiveMinAgentChars: number;
+    /** 0.3.40 (user decision): the counting window restarts at the INJECTION, not
+     * at the threshold fire. `false` keeps the counters MONOTONIC across fires
+     * (the `>=` check still returns the kind; the caller resets the counters at
+     * its own injection point). Default `true` preserves the historical
+     * fire-resets window for existing callers/tests. */
+    resetOnFire?: boolean;
 }
 export interface TurnSignals {
     substantive: boolean;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-core",
   "description": "Shared stores, prompts, signals and lifecycle logic for the dsh-evolution plugin family (community build)",
-  "version": "0.3.38",
+  "version": "0.3.40",
   "publishConfig": {
     "access": "public"
   },