@lmjs/core 2.1.0 → 2.1.2

package/build/bundle.js

@@ -3,37 +3,31 @@
 // working-session decision (2026-09-13) to keep V2 fully separate rather
 // than editing the live PHP CDN pipeline.
 //
-// Produces two bundles:
+// Produces one bundle:
 //   - dist/lumenjs-core.js — dom-shim.js (a minimal jQuery-compatible
 //     layer) + the css/up workers + walk.js + _re.js + vendor/
 //     reconnecting-websocket.js + index-bootstrap.js + ws.js + lstnrs.js.
 //     No real jQuery, no plugins. This is the default every LumenJS V2
 //     page gets.
-//   - dist/lumenjs-core-with-plugins.js (+ dist/lumenjs-plugins.css) —
-//     2026-09-14: the same file list, but with dom-shim.js swapped for
-//     real jQuery, plus the plugins confirmed by testing real production
-//     content (console.roxyon.com) end-to-end: Select2, Flickity,
-//     bootstrap-colorpicker, bootstrap-datetimepicker. See PROVENANCE.md
-//     for exactly how each one was identified (bea.js is minified with no
-//     identifying strings left — matched by API/option shape instead:
-//     `format: 'rgba'` for bootstrap-colorpicker, the DPGlobal/startView/
-//     minView/maxView/todayBtn signature for bootstrap-datetimepicker) and
-//     why these four and not the wider list an earlier version of this
-//     comment speculated (jQuery UI, tag-editor, jquery.lazy, ...) — none
-//     of those are actually called anywhere in any real project checked
-//     (10 real sites), and drag/sort (§6.4 of the spec) turned out to be
-//     custom-implemented, not jQuery-UI-based, so no jQuery UI dependency
-//     is needed at all.
+//
+// 2026-09-19: this file used to also produce a second, monolithic
+// dist/lumenjs-core-with-plugins.js (+ dist/lumenjs-plugins.css) — real
+// jQuery + all 18 registry libraries baked into one file. Removed: proven
+// functionally redundant with packages/cli's per-project selective plugin
+// bundling (a project lists exact registry keys in its own package.json
+// dependencies) — both ultimately produce [some real-jQuery-based plugin
+// set] + the exact same buildCommonTail() engine code below; the only real
+// difference was one combined file vs. two. See PROVENANCE.md and
+// build/plugins-registry.js (kept — still the shared source of truth the
+// selective mechanism in packages/cli reads from) for the full per-library
+// sourcing trail, which is still accurate and still load-bearing.
 
 const fs = require('fs');
 const path = require('path');
-const less = require('less');
 const esbuild = require('esbuild');
-const pluginsRegistry = require('./plugins-registry.js');
 
 const SRC = path.join(__dirname, '..', 'src');
 const VENDOR = path.join(__dirname, '..', 'vendor');
-const NODE_MODULES = path.join(__dirname, '..', 'node_modules');
 const OUT_DIR = path.join(__dirname, '..', 'dist');
 
 // 2026-09-16: this codebase's own source comments are deliberately
@@ -64,8 +58,7 @@ const OUT_DIR = path.join(__dirname, '..', 'dist');
 // astring.js is already a minified third-party build with nothing to
 // gain from re-stripping. Applied explicitly at each call site below
 // instead, only for files that really are directly-concatenated,
-// standalone top-level JS — and never to readModule() (real third-party
-// npm packages), whose license headers must be preserved as-is.
+// standalone top-level JS.
 function stripComments(src) {
     return esbuild.transformSync(src, {
         loader: 'js',
@@ -83,13 +76,11 @@ function readVendor(relPath) {
     return fs.readFileSync(path.join(VENDOR, relPath), 'utf8');
 }
 
-function readModule(relPath) {
-    return fs.readFileSync(path.join(NODE_MODULES, relPath), 'utf8');
-}
-
 // The part of the bundle that's identical regardless of which jQuery layer
-// (shim vs. real+plugins) sits underneath it. Takes the already-built
-// jQuery layer as a string and appends everything else after it.
+// sits underneath it — dom-shim.js here; a project's own selective plugin
+// bundle (packages/cli) can layer real jQuery on top of this same output
+// as a separate, later <script>. Takes the already-built jQuery layer as a
+// string and appends everything else after it.
 function buildCommonTail() {
     const parts = [];
 
@@ -166,69 +157,6 @@ function buildCore() {
     return parts.join('\n');
 }
 
-// 2026-09-16: registry-ified. Every library's npm path(s), ordering
-// constraint, and build-time patch used to live inline here — now in
-// build/plugins-registry.js, the single source of truth both this
-// monolithic build AND a future per-project selective bundle (packages/cli)
-// consume. This refactor is a pure mechanical transcription with no
-// intended behavior change — see plugins-registry.js's own header for the
-// exact reasoning (why a plain ordered array, not a topological sort) and
-// PROVENANCE.md for the full per-library sourcing trail (why each library
-// was picked, exact version matches, etc. — that detail lives there, not
-// duplicated per-entry here anymore).
-function buildCoreWithPlugins() {
-    pluginsRegistry.validateOrder(pluginsRegistry);
-    const parts = [];
-    parts.push('/* LumenJS V2 core (with real jQuery + plugins) — generated by packages/core/build/bundle.js, do not edit directly */');
-    for (const entry of pluginsRegistry) {
-        for (const npmPath of [].concat(entry.npm || [])) {
-            let src = readModule(npmPath);
-            if (entry.patch) src = entry.patch(src);
-            parts.push(src);
-        }
-        if (entry.code) parts.push(entry.code);
-    }
-    parts.push(buildCommonTail());
-    // 2026-09-15, real bug: joining with a bare '\n' let a missing trailing
-    // semicolon in one vendored file merge into the next one via automatic
-    // semicolon insertion — bootstrap-datetimepicker's source ends with
-    // `})(window.jQuery)` (no `;`), and jQuery UI's starts with
-    // `( function( factory ) {`, so ASI read the two as ONE continuous
-    // call chain (`(...)(...)(...)...`) instead of two separate IIFEs —
-    // exactly matching the resulting error, "(intermediate value)(...) is
-    // not a function". This is a real risk for ANY two files in this list,
-    // not just this one pair, since none of the ~18 vendored sources here
-    // are guaranteed to end with a semicolon. `;\n` as the join separator
-    // closes the whole class of bug at once — an extra leading `;` is
-    // always a harmless no-op statement in JS.
-    return parts.join(';\n');
-}
-
-async function buildPluginsCss() {
-    const parts = [];
-    parts.push('/* LumenJS V2 plugins CSS — generated by packages/core/build/bundle.js, do not edit directly */');
-    for (const entry of pluginsRegistry) {
-        if (entry.css) {
-            for (const cssPath of [].concat(entry.css)) {
-                let src = readModule(cssPath);
-                if (entry.cssPatch) src = entry.cssPatch(src);
-                parts.push(src);
-            }
-        }
-        if (entry.lessCss) {
-            // bootstrap-datetimepicker ships only LESS, no compiled CSS at
-            // all — compile it here rather than hand-vendoring a pre-built copy.
-            const lessSrc = readModule(entry.lessCss);
-            const lessOut = await less.render(lessSrc, {
-                filename: path.join(NODE_MODULES, entry.lessCss),
-                paths: [path.join(VENDOR, 'bootstrap2-less-stubs')],
-            });
-            parts.push(lessOut.css);
-        }
-    }
-    return parts.join('\n');
-}
-
 async function main() {
     if (!fs.existsSync(OUT_DIR)) fs.mkdirSync(OUT_DIR, { recursive: true });
 
@@ -237,17 +165,6 @@ async function main() {
     fs.writeFileSync(outPath, core);
     console.log('Wrote ' + outPath + ' (' + core.length + ' bytes)');
     checkSyntax(core, outPath);
-
-    const withPlugins = buildCoreWithPlugins();
-    const withPluginsPath = path.join(OUT_DIR, 'lumenjs-core-with-plugins.js');
-    fs.writeFileSync(withPluginsPath, withPlugins);
-    console.log('Wrote ' + withPluginsPath + ' (' + withPlugins.length + ' bytes)');
-    checkSyntax(withPlugins, withPluginsPath);
-
-    const pluginsCss = await buildPluginsCss();
-    const pluginsCssPath = path.join(OUT_DIR, 'lumenjs-plugins.css');
-    fs.writeFileSync(pluginsCssPath, pluginsCss);
-    console.log('Wrote ' + pluginsCssPath + ' (' + pluginsCss.length + ' bytes)');
 }
 
 function checkSyntax(code, outPath) {

package/build/plugins-registry.js

@@ -1,30 +1,32 @@
-// plugins-registry.js — the 18-library (+jQuery) `--with-plugins` set,
-// factored out of build/bundle.js's buildCoreWithPlugins()/buildPluginsCss()
-// (2026-09-16) into one data structure both the existing prebuilt monolith
-// AND a future per-project selective bundle (packages/cli) can consume.
+// plugins-registry.js — the 18-library (+jQuery) set available for
+// per-project selective plugin bundling (packages/cli/lib/
+// plugins-esbuild-plugin.js), the single source of truth for each
+// library's npm path(s), build-time patch, and `after`-ordering
+// constraint. (2026-09-19: originally factored out of build/bundle.js's
+// now-removed buildCoreWithPlugins()/buildPluginsCss() — those built one
+// monolithic bundle with all 18 always included; removed as functionally
+// redundant with selecting all 18 via the selective mechanism. This
+// registry itself is unaffected — still the shared source of truth, just
+// with one consumer instead of two.)
 //
 // Deliberately a plain ORDERED ARRAY, not something that computes an order
-// via topological sort: this array's declaration order IS today's real,
-// already-shipped, already-tested load order — transcribed mechanically
-// from build/bundle.js's buildCoreWithPlugins(), not reconstructed from
-// memory. A topo sort over `after` edges could legally reorder two
-// independent no-dependency entries (e.g. jquery.easing vs jquery.numeric —
-// no real dependency between them, but SOME specific order exists in the
-// real, shipped bundle), which would change dist/lumenjs-core-with-plugins.js's
-// bytes for no functional reason. `validateOrder()` below instead turns the
-// ordering knowledge that used to live only in code comments into an
-// enforced invariant: it throws if any entry's `after` key doesn't already
-// appear earlier in the array, catching a broken reorder immediately
-// instead of letting it silently ship.
+// via topological sort: this array's declaration order IS the real,
+// already-tested load order. A topo sort over `after` edges could legally
+// reorder two independent no-dependency entries (e.g. jquery.easing vs
+// jquery.numeric — no real dependency between them, but SOME specific
+// order was already tested) for no functional reason. `validateOrder()`
+// below instead turns the ordering knowledge that used to live only in
+// code comments into an enforced invariant: it throws if any entry's
+// `after` key doesn't already appear earlier in the array, catching a
+// broken reorder immediately instead of letting it silently ship.
 //
 // Each entry:
 //   key      — the real npm package name (also what a project's own
-//              package.json dependency list is matched against, for the
-//              future per-project selective bundle — see PROVENANCE.md).
-//   npm      — one path or an array of paths, relative to node_modules,
-//              exactly matching the readModule() calls this replaces.
-//   css      — one path or an array of paths (relative to node_modules)
-//              for buildPluginsCss(), if this library ships compiled CSS.
+//              package.json dependency list is matched against — see
+//              PROVENANCE.md).
+//   npm      — one path or an array of paths, relative to node_modules.
+//   css      — one path or an array of paths (relative to node_modules),
+//              if this library ships compiled CSS.
 //   lessCss  — a LESS source path to compile via the `less` package,
 //              for the one library (bootstrap-datetimepicker) that ships
 //              only LESS, no compiled CSS.
@@ -82,10 +84,10 @@ const registry = [
         css: 'select2/dist/css/select2.css',
         after: ['jquery'],
         // Only consumed by packages/cli's per-project selective esbuild
-        // bundle (plugins-esbuild-plugin.js), not by this file's own
-        // buildCoreWithPlugins() — that build is plain string
-        // concatenation, never triggers select2's UMD wrapper's CommonJS
-        // branch at all, so this quirk never applies to it. Select2's own
+        // bundle (plugins-esbuild-plugin.js) — plain string concatenation
+        // (how every other entry here gets combined) never triggers
+        // select2's UMD wrapper's CommonJS branch at all, so this quirk
+        // only matters for esbuild-based resolution. Select2's own
         // UMD wrapper (dist/js/select2.js) is unusual among these 18
         // libraries: its CommonJS branch exports a FACTORY FUNCTION
         // (`module.exports = function (root, jQuery) {...}`) rather than