@llui/dom 0.2.0 → 0.2.1

package/dist/primitives/each.js

@@ -1,8 +1,10 @@
-import { getRenderContext, setRenderContext, clearRenderContext, enterAccessor, exitAccessor, } from '../render-context.js';
+import { getRenderContext, setRenderContext, clearRenderContext, enterAccessor, exitAccessor, getInstanceViewBag, } from '../render-context.js';
 import { createLifetime, disposeLifetime, disposeLifetimesBulk, addDisposer, removeOrphanedChildren, } from '../lifetime.js';
 import { getFlatBindings, setFlatBindings } from '../binding.js';
 import { FULL_MASK } from '../update-loop.js';
-import { createView } from '../view-helpers.js';
+// v0.4 size-cut (Tier 1.2): no more createView fallback — every compiled
+// component carries a __view factory; each() pulls the bag from the owning
+// instance via the render context.
 // Clear callbacks — registered by selector.bind() during render, called by reconcileClear().
 // Eliminates per-row disposers (1000 Set.delete calls → 1 registry.clear() call).
 let activeClearCallbacks = null;
@@ -83,56 +85,62 @@ export function each(opts) {
     let lastItemsRef = initialItems;
     // Dev-only diff tracking: if the owning component has an _eachDiffLog
     // (installed by devtools), we capture key sets before/after each
-    // key-mutating reconcile call and emit an EachDiff entry. The siteId
-    // is derived from this each() block's position in the flat block
-    // array at registration time — stable for the lifetime of the block.
+    // key-mutating reconcile call and emit an EachDiff entry. Wrapped in
+    // `import.meta.env?.DEV` so production builds dead-code the entire
+    // block — saves ~1-2 kB in the prod bundle. The reconcile-side call
+    // sites are also gated below; the stubs (`null`/no-op) keep types
+    // and call sites consistent across modes.
     const inst = ctx.instance;
-    const eachSiteId = inst?._eachDiffLog !== undefined ? `each#${blocks.length}` : '';
-    const snapshotKeys = () => {
-        if (inst?._eachDiffLog === undefined)
-            return null;
-        const keys = [];
-        for (let i = 0; i < entries.length; i++)
-            keys.push(String(entries[i].key));
-        return keys;
-    };
-    const emitDiff = (oldKeys) => {
-        if (oldKeys === null || inst?._eachDiffLog === undefined)
-            return;
-        const newKeys = [];
-        for (let i = 0; i < entries.length; i++)
-            newKeys.push(String(entries[i].key));
-        const oldKeySet = new Set(oldKeys);
-        const newKeySet = new Set(newKeys);
-        const added = [];
-        const removed = [];
-        const moved = [];
-        const reused = [];
-        for (const k of newKeys)
-            if (!oldKeySet.has(k))
-                added.push(k);
-        for (const k of oldKeys)
-            if (!newKeySet.has(k))
-                removed.push(k);
-        for (let i = 0; i < newKeys.length; i++) {
-            const k = newKeys[i];
-            if (!oldKeySet.has(k))
-                continue;
-            const from = oldKeys.indexOf(k);
-            if (from !== i)
-                moved.push({ key: k, from, to: i });
-            else
-                reused.push(k);
-        }
-        inst._eachDiffLog.push({
-            updateIndex: inst._updateCounter ?? 0,
-            eachSiteId,
-            added,
-            removed,
-            moved,
-            reused,
-        });
-    };
+    let snapshotKeys = () => null;
+    let emitDiff = () => { };
+    if (import.meta.env?.DEV) {
+        const eachSiteId = inst?._eachDiffLog !== undefined ? `each#${blocks.length}` : '';
+        snapshotKeys = () => {
+            if (inst?._eachDiffLog === undefined)
+                return null;
+            const keys = [];
+            for (let i = 0; i < entries.length; i++)
+                keys.push(String(entries[i].key));
+            return keys;
+        };
+        emitDiff = (oldKeys) => {
+            if (oldKeys === null || inst?._eachDiffLog === undefined)
+                return;
+            const newKeys = [];
+            for (let i = 0; i < entries.length; i++)
+                newKeys.push(String(entries[i].key));
+            const oldKeySet = new Set(oldKeys);
+            const newKeySet = new Set(newKeys);
+            const added = [];
+            const removed = [];
+            const moved = [];
+            const reused = [];
+            for (const k of newKeys)
+                if (!oldKeySet.has(k))
+                    added.push(k);
+            for (const k of oldKeys)
+                if (!newKeySet.has(k))
+                    removed.push(k);
+            for (let i = 0; i < newKeys.length; i++) {
+                const k = newKeys[i];
+                if (!oldKeySet.has(k))
+                    continue;
+                const from = oldKeys.indexOf(k);
+                if (from !== i)
+                    moved.push({ key: k, from, to: i });
+                else
+                    reused.push(k);
+            }
+            inst._eachDiffLog.push({
+                updateIndex: inst._updateCounter ?? 0,
+                eachSiteId,
+                added,
+                removed,
+                moved,
+                reused,
+            });
+        };
+    }
     const block = {
         mask: opts.__mask ?? FULL_MASK,
         maskHi: opts.__maskHi ?? 0,
@@ -146,9 +154,17 @@ export function each(opts) {
                 return;
             lastItemsRef = newItems;
             const oldKeys = snapshotKeys();
-            const report = opts.onTransition ? { entering: [], leaving: [] } : null;
+            // Transition support gated by `__LLUI_TRANSITIONS__` build flag.
+            // When false, the `report` allocation, the `onTransition` invocation,
+            // and (via type narrowing inside `reconcileEntries`) the per-entry
+            // leave/enter helpers all dead-code-eliminate.
+            const report = typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && opts.onTransition
+                ? { entering: [], leaving: [] }
+                : null;
             reconcileEntries(entries, newItems, opts, parentLifetime, parent, anchor, endAnchor, ctx, state, leaving, report);
-            if (opts.onTransition && report) {
+            if (typeof __LLUI_TRANSITIONS__ !== 'undefined' &&
+                __LLUI_TRANSITIONS__ &&
+                opts.onTransition) {
                 opts.onTransition({ entering: report.entering, leaving: report.leaving, parent });
             }
             emitDiff(oldKeys);
@@ -192,7 +208,8 @@ export function each(opts) {
             const scopes = [];
             for (let i = 0; i < entries.length; i++) {
                 const s = entries[i].scope;
-                s.disposalCause = 'each-remove';
+                if (import.meta.env?.DEV)
+                    s.disposalCause = 'each-remove';
                 scopes.push(s);
             }
             disposeLifetimesBulk(scopes);
@@ -236,7 +253,8 @@ export function each(opts) {
                         removeCallbacks[ci](entry.key);
                     for (const node of entry.nodes)
                         parent.removeChild(node);
-                    entry.scope.disposalCause = 'each-remove';
+                    if (import.meta.env?.DEV)
+                        entry.scope.disposalCause = 'each-remove';
                     disposeLifetime(entry.scope, true);
                     entries[oi] = null;
                     didRemove = true;
@@ -286,8 +304,10 @@ export function each(opts) {
     }
     activeClearCallbacks = null;
     activeRemoveCallbacks = null;
-    // Fire initial enter for mount-time items
-    if (opts.enter) {
+    // Fire initial enter for mount-time items. Build-flag-gated:
+    // `__LLUI_TRANSITIONS__` lets the DCE drop this loop when the app
+    // doesn't use animation callbacks.
+    if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && opts.enter) {
         for (const entry of entries) {
             if (entry.nodes.length > 0)
                 opts.enter(entry.nodes);
@@ -350,13 +370,20 @@ function removeEntry(entry, opts, leaving) {
             if (node.parentNode)
                 node.parentNode.removeChild(node);
         }
-        entry.scope.disposalCause = 'each-remove';
+        if (import.meta.env?.DEV)
+            entry.scope.disposalCause = 'each-remove';
         disposeLifetime(entry.scope);
         const idx = leaving.indexOf(entry);
         if (idx !== -1)
             leaving.splice(idx, 1);
     };
-    if (opts.leave && entry.nodes.length > 0) {
+    // Build-flag-gated leave animation. When `__LLUI_TRANSITIONS__` is
+    // false the whole block dead-code-eliminates and `removeEntry`
+    // collapses to its `removeNow()` call.
+    if (typeof __LLUI_TRANSITIONS__ !== 'undefined' &&
+        __LLUI_TRANSITIONS__ &&
+        opts.leave &&
+        entry.nodes.length > 0) {
         const result = opts.leave(entry.nodes);
         if (result && typeof result.then === 'function') {
             leaving.push(entry);
@@ -367,7 +394,13 @@ function removeEntry(entry, opts, leaving) {
     removeNow();
 }
 function fireEnter(entry, opts) {
-    if (opts.enter && entry.nodes.length > 0) {
+    // Build-flag-gated enter animation. `fireEnter` collapses to a no-op
+    // function when `__LLUI_TRANSITIONS__` is false; terser then inlines
+    // and drops the callers' calls.
+    if (typeof __LLUI_TRANSITIONS__ !== 'undefined' &&
+        __LLUI_TRANSITIONS__ &&
+        opts.enter &&
+        entry.nodes.length > 0) {
         void opts.enter(entry.nodes);
     }
 }
@@ -377,7 +410,8 @@ function buildEntry(item, index, opts, parentLifetime, ctx, state) {
     // Full scope features (disposers, bindings, children) are only needed when
     // the render callback uses structural primitives or selector.bind().
     const scope = createLifetime(parentLifetime);
-    scope._kind = 'each';
+    if (import.meta.env?.DEV)
+        scope._kind = 'each';
     const currentState = (state ?? ctx.state);
     const send = ctx.send;
     // Create entry before render so itemAccessor closures can capture it
@@ -454,7 +488,11 @@ function buildEntry(item, index, opts, parentLifetime, ctx, state) {
     // The View bag — lets each.render use `h.text`, `h.scope`, `h.sample`,
     // etc. without reaching for the top-level imports. Each entry gets a
     // fresh View so its `send` is bound to this row's dispatch path.
-    buildBag.h = createView(send);
+    // v0.4 Tier 1.2 + cache follow-up: the bag is constructed once per
+    // owning instance and reused for every row. Pre-cache: 1000 rows = 1000
+    // bag allocations + 1000 __view calls. Post-cache: 1 per instance.
+    // (Test-mode createView fallback is gated inside getInstanceViewBag.)
+    buildBag.h = getInstanceViewBag(ctx.instance, send);
     // Row factory: pass compiler-injected template + update function through to render
     const rfOpts = opts;
     if (rfOpts.__tpl)
@@ -480,12 +518,16 @@ function collectNodes(target, nodes) {
 function reconcileEntries(entries, newItems, opts, parentLifetime, parent, anchor, endAnchor, ctx, state, leaving, report) {
     const oldLen = entries.length;
     const newLen = newItems.length;
-    const hasLeave = !!opts.leave;
+    // Build-flag-gated: when `__LLUI_TRANSITIONS__` is false, `hasLeave`
+    // folds to `false`, the report branch folds away, and `removeEntry`
+    // collapses to synchronous removal. Per-item removal fast path
+    // (lines below this) becomes unreachable.
+    const hasLeave = typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && !!opts.leave;
     // Fast path 1: clear all — bulk DOM removal.
     // When opts.leave is set, each item needs its own leave animation, so
     // fall through to per-item removal instead of Range.deleteContents().
     if (newLen === 0) {
-        if (report) {
+        if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && report) {
             for (const entry of entries)
                 collectNodes(report.leaving, entry.nodes);
         }
@@ -508,7 +550,8 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
         const scopes = [];
         for (let i = 0; i < entries.length; i++) {
             const s = entries[i].scope;
-            s.disposalCause = 'each-remove';
+            if (import.meta.env?.DEV)
+                s.disposalCause = 'each-remove';
             scopes.push(s);
         }
         disposeLifetimesBulk(scopes);
@@ -536,7 +579,7 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
                 frag.appendChild(node);
         }
         parent.insertBefore(frag, ref);
-        if (report) {
+        if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && report) {
             for (const entry of newlyAdded)
                 collectNodes(report.entering, entry.nodes);
         }
@@ -608,7 +651,7 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
             }
         }
         if (!anyShared) {
-            if (report) {
+            if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && report) {
                 for (const entry of entries)
                     collectNodes(report.leaving, entry.nodes);
             }
@@ -623,7 +666,8 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
             const oldLifetimes = [];
             for (let i = 0; i < entries.length; i++) {
                 const s = entries[i].scope;
-                s.disposalCause = 'each-remove';
+                if (import.meta.env?.DEV)
+                    s.disposalCause = 'each-remove';
                 oldLifetimes.push(s);
             }
             disposeLifetimesBulk(oldLifetimes);
@@ -640,7 +684,7 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
                     frag.appendChild(node);
             }
             parent.insertBefore(frag, anchor.nextSibling);
-            if (report) {
+            if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && report) {
                 for (const entry of newlyAdded)
                     collectNodes(report.entering, entry.nodes);
             }
@@ -678,7 +722,7 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
     let didBulkDetach = false;
     for (const entry of entries) {
         if (!usedKeys.has(entry.key)) {
-            if (report)
+            if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && report)
                 collectNodes(report.leaving, entry.nodes);
             if (hasLeave) {
                 removeEntry(entry, opts, leaving);
@@ -696,7 +740,8 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
                     if (node.parentNode === parent)
                         parent.removeChild(node);
                 }
-                entry.scope.disposalCause = 'each-remove';
+                if (import.meta.env?.DEV)
+                    entry.scope.disposalCause = 'each-remove';
                 disposeLifetime(entry.scope, true);
                 didBulkDetach = true;
             }
@@ -744,12 +789,14 @@ function reconcileEntries(entries, newItems, opts, parentLifetime, parent, ancho
     entries.length = newEntries.length;
     for (let i = 0; i < newEntries.length; i++)
         entries[i] = newEntries[i];
-    if (report) {
+    if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && report) {
         for (const entry of newlyAdded)
             collectNodes(report.entering, entry.nodes);
     }
-    // Fire enter for newly-added entries (after DOM insertion)
-    if (opts.enter) {
+    // Fire enter for newly-added entries (after DOM insertion). Gated
+    // by `__LLUI_TRANSITIONS__` build flag — bench-shape apps skip
+    // the whole branch.
+    if (typeof __LLUI_TRANSITIONS__ !== 'undefined' && __LLUI_TRANSITIONS__ && opts.enter) {
         for (const entry of newlyAdded)
             fireEnter(entry, opts);
     }