@llm4ts/shell 2.24.0 → 2.25.0

package/flows/lib/epic-stories.js

@@ -15,6 +15,7 @@ import { parseEpicBrief, renderEpicBrief, unanswered } from "@llm4ts/flow/EpicBr
 import { structuredAndPublish } from "@llm4ts/flow/Flow";
 import { EpicBriefInvalid, EpicBriefNotApproved, EpicCheckoutDirty, LandingFailed, RefineRefused } from "@llm4ts/flow/FlowError";
 import { Info } from "@llm4ts/flow/FlowEvents";
+import { nodePreflight } from "@llm4ts/flow/NodePreflight";
 import { statusPaths } from "@llm4ts/flow/GitTool";
 import { EpicLanded, EpicLandedVersion, landedPath } from "@llm4ts/flow/Landing";
 import { RefineProposal, assembleRound, countNotPlanned, earlierStories, refineProposalJsonSchema, renderNotPlanned, roundPrefix, roundRepair, runAction } from "@llm4ts/flow/RefineRound";
@@ -1025,7 +1026,8 @@ export const storyContextChars = (environment) => {
 /** Today's story judge: the rubric judge over the four dimensions. */
 export const rubricStoryJudge = (context) => (story, diff, seats, subject) => judgeStory(
 // The story's own seat, not the run's: its time counts for the story.
-seats.context.roster?.forRole("judge") ?? seats.context.reasoning, story, diff, context.budget, context.plan, subject);
+// And the judge seat, never the writing reasoner: a judge reads.
+seats.context.roster?.forRole("judge") ?? seats.context.judge ?? seats.context.reasoning, story, diff, context.budget, context.plan, subject);
 /** The runner options the two flags above add; empty when neither is set. */
 export const epicRunnerOptions = Effect.fn("epic-stories.runnerOptions")(function* (options, environment) {
     const judgment = options.judgmentFromEnvironment === true
@@ -1237,6 +1239,12 @@ export const runEpicStories = (options) => Effect.gen(function* () {
                 ? "gates: none (the app defines none of typecheck, lint, test, build; set LLM4TS_GATES)"
                 : `gates: ${commands.map((command) => command.join(" ")).join(" · ")}`
         }));
+        // The Node the gates would run on is the one on PATH, not the one
+        // the application pins; a mismatch is a red first story that says
+        // nothing about Node. Ask now, and name both.
+        if (commands.length > 0) {
+            yield* nodePreflight(nodeProcessExecutor, files, events, join(input.workDir, appDir), process.env);
+        }
         if (flags.land !== undefined) {
             const landed = yield* landEpic(context, {
                 plan,

package/flows/modernize-implement.js

@@ -29,6 +29,7 @@ import { judgeAllPrograms } from "@llm4ts/flow/ProgramJudge";
 import { Provenance, makeProvenanceStore } from "@llm4ts/flow/Provenance";
 import { ApprovedMarker, DraftApprovalMarker, requireApproval } from "@llm4ts/flow/Approval";
 import { loadPatternCards, taggedPatternIds } from "@llm4ts/flow/Patterns";
+import { nodePreflight } from "@llm4ts/flow/NodePreflight";
 import { ReviewIssue } from "@llm4ts/flow/Review";
 import { checkWall, wallBreachMessage } from "@llm4ts/flow/Wall";
 import { parseDecisions } from "@llm4ts/flow/Decisions";
@@ -194,6 +195,8 @@ const program = Effect.gen(function* () {
                 message: `no plan at ${planPath} — run modernize-seed first`
             });
         }
+        // The pack's gates run on the node on PATH: check it against the target's pin first.
+        yield* nodePreflight(nodeProcessExecutor, files, context.events, input.workDir, process.env);
         const gate = (name) => {
             const command = pack.gate(name);
             return command === undefined

package/kits/j2ee-nextjs/README.md

@@ -28,3 +28,15 @@ LLM4TS_LEGACY_REPO=/path/to/legacy-estate llm4ts run convert-page --pack j2ee-ne
 
 The convert flows default to `j2ee-nextjs-spa`; `kits/test/packs.test.ts`
 shows what the flows require of a manifest.
+
+## Node for the gates
+
+The Next.js scaffold pins Node 22 (`.nvmrc`, `package.json` `engines`). The
+pack's gates run on the `node` on the PATH of the shell that launches
+`llm4ts`, so `convert-*`, `modernize-implement` and `epic-stories` check it
+against the target's pin before the first gate and stop, naming both, when
+they disagree; `llm4ts doctor` reports the same under `gates:`. Switch Node
+(`nvm use` / `fnm use`), or uncomment `use-node-version` in the target's
+`.npmrc` so pnpm runs the pinned Node itself, or give the pack gates a
+version-manager wrapper (`fnm exec --using=.nvmrc pnpm lint`). Set
+`LLM4TS_NODE_CHECK=off` to run anyway.

package/kits/j2ee-nextjs/fixtures/demo-bank/RUNBOOK.md

@@ -18,10 +18,10 @@ node kits/j2ee-nextjs/fixtures/demo-bank/preflight.mjs
 ```
 
 Preflight seeds both fixtures into a temp dir, runs their smoke checks, and
-verifies git, pnpm, the `claude` CLI, and that the installed `llm4ts` ships
-the `j2ee-nextjs` kit with its `j2ee-nextjs-spa` pack (`@llm4ts/shell`
-0.18.0 or newer). Fix anything red before continuing. Then materialize the
-demo estate (pick a short path you can type on stage):
+verifies git, Node 22 on PATH, pnpm, the `claude` CLI, and that the installed
+`llm4ts` ships the `j2ee-nextjs` kit with its `j2ee-nextjs-spa` pack
+(`@llm4ts/shell` 0.18.0 or newer). Fix anything red before continuing. Then
+materialize the demo estate (pick a short path you can type on stage):
 
 ```bash
 node kits/j2ee-nextjs/fixtures/demo-bank/reset-demo.mjs ~/demo
@@ -32,6 +32,17 @@ warms the target's node_modules from the pnpm store (documented offline
 strategy: the lockfile is committed; run it once on hotel wifi, never on
 stage). Finally: `cd ~/demo/nextjs && pnpm test` must be green.
 
+**Node for the gates.** The target pins Node 22 (`.nvmrc`, `package.json`
+`engines`). Gates run on the `node` found on the PATH of the shell that
+launches `llm4ts`, so every gated flow checks that node against the pin
+before its first gate and stops with both versions named when they
+disagree (`llm4ts doctor` shows the same line under `gates:`). On a machine
+whose Node you cannot switch (`nvm use 22` / `fnm use 22`), uncomment
+`use-node-version` in the target's `.npmrc` so pnpm fetches and runs that
+Node itself (one download, then offline), or wrap the pack's gate commands
+in a version manager (`fnm exec --using=.nvmrc pnpm lint` works as a gate
+line, since gates are plain argv). `LLM4TS_NODE_CHECK=off` skips the check.
+
 Timing bounds for the day (set in the environment you run flows from):
 
 ```bash

package/kits/j2ee-nextjs/fixtures/demo-bank/nextjs/.nvmrc

@@ -0,0 +1 @@
+22

package/kits/j2ee-nextjs/fixtures/demo-bank/nextjs/package.json

@@ -2,6 +2,9 @@
   "name": "demo-bank-nextjs",
   "version": "0.1.0",
   "private": true,
+  "engines": {
+    "node": ">=22"
+  },
   "scripts": {
     "dev": "next dev",
     "build": "next build",

package/kits/j2ee-nextjs/fixtures/demo-bank/preflight.mjs

@@ -23,7 +23,12 @@ const tool = (label, command, args) =>
   check(label, () => execFileSync(command, args, { stdio: "pipe" }))
 
 tool("git available", "git", ["--version"])
-tool("node >= 20", "node", ["--version"])
+check("node >= 22 (the fixtures pin it in .nvmrc and engines)", () => {
+  const version = execFileSync("node", ["--version"], { encoding: "utf8" }).trim()
+  if (Number(version.replace(/^v/, "").split(".")[0]) < 22) {
+    throw new Error(`${version} on PATH; the gates need Node 22 (nvm use 22 / fnm use 22)`)
+  }
+})
 tool("pnpm available", "pnpm", ["--version"])
 tool("claude CLI available (the coder seat)", "claude", ["--version"])
 check("llm4ts CLI available", () => execFileSync("llm4ts", ["--version"], { stdio: "pipe" }))

package/kits/j2ee-nextjs/flows/lib/convert.js

@@ -14,6 +14,7 @@ import { budget, capped } from "@llm4ts/flow/Context";
 import { Decisions, parseDecisions } from "@llm4ts/flow/Decisions";
 import { navigationOrder, parseDomains } from "@llm4ts/flow/Domains";
 import { FlowEvents } from "@llm4ts/flow/FlowEvents";
+import { nodePreflight } from "@llm4ts/flow/NodePreflight";
 import { openApiFor, openApiForFeature, parsePageSpec, renderPageSpec } from "@llm4ts/flow/PageSpec";
 import { loadPatternCards, matchingPatternCards } from "@llm4ts/flow/Patterns";
 import { Task } from "@llm4ts/flow/Plan";
@@ -554,6 +555,8 @@ export const setupConversion = Effect.fn("convert.setup")(function* (context, in
     };
     const legacy = yield* makeNodeWorkspace(legacyDir, workspaceLimitsFromEnv(environment, legacySourceWorkspaceLimits));
     const target = yield* makeNodeWorkspace(input.workDir);
+    // The pack's gates run on the node on PATH: check it against the target's pin first.
+    yield* nodePreflight(nodeProcessExecutor, nodePlainFileStore, context.events, input.workDir, environment);
     const opened = yield* stage(context.events, "pack", openPack({
         environment: {
             ...environment,

package/kits/j2ee-nextjs/scaffolds/nextjs-spa/.nvmrc

@@ -0,0 +1 @@
+22

package/kits/j2ee-nextjs/scaffolds/nextjs-spa/package.json

@@ -2,6 +2,9 @@
   "name": "meridian-spa",
   "version": "0.1.0",
   "private": true,
+  "engines": {
+    "node": ">=22"
+  },
   "scripts": {
     "test": "node --test tests/*.test.js",
     "build": "next build",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@llm4ts/shell",
-  "version": "2.24.0",
+  "version": "2.25.0",
   "description": "Interactive shell and CLI for llm4ts: flow discovery, run-a-flow, and view",
   "license": "MIT",
   "type": "module",
@@ -52,9 +52,9 @@
   "dependencies": {
     "@effect/platform-node": "4.0.0",
     "@effect/platform-node-shared": "4.0.0",
-    "@llm4ts/core": "2.24.0",
-    "@llm4ts/flow": "2.24.0",
-    "@llm4ts/runner": "2.24.0"
+    "@llm4ts/core": "2.25.0",
+    "@llm4ts/flow": "2.25.0",
+    "@llm4ts/runner": "2.25.0"
   },
   "peerDependencies": {
     "effect": "4.0.0"