@llblab/pi-actors 0.38.0 → 0.38.1

package/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+## 0.38.1: Windows Recipe ACL Hotfix
+
+- `[Registry]` Replaced POSIX mode-bit recipe-root writability checks on Windows with ACL-aware diagnostics, avoiding false `world-writable` and `group-writable` startup warnings from Node's NTFS mode emulation while still flagging broad Windows write grants.
+- `[Tests]` Added portable coverage for broad Windows ACL parsing and skipped the POSIX chmod diagnostic regression on Windows.
+
 ## 0.38.0: Review Swarm Pipeline Hardening
 
 - `[Recipes]` Added current model/thinking inheritance for packaged review/lens-swarm recipes through `{current_model}` and `{current_thinking}`, so normal subagent review swarms use the selected Pi session policy by default while explicit args still override it.

package/dist/lib/recipes-discovery.d.ts

@@ -45,6 +45,7 @@ export interface RecipesDiscoverySource {
     defaultTool?: boolean;
     mutableUsage?: boolean;
 }
+export declare function hasBroadWindowsWriteAcl(icaclsOutput: string): boolean;
 export declare function discoverRecipeSources(sources: RecipesDiscoverySource[]): RecipesDiscoveryResult;
 export declare function discoverRecipes(roots: string[]): RecipesDiscoveryResult;
 export declare function createRecipeIntegrityManifest(result: RecipesDiscoveryResult): RecipeIntegrityManifestEntry[];

package/dist/lib/recipes-discovery.js

@@ -3,6 +3,7 @@
  * Zones: recipe discovery, tool exposure, registry diagnostics
  * Owns filename identity discovery across prioritized recipe roots
  */
+import { execFileSync } from "node:child_process";
 import { createHash } from "node:crypto";
 import { existsSync, readFileSync, readdirSync, statSync } from "node:fs";
 import { join } from "node:path";
@@ -140,6 +141,50 @@ function filesForSource(source) {
         }))
         : [];
 }
+const WINDOWS_BROAD_WRITE_PRINCIPALS = [
+    "Everyone",
+    "BUILTIN\\Users",
+    "Authenticated Users",
+    "S-1-1-0",
+    "S-1-5-11",
+    "S-1-5-32-545",
+];
+const WINDOWS_WRITE_ACL_PATTERN = /\((?:[^)]*,)?(?:F|M|W|WD|AD|DC|GA|GW)(?:,[^)]*)?\)/i;
+export function hasBroadWindowsWriteAcl(icaclsOutput) {
+    return icaclsOutput
+        .split(/\r?\n/)
+        .some((line) => WINDOWS_BROAD_WRITE_PRINCIPALS.some((principal) => line.includes(principal)) && WINDOWS_WRITE_ACL_PATTERN.test(line));
+}
+function getWindowsRecipeRootDiagnostics(root) {
+    try {
+        const output = execFileSync("icacls", [root], {
+            encoding: "utf8",
+            windowsHide: true,
+            timeout: 5000,
+        });
+        if (!hasBroadWindowsWriteAcl(output))
+            return [];
+        return [
+            `Recipe root grants write access to broad Windows principals; review ACLs: ${root}`,
+        ];
+    }
+    catch (error) {
+        return [
+            `Failed to inspect Windows ACL for recipe root ${root}: ${error instanceof Error ? error.message : String(error)}`,
+        ];
+    }
+}
+function getPosixRecipeRootDiagnostics(root) {
+    const diagnostics = [];
+    const stat = statSync(root);
+    if ((stat.mode & 0o002) !== 0) {
+        diagnostics.push(`Recipe root is world-writable; review permissions: ${root}`);
+    }
+    if ((stat.mode & 0o020) !== 0) {
+        diagnostics.push(`Recipe root is group-writable; review ownership and permissions: ${root}`);
+    }
+    return diagnostics;
+}
 function getRecipeRootDiagnostics(sources) {
     const diagnostics = [];
     const roots = new Set(sources
@@ -149,13 +194,9 @@ function getRecipeRootDiagnostics(sources) {
         try {
             if (!existsSync(root))
                 continue;
-            const stat = statSync(root);
-            if ((stat.mode & 0o002) !== 0) {
-                diagnostics.push(`Recipe root is world-writable; review permissions: ${root}`);
-            }
-            if ((stat.mode & 0o020) !== 0) {
-                diagnostics.push(`Recipe root is group-writable; review ownership and permissions: ${root}`);
-            }
+            diagnostics.push(...(process.platform === "win32"
+                ? getWindowsRecipeRootDiagnostics(root)
+                : getPosixRecipeRootDiagnostics(root)));
         }
         catch (error) {
             diagnostics.push(`Failed to inspect recipe root ${root}: ${error instanceof Error ? error.message : String(error)}`);

package/dist/skills/actors/SKILL.md

@@ -2,7 +2,7 @@
 name: actors
 description: Required practical guide for non-trivial pi-actors use. Read before using or changing spawn, message, inspect, actor runs, tools, recipes, command templates, async lifecycle, mailboxes, artifacts, and local orchestration mechanics.
 metadata:
-  version: 0.38.0
+  version: 0.38.1
 ---
 
 # Actors (pi-actors)

package/dist/skills/swarm/SKILL.md

@@ -2,7 +2,7 @@
 name: swarm
 description: Subagent orchestration with scoped locks and quorum consensus. Use for multi-model review, parallel scoped work, delegated audit, and coordinated subagent execution.
 metadata:
-  version: 0.38.0
+  version: 0.38.1
 ---
 
 # Swarm

package/lib/recipes-discovery.ts

@@ -4,6 +4,7 @@
  * Owns filename identity discovery across prioritized recipe roots
  */
 
+import { execFileSync } from "node:child_process";
 import { createHash } from "node:crypto";
 import { existsSync, readFileSync, readdirSync, statSync } from "node:fs";
 import { join } from "node:path";
@@ -234,6 +235,61 @@ function filesForSource(source: RecipesDiscoverySource): Array<{
     : [];
 }
 
+const WINDOWS_BROAD_WRITE_PRINCIPALS = [
+  "Everyone",
+  "BUILTIN\\Users",
+  "Authenticated Users",
+  "S-1-1-0",
+  "S-1-5-11",
+  "S-1-5-32-545",
+];
+
+const WINDOWS_WRITE_ACL_PATTERN = /\((?:[^)]*,)?(?:F|M|W|WD|AD|DC|GA|GW)(?:,[^)]*)?\)/i;
+
+export function hasBroadWindowsWriteAcl(icaclsOutput: string): boolean {
+  return icaclsOutput
+    .split(/\r?\n/)
+    .some((line) =>
+      WINDOWS_BROAD_WRITE_PRINCIPALS.some((principal) =>
+        line.includes(principal),
+      ) && WINDOWS_WRITE_ACL_PATTERN.test(line),
+    );
+}
+
+function getWindowsRecipeRootDiagnostics(root: string): string[] {
+  try {
+    const output = execFileSync("icacls", [root], {
+      encoding: "utf8",
+      windowsHide: true,
+      timeout: 5000,
+    });
+    if (!hasBroadWindowsWriteAcl(output)) return [];
+    return [
+      `Recipe root grants write access to broad Windows principals; review ACLs: ${root}`,
+    ];
+  } catch (error) {
+    return [
+      `Failed to inspect Windows ACL for recipe root ${root}: ${error instanceof Error ? error.message : String(error)}`,
+    ];
+  }
+}
+
+function getPosixRecipeRootDiagnostics(root: string): string[] {
+  const diagnostics: string[] = [];
+  const stat = statSync(root);
+  if ((stat.mode & 0o002) !== 0) {
+    diagnostics.push(
+      `Recipe root is world-writable; review permissions: ${root}`,
+    );
+  }
+  if ((stat.mode & 0o020) !== 0) {
+    diagnostics.push(
+      `Recipe root is group-writable; review ownership and permissions: ${root}`,
+    );
+  }
+  return diagnostics;
+}
+
 function getRecipeRootDiagnostics(sources: RecipesDiscoverySource[]): string[] {
   const diagnostics: string[] = [];
   const roots = new Set(
@@ -244,17 +300,11 @@ function getRecipeRootDiagnostics(sources: RecipesDiscoverySource[]): string[] {
   for (const root of roots) {
     try {
       if (!existsSync(root)) continue;
-      const stat = statSync(root);
-      if ((stat.mode & 0o002) !== 0) {
-        diagnostics.push(
-          `Recipe root is world-writable; review permissions: ${root}`,
-        );
-      }
-      if ((stat.mode & 0o020) !== 0) {
-        diagnostics.push(
-          `Recipe root is group-writable; review ownership and permissions: ${root}`,
-        );
-      }
+      diagnostics.push(
+        ...(process.platform === "win32"
+          ? getWindowsRecipeRootDiagnostics(root)
+          : getPosixRecipeRootDiagnostics(root)),
+      );
     } catch (error) {
       diagnostics.push(
         `Failed to inspect recipe root ${root}: ${error instanceof Error ? error.message : String(error)}`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@llblab/pi-actors",
-  "version": "0.38.0",
+  "version": "0.38.1",
   "private": false,
   "description": "Local Actor Kernel for Pi",
   "keywords": [

package/skills/actors/SKILL.md

@@ -2,7 +2,7 @@
 name: actors
 description: Required practical guide for non-trivial pi-actors use. Read before using or changing spawn, message, inspect, actor runs, tools, recipes, command templates, async lifecycle, mailboxes, artifacts, and local orchestration mechanics.
 metadata:
-  version: 0.38.0
+  version: 0.38.1
 ---
 
 # Actors (pi-actors)

package/skills/swarm/SKILL.md

@@ -2,7 +2,7 @@
 name: swarm
 description: Subagent orchestration with scoped locks and quorum consensus. Use for multi-model review, parallel scoped work, delegated audit, and coordinated subagent execution.
 metadata:
-  version: 0.38.0
+  version: 0.38.1
 ---
 
 # Swarm