@livingdocs/editable.js 5.0.9 → 5.0.11

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@livingdocs/editable.js",
   "description": "Friendly contenteditable API",
-  "version": "5.0.9",
+  "version": "5.0.11",
   "dependencies": {
     "@babel/runtime": "^7.16.7",
     "lodash-es": "^4.17.21"
@@ -12,13 +12,15 @@
     "@babel/plugin-transform-runtime": "^7.16.10",
     "@babel/preset-env": "^7.16.11",
     "@babel/preset-react": "^7.16.7",
+    "@eslint/compat": "^1.1.0",
     "babel-loader": "^9.0.0",
     "babel-plugin-add-module-exports": "^1.0.4",
-    "babel-plugin-istanbul": "^6.1.1",
+    "babel-plugin-istanbul": "^7.0.0",
     "chai": "^5.0.0",
     "css-loader": "^7.0.0",
-    "eslint": "^8.8.0",
-    "eslint-plugin-react": "^7.28.0",
+    "eslint": "^9.6.0",
+    "eslint-plugin-react": "^7.34.3",
+    "globals": "^15.8.0",
     "karma": "^6.3.13",
     "karma-chrome-launcher": "^3.1.0",
     "karma-coverage": "^2.1.0",
@@ -33,7 +35,7 @@
     "react": "^18.0.0",
     "react-dom": "^18.0.0",
     "react-transition-group": "^4.4.2",
-    "rimraf": "^5.0.0",
+    "rimraf": "^6.0.0",
     "sinon": "^18.0.0",
     "style-loader": "^4.0.0",
     "url-loader": "^4.1.1",
@@ -71,7 +73,7 @@
     "test:all": "npm run test:karma -s -- --browsers Chrome,Firefox,Safari",
     "test:karma": "karma start",
     "test:watch": "npm run test:karma -s -- --single-run false",
-    "lint": "eslint --ignore-path .gitignore ."
+    "lint": "eslint"
   },
   "release": {
     "extends": "@livingdocs/semantic-release-presets/npm-github-verify"
@@ -80,11 +82,11 @@
     "isCi": true,
     "name": "Drone",
     "service": "drone",
-    "commit": "240d82b1c7a2b66d5fa322236b5eaa2bdb8e2712",
-    "build": "1638",
+    "commit": "85675583caacbfd2acf2577f7e7d170992627f60",
+    "build": "1700",
     "branch": "master",
     "isPr": false,
     "slug": "livingdocsIO/editable.js",
-    "date": "2024-06-28T14:06:28.269Z"
+    "date": "2024-07-22T15:51:53.699Z"
   }
 }

package/src/cursor.js

@@ -296,7 +296,7 @@ export default class Cursor {
 
   retainVisibleSelection (callback) {
     this.save()
-    callback()
+    callback() // eslint-disable-line callback-return
     this.restore()
     this.setVisibleSelection()
   }

package/src/dispatcher.js

@@ -7,11 +7,6 @@ import Keyboard from './keyboard.js'
 import {closest} from './util/dom.js'
 import {replaceLast, endsWithSingleSpace} from './util/string.js'
 
-// This will be set to true once we detect the input event is working.
-// Input event description on MDN:
-// https://developer.mozilla.org/en-US/docs/Web/Reference/Events/input
-let isInputEventSupported = false
-
 /**
  * The Dispatcher module is responsible for dealing with events and their handlers.
  *
@@ -23,7 +18,6 @@ export default class Dispatcher {
   constructor (editable) {
     const win = editable.win
     eventable(this, editable)
-    this.supportsInputEvent = false
     this.document = win.document
     this.config = editable.config
     this.editable = editable
@@ -122,7 +116,6 @@ export default class Dispatcher {
         const selection = this.selectionWatcher.getFreshSelection()
         if (selection && selection.isSelection) {
           this.notify('clipboard', block, 'cut', selection)
-          this.triggerChangeEvent(block)
         }
       })
       .setupDocumentListener('paste', function pasteListener (evt) {
@@ -151,14 +144,7 @@ export default class Dispatcher {
       .setupDocumentListener('input', function inputListener (evt) {
         const block = this.getEditableBlockByEvent(evt)
         if (!block) return
-        if (isInputEventSupported) {
-          this.notify('change', block)
-        } else {
-          // Most likely the event was already handled manually by
-          // triggerChangeEvent so the first time we just switch the
-          // isInputEventSupported flag without notifying the change event.
-          isInputEventSupported = true
-        }
+        this.notify('change', block)
       })
 
       .setupDocumentListener('formatEditable', function formatEditableListener (evt) {
@@ -168,26 +154,6 @@ export default class Dispatcher {
       })
   }
 
-  /**
-  * Trigger a change event
-  *
-  * This should be done in these cases:
-  * - typing a letter
-  * - delete (backspace and delete keys)
-  * - cut
-  * - paste
-  * - copy and paste (not easily possible manually as far as I know)
-  *
-  * Preferably this is done using the input event. But the input event is not
-  * supported on all browsers for contenteditable elements.
-  * To make things worse it is not detectable either. So instead of detecting
-  * we set 'isInputEventSupported' when the input event fires the first time.
-  */
-  triggerChangeEvent (target) {
-    if (isInputEventSupported) return
-    this.notify('change', target)
-  }
-
   dispatchSwitchEvent (event, element, direction) {
     if (event.altKey || event.ctrlKey || event.metaKey || event.shiftKey) return
     const cursor = this.selectionWatcher.getFreshSelection()
@@ -228,8 +194,7 @@ export default class Dispatcher {
     this.setupDocumentListener('keydown', function (evt) {
       const block = this.getEditableBlockByEvent(evt)
       if (!block) return
-      const notifyCharacterEvent = !isInputEventSupported
-      this.keyboard.dispatchKeyEvent(evt, block, notifyCharacterEvent)
+      this.keyboard.dispatchKeyEvent(evt, block, false)
     }, true)
   }
 
@@ -253,10 +218,10 @@ export default class Dispatcher {
 
       .on('backspace', function (event) {
         const rangeContainer = self.selectionWatcher.getFreshRange()
-        if (!rangeContainer.isCursor) return self.triggerChangeEvent(this)
+        if (!rangeContainer.isCursor) return
 
         const cursor = rangeContainer.getCursor()
-        if (!cursor.isAtBeginning()) return self.triggerChangeEvent(this)
+        if (!cursor.isAtBeginning()) return
 
         event.preventDefault()
         event.stopPropagation()
@@ -265,10 +230,10 @@ export default class Dispatcher {
 
       .on('delete', function (event) {
         const rangeContainer = self.selectionWatcher.getFreshRange()
-        if (!rangeContainer.isCursor) return self.triggerChangeEvent(this)
+        if (!rangeContainer.isCursor) return
 
         const cursor = rangeContainer.getCursor()
-        if (!cursor.isAtTextEnd()) return self.triggerChangeEvent(this)
+        if (!cursor.isAtTextEnd()) return
 
         event.preventDefault()
         event.stopPropagation()

package/src/plugins/highlighting/spellcheck-service.js

@@ -19,10 +19,9 @@ export default class SpellcheckService {
 
     this.spellcheckService(condensedText, (misspelledWords) => {
       if (misspelledWords && misspelledWords.length > 0) {
-        callback(null, misspelledWords)
-      } else {
-        callback(null)
+        return callback(null, misspelledWords)
       }
+      return callback(null)
     })
   }