@livestore/wa-sqlite 1.0.8-dev.2 → 1.0.8-dev.3

package/README.md

@@ -8,6 +8,10 @@ This fork adds synchronous APIs and session extensions needed for LiveStore's re
 - **Session extensions**: Enables change tracking and replication for collaborative features  
 - **Node.js compatibility**: Additional build targets for server-side testing
 
+## Future work
+
+- **Async build investigation**: Some VFS implementations (e.g., IndexedDB) require async APIs ([#131](https://github.com/livestorejs/livestore/issues/131)). We're investigating whether to support this through a unified hybrid build or separate builds.
+
 ### Changes include:
 
 - `src/sqlite-api.js`:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@livestore/wa-sqlite",
-  "version": "1.0.8-dev.2",
+  "version": "1.0.8-dev.3",
   "type": "module",
   "main": "src/sqlite-api.js",
   "types": "src/types/index.d.ts",
@@ -15,6 +15,12 @@
     "dist/*",
     "test/*"
   ],
+  "scripts": {
+    "build-docs": "typedoc",
+    "start": "web-dev-server --node-resolve",
+    "test": "web-test-runner",
+    "test-manual": "web-test-runner --manual"
+  },
   "devDependencies": {
     "@types/jasmine": "^5.1.4",
     "@web/dev-server": "^0.4.6",
@@ -34,11 +40,5 @@
     "web-test-runner-jasmine@0.0.6": {
       "unplugged": true
     }
-  },
-  "scripts": {
-    "build-docs": "typedoc",
-    "start": "web-dev-server --node-resolve",
-    "test": "web-test-runner",
-    "test-manual": "web-test-runner --manual"
   }
-}
+}

package/src/sqlite-api.js

@@ -260,18 +260,21 @@ export function Factory(Module) {
     return function(db, schema) {
       verifyDatabase(db);
       const piSize = tmpPtr[0];
-      let address = f(db, schema, piSize, 0);
+      let address = f(db, schema, piSize, 0); // 0 means no flags
       if (address === 0) {
         address = f(db, schema, piSize, SQLITE_SERIALIZE_NOCOPY);
         const size = Module.getValue(piSize, '*');
         const result = Module.HEAPU8.subarray(address, address + size);
         // NOTE Given that the memory is owned by SQLite, we must copy it.
+        // Warning: We're not super confident yet about this code path. There might be dragons.
         return new Uint8Array(result.slice());
       } else {
         const size = Module.getValue(piSize, '*');
         const result = Module.HEAPU8.subarray(address, address + size);
-        // Here we're getting a copy of the memory, so we can return it directly.
-        return new Uint8Array(result);
+        // Copy the data immediately, then free the SQLite buffer to prevent ref-count issues
+        const copy = new Uint8Array(result);
+        Module._sqlite3_free(address); 
+        return copy;
       }
     };
   })();
@@ -290,10 +293,15 @@ export function Factory(Module) {
         const errMsg = Module.ccall('sqlite3_errmsg', 'string', ['number'], [dest]);
         throw new SQLiteError(`backup failed: ${errMsg}`, SQLite.SQLITE_ERROR);
       }
-      fStep(backup, -1);
+      // TODO also allow run in chunks with some yielding mechanism
+      fStep(backup, -1); // -1 means do it in one go
       return fFinish(backup);
     };
   })();
+  
+
+  // TODO implement this at some point
+  // sqlite3.backup_step = (function() {
 
   sqlite3.clear_bindings = (function() {
     const fname = 'sqlite3_clear_bindings';