@livestore/livestore 0.4.0-dev.21 → 0.4.0-dev.23

package/src/live-queries/base-class.ts

@@ -1,10 +1,11 @@
+import type * as otel from '@opentelemetry/api'
+
 import { isNotNil } from '@livestore/utils'
 import { Equal, Hash, Predicate } from '@livestore/utils/effect'
-import type * as otel from '@opentelemetry/api'
 
 import * as RG from '../reactive.ts'
-import type { Store } from '../store/store.ts'
 import type { QueryDebugInfo, RefreshReason } from '../store/store-types.ts'
+import type { Store } from '../store/store.ts'
 import type { StackInfo } from '../utils/stack-info.ts'
 
 export type ReactivityGraph = RG.ReactiveGraph<RefreshReason, QueryDebugInfo, ReactivityGraphContext>
@@ -272,8 +273,8 @@ export abstract class LiveStoreQueryBase<TResult> implements LiveQuery<TResult>
  */
 export type GetAtomResult = <T>(
   atom: RG.Atom<T, any, RefreshReason> | LiveQueryDef<T> | LiveQuery<T> | ISignal<T> | SignalDef<T>,
-  otelContext?: otel.Context | undefined,
-  debugRefreshReason?: RefreshReason | undefined,
+  otelContext?: otel.Context  ,
+  debugRefreshReason?: RefreshReason  ,
 ) => T
 
 export type DependencyQueriesRef = Set<RcRef<LiveQuery.Any | ISignal<any>>>
@@ -298,7 +299,7 @@ export const makeGetAtomResult = (
     }
 
     // Signal case
-    if (atom._tag === 'signal' && Predicate.hasProperty(atom, 'ref')) {
+    if (atom._tag === 'signal' && Predicate.hasProperty(atom, 'ref') === true) {
       return get(atom.ref, otelContext, debugRefreshReason)
     }
 
@@ -315,7 +316,7 @@ export const withRCMap = <T extends LiveQuery.Any | ISignal<any>>(
 ): ((ctx: ReactivityGraphContext, otelContext?: otel.Context) => RcRef<T>) => {
   return (ctx, otelContext) => {
     let item = ctx.defRcMap.get(id)
-    if (item) {
+    if (item !== undefined) {
       item.rc++
       return item as RcRef<T>
     }

package/src/live-queries/client-document-get-query.ts

@@ -1,8 +1,10 @@
+import type * as otel from '@opentelemetry/api'
+
 import type { PreparedBindValues } from '@livestore/common'
 import { SessionIdSymbol } from '@livestore/common'
 import { State } from '@livestore/common/schema'
 import { shouldNeverHappen } from '@livestore/utils'
-import type * as otel from '@opentelemetry/api'
+
 import { StoreInternalsSymbol } from '../store/store-types.ts'
 import type { ReactivityGraphContext } from './base-class.ts'
 
@@ -40,7 +42,7 @@ export const makeExecBeforeFirstRun =
         { otelContext },
       ).length === 1
 
-    if (rowExists) return
+    if (rowExists === true) return
 
     // It's important that we only commit and don't refresh here, as this function might be called during a render
     // and otherwise we might end up in a "reactive loop"

package/src/live-queries/computed.ts

@@ -1,6 +1,7 @@
+import * as otel from '@opentelemetry/api'
+
 import { getDurationMsFromSpan } from '@livestore/common'
 import { Equal, Hash } from '@livestore/utils/effect'
-import * as otel from '@opentelemetry/api'
 
 import type { Thunk } from '../reactive.ts'
 import type { RefreshReason } from '../store/store-types.ts'
@@ -64,7 +65,7 @@ export const computed = <TResult>(
     deps?: DepKey
   },
 ): LiveQueryDef<TResult> => {
-  const hash = options?.deps ? depsToString(options.deps) : fn.toString()
+  const hash = options?.deps !== undefined ? depsToString(options.deps) : fn.toString()
   if (isValidFunctionString(hash)._tag === 'invalid') {
     throw new Error(`On Expo/React Native, computed queries must provide a \`deps\` option`)
   }

package/src/live-queries/db-query.test.ts

@@ -1,9 +1,10 @@
-import { Effect, ReadonlyRecord, Schema } from '@livestore/utils/effect'
-import { Vitest } from '@livestore/utils-dev/node-vitest'
 import * as otel from '@opentelemetry/api'
 import { BasicTracerProvider, InMemorySpanExporter, SimpleSpanProcessor } from '@opentelemetry/sdk-trace-base'
 import { assert, expect } from 'vitest'
 
+import { Vitest } from '@livestore/utils-dev/node-vitest'
+import { Effect, ReadonlyRecord, Schema } from '@livestore/utils/effect'
+
 import * as RG from '../reactive.ts'
 import { StoreInternalsSymbol } from '../store/store-types.ts'
 import { events, makeTodoMvc, type Todo, tables } from '../utils/tests/fixture.ts'

package/src/live-queries/db-query.ts

@@ -9,7 +9,7 @@ import {
   SessionIdSymbol,
   UnknownError,
 } from '@livestore/common'
-import { deepEqual, omitUndefineds, shouldNeverHappen } from '@livestore/utils'
+import { deepEqual, objectToString, omitUndefineds, shouldNeverHappen } from '@livestore/utils'
 import { Equal, Hash, Predicate, Schema, TreeFormatter } from '@livestore/utils/effect'
 import * as otel from '@opentelemetry/api'
 
@@ -103,7 +103,7 @@ export const queryDb: {
 } = (queryInput, options) => {
   const { queryString, extraDeps } = getQueryStringAndExtraDeps(queryInput)
 
-  const hash = [queryString, options?.deps ? depsToString(options.deps) : undefined, depsToString(extraDeps)]
+  const hash = [queryString, options?.deps !== undefined ? depsToString(options.deps) : undefined, depsToString(extraDeps)]
     .filter(Boolean)
     .join('-')
 
@@ -112,7 +112,7 @@ export const queryDb: {
   }
 
   if (hash.trim() === '') {
-    return shouldNeverHappen(`Invalid query hash for query: ${queryInput}`)
+      return shouldNeverHappen('Invalid query hash for query:', objectToString(queryInput))
   }
 
   const label = options?.label ?? queryString
@@ -155,12 +155,12 @@ const bindValuesToDepKey = (bindValues: Bindable | undefined): DepKey => {
 const getQueryStringAndExtraDeps = (
   queryInput: QueryInput<any, any> | ((get: GetAtomResult) => QueryInput<any, any>),
 ): { queryString: string; extraDeps: DepKey } => {
-  if (isQueryBuilder(queryInput)) {
+  if (isQueryBuilder(queryInput) === true) {
     const { query, bindValues } = queryInput.asSql()
     return { queryString: query, extraDeps: bindValuesToDepKey(bindValues) }
   }
 
-  if (isQueryInputRaw(queryInput)) {
+  if (isQueryInputRaw(queryInput) === true) {
     return { queryString: queryInput.query, extraDeps: bindValuesToDepKey(queryInput.bindValues) }
   }
 
@@ -168,7 +168,7 @@ const getQueryStringAndExtraDeps = (
     return { queryString: queryInput.toString(), extraDeps: [] }
   }
 
-  return shouldNeverHappen(`Invalid query input: ${queryInput}`)
+  return shouldNeverHappen(`Invalid query input: ${String(queryInput)}`)
 }
 
 /* An object encapsulating a reactive SQL query */
@@ -216,7 +216,7 @@ export class LiveStoreDbQuery<TResultSchema, TResult = TResultSchema> extends Li
 
     const schemaRef: { current: Schema.Schema<any, any> | undefined } = {
       current:
-        typeof queryInput === 'function' ? undefined : isQueryBuilder(queryInput) ? undefined : queryInput.schema,
+        typeof queryInput === 'function' ? undefined : isQueryBuilder(queryInput) === true ? undefined : queryInput.schema,
     }
 
     const execBeforeFirstRunRef: {
@@ -270,7 +270,7 @@ export class LiveStoreDbQuery<TResultSchema, TResult = TResultSchema> extends Li
 
           let queryInputRaw: TQueryInputRaw
 
-          if (isQueryBuilder(queryInputResult)) {
+          if (isQueryBuilder(queryInputResult) === true) {
             const res = fromQueryBuilder(queryInputResult, otelContext)
             queryInputRaw = res.queryInputRaw
             // setting label dynamically here
@@ -297,7 +297,7 @@ export class LiveStoreDbQuery<TResultSchema, TResult = TResultSchema> extends Li
       this.queryInput$ = queryInputRaw$OrQueryInputRaw
     } else {
       let queryInputRaw: TQueryInputRaw
-      if (isQueryBuilder(queryInput)) {
+      if (isQueryBuilder(queryInput) === true) {
         const res = fromQueryBuilder(queryInput, otelContext)
         queryInputRaw = res.queryInputRaw
         label = res.label
@@ -310,7 +310,7 @@ export class LiveStoreDbQuery<TResultSchema, TResult = TResultSchema> extends Li
       queryInputRaw$OrQueryInputRaw = queryInputRaw
 
       // this.label = inputLabel ? this.label : `db(${})`
-      if (inputLabel === undefined && isQueryBuilder(queryInput)) {
+      if (inputLabel === undefined && isQueryBuilder(queryInput) === true) {
         const ast = queryInput[QueryBuilderAstSymbol]
         if (ast._tag === 'RowQuery') {
           label = `db(${rowQueryLabel(ast.tableDef, ast.id)})`
@@ -342,7 +342,7 @@ export class LiveStoreDbQuery<TResultSchema, TResult = TResultSchema> extends Li
           'db:...', // NOTE span name will be overridden further down
           {
             attributes: {
-              'livestore.debugRefreshReason': Predicate.hasProperty(debugRefreshReason, 'label')
+              'livestore.debugRefreshReason': Predicate.hasProperty(debugRefreshReason, 'label') === true
                 ? (debugRefreshReason.label as string)
                 : debugRefreshReason?._tag,
             },
@@ -357,7 +357,7 @@ export class LiveStoreDbQuery<TResultSchema, TResult = TResultSchema> extends Li
               execBeforeFirstRunRef.current = undefined
             }
 
-            const queryInputResult = isThunk(queryInputRaw$OrQueryInputRaw)
+            const queryInputResult = isThunk(queryInputRaw$OrQueryInputRaw) === true
               ? (get(queryInputRaw$OrQueryInputRaw, otelContext, debugRefreshReason) as TQueryInputRaw)
               : (queryInputRaw$OrQueryInputRaw as TQueryInputRaw)
 
@@ -383,12 +383,12 @@ export class LiveStoreDbQuery<TResultSchema, TResult = TResultSchema> extends Li
             span.setAttribute('sql.query', sqlString)
             span.updateName(`db:${sqlString.slice(0, 50)}`)
 
-            const rawDbResults = store[StoreInternalsSymbol].sqliteDbWrapper.cachedSelect<any>(
+            const rawDbResults = store[StoreInternalsSymbol].sqliteDbWrapper.cachedSelect(
               sqlString,
-              bindValues ? prepareBindValues(bindValues, sqlString) : undefined,
+              bindValues !== undefined ? prepareBindValues(bindValues, sqlString) : undefined,
               {
-                queriedTables: queriedTablesRef.current,
                 otelContext,
+                ...(queriedTablesRef.current !== undefined ? { queriedTables: queriedTablesRef.current } : {}),
               },
             )
 

package/src/live-queries/signal.test.ts

@@ -1,7 +1,8 @@
-import { Effect } from '@livestore/utils/effect'
-import { Vitest } from '@livestore/utils-dev/node-vitest'
 import { expect } from 'vitest'
 
+import { Vitest } from '@livestore/utils-dev/node-vitest'
+import { Effect } from '@livestore/utils/effect'
+
 import { makeTodoMvc } from '../utils/tests/fixture.ts'
 import { computed } from './computed.ts'
 import { signal } from './signal.ts'

package/src/mod.ts

@@ -41,6 +41,7 @@ export {
   createStore,
   createStorePromise,
 } from './store/create-store.ts'
+export { type RegistryStoreOptions, StoreRegistry, storeOptions } from './store/StoreRegistry.ts'
 export { Store } from './store/store.ts'
 export {
   isLiveQueryDef,
@@ -57,6 +58,7 @@ export {
   type StoreInternals,
   StoreInternalsSymbol,
   type SubscribeOptions,
+  type SyncStatus,
   type Unsubscribe,
 } from './store/store-types.ts'
 export { exposeDebugUtils } from './utils/dev.ts'

package/src/reactive.test.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+
 import type { DebugRefreshReasonBase, DebugThunkInfo } from './reactive.ts'
 import { ReactiveGraph } from './reactive.ts'
 
@@ -142,7 +143,7 @@ describe('a trivial graph', () => {
       expect(numberOfEffectRuns).toBe(0)
       const effect = graph.makeEffect((get) => {
         // establish a dependency on thunk c and mutate an outside value
-        expect(get(c)).toBe(aHasChanged ? 3 : 4)
+        expect(get(c)).toBe(aHasChanged === true ? 3 : 4)
         numberOfEffectRuns++
       })
 
@@ -562,7 +563,7 @@ describe('bug fix: node corruption protection', () => {
 
     let firstRun = true
     const effect = graph.makeEffect((get) => {
-      if (firstRun) {
+      if (firstRun !== undefined) {
         firstRun = false
         graph.destroyNode(thunk1) // Destroy dependency mid-execution
       }

package/src/reactive.ts

@@ -21,10 +21,11 @@
 //   is maintained eagerly as edges are added and removed.)
 // - At every thunk we check value equality with the previous value and cutoff propagation if possible.
 
+import type * as otel from '@opentelemetry/api'
+
 import { BoundArray } from '@livestore/common'
 import { deepEqual, omitUndefineds, shouldNeverHappen } from '@livestore/utils'
 import type { Types } from '@livestore/utils/effect'
-import type * as otel from '@opentelemetry/api'
 // import { getDurationMsFromSpan } from './otel.ts'
 
 export const NOT_REFRESHED_YET = Symbol.for('NOT_REFRESHED_YET')
@@ -32,8 +33,8 @@ export type NOT_REFRESHED_YET = typeof NOT_REFRESHED_YET
 
 export type GetAtom = <T>(
   atom: Atom<T, any, any>,
-  otelContext?: otel.Context | undefined,
-  debugRefreshReason?: TODO | undefined,
+  otelContext?: otel.Context  ,
+  debugRefreshReason?: TODO  ,
 ) => T
 
 export type Ref<T, TContext, TDebugRefreshReason extends DebugRefreshReason> = {
@@ -47,7 +48,7 @@ export type Ref<T, TContext, TDebugRefreshReason extends DebugRefreshReason> = {
   super: Set<Thunk<any, TContext, TDebugRefreshReason> | Effect<TDebugRefreshReason>>
   label?: string | undefined
   /** Container for meta information (e.g. the LiveStore Store) */
-  meta?: any | undefined
+  meta?: unknown
   equal: (a: T, b: T) => boolean
   refreshes: number
 }
@@ -63,7 +64,7 @@ export type Thunk<TResult, TContext, TDebugRefreshReason extends DebugRefreshRea
   super: Set<Thunk<any, TContext, TDebugRefreshReason> | Effect<TDebugRefreshReason>>
   label?: string | undefined
   /** Container for meta information (e.g. the LiveStore Store) */
-  meta?: any | undefined
+  meta?: unknown
   equal: (a: TResult, b: TResult) => boolean
   recomputations: number
 
@@ -78,7 +79,7 @@ export type Effect<TDebugRefreshReason extends DebugRefreshReason> = {
   _tag: 'effect'
   id: string
   isDestroyed: boolean
-  doEffect: (otelContext?: otel.Context | undefined, debugRefreshReason?: TDebugRefreshReason | undefined) => void
+  doEffect: (otelContext?: otel.Context  , debugRefreshReason?: TDebugRefreshReason  ) => void
   sub: Set<Atom<any, TODO, TODO>>
   label?: string | undefined
   invocations: number
@@ -91,7 +92,7 @@ export type Node<T, TContext, TDebugRefreshReason extends DebugRefreshReason> =
 export const isThunk = <T, TContext, TDebugRefreshReason extends DebugRefreshReason>(
   obj: unknown,
 ): obj is Thunk<T, TContext, TDebugRefreshReason> => {
-  return typeof obj === 'object' && obj !== null && '_tag' in obj && (obj as any)._tag === 'thunk'
+  return typeof obj === 'object' && obj !== null && '_tag' in obj && (obj as { _tag: unknown })._tag === 'thunk'
 }
 
 export type DebugThunkInfo<T extends string = string> = {
@@ -203,9 +204,7 @@ export class ReactiveGraph<
 
   debugRefreshInfos: BoundArray<RefreshDebugInfo<TDebugRefreshReason, TDebugThunkInfo>> = new BoundArray(200)
 
-  private currentDebugRefresh:
-    | { refreshedAtoms: AtomDebugInfo<TDebugThunkInfo>[]; startMs: DOMHighResTimeStamp }
-    | undefined
+  private currentDebugRefresh: { refreshedAtoms: AtomDebugInfo<TDebugThunkInfo>[]; startMs: number } | undefined
 
   private deferredEffects: Map<Effect<TDebugRefreshReason>, Set<TDebugRefreshReason>> = new Map()
 
@@ -253,7 +252,7 @@ export class ReactiveGraph<
           meta?: any
           equal?: (a: T, b: T) => boolean
         }
-      | undefined,
+       ,
   ): Thunk<T, TContext, TDebugRefreshReason> {
     const thunk: Thunk<T, TContext, TDebugRefreshReason> = {
       _tag: 'thunk',
@@ -262,10 +261,10 @@ export class ReactiveGraph<
       isDirty: true,
       isDestroyed: false,
       computeResult: (otelContext, debugRefreshReason) => {
-        if (thunk.isDirty) {
+        if (thunk.isDirty === true) {
           const neededCurrentRefresh = this.currentDebugRefresh === undefined
           let localDebugRefresh: { refreshedAtoms: any[]; startMs: number } | undefined
-          if (neededCurrentRefresh) {
+          if (neededCurrentRefresh === true) {
             // Use local variable to prevent corruption from nested computations
             localDebugRefresh = { refreshedAtoms: [], startMs: performance.now() }
             this.currentDebugRefresh = localDebugRefresh
@@ -292,7 +291,7 @@ export class ReactiveGraph<
             debugRefreshReason,
           )
 
-          const resultChanged = thunk.equal(thunk.previousResult as T, result) === false
+          const resultChanged = ! thunk.equal(thunk.previousResult as T, result)
 
           const debugInfoForAtom = {
             atom: serializeAtom(thunk, false),
@@ -302,7 +301,7 @@ export class ReactiveGraph<
 
           // Use currentDebugRefresh if available (could be from parent or local)
           const debugRefresh = localDebugRefresh ?? this.currentDebugRefresh
-          if (debugRefresh) {
+          if (debugRefresh !== undefined) {
             debugRefresh.refreshedAtoms.push(debugInfoForAtom)
           }
 
@@ -310,7 +309,7 @@ export class ReactiveGraph<
           thunk.previousResult = result
           thunk.recomputations++
 
-          if (neededCurrentRefresh && localDebugRefresh) {
+          if (neededCurrentRefresh === true && localDebugRefresh !== undefined) {
             // Use local reference which can't be corrupted by nested calls
             const refreshedAtoms = localDebugRefresh.refreshedAtoms
             const durationMs = performance.now() - localDebugRefresh.startMs
@@ -385,7 +384,7 @@ export class ReactiveGraph<
       otelContext: otel.Context | undefined,
       debugRefreshReason: DebugRefreshReason | undefined,
     ) => void,
-    options?: { label?: string } | undefined,
+    options?: { label?: string }  ,
   ): Effect<TDebugRefreshReason> {
     const effect: Effect<TDebugRefreshReason> = {
       _tag: 'effect',
@@ -429,7 +428,7 @@ export class ReactiveGraph<
           debugRefreshReason?: TDebugRefreshReason
           otelContext?: otel.Context
         }
-      | undefined,
+       ,
   ) {
     this.setRefs([[ref, val]], options)
   }
@@ -442,7 +441,7 @@ export class ReactiveGraph<
           debugRefreshReason?: TDebugRefreshReason
           otelContext?: otel.Context
         }
-      | undefined,
+       ,
   ) {
     const effectsToRefresh = new Set<Effect<TDebugRefreshReason>>()
     for (const [ref, val] of refs) {
@@ -452,7 +451,7 @@ export class ReactiveGraph<
       markSuperCompDirtyRec(ref, effectsToRefresh)
     }
 
-    if (options?.skipRefresh) {
+    if (options?.skipRefresh === true) {
       for (const effect of effectsToRefresh) {
         if (this.deferredEffects.has(effect) === false) {
           this.deferredEffects.set(effect, new Set())
@@ -598,11 +597,11 @@ const compute = <T>(
   debugRefreshReason: DebugRefreshReason | undefined,
 ): T => {
   // const __getResult = atom._tag === 'thunk' ? atom.__getResult.toString() : ''
-  if (atom.isDestroyed) {
+  if (atom.isDestroyed === true) {
     shouldNeverHappen(`LiveStore Error: Attempted to compute destroyed ${atom._tag} (${atom.id}): ${atom.label ?? ''}`)
   }
 
-  if (atom.isDirty) {
+  if (atom.isDirty === true) {
     // console.log('atom is dirty', atom.id, atom.label ?? '', atom._tag, __getResult)
     const result = atom.computeResult(otelContext, debugRefreshReason)
     atom.isDirty = false
@@ -641,7 +640,7 @@ const serializeAtom = (atom: Atom<any, unknown, any>, includeResult: boolean): S
     super_.push(a.id)
   }
 
-  const previousResult: EncodedOption<string> = includeResult
+  const previousResult: EncodedOption<string> = includeResult === true
     ? encodedOptionSome(
         atom.previousResult === NOT_REFRESHED_YET ? '"SYMBOL_NOT_REFRESHED_YET"' : JSON.stringify(atom.previousResult),
       )