@livekit/agents 1.2.1 → 1.2.2

package/src/voice/room_io/room_io.test.ts

@@ -0,0 +1,38 @@
+// SPDX-FileCopyrightText: 2026 LiveKit, Inc.
+//
+// SPDX-License-Identifier: Apache-2.0
+import { describe, expect, it } from 'vitest';
+import { IdentityTransform } from '../../stream/identity_transform.js';
+
+/**
+ * Regression tests proving WritableStream.close() rejects when the writer is
+ * already closed or errored — the exact scenario RoomIO.close() guards against
+ * with a try/catch.
+ *
+ * RoomIO holds a WritableStreamDefaultWriter for user transcript forwarding.
+ * During teardown, the writer may already be closed or errored (e.g. a
+ * concurrent write failed during speech interruption). Without the guard,
+ * close() throws ERR_INVALID_STATE and crashes teardown.
+ */
+describe('RoomIO WritableStream close guard', () => {
+  it('should reject when closing an already-closed writer', async () => {
+    const transform = new IdentityTransform<string>();
+    const writer = transform.writable.getWriter();
+
+    await writer.close();
+
+    // Proves the bug: second close() rejects — RoomIO.close() must guard this.
+    await expect(writer.close()).rejects.toThrow();
+  });
+
+  it('should reject when closing a writer on an errored stream', async () => {
+    const transform = new IdentityTransform<string>();
+    const writer = transform.writable.getWriter();
+
+    // Force the stream into an errored state
+    await writer.abort(new Error('simulated write failure'));
+
+    // Proves the bug: close() on errored writer rejects — RoomIO.close() must guard this.
+    await expect(writer.close()).rejects.toThrow();
+  });
+});

package/src/voice/room_io/room_io.ts

@@ -529,8 +529,13 @@ export class RoomIO {
     await this.initTask?.cancelAndWait();
 
     // Close stream FIRST so reader.read() in forwardUserTranscript can exit.
-    // This is a workaround for a race condition in the stream API.
-    this.userTranscriptWriter.close();
+    // Writer may already be closed or errored if a concurrent write failed
+    // during session teardown (e.g. speech interruption race). Safe to ignore.
+    try {
+      await this.userTranscriptWriter.close();
+    } catch (e) {
+      this.logger.debug({ error: e }, 'userTranscriptWriter already closed or errored');
+    }
     await this.forwardUserTranscriptTask?.cancelAndWait();
 
     await this.audioInput?.close();