@livefolio/sdk 0.4.1 → 0.4.3

package/dist/index.d.ts

@@ -577,6 +577,11 @@ type PriceMap = ReadonlyMap<AssetId, number>;
  *   value and existing share counts.
  * @param prices - Current prices for all assets that appear in `targets` or are
  *   currently held. Throws `Error` if a target asset is missing from this map.
+ * @param assets - Optional canonical {@link Asset} metadata keyed by id. When
+ *   `reconcile` needs to emit an order for an asset that is not yet held in the
+ *   portfolio, it consults this map for the proper `symbol`/`kind`. If the
+ *   asset is missing here too, the order falls back to a synthesized
+ *   `{ kind: 'equity', id, symbol: id }` — lossless but display-unfriendly.
  * @returns A readonly array of `RebalanceOrder` objects. The array may be empty
  *   if the portfolio is already at the target allocation. Order IDs are
  *   deterministic within a single call (`rebal_<assetId>_<counter>`).
@@ -603,7 +608,7 @@ type PriceMap = ReadonlyMap<AssetId, number>;
  * // ]
  * ```
  */
-declare function reconcile(targets: TargetWeights, portfolio: Portfolio, prices: PriceMap): ReadonlyArray<RebalanceOrder>;
+declare function reconcile(targets: TargetWeights, portfolio: Portfolio, prices: PriceMap, assets?: ReadonlyMap<AssetId, Asset>): ReadonlyArray<RebalanceOrder>;
 
 /**
  * A flat record of fundamental data points for an asset at a point in time.
@@ -3523,7 +3528,10 @@ declare namespace index {
  * - `'close'`     — removes shares from an existing position and credits cash.
  * - `'adjust'`    — updates the position's `quantity`; only fees are debited.
  * - `'rebalance'` — buys or sells shares in the long position for `asset`;
- *                   creates or removes the position as needed.
+ *                   creates the position on a positive `delta`, removes it
+ *                   when fully reduced. A reduce against a non-existent
+ *                   long position is silently ignored (matching the same
+ *                   case in {@link applyOrders}).
  *
  * The returned `portfolio.t` is updated to the maximum fill timestamp.
  *

package/dist/index.js

@@ -5,7 +5,7 @@ var __export = (target, all) => {
 };
 
 // src/strategy/reconcile.ts
-function reconcile(targets, portfolio, prices) {
+function reconcile(targets, portfolio, prices, assets) {
   const longByAsset = /* @__PURE__ */ new Map();
   for (const p of portfolio.positions) {
     if (p.side !== "long") continue;
@@ -27,16 +27,16 @@ function reconcile(targets, portfolio, prices) {
     if (price === void 0) {
       throw new Error(`reconcile: missing price for target asset ${assetId}`);
     }
-    const targetShares = Math.floor(totalValue * weight / price);
+    const targetShares = Math.max(0, Math.floor(totalValue * weight / price));
     const held = longByAsset.get(assetId);
     const currentShares = held?.quantity ?? 0;
     const delta = targetShares - currentShares;
     seen.add(assetId);
     if (delta !== 0) {
-      const asset = held?.asset ?? {
+      const asset = held?.asset ?? assets?.get(assetId) ?? {
         kind: "equity",
         id: assetId,
-        symbol: assetId.split(":").pop() ?? assetId
+        symbol: assetId
       };
       orders.push({ id: nextId(assetId), kind: "rebalance", asset, delta });
     }
@@ -125,10 +125,7 @@ function applyFills(portfolio, fills, orders) {
               basis: prev.basis + cost
             };
           }
-        } else {
-          if (idx < 0) {
-            throw new Error(`applyFills: rebalance reduce on ${order.asset.id} but no long position exists`);
-          }
+        } else if (idx >= 0) {
           const prev = positions[idx];
           cash += fill.quantity * fill.price - fill.fees;
           const remaining = prev.quantity - fill.quantity;
@@ -2890,6 +2887,13 @@ function fromSpec(spec, opts) {
   }
   validateSynthetics(spec);
   const universe = spec.universe.map(resolveAssetRef);
+  const assetsById = /* @__PURE__ */ new Map();
+  for (const a of universe) assetsById.set(a.id, a);
+  for (const s of spec.synthetics ?? []) {
+    if (!assetsById.has(s.id)) {
+      assetsById.set(s.id, { kind: "equity", id: s.id, symbol: s.symbol });
+    }
+  }
   const { runtime, calendar } = opts;
   const cadence = spec.rebalance?.frequency ?? "Daily";
   return {
@@ -2934,7 +2938,7 @@ function fromSpec(spec, opts) {
         }
       }
       return {
-        orders: reconcile(evaluated.weights, portfolio, features.prices),
+        orders: reconcile(evaluated.weights, portfolio, features.prices, assetsById),
         state: evaluated.state
       };
     }