@livedigital/client 2.7.1 → 2.7.2

package/package.json

@@ -2,7 +2,7 @@
   "name": "@livedigital/client",
   "author": "vlprojects",
   "license": "MIT",
-  "version": "2.7.1",
+  "version": "2.7.2",
   "private": false,
   "bugs": {
     "url": "https://github.com/vlprojects/livedigital-sdk/issues"

package/src/engine/wid/WebRTCIssueDetector.ts

@@ -1,5 +1,4 @@
 import { WebRTCStats, WebRTCStatsEventData } from '@peermetrics/webrtc-stats';
-import WIDRTCPeerConnection from './WIDRTCPeerConnection';
 import { WebRTCIssueEmitter } from './WebRTCIssueEmitter';
 import {
   WebRTCIssueDetectorConstructorParams,
@@ -38,9 +37,7 @@ class WebRTCIssueDetector {
     });
 
     (window as unknown as WIDWindow).wid = this;
-    if (window.RTCPeerConnection) {
-      window.RTCPeerConnection = WIDRTCPeerConnection;
-    }
+    this.wrapRTCPeerConnection();
 
     this.detectors = [
       new QualityLimitationsIssueDetector(),
@@ -81,10 +78,6 @@ class WebRTCIssueDetector {
       return;
     }
 
-    if (!(pc instanceof RTCPeerConnection)) {
-      return;
-    }
-
     this.webrtcStats.addConnection({
       pc,
       peerId: this.webrtcStatsPeerId,
@@ -105,6 +98,24 @@ class WebRTCIssueDetector {
       this.emitIssues(issues);
     }
   }
+
+  private wrapRTCPeerConnection(): void {
+    if (!window.RTCPeerConnection) {
+      return;
+    }
+
+    const OriginalRTCPeerConnection = window.RTCPeerConnection;
+    const onConnectionCreated = (pc: RTCPeerConnection) => this.handleNewPeerConnection(pc);
+
+    function WIDRTCPeerConnection(rtcConfig?: RTCConfiguration) {
+      const connection = new OriginalRTCPeerConnection(rtcConfig);
+      onConnectionCreated(connection);
+      return connection;
+    }
+
+    WIDRTCPeerConnection.prototype = OriginalRTCPeerConnection.prototype;
+    (window.RTCPeerConnection as unknown) = WIDRTCPeerConnection;
+  }
 }
 
 export default WebRTCIssueDetector;

package/src/engine/wid/detectors/FramesDroppedIssueDetector.ts

@@ -18,10 +18,6 @@ class FramesDroppedIssueDetector implements IssueDetector {
   }
 
   private processData(data: WebRTCStatsEventData): IssueDetectorResult {
-    if (!data.video?.inbound) {
-      return [];
-    }
-
     const streamsWithDroppedFrames = data.video.inbound.filter((stats) => stats.framesDropped > 0);
     const issues: IssueDetectorResult = [];
     const previousInboundRTPVideoStreamsStats = this.#lastProcessedStats[data.connection.id]?.video.inbound;

package/src/engine/wid/detectors/FramesEncodedSentIssueDetector.ts

@@ -18,10 +18,6 @@ class FramesEncodedSentIssueDetector implements IssueDetector {
   }
 
   private processData(data: WebRTCStatsEventData): IssueDetectorResult {
-    if (!data.video?.outbound) {
-      return [];
-    }
-
     const streamsWithEncodedFrames = data.video.outbound.filter((stats) => stats.framesEncoded > 0);
     const issues: IssueDetectorResult = [];
     const previousOutboundRTPVideoStreamsStats = this.#lastProcessedStats[data.connection.id]?.video.outbound;

package/src/engine/wid/detectors/NetworkIssueDetector.ts

@@ -18,13 +18,16 @@ class NetworkIssueDetector implements IssueDetector {
   private processData(data: WebRTCStatsEventData): IssueDetectorResult {
     const issues: IssueDetectorResult = [];
     const inboundRTPStreamsStats = [...data.audio?.inbound, ...data.video?.inbound];
-    const previousStats = this.#lastProcessedStats[data.connection.id];
-    const previousInboundStreamStats = [...previousStats.video?.inbound, ...previousStats.audio?.inbound];
+    if (!inboundRTPStreamsStats.length) {
+      return issues;
+    }
 
-    if (!inboundRTPStreamsStats.length || !previousStats) {
+    const previousStats = this.#lastProcessedStats[data.connection.id];
+    if (!previousStats) {
       return issues;
     }
 
+    const previousInboundStreamStats = [...previousStats.video?.inbound, ...previousStats.audio?.inbound];
     const { packetsReceived } = data.connection;
     const lastPacketsReceived = previousStats.connection.packetsReceived;
 

package/src/engine/wid/detectors/QualityLimitationsIssueDetector.ts

@@ -16,10 +16,6 @@ class QualityLimitationsIssueDetector implements IssueDetector {
   }
 
   private processData(data: WebRTCStatsEventData): IssueDetectorResult {
-    if (!data.video?.outbound) {
-      return [];
-    }
-
     const streamsWithLimitation = data.video.outbound.filter((stats) => stats.qualityLimitationReason !== 'none');
     const issues: IssueDetectorResult = [];
     const previousOutboundRTPVideoStreamsStats = this.#lastProcessedStats[data.connection.id]?.video.outbound;

package/dist/engine/wid/WIDRTCPeerConnection.d.ts

@@ -1,4 +0,0 @@
-declare class WIDRTCPeerConnection extends RTCPeerConnection {
-    constructor(configuration?: RTCConfiguration);
-}
-export default WIDRTCPeerConnection;

package/src/engine/wid/WIDRTCPeerConnection.ts

@@ -1,13 +0,0 @@
-import { WIDWindow } from './types';
-
-class WIDRTCPeerConnection extends RTCPeerConnection {
-  constructor(configuration?: RTCConfiguration) {
-    super(configuration);
-    const { wid: webRTCIssueDetector } = (window as unknown as WIDWindow);
-    if (webRTCIssueDetector) {
-      webRTCIssueDetector.handleNewPeerConnection(this);
-    }
-  }
-}
-
-export default WIDRTCPeerConnection;