@livedesk/hub 0.1.71 → 0.1.72

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@livedesk/hub",
-  "version": "0.1.71",
+  "version": "0.1.72",
   "description": "VuvoDesk local Hub API and browser frame bridge",
   "type": "module",
   "main": "src/server.js",

package/src/console-direct.js

@@ -1343,7 +1343,11 @@ export function createHubConsoleDirect(options = {}) {
         iceTransportPolicy: 'all',
         disableAutoNegotiation: false,
         disableFingerprintVerification: false,
-        maxMessageSize: MAX_FRAME_MESSAGE_BYTES
+        // Each native send is one wire chunk. libdatachannel also uses this
+        // setting as the minimum SCTP socket buffer size, below bufferedAmount.
+        // A whole-frame limit here hides megabytes from our admission gate.
+        // Complete frame/HTTP limits remain enforced by the wire assemblers.
+        maxMessageSize: DIRECT_CONSOLE_WIRE_CHUNK_BYTES
       });
     } catch (error) {
       lastError = error instanceof Error ? error.message : String(error);

package/src/console-direct.test.mjs

@@ -4,6 +4,7 @@ import { readFileSync } from 'node:fs';
 import test from 'node:test';
 import nodeDataChannel from 'node-datachannel';
 import {
+  DIRECT_CONSOLE_WIRE_CHUNK_BYTES,
   createDirectConsoleWireAssembler,
   encodeDirectConsoleWireMessage
 } from '../../runtime-core/src/console-direct-wire.js';
@@ -358,6 +359,8 @@ test('STUN-only peer answers and rejects stale owner callbacks after replacement
   assert.deepEqual(firstPeer.config.iceServers, ['stun:stun.example.test:3478']);
   assert.equal(firstPeer.config.iceTransportPolicy, 'all');
   assert.equal(firstPeer.config.disableFingerprintVerification, false);
+  assert.equal(firstPeer.config.maxMessageSize, DIRECT_CONSOLE_WIRE_CHUNK_BYTES,
+    'native SCTP accepts wire chunks, not whole frames; a frame-sized setting silently enlarges its hidden buffers');
   assert.equal(signalingMessages(signal).some(message => (
     message.type === 'rtc-answer' && message.connectionId === CONNECTION_ONE
   )), true);
@@ -1566,18 +1569,19 @@ test('server session refresh preserves peers while logout uses the revoking clos
   assert.doesNotMatch(logoutBlock, /hubConsoleDirect\?\.refresh\(\)/);
 });
 
-test('native node-datachannel buffered sends deliver the complete fragmented wire over loopback', { timeout: 8_000 }, async t => {
+test('native chunk-sized SCTP accepts a full-size fragmented frame over loopback', { timeout: 8_000 }, async t => {
   let offerer = null;
   let answerer = null;
   let offerChannel = null;
   let answerChannel = null;
-  const assembler = createDirectConsoleWireAssembler();
+  const assembler = createDirectConsoleWireAssembler({ maxMessageBytes: consoleDirectContract.maxFrameMessageBytes });
   let openTimer = null;
   let messageTimer = null;
   try {
     nodeDataChannel.setSctpSettings({ sendBufferSize: 64 * 1024 });
-    offerer = new nodeDataChannel.PeerConnection('console-direct-native-offerer', { iceServers: [] });
-    answerer = new nodeDataChannel.PeerConnection('console-direct-native-answerer', { iceServers: [] });
+    const config = { iceServers: [], maxMessageSize: DIRECT_CONSOLE_WIRE_CHUNK_BYTES };
+    offerer = new nodeDataChannel.PeerConnection('console-direct-native-offerer', config);
+    answerer = new nodeDataChannel.PeerConnection('console-direct-native-answerer', config);
     offerer.onLocalDescription((sdp, type) => {
       answerer.setRemoteDescription(sdp, type);
     });
@@ -1611,11 +1615,16 @@ test('native node-datachannel buffered sends deliver the complete fragmented wir
     await opened;
     clearTimeout(openTimer);
     openTimer = null;
-    const payload = JSON.stringify({ type: 'direct-ready', connectionId: CONNECTION_ONE, hubEpoch: HUB_EPOCH });
-    const expected = payload.repeat(20_000);
+    assert.match(offerer.localDescription().sdp, /a=max-message-size:16384(?:\r?\n|$)/);
+    assert.match(answerer.localDescription().sdp, /a=max-message-size:16384(?:\r?\n|$)/);
+    assert.throws(() => offerChannel.sendMessageBinary(Buffer.alloc(DIRECT_CONSOLE_WIRE_CHUNK_BYTES + 1)),
+      /[Mm]essage.*large|[Ss]ize/);
+    const expected = Buffer.alloc(consoleDirectContract.maxFrameMessageBytes);
+    for (let n = 0; n < expected.length; n += 1) expected[n] = n % 251;
     const chunks = encodeDirectConsoleWireMessage(expected, {
       messageId: 77,
-      kind: 'control'
+      kind: 'binary',
+      maxMessageBytes: consoleDirectContract.maxFrameMessageBytes
     });
     assert.ok(chunks.length > 1);
     let bufferedSends = 0;
@@ -1626,8 +1635,8 @@ test('native node-datachannel buffered sends deliver the complete fragmented wir
     const message = await received;
     clearTimeout(messageTimer);
     messageTimer = null;
-    assert.equal(message.kind, 'control');
-    assert.equal(message.data, expected);
+    assert.equal(message.kind, 'binary');
+    assert.deepEqual(Buffer.from(message.data), expected);
     t.diagnostic(`native buffered sends=${bufferedSends}; complete bytes=${message.byteLength}; chunks=${chunks.length}`);
   } finally {
     if (openTimer) clearTimeout(openTimer);