@livedesk/hub 0.1.69 → 0.1.70

package/package.json

@@ -1,33 +1,33 @@
-{
-  "name": "@livedesk/hub",
-  "version": "0.1.69",
-  "description": "VuvoDesk local Hub API and browser frame bridge",
-  "type": "module",
-  "main": "src/server.js",
-  "files": [
-    "src/",
-    "README.md"
-  ],
-  "scripts": {
-    "dev": "node src/server.js",
-    "start": "node src/server.js",
-    "check": "node --check src/server.js && node --check src/remote-hub.js && node --check src/remote-clipboard-contract.mjs && node --check src/console-direct.js",
-    "prepublishOnly": "node ../../scripts/vuvodesk-release-git-gate.mjs"
-  },
-  "dependencies": {
-    "@ffmpeg-installer/ffmpeg": "^1.1.0",
+{
+  "name": "@livedesk/hub",
+  "version": "0.1.70",
+  "description": "VuvoDesk local Hub API and browser frame bridge",
+  "type": "module",
+  "main": "src/server.js",
+  "files": [
+    "src/",
+    "README.md"
+  ],
+  "scripts": {
+    "dev": "node src/server.js",
+    "start": "node src/server.js",
+    "check": "node --check src/server.js && node --check src/remote-hub.js && node --check src/remote-clipboard-contract.mjs && node --check src/console-direct.js",
+    "prepublishOnly": "node ../../scripts/vuvodesk-release-git-gate.mjs"
+  },
+  "dependencies": {
+    "@ffmpeg-installer/ffmpeg": "^1.1.0",
     "@livedesk/runtime-core": "0.1.9",
-    "@openai/codex-sdk": "0.145.0",
-    "cors": "^2.8.5",
-    "express": "^4.21.2",
-    "node-datachannel": "0.33.0",
-    "path-to-regexp": "0.1.13",
-    "ws": "^8.18.3"
-  },
-  "engines": {
-    "node": ">=20"
-  },
-  "publishConfig": {
-    "access": "public"
-  }
-}
+    "@openai/codex-sdk": "0.145.0",
+    "cors": "^2.8.5",
+    "express": "^4.21.2",
+    "node-datachannel": "0.33.0",
+    "path-to-regexp": "0.1.13",
+    "ws": "^8.18.3"
+  },
+  "engines": {
+    "node": ">=20"
+  },
+  "publishConfig": {
+    "access": "public"
+  }
+}

package/src/console-direct.js

@@ -739,7 +739,10 @@ export function createHubConsoleDirect(options = {}) {
         // Node Buffer shape. Share the exact encoded bytes without copying or
         // retaining a second application queue.
         const nativeChunk = Buffer.from(chunk.buffer, chunk.byteOffset, chunk.byteLength);
-        if (channelState.channel.sendMessageBinary(nativeChunk) !== true) throw new Error('send-rejected');
+        // libdatachannel returns false when it accepted the chunk into its
+        // bounded send buffer. Only an exception means this send failed.
+        // Retrying duplicates a fragment; closing here truncates the frame.
+        channelState.channel.sendMessageBinary(nativeChunk);
       } catch (error) {
         dataChannelSendFailures += 1;
         lastDataChannelSendFailure = Object.freeze({

package/src/console-direct.test.mjs

@@ -293,6 +293,64 @@ function offer(signal, connectionId = CONNECTION_ONE, sdp = 'v=0\r\na=fake-offer
   return FakePeerConnection.instances.at(-1);
 }
 
+test('native buffered sends complete each media message without closing input or control', async () => {
+  const { direct, signal } = await connectedDirect();
+  try {
+    const peer = offer(signal);
+    const control = new FakeDataChannel('livedesk-control-v1');
+    const nativeSend = FakeDataChannel.prototype.sendMessageBinary;
+    const acceptBuffered = function (value) {
+      nativeSend.call(this, value);
+      this.buffered += value.byteLength;
+      return false; // libdatachannel accepted and buffered this exact chunk.
+    };
+    control.sendMessageBinary = acceptBuffered;
+    peer.emitDataChannel(control);
+    control.open();
+    assert.equal(peer.closed, false, 'buffered direct-ready is not a send failure');
+    assert.equal(JSON.parse(decodeWireMessages(control.sent)[0].data).type, 'direct-ready');
+    const input = new FakeDataChannel(`livedesk-ws-v1:${CHANNEL_ID_TWO}:input`);
+    peer.emitDataChannel(input);
+    input.open();
+    const lane = new FakeDataChannel(`livedesk-ws-v1:${CHANNEL_ID}:frame`);
+    lane.sendMessageBinary = acceptBuffered;
+    peer.emitDataChannel(lane);
+    lane.open();
+    sendWire(control, {
+      type: 'ws-open', connectionId: CONNECTION_ONE, hubEpoch: HUB_EPOCH,
+      channelId: CHANNEL_ID, purpose: 'frame', path: '/api/remote/frames/ws'
+    });
+    const local = FakeLocalSocket.instances[0];
+    local.open();
+    for (let frame = 0; frame < 30; frame += 1) {
+      lane.buffered = 0;
+      local.receive(Buffer.alloc(74 * 1024, frame), true);
+      assert.equal(lane.closed, false, `transient congestion must preserve frame ${frame}`);
+    }
+    const received = decodeWireMessages(lane.sent);
+    assert.equal(received.length, 30);
+    for (let frame = 0; frame < 30; frame += 1) {
+      assert.deepEqual(Buffer.from(received[frame].data), Buffer.alloc(74 * 1024, frame));
+    }
+    assert.equal(local.readyState, FakeSocket.OPEN);
+    assert.equal(input.closed, false);
+    assert.equal(control.closed, false);
+    assert.equal(peer.closed, false);
+    assert.equal(direct.inspect().dataChannelSendFailures, 0);
+    assert.equal(direct.inspect().dataChannelBackpressureCloses, 0);
+    lane.sendMessageBinary = () => { throw new Error('native-send-failed'); };
+    local.receive(Buffer.alloc(10), true);
+    assert.equal(lane.closed, true, 'an actual native exception still retires the exact lane');
+    assert.equal(control.closed, false);
+    assert.equal(input.closed, false);
+    assert.equal(direct.inspect().dataChannelSendFailures, 1);
+  } finally {
+    direct.close();
+    assert.equal(direct.inspect().resourceTimers, 0);
+    assert.equal(direct.inspect().retainedAssemblyBytes, 0);
+  }
+});
+
 test('STUN-only peer answers and rejects stale owner callbacks after replacement', async () => {
   const { direct, signal } = await connectedDirect();
   const firstPeer = offer(signal, CONNECTION_ONE);
@@ -1449,7 +1507,7 @@ test('server session refresh preserves peers while logout uses the revoking clos
   assert.doesNotMatch(logoutBlock, /hubConsoleDirect\?\.refresh\(\)/);
 });
 
-test('native node-datachannel peers carry the fragmented control wire over loopback', { timeout: 8_000 }, async () => {
+test('native node-datachannel buffered sends deliver the complete fragmented wire over loopback', { timeout: 8_000 }, async t => {
   let offerer = null;
   let answerer = null;
   let offerChannel = null;
@@ -1458,6 +1516,7 @@ test('native node-datachannel peers carry the fragmented control wire over loopb
   let openTimer = null;
   let messageTimer = null;
   try {
+    nodeDataChannel.setSctpSettings({ sendBufferSize: 64 * 1024 });
     offerer = new nodeDataChannel.PeerConnection('console-direct-native-offerer', { iceServers: [] });
     answerer = new nodeDataChannel.PeerConnection('console-direct-native-answerer', { iceServers: [] });
     offerer.onLocalDescription((sdp, type) => {
@@ -1494,17 +1553,23 @@ test('native node-datachannel peers carry the fragmented control wire over loopb
     clearTimeout(openTimer);
     openTimer = null;
     const payload = JSON.stringify({ type: 'direct-ready', connectionId: CONNECTION_ONE, hubEpoch: HUB_EPOCH });
-    const chunks = encodeDirectConsoleWireMessage(payload.repeat(400), {
+    const expected = payload.repeat(20_000);
+    const chunks = encodeDirectConsoleWireMessage(expected, {
       messageId: 77,
       kind: 'control'
     });
     assert.ok(chunks.length > 1);
-    for (const chunk of chunks) assert.equal(offerChannel.sendMessageBinary(Buffer.from(chunk)), true);
+    let bufferedSends = 0;
+    for (const chunk of chunks) {
+      if (offerChannel.sendMessageBinary(Buffer.from(chunk)) === false) bufferedSends += 1;
+    }
+    assert.ok(bufferedSends > 0, 'the native congestion path must actually be exercised');
     const message = await received;
     clearTimeout(messageTimer);
     messageTimer = null;
     assert.equal(message.kind, 'control');
-    assert.equal(message.data, payload.repeat(400));
+    assert.equal(message.data, expected);
+    t.diagnostic(`native buffered sends=${bufferedSends}; complete bytes=${message.byteLength}; chunks=${chunks.length}`);
   } finally {
     if (openTimer) clearTimeout(openTimer);
     if (messageTimer) clearTimeout(messageTimer);
@@ -1515,5 +1580,6 @@ test('native node-datachannel peers carry the fragmented control wire over loopb
     try { answerer?.close(); } catch {}
     await new Promise(resolve => setTimeout(resolve, 100));
     nodeDataChannel.cleanup();
+    nodeDataChannel.setSctpSettings({});
   }
 });