@livedesk/hub 0.1.46 → 0.1.47

package/src/live-desk-update.js

@@ -241,11 +241,11 @@ function resetReconnectCandidate(target) {
   target.stabilityDeadlineAt = '';
 }
 
-export function createLiveDeskUpdateManager({
-  remoteHub,
-  currentManagerVersion,
-  currentClientVersion,
-  excludedDeviceIds = [],
+export function createLiveDeskUpdateManager({
+  remoteHub,
+  currentManagerVersion,
+  currentClientVersion,
+  excludedDeviceIds = [],
   restartSupported = false,
   requestHubRestart,
   fetchImpl = globalThis.fetch,
@@ -261,16 +261,16 @@ export function createLiveDeskUpdateManager({
   let checkPromise = null;
   let run = null;
   let checkTimer = null;
-  let runTimer = null;
-  const excludedDeviceIdSet = new Set(
-    (Array.isArray(excludedDeviceIds) ? excludedDeviceIds : [excludedDeviceIds])
-      .map(value => String(value || '').trim())
-      .filter(Boolean)
-  );
-  const connectedClientDevices = () => connectedDevices(remoteHub)
-    .filter(device => !excludedDeviceIdSet.has(String(device?.deviceId || '')));
-  const knownOfflineClientDevices = () => knownOfflineDevices(remoteHub)
-    .filter(device => !excludedDeviceIdSet.has(String(device?.deviceId || '')));
+  let runTimer = null;
+  const excludedDeviceIdSet = new Set(
+    (Array.isArray(excludedDeviceIds) ? excludedDeviceIds : [excludedDeviceIds])
+      .map(value => String(value || '').trim())
+      .filter(Boolean)
+  );
+  const connectedClientDevices = () => connectedDevices(remoteHub)
+    .filter(device => !excludedDeviceIdSet.has(String(device?.deviceId || '')));
+  const knownOfflineClientDevices = () => knownOfflineDevices(remoteHub)
+    .filter(device => !excludedDeviceIdSet.has(String(device?.deviceId || '')));
   const effectiveClientBatchSize = Math.max(
     1,
     Math.min(50, Math.floor(Number(clientBatchSize) || LIVE_DESK_UPDATE_CLIENT_BATCH_SIZE))
@@ -321,7 +321,7 @@ export function createLiveDeskUpdateManager({
   const getStatus = () => {
     const managerUpdateAvailable = !!latestRelease
       && compareVersions(latestRelease.latestManagerVersion, currentManagerVersion) > 0;
-    const clientDevices = connectedClientDevices();
+    const clientDevices = connectedClientDevices();
     const outdatedClientDevices = latestRelease
       ? clientDevices.filter(device => deviceNeedsUpdate(
         device,
@@ -330,7 +330,7 @@ export function createLiveDeskUpdateManager({
       ))
       : [];
     const pendingOfflineClientCount = latestRelease
-      ? knownOfflineClientDevices().filter(device => deviceNeedsUpdate(
+      ? knownOfflineClientDevices().filter(device => deviceNeedsUpdate(
         device,
         latestRelease.latestManagerVersion,
         latestRelease.latestClientVersion
@@ -414,9 +414,9 @@ export function createLiveDeskUpdateManager({
     if (!run || run.state !== 'failed') return [];
     const currentTime = now();
     const devices = new Map(
-      remoteHub.listDevices({ includeDataUrl: false })
-        .filter(device => !excludedDeviceIdSet.has(String(device?.deviceId || '')))
-        .map(device => [String(device.deviceId), device])
+      remoteHub.listDevices({ includeDataUrl: false })
+        .filter(device => !excludedDeviceIdSet.has(String(device?.deviceId || '')))
+        .map(device => [String(device.deviceId), device])
     );
     return run.targets.filter(target => {
       if (target.state !== 'failed' || !target.dispatchedAt) return false;
@@ -523,7 +523,7 @@ export function createLiveDeskUpdateManager({
     const activeCount = run.targets.filter(target => target.state === 'waiting').length;
     let availableSlots = Math.max(0, run.batchSize - activeCount);
     if (availableSlots <= 0) return true;
-    const devices = new Map(connectedClientDevices().map(device => [String(device.deviceId), device]));
+    const devices = new Map(connectedClientDevices().map(device => [String(device.deviceId), device]));
     for (const target of run.targets) {
       if (availableSlots <= 0) break;
       if (!['queued', 'pending-offline'].includes(target.state)) continue;
@@ -562,7 +562,7 @@ export function createLiveDeskUpdateManager({
       failRun(`Timed out waiting for ${unfinishedCount} client(s) to finish the rollout.`);
       return;
     }
-    const devices = new Map(connectedClientDevices().map(device => [String(device.deviceId), device]));
+    const devices = new Map(connectedClientDevices().map(device => [String(device.deviceId), device]));
     for (const target of run.targets) {
       if (target.state === 'failed' || target.state === 'completed') continue;
       const device = devices.get(target.deviceId);
@@ -689,7 +689,7 @@ export function createLiveDeskUpdateManager({
     if (!release) return { ok: false, error: checkError || 'LiveDesk update check failed.', ...getStatus() };
     const managerNeedsUpdate = compareVersions(release.latestManagerVersion, currentManagerVersion) > 0;
     const clientPackageNeedsUpdate = compareVersions(release.latestClientVersion, currentClientVersion) > 0;
-    const connected = connectedClientDevices();
+    const connected = connectedClientDevices();
     const outdatedClients = connected.filter(device => deviceNeedsUpdate(
       device,
       release.latestManagerVersion,
@@ -790,7 +790,7 @@ export function createLiveDeskUpdateManager({
       if (target.method === 'dedicated'
         && target.bootstrapRetryCount === 0
         && isDedicatedBootstrapFailure(failure)) {
-        const retryDevice = connectedClientDevices()
+        const retryDevice = connectedClientDevices()
           .find(device => String(device.deviceId || '') === target.deviceId);
         const remainingMs = Date.parse(target.deadlineAt || '') - now();
         if (retryDevice?.connected === true && remainingMs >= 10_000) {

package/src/remote-hub.js

@@ -1164,10 +1164,12 @@ function normalizeRemoteKeyboardKey(value) {
     return raw === ' ' ? ' ' : safeString(raw, 80);
 }
 
-function normalizeRemoteKeyboardText(value) {
-    const raw = String(value ?? '').replace(/\0/g, '');
-    return raw === ' ' ? ' ' : safeText(raw, 256);
-}
+function normalizeRemoteKeyboardText(value) {
+    const raw = String(value ?? '').replace(/\0/g, '');
+    // Remote text is input data, not a label. Preserve leading/trailing spaces
+    // and IME whitespace while keeping every ordered message bounded.
+    return raw.slice(0, 256);
+}
 
 function safeTaskData(value) {
     if (value === undefined || value === null) return undefined;

package/src/server.js

@@ -7,9 +7,9 @@ import { chmodSync, existsSync, mkdirSync, readFileSync, renameSync, rmSync, wri
 import { dirname, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import os from 'node:os';
-import { WebSocketServer } from 'ws';
-import { createRemoteHub } from './remote-hub.js';
-import { createHubConsoleRelay } from './console-relay.js';
+import { WebSocketServer } from 'ws';
+import { createRemoteHub } from './remote-hub.js';
+import { createHubConsoleRelay } from './console-relay.js';
 import {
   buildImmutableRemoteFramePacket,
   createRemoteFramePacketMetrics,
@@ -40,9 +40,9 @@ import { createAgentDeviceScope, resolveAgentTargetIds } from './agents/agent-de
 import { AgentRuntimeError } from './agents/agent-runtime-error.js';
 import { AGENT_PERMISSION_MODES, createAgentPermissionPolicy, evaluateAgentToolPermission, hashAgentPermissionPolicy } from './agents/agent-permissions.js';
 import { createAgentPermissionStore } from './agents/agent-permission-store.js';
-import { createAgentAuditStore } from './agents/agent-audit-store.js';
-import { getAgentToolDefinition } from './agents/agent-tool-registry.js';
-import { enrichAgentTaskResults } from './agents/agent-result-enrichment.js';
+import { createAgentAuditStore } from './agents/agent-audit-store.js';
+import { getAgentToolDefinition } from './agents/agent-tool-registry.js';
+import { enrichAgentTaskResults } from './agents/agent-result-enrichment.js';
 import { LiveDeskSettingsStore, SettingsConflictError } from './settings/settings-store.js';
 import { effectiveDevicePolicy } from './settings/settings-schema.js';
 import { buildEffectiveDevicePolicy } from './settings/effective-device-policy.js';
@@ -204,22 +204,22 @@ let verifiedLicense = {
 let frameClientSeq = 0;
 let inputClientSeq = 0;
 let audioClientSeq = 0;
-let liveDeskUpdateManager = null;
-let hubTransferJobs = null;
-let hubConsoleRelay = null;
+let liveDeskUpdateManager = null;
+let hubTransferJobs = null;
+let hubConsoleRelay = null;
 const HUB_HOST_TARGET_LEASE_MS = Math.max(5000, readPositiveIntegerEnv('LIVEDESK_HOST_TARGET_LEASE_MS', 60_000));
 const HUB_HOST_TARGET_RENEW_MS = Math.max(1000, Math.min(
   readPositiveIntegerEnv('LIVEDESK_HOST_TARGET_RENEW_MS', 20_000),
   Math.max(1000, HUB_HOST_TARGET_LEASE_MS - 1000)
 ));
-const HUB_ACCESS_TOKEN_REFRESH_SKEW_MS = 90_000;
-const hubWakeBaseUrl = String(process.env.LIVEDESK_WAKE_URL || 'https://livedesk-wake.lovecrdm.workers.dev').trim();
-const hubConsoleRelayBaseUrl = String(
-  process.env.LIVEDESK_CONSOLE_RELAY_URL
-  || (process.env.LIVEDESK_TEST_MODE === '1' || process.env.LIVEDESK_AUTH_TEST_MODE === '1'
-    ? 'off'
-    : 'https://livedesk-wake.lovecrdm.workers.dev')
-).trim();
+const HUB_ACCESS_TOKEN_REFRESH_SKEW_MS = 90_000;
+const hubWakeBaseUrl = String(process.env.LIVEDESK_WAKE_URL || 'https://livedesk-wake.lovecrdm.workers.dev').trim();
+const hubConsoleRelayBaseUrl = String(
+  process.env.LIVEDESK_CONSOLE_RELAY_URL
+  || (process.env.LIVEDESK_TEST_MODE === '1' || process.env.LIVEDESK_AUTH_TEST_MODE === '1'
+    ? 'off'
+    : 'https://livedesk-wake.lovecrdm.workers.dev')
+).trim();
 const HUB_WAKE_NOTIFY_RETRY_MS = 60_000;
 let hubHostTargetRenewTimer = null;
 let hubHostTargetRenewInFlight = false;
@@ -513,19 +513,19 @@ async function getRuntimeAccessToken() {
   const accessToken = String(runtimeAccessToken || '').trim();
   const expiresSoon = runtimeAccessTokenExpiresAt > 0
     && runtimeAccessTokenExpiresAt <= Date.now() + HUB_ACCESS_TOKEN_REFRESH_SKEW_MS;
-  if (accessToken && !expiresSoon) {
-    return accessToken;
-  }
-
-  // The packaged Electron main process owns the encrypted refresh token and
-  // proactively sends each rotation to this child runtime. A second refresh
-  // owner here could consume the one-time token first and make the desktop
-  // shell appear signed out after sleep.
-  if (desktopMainAuthConfig) {
-    return accessToken;
-  }
-
-  const refreshToken = String(runtimeRefreshToken || '').trim();
+  if (accessToken && !expiresSoon) {
+    return accessToken;
+  }
+
+  // The packaged Electron main process owns the encrypted refresh token and
+  // proactively sends each rotation to this child runtime. A second refresh
+  // owner here could consume the one-time token first and make the desktop
+  // shell appear signed out after sleep.
+  if (desktopMainAuthConfig) {
+    return accessToken;
+  }
+
+  const refreshToken = String(runtimeRefreshToken || '').trim();
   if (!refreshToken) {
     return accessToken;
   }
@@ -629,9 +629,9 @@ async function queryAuthoritativeRuntimeRole() {
     },
     SUPABASE_AUTH_TIMEOUT_MS
   );
-  if (response.status === 401 || response.status === 403) {
-    if (!desktopMainAuthConfig) clearRuntimeSession();
-    throw new Error(`hub-role-query-not-authenticated:${response.status}`);
+  if (response.status === 401 || response.status === 403) {
+    if (!desktopMainAuthConfig) clearRuntimeSession();
+    throw new Error(`hub-role-query-not-authenticated:${response.status}`);
   }
   if (!response.ok) {
     throw new Error(`hub-role-query-failed:${response.status}`);
@@ -813,12 +813,12 @@ function getLiveDeskUpdateStatus() {
 }
 
 if (process.env.LIVEDESK_DESKTOP_HOST !== '1') {
-  liveDeskUpdateManager = createLiveDeskUpdateManager({
-    remoteHub,
-    currentManagerVersion: process.env.LIVEDESK_MANAGER_VERSION || packageInfo.version,
-    currentClientVersion: process.env.LIVEDESK_CLIENT_PACKAGE_VERSION || '',
-    excludedDeviceIds: [runtimeDeviceId],
-    restartSupported: !!String(process.env.LIVEDESK_HUB_UPDATE_REQUEST_PATH || '').trim(),
+  liveDeskUpdateManager = createLiveDeskUpdateManager({
+    remoteHub,
+    currentManagerVersion: process.env.LIVEDESK_MANAGER_VERSION || packageInfo.version,
+    currentClientVersion: process.env.LIVEDESK_CLIENT_PACKAGE_VERSION || '',
+    excludedDeviceIds: [runtimeDeviceId],
+    restartSupported: !!String(process.env.LIVEDESK_HUB_UPDATE_REQUEST_PATH || '').trim(),
     requestHubRestart
   });
 }
@@ -1278,16 +1278,16 @@ async function dispatchAgentMcpTool(session, name, args = {}) {
       remoteHub.cancelTaskBatch(result.batchId);
       return { ok: false, error: 'cancelled-by-user', batchId: result.batchId };
     }
-    const batch = remoteHub.getTaskBatch(result.batchId);
-    if (!batch) return { ok: false, error: 'task-not-found', batchId: result.batchId };
-    if (!['queued', 'running'].includes(batch.status)) {
-      const taskResults = enrichAgentTaskResults({
-        operation,
-        results: batch.results,
-        devices: remoteHub.listDevices({ includeDataUrl: false })
-          .filter(device => targetIds.includes(device.deviceId))
-      });
-      return {
+    const batch = remoteHub.getTaskBatch(result.batchId);
+    if (!batch) return { ok: false, error: 'task-not-found', batchId: result.batchId };
+    if (!['queued', 'running'].includes(batch.status)) {
+      const taskResults = enrichAgentTaskResults({
+        operation,
+        results: batch.results,
+        devices: remoteHub.listDevices({ includeDataUrl: false })
+          .filter(device => targetIds.includes(device.deviceId))
+      });
+      return {
         ok: true,
         batchId: result.batchId,
         operation,
@@ -1295,8 +1295,8 @@ async function dispatchAgentMcpTool(session, name, args = {}) {
         total: batch.total,
         completed: batch.completed,
         failed: batch.failed,
-        results: taskResults.map(item => ({ deviceId: item.deviceId, deviceName: item.deviceName, status: item.status, stage: item.stage, result: String(item.result || '').slice(0, 3000), data: item.data, error: String(item.error || '').slice(0, 500) }))
-      };
+        results: taskResults.map(item => ({ deviceId: item.deviceId, deviceName: item.deviceName, status: item.status, stage: item.stage, result: String(item.result || '').slice(0, 3000), data: item.data, error: String(item.error || '').slice(0, 500) }))
+      };
     }
     await delayAgentMcp(200);
   }
@@ -1356,16 +1356,16 @@ const hubSharedFolders = createHubSharedFolders({
   dataDir: agentDataDir
 });
 
-const app = express();
-const httpServer = createServer(app);
-hubConsoleRelay = createHubConsoleRelay({
-  url: runtimeRole === 'hub' ? hubConsoleRelayBaseUrl : 'off',
-  deviceId: runtimeDeviceId,
-  httpBaseUrl: `http://127.0.0.1:${httpPort}`,
-  getAccessToken: () => getRuntimeAccessToken(),
-  logger: console
-});
-const httpConnections = new Set();
+const app = express();
+const httpServer = createServer(app);
+hubConsoleRelay = createHubConsoleRelay({
+  url: runtimeRole === 'hub' ? hubConsoleRelayBaseUrl : 'off',
+  deviceId: runtimeDeviceId,
+  httpBaseUrl: `http://127.0.0.1:${httpPort}`,
+  getAccessToken: () => getRuntimeAccessToken(),
+  logger: console
+});
+const httpConnections = new Set();
 const frameWss = new WebSocketServer({ noServer: true, perMessageDeflate: false });
 const atlasWss = new WebSocketServer({ noServer: true, perMessageDeflate: false });
 const inputWss = new WebSocketServer({ noServer: true, perMessageDeflate: false });
@@ -4249,10 +4249,10 @@ app.get('/api/remote/status', (_req, res) => {
     runtimeRole,
     deviceId: runtimeDeviceId,
     deviceName: runtimeDeviceName,
-    roleSource: runtimeRoleSource,
-    agentPackage: '@livedesk/client',
-    consoleRelay: hubConsoleRelay?.inspect() || { enabled: false, state: 'starting' },
-    frameLanes: snapshotFrameLaneResourceHealth(),
+    roleSource: runtimeRoleSource,
+    agentPackage: '@livedesk/client',
+    consoleRelay: hubConsoleRelay?.inspect() || { enabled: false, state: 'starting' },
+    frameLanes: snapshotFrameLaneResourceHealth(),
     update: getLiveDeskUpdateStatus()
   });
 });
@@ -4484,11 +4484,11 @@ app.post('/api/auth/session', async (req, res) => {
         csrfToken: uiSession.csrfToken,
         expiresAt: uiSession.expiresAt
       }
-    });
-    if (runtimeRole === 'hub') {
-      hubConsoleRelay?.refresh();
-      scheduleAuthenticatedHubHostTargetPublication('session-received');
-    }
+    });
+    if (runtimeRole === 'hub') {
+      hubConsoleRelay?.refresh();
+      scheduleAuthenticatedHubHostTargetPublication('session-received');
+    }
   } catch (error) {
     const message = error instanceof Error ? error.message : String(error);
     const status = authVerificationHttpStatus(message);
@@ -4508,11 +4508,11 @@ function getHubHostTargetLeaseStatus() {
     ...hubHostTargetLeaseState,
     renewing: hubHostTargetRenewInFlight,
     renewalIntervalMs: HUB_HOST_TARGET_RENEW_MS,
-    leaseDurationMs: HUB_HOST_TARGET_LEASE_MS,
-    authenticated: Boolean(runtimeAccessToken),
-    timerActive: Boolean(hubHostTargetRenewTimer),
-    wake: { ...hubWakeNotificationState },
-    consoleRelay: hubConsoleRelay?.inspect() || { enabled: false, state: 'starting' }
+    leaseDurationMs: HUB_HOST_TARGET_LEASE_MS,
+    authenticated: Boolean(runtimeAccessToken),
+    timerActive: Boolean(hubHostTargetRenewTimer),
+    wake: { ...hubWakeNotificationState },
+    consoleRelay: hubConsoleRelay?.inspect() || { enabled: false, state: 'starting' }
   };
 }
 
@@ -4609,9 +4609,9 @@ async function callHubSupabaseRpc(name, payload, accessToken) {
   );
   const data = await response.json().catch(() => null);
   const result = Array.isArray(data) ? data[0] : data;
-  if (response.status === 401 || response.status === 403) {
-    if (!desktopMainAuthConfig) clearRuntimeSession();
-    throw new Error(`${name}-not-authenticated:${response.status}`);
+  if (response.status === 401 || response.status === 403) {
+    if (!desktopMainAuthConfig) clearRuntimeSession();
+    throw new Error(`${name}-not-authenticated:${response.status}`);
   }
   if (!response.ok) {
     throw new Error(`${name}-failed:${response.status}`);
@@ -4816,11 +4816,11 @@ app.get('/api/hub/status', (_req, res) => {
     ...remoteHub.getStatus({ includeSecrets: false }),
     role: 'hub',
     deviceId: runtimeDeviceId,
-    deviceName: runtimeDeviceName,
-    roleSource: runtimeRoleSource,
-    runtimeStarted: true,
-    consoleRelay: hubConsoleRelay?.inspect() || { enabled: false, state: 'starting' },
-    hostTargetLease: getHubHostTargetLeaseStatus(),
+    deviceName: runtimeDeviceName,
+    roleSource: runtimeRoleSource,
+    runtimeStarted: true,
+    consoleRelay: hubConsoleRelay?.inspect() || { enabled: false, state: 'starting' },
+    hostTargetLease: getHubHostTargetLeaseStatus(),
     update: getLiveDeskUpdateStatus()
   });
 });
@@ -5827,14 +5827,14 @@ hubSharedFolders.startAutoSync(
   () => remoteHub.listDevices({ includeDataUrl: false }).filter(device => device.connected).map(device => device.deviceId),
   () => process.env.LIVEDESK_REMOTE_DIRECTORY || 'Desktop/LiveDeskFiles'
 );
-httpServer.listen(httpPort, httpHost, () => {
+httpServer.listen(httpPort, httpHost, () => {
   const status = remoteHub.getStatus({ includeSecrets: true });
   const managerVersion = String(process.env.LIVEDESK_MANAGER_VERSION || packageInfo.version || 'dev');
   console.log(`[LiveDesk Hub] Version ${managerVersion}`);
-  console.log(`[LiveDesk Hub] HTTP API http://${httpHost}:${httpPort}`);
-  console.log(`[LiveDesk Hub] Client endpoint ${status.agentEndpoint} pair=${status.pairTokenPreview}`);
-  hubConsoleRelay?.start();
-});
+  console.log(`[LiveDesk Hub] HTTP API http://${httpHost}:${httpPort}`);
+  console.log(`[LiveDesk Hub] Client endpoint ${status.agentEndpoint} pair=${status.pairTokenPreview}`);
+  hubConsoleRelay?.start();
+});
 
 const roleWatchTimer = runtimeRole === 'hub'
   ? setInterval(() => { void watchAuthoritativeRuntimeRole(); }, 5000)
@@ -5915,10 +5915,10 @@ function shutdownHub(signal) {
     const startedAt = Date.now();
     console.log(`[LiveDesk Hub] Shutdown started signal=${signal} grace=${hubShutdownGraceMs}ms timeout=${hubShutdownTimeoutMs}ms.`);
     if (roleWatchTimer) clearInterval(roleWatchTimer);
-    clearInterval(browserWebSocketHeartbeatTimer);
-    runSynchronousShutdownStep('update manager close', () => liveDeskUpdateManager?.close());
-    runSynchronousShutdownStep('mobile console relay close', () => hubConsoleRelay?.close());
-    atlasClients.clear();
+    clearInterval(browserWebSocketHeartbeatTimer);
+    runSynchronousShutdownStep('update manager close', () => liveDeskUpdateManager?.close());
+    runSynchronousShutdownStep('mobile console relay close', () => hubConsoleRelay?.close());
+    atlasClients.clear();
     runSynchronousShutdownStep('shared folder close', () => hubSharedFolders.close());
 
     const httpClosed = new Promise(resolveClose => {

package/src/settings/settings-schema.js

@@ -13,7 +13,8 @@ export const DEFAULT_LIVEDESK_SETTINGS = Object.freeze({
     approveNewDevices: true,
     startWithComputer: true,
     keepRunningInTray: true,
-    showConnectionNotifications: true
+    showConnectionNotifications: true,
+    showThisComputer: false
   },
   security: {
     accessMode: 'trusted-only',
@@ -157,7 +158,7 @@ const numbers = (entries) => Object.fromEntries(entries.map(([key, min, max]) =>
 
 const RULES = {
   connection: {
-    ...bools(['usePinToAddDevices', 'rotatePinAfterPairing', 'allowNewDevices', 'approveNewDevices', 'startWithComputer', 'keepRunningInTray', 'showConnectionNotifications']),
+    ...bools(['usePinToAddDevices', 'rotatePinAfterPairing', 'allowNewDevices', 'approveNewDevices', 'startWithComputer', 'keepRunningInTray', 'showConnectionNotifications', 'showThisComputer']),
     ...numbers([['pinValidityMinutes', 10, 1440]])
   },
   security: {