@livedesk/hub 0.1.36 → 0.1.38

package/src/filesystem/transfer-jobs.js

@@ -1,345 +1,314 @@
-import crypto from 'node:crypto';
-import fs from 'node:fs';
-import { setImmediate as yieldToEventLoop } from 'node:timers/promises';
-
-const CHUNK_BYTES = 512 * 1024;
-const JOB_RETENTION_MS = 10 * 60 * 1000;
-const COMMAND_RESULT_TIMEOUT_MS = 30 * 1000;
-
-function snapshot(job) {
-  return {
-    jobId: job.jobId,
-    state: job.state,
-    totalFiles: job.totalFiles,
-    completedFiles: job.completedFiles,
-    totalBytes: job.totalBytes,
-    sentBytes: job.sentBytes,
-    currentPath: job.currentPath || '',
-    targetCount: job.deviceIds.length,
-    failedTargets: [...job.failedTargets].map(deviceId => ({ deviceId, error: job.targetErrors.get(deviceId) || 'transfer-failed' })),
-    error: job.error || null,
-    createdAt: job.createdAt,
-    updatedAt: job.updatedAt,
-    completedAt: job.completedAt || null
-  };
-}
-
-function markUpdated(job) {
-  job.updatedAt = new Date().toISOString();
-}
-
-export class HubTransferJobs {
-  constructor({ filesystem, remoteHub, maxConcurrent = 2, commandResultTimeoutMs = COMMAND_RESULT_TIMEOUT_MS, getMaxFileSizeBytes = () => Number.MAX_SAFE_INTEGER } = {}) {
-    this.filesystem = filesystem;
-    this.remoteHub = remoteHub;
-    this.maxConcurrent = Math.max(1, Number(maxConcurrent) || 2);
-    this.commandResultTimeoutMs = Math.max(1_000, Number(commandResultTimeoutMs) || COMMAND_RESULT_TIMEOUT_MS);
-    this.getMaxFileSizeBytes = typeof getMaxFileSizeBytes === 'function'
-      ? getMaxFileSizeBytes
-      : () => Number.MAX_SAFE_INTEGER;
-    this.jobs = new Map();
-    this.queue = [];
-    this.running = 0;
-    this.pendingCommands = new Map();
-  }
-
-  create({ itemIds = [], deviceIds = [], remoteDirectory = '', files = null, onComplete = null } = {}) {
-    const targets = [...new Set((Array.isArray(deviceIds) ? deviceIds : []).map(value => String(value || '').trim()).filter(Boolean))].slice(0, 240);
-    if (targets.length === 0) throw new Error('no-target-devices');
-    const job = {
-      jobId: `job_${crypto.randomBytes(14).toString('base64url')}`,
-      state: 'queued',
-      itemIds: [...new Set((Array.isArray(itemIds) ? itemIds : []).map(value => String(value || '').trim()).filter(Boolean))],
-      files,
-      deviceIds: targets,
-      remoteDirectory: String(remoteDirectory || '').replace(/[\0\r\n\t]/g, ' ').trim().slice(0, 600),
-      totalFiles: 0,
-      completedFiles: 0,
-      totalBytes: 0,
-      sentBytes: 0,
-      currentPath: '',
-      failedTargets: new Set(),
-      targetErrors: new Map(),
-      error: '',
-      createdAt: new Date().toISOString(),
-      updatedAt: new Date().toISOString(),
-      completedAt: '',
-      cancelled: false,
-      currentStream: null,
-      onComplete
-    };
-    this.jobs.set(job.jobId, job);
-    this.queue.push(job);
-    this.pump();
-    return snapshot(job);
-  }
-
-  get(jobId) {
-    this.prune();
-    const job = this.jobs.get(String(jobId || ''));
-    return job ? snapshot(job) : null;
-  }
-
-  list({ activeOnly = false } = {}) {
-    this.prune();
-    return [...this.jobs.values()]
-      .filter(job => !activeOnly || ['scanning', 'queued', 'sending'].includes(job.state))
-      .sort((left, right) => right.createdAt.localeCompare(left.createdAt))
-      .map(snapshot);
-  }
-
-  cancel(jobId) {
-    const job = this.jobs.get(String(jobId || ''));
-    if (!job) return null;
-    if (['completed', 'partially-failed', 'failed', 'cancelled'].includes(job.state)) return snapshot(job);
-    job.cancelled = true;
-    job.state = 'cancelled';
-    job.error = 'transfer-cancelled';
-    if (job.currentStream) job.currentStream.destroy();
-    this.finishPendingCommands(job.jobId, 'transfer-cancelled');
-    markUpdated(job);
-    return snapshot(job);
-  }
-
-  clear() {
-    let cancelled = 0;
-    for (const job of this.jobs.values()) {
-      if (!['completed', 'partially-failed', 'failed', 'cancelled'].includes(job.state)) {
-        this.cancel(job.jobId);
-        cancelled += 1;
-      }
-    }
-    const removed = this.jobs.size;
-    this.jobs.clear();
-    this.queue = [];
-    this.pendingCommands.clear();
-    return { cancelled, removed };
-  }
-
-  pump() {
-    while (this.running < this.maxConcurrent && this.queue.length > 0) {
-      const job = this.queue.shift();
-      if (!job || job.cancelled) continue;
-      this.running += 1;
-      void this.run(job).finally(() => {
-        this.running -= 1;
-        this.pump();
-      });
-    }
-  }
-
-  async run(job) {
-    try {
-      job.state = 'scanning';
-      markUpdated(job);
-      const scan = job.files
-        ? { files: job.files, totalBytes: job.files.reduce((sum, file) => sum + Number(file.size || 0), 0) }
-        : await this.filesystem.scan(job.itemIds);
-      if (job.cancelled) return;
-      const maxFileSizeBytes = Math.max(1, Number(this.getMaxFileSizeBytes()) || 1);
-      if (scan.files.some(file => Number(file.size || 0) > maxFileSizeBytes)) {
-        throw new Error('file-transfer-file-too-large');
-      }
-      job.totalFiles = scan.files.length;
-      job.totalBytes = scan.totalBytes;
-      job.state = 'sending';
-      markUpdated(job);
-      if (scan.files.length === 0) {
-        job.state = 'completed';
-        job.completedAt = new Date().toISOString();
-        markUpdated(job);
-        await this.finishCallback(job, true);
-        return;
-      }
-
-      for (const file of scan.files) {
-        if (job.cancelled) return;
-        job.currentPath = file.relativePath;
-        markUpdated(job);
-        await this.sendFile(job, file);
-        job.completedFiles += 1;
-        markUpdated(job);
-      }
-
-      if (job.cancelled) return;
-      job.state = job.failedTargets.size === 0 ? 'completed' : 'partially-failed';
-      job.completedAt = new Date().toISOString();
-      job.currentPath = '';
-      if (job.failedTargets.size > 0) job.error = 'one-or-more-targets-failed';
-      markUpdated(job);
-      await this.finishCallback(job, job.state === 'completed');
-    } catch (error) {
-      if (job.cancelled) return;
-      job.state = job.failedTargets.size > 0 ? 'partially-failed' : 'failed';
-      job.error = error instanceof Error ? error.message : String(error);
-      job.completedAt = new Date().toISOString();
-      job.currentPath = '';
-      markUpdated(job);
-      await this.finishCallback(job, false);
-    }
-  }
-
-  async sendFile(job, file) {
-    const activeTargets = () => job.deviceIds.filter(deviceId => !job.failedTargets.has(deviceId));
-    if (Number(file.size || 0) === 0) {
-      const sha256 = crypto.createHash('sha256').update(Buffer.alloc(0)).digest('hex');
-      await this.sendChunk(job, file, 0, Buffer.alloc(0), true, activeTargets(), sha256);
-      return;
-    }
-    const stream = fs.createReadStream(file.absolutePath, { highWaterMark: CHUNK_BYTES });
-    const hasher = crypto.createHash('sha256');
-    job.currentStream = stream;
-    let offset = 0;
-    try {
-      for await (const chunk of stream) {
-        if (job.cancelled) return;
-        const buffer = Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk);
-        const final = offset + buffer.length >= Number(file.size || 0);
-        hasher.update(buffer);
-        const sha256 = final ? hasher.digest('hex') : '';
-        const targets = activeTargets();
-        if (targets.length === 0) throw new Error('all-targets-failed');
-        await this.sendChunk(job, file, offset, buffer, final, targets, sha256);
-        offset += buffer.length;
-        job.sentBytes += buffer.length;
-        markUpdated(job);
-        await yieldToEventLoop();
-      }
-    } finally {
-      job.currentStream = null;
-    }
-  }
-
-  async sendChunk(job, file, offset, buffer, final, targets, sha256 = '') {
-    const outcomes = await Promise.all(targets.map(async deviceId => {
-      if (job.cancelled) return { deviceId, ok: false, error: 'transfer-cancelled' };
-      const commandId = crypto.randomUUID();
-      const pending = this.waitForCommandResult(job.jobId, deviceId, commandId);
-      const result = this.remoteHub.sendCommand(deviceId, {
-        command: 'file.transfer.chunk',
-        commandId,
-        payload: {
-          transferId: job.jobId,
-          remoteDirectory: job.remoteDirectory,
-          name: file.name,
-          relativePath: file.relativePath,
-          offset,
-          totalBytes: Number(file.size || 0),
-          final,
-          sha256,
-          dataBase64: buffer.toString('base64'),
-          lastModified: Number(file.modifiedMs || 0) || 0,
-          requestedAt: new Date().toISOString()
-        }
-      });
-      if (!result?.ok) {
-        this.settlePendingCommand(commandId, {
-          ok: false,
-          error: String(result?.error || 'device-not-connected')
-        });
-      }
-      return { deviceId, ...await pending };
-    }));
-
-    for (const outcome of outcomes) {
-      if (outcome.ok || outcome.error === 'transfer-cancelled') continue;
-      job.failedTargets.add(outcome.deviceId);
-      job.targetErrors.set(outcome.deviceId, outcome.error || 'transfer-failed');
-    }
-    if (!job.cancelled && outcomes.length > 0 && outcomes.every(outcome => !outcome.ok)) {
-      throw new Error('all-targets-failed');
-    }
-  }
-
-  waitForCommandResult(jobId, deviceId, commandId) {
-    return new Promise(resolve => {
-      const timer = setTimeout(() => {
-        this.settlePendingCommand(commandId, {
-          ok: false,
-          error: 'file-transfer-ack-timeout'
-        });
-      }, this.commandResultTimeoutMs);
-      timer.unref?.();
-      this.pendingCommands.set(commandId, {
-        jobId,
-        deviceId,
-        timer,
-        resolve
-      });
-    });
-  }
-
-  settlePendingCommand(commandId, outcome) {
-    const pending = this.pendingCommands.get(String(commandId || ''));
-    if (!pending) return false;
-    this.pendingCommands.delete(commandId);
-    clearTimeout(pending.timer);
-    pending.resolve(outcome);
-    return true;
-  }
-
-  finishPendingCommands(jobId, error) {
-    for (const [commandId, pending] of this.pendingCommands) {
-      if (pending.jobId !== jobId) continue;
-      this.settlePendingCommand(commandId, { ok: false, error });
-    }
-  }
-
-  handleRemoteEvent(type, event) {
-    if (type === 'RemoteCommandResult') {
-      const commandId = String(event?.commandId || '');
-      const pending = this.pendingCommands.get(commandId);
-      if (!pending) return;
-      const eventDeviceId = String(event?.deviceId || event?.device?.deviceId || '');
-      if (eventDeviceId && eventDeviceId !== pending.deviceId) return;
-      const result = event?.result;
-      const error = String(
-        event?.error
-        || (result?.ok === false || result?.status === 'failed' || result?.status === 'rejected'
-          ? result?.error || 'file-transfer-rejected'
-          : '')
-      );
-      this.settlePendingCommand(commandId, error
-        ? { ok: false, error }
-        : { ok: true, result });
-      return;
-    }
-
-    if (type !== 'RemoteDeviceDisconnected') return;
-    const deviceId = String(event?.deviceId || event?.device?.deviceId || '');
-    if (!deviceId) return;
-    for (const [commandId, pending] of this.pendingCommands) {
-      if (pending.deviceId !== deviceId) continue;
-      this.settlePendingCommand(commandId, {
-        ok: false,
-        error: 'device-disconnected'
-      });
-    }
-  }
-
-  async finishCallback(job, completed) {
-    if (typeof job.onComplete !== 'function') return;
-    try {
-      await job.onComplete({ completed, job: snapshot(job) });
-    } catch (error) {
-      // A completion callback can be the durable security-audit gate. Never
-      // leave a job looking successful when that final record was not stored.
-      job.state = 'failed';
-      job.error = `completion-callback-failed:${error instanceof Error ? error.message : String(error)}`;
-      job.completedAt ||= new Date().toISOString();
-      markUpdated(job);
-    }
-  }
-
-  prune() {
-    const threshold = Date.now() - JOB_RETENTION_MS;
-    for (const [id, job] of this.jobs) {
-      const createdAt = Date.parse(job.createdAt);
-      if (job.completedAt && Number.isFinite(createdAt) && createdAt < threshold) this.jobs.delete(id);
-    }
-  }
-}
-
-export function createHubTransferJobs(options) {
-  return new HubTransferJobs(options);
-}
+import crypto from 'node:crypto';
+import fs from 'node:fs';
+import { setImmediate as yieldToEventLoop } from 'node:timers/promises';
+
+const CHUNK_BYTES = 512 * 1024;
+const JOB_RETENTION_MS = 10 * 60 * 1000;
+const COMMAND_RESULT_TIMEOUT_MS = 30 * 1000;
+
+function snapshot(job) {
+  return {
+    jobId: job.jobId,
+    state: job.state,
+    totalFiles: job.totalFiles,
+    completedFiles: job.completedFiles,
+    totalBytes: job.totalBytes,
+    sentBytes: job.sentBytes,
+    currentPath: job.currentPath || '',
+    targetCount: job.deviceIds.length,
+    failedTargets: [...job.failedTargets].map(deviceId => ({ deviceId, error: job.targetErrors.get(deviceId) || 'transfer-failed' })),
+    error: job.error || null,
+    createdAt: job.createdAt,
+    updatedAt: job.updatedAt,
+    completedAt: job.completedAt || null
+  };
+}
+
+function markUpdated(job) {
+  job.updatedAt = new Date().toISOString();
+}
+
+export class HubTransferJobs {
+  constructor({ filesystem, remoteHub, maxConcurrent = 2, commandResultTimeoutMs = COMMAND_RESULT_TIMEOUT_MS } = {}) {
+    this.filesystem = filesystem;
+    this.remoteHub = remoteHub;
+    this.maxConcurrent = Math.max(1, Number(maxConcurrent) || 2);
+    this.commandResultTimeoutMs = Math.max(1_000, Number(commandResultTimeoutMs) || COMMAND_RESULT_TIMEOUT_MS);
+    this.jobs = new Map();
+    this.queue = [];
+    this.running = 0;
+    this.pendingCommands = new Map();
+  }
+
+  create({ itemIds = [], deviceIds = [], remoteDirectory = '', files = null, onComplete = null } = {}) {
+    const targets = [...new Set((Array.isArray(deviceIds) ? deviceIds : []).map(value => String(value || '').trim()).filter(Boolean))].slice(0, 240);
+    if (targets.length === 0) throw new Error('no-target-devices');
+    const job = {
+      jobId: `job_${crypto.randomBytes(14).toString('base64url')}`,
+      state: 'queued',
+      itemIds: [...new Set((Array.isArray(itemIds) ? itemIds : []).map(value => String(value || '').trim()).filter(Boolean))],
+      files,
+      deviceIds: targets,
+      remoteDirectory: String(remoteDirectory || '').replace(/[\0\r\n\t]/g, ' ').trim().slice(0, 600),
+      totalFiles: 0,
+      completedFiles: 0,
+      totalBytes: 0,
+      sentBytes: 0,
+      currentPath: '',
+      failedTargets: new Set(),
+      targetErrors: new Map(),
+      error: '',
+      createdAt: new Date().toISOString(),
+      updatedAt: new Date().toISOString(),
+      completedAt: '',
+      cancelled: false,
+      currentStream: null,
+      onComplete
+    };
+    this.jobs.set(job.jobId, job);
+    this.queue.push(job);
+    this.pump();
+    return snapshot(job);
+  }
+
+  get(jobId) {
+    this.prune();
+    const job = this.jobs.get(String(jobId || ''));
+    return job ? snapshot(job) : null;
+  }
+
+  list({ activeOnly = false } = {}) {
+    this.prune();
+    return [...this.jobs.values()]
+      .filter(job => !activeOnly || ['scanning', 'queued', 'sending'].includes(job.state))
+      .sort((left, right) => right.createdAt.localeCompare(left.createdAt))
+      .map(snapshot);
+  }
+
+  cancel(jobId) {
+    const job = this.jobs.get(String(jobId || ''));
+    if (!job) return null;
+    if (['completed', 'partially-failed', 'failed', 'cancelled'].includes(job.state)) return snapshot(job);
+    job.cancelled = true;
+    job.state = 'cancelled';
+    job.error = 'transfer-cancelled';
+    if (job.currentStream) job.currentStream.destroy();
+    this.finishPendingCommands(job.jobId, 'transfer-cancelled');
+    markUpdated(job);
+    return snapshot(job);
+  }
+
+  pump() {
+    while (this.running < this.maxConcurrent && this.queue.length > 0) {
+      const job = this.queue.shift();
+      if (!job || job.cancelled) continue;
+      this.running += 1;
+      void this.run(job).finally(() => {
+        this.running -= 1;
+        this.pump();
+      });
+    }
+  }
+
+  async run(job) {
+    try {
+      job.state = 'scanning';
+      markUpdated(job);
+      const scan = job.files
+        ? { files: job.files, totalBytes: job.files.reduce((sum, file) => sum + Number(file.size || 0), 0) }
+        : await this.filesystem.scan(job.itemIds);
+      if (job.cancelled) return;
+      job.totalFiles = scan.files.length;
+      job.totalBytes = scan.totalBytes;
+      job.state = 'sending';
+      markUpdated(job);
+      if (scan.files.length === 0) {
+        job.state = 'completed';
+        job.completedAt = new Date().toISOString();
+        markUpdated(job);
+        await this.finishCallback(job, true);
+        return;
+      }
+
+      for (const file of scan.files) {
+        if (job.cancelled) return;
+        job.currentPath = file.relativePath;
+        markUpdated(job);
+        await this.sendFile(job, file);
+        job.completedFiles += 1;
+        markUpdated(job);
+      }
+
+      if (job.cancelled) return;
+      job.state = job.failedTargets.size === 0 ? 'completed' : 'partially-failed';
+      job.completedAt = new Date().toISOString();
+      job.currentPath = '';
+      if (job.failedTargets.size > 0) job.error = 'one-or-more-targets-failed';
+      markUpdated(job);
+      await this.finishCallback(job, job.state === 'completed');
+    } catch (error) {
+      if (job.cancelled) return;
+      job.state = job.failedTargets.size > 0 ? 'partially-failed' : 'failed';
+      job.error = error instanceof Error ? error.message : String(error);
+      job.completedAt = new Date().toISOString();
+      job.currentPath = '';
+      markUpdated(job);
+      await this.finishCallback(job, false);
+    }
+  }
+
+  async sendFile(job, file) {
+    const activeTargets = () => job.deviceIds.filter(deviceId => !job.failedTargets.has(deviceId));
+    if (Number(file.size || 0) === 0) {
+      await this.sendChunk(job, file, 0, Buffer.alloc(0), true, activeTargets());
+      return;
+    }
+    const stream = fs.createReadStream(file.absolutePath, { highWaterMark: CHUNK_BYTES });
+    job.currentStream = stream;
+    let offset = 0;
+    try {
+      for await (const chunk of stream) {
+        if (job.cancelled) return;
+        const buffer = Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk);
+        const final = offset + buffer.length >= Number(file.size || 0);
+        const targets = activeTargets();
+        if (targets.length === 0) throw new Error('all-targets-failed');
+        await this.sendChunk(job, file, offset, buffer, final, targets);
+        offset += buffer.length;
+        job.sentBytes += buffer.length;
+        markUpdated(job);
+        await yieldToEventLoop();
+      }
+    } finally {
+      job.currentStream = null;
+    }
+  }
+
+  async sendChunk(job, file, offset, buffer, final, targets) {
+    const outcomes = await Promise.all(targets.map(async deviceId => {
+      if (job.cancelled) return { deviceId, ok: false, error: 'transfer-cancelled' };
+      const commandId = crypto.randomUUID();
+      const pending = this.waitForCommandResult(job.jobId, deviceId, commandId);
+      const result = this.remoteHub.sendCommand(deviceId, {
+        command: 'file.transfer.chunk',
+        commandId,
+        payload: {
+          transferId: job.jobId,
+          remoteDirectory: job.remoteDirectory,
+          name: file.name,
+          relativePath: file.relativePath,
+          offset,
+          totalBytes: Number(file.size || 0),
+          final,
+          dataBase64: buffer.toString('base64'),
+          lastModified: Number(file.modifiedMs || 0) || 0,
+          requestedAt: new Date().toISOString()
+        }
+      });
+      if (!result?.ok) {
+        this.settlePendingCommand(commandId, {
+          ok: false,
+          error: String(result?.error || 'device-not-connected')
+        });
+      }
+      return { deviceId, ...await pending };
+    }));
+
+    for (const outcome of outcomes) {
+      if (outcome.ok || outcome.error === 'transfer-cancelled') continue;
+      job.failedTargets.add(outcome.deviceId);
+      job.targetErrors.set(outcome.deviceId, outcome.error || 'transfer-failed');
+    }
+    if (!job.cancelled && outcomes.length > 0 && outcomes.every(outcome => !outcome.ok)) {
+      throw new Error('all-targets-failed');
+    }
+  }
+
+  waitForCommandResult(jobId, deviceId, commandId) {
+    return new Promise(resolve => {
+      const timer = setTimeout(() => {
+        this.settlePendingCommand(commandId, {
+          ok: false,
+          error: 'file-transfer-ack-timeout'
+        });
+      }, this.commandResultTimeoutMs);
+      timer.unref?.();
+      this.pendingCommands.set(commandId, {
+        jobId,
+        deviceId,
+        timer,
+        resolve
+      });
+    });
+  }
+
+  settlePendingCommand(commandId, outcome) {
+    const pending = this.pendingCommands.get(String(commandId || ''));
+    if (!pending) return false;
+    this.pendingCommands.delete(commandId);
+    clearTimeout(pending.timer);
+    pending.resolve(outcome);
+    return true;
+  }
+
+  finishPendingCommands(jobId, error) {
+    for (const [commandId, pending] of this.pendingCommands) {
+      if (pending.jobId !== jobId) continue;
+      this.settlePendingCommand(commandId, { ok: false, error });
+    }
+  }
+
+  handleRemoteEvent(type, event) {
+    if (type === 'RemoteCommandResult') {
+      const commandId = String(event?.commandId || '');
+      const pending = this.pendingCommands.get(commandId);
+      if (!pending) return;
+      const eventDeviceId = String(event?.deviceId || event?.device?.deviceId || '');
+      if (eventDeviceId && eventDeviceId !== pending.deviceId) return;
+      const result = event?.result;
+      const error = String(
+        event?.error
+        || (result?.ok === false || result?.status === 'failed' || result?.status === 'rejected'
+          ? result?.error || 'file-transfer-rejected'
+          : '')
+      );
+      this.settlePendingCommand(commandId, error
+        ? { ok: false, error }
+        : { ok: true, result });
+      return;
+    }
+
+    if (type !== 'RemoteDeviceDisconnected') return;
+    const deviceId = String(event?.deviceId || event?.device?.deviceId || '');
+    if (!deviceId) return;
+    for (const [commandId, pending] of this.pendingCommands) {
+      if (pending.deviceId !== deviceId) continue;
+      this.settlePendingCommand(commandId, {
+        ok: false,
+        error: 'device-disconnected'
+      });
+    }
+  }
+
+  async finishCallback(job, completed) {
+    if (typeof job.onComplete !== 'function') return;
+    try {
+      await job.onComplete({ completed, job: snapshot(job) });
+    } catch (error) {
+      job.error = error instanceof Error ? error.message : String(error);
+      markUpdated(job);
+    }
+  }
+
+  prune() {
+    const threshold = Date.now() - JOB_RETENTION_MS;
+    for (const [id, job] of this.jobs) {
+      const createdAt = Date.parse(job.createdAt);
+      if (job.completedAt && Number.isFinite(createdAt) && createdAt < threshold) this.jobs.delete(id);
+    }
+  }
+}
+
+export function createHubTransferJobs(options) {
+  return new HubTransferJobs(options);
+}