@livedesk/hub 0.1.35 → 0.1.37

package/src/settings/settings-schema.js

@@ -1,17 +1,34 @@
 import os from 'node:os';
 import path from 'node:path';
 
-export const SETTINGS_SCHEMA_VERSION = 3;
+export const SETTINGS_SCHEMA_VERSION = 1;
 
 export const DEFAULT_LIVEDESK_SETTINGS = Object.freeze({
   settingsSchemaVersion: SETTINGS_SCHEMA_VERSION,
-  connection: {},
+  connection: {
+    usePinToAddDevices: true,
+    pinValidityMinutes: 30,
+    rotatePinAfterPairing: true,
+    allowNewDevices: true,
+    approveNewDevices: true,
+    startWithComputer: true,
+    keepRunningInTray: true,
+    showConnectionNotifications: true
+  },
   security: {
     accessMode: 'trusted-only',
-    allowInternetConnections: true,
+    requireEncryptedConnections: true,
+    allowInternetConnections: false,
     allowLanConnections: true,
+    allowUnencryptedLanFallback: false,
+    requireNewDeviceApproval: true,
+    requireAdministratorForSecurityChanges: true,
+    visibleControlIndicator: true,
     lockOnControlEnd: true,
-    idleControlMinutes: 30
+    disconnectIdleControlSessions: true,
+    idleControlMinutes: 30,
+    keepSessionHistory: true,
+    sessionHistoryDays: 30
   },
   control: {
     allowKeyboardMouse: true,
@@ -43,8 +60,10 @@ export const DEFAULT_LIVEDESK_SETTINGS = Object.freeze({
   filesAudio: {
     allowFileTransfer: true,
     allowFolderSync: false,
+    askBeforeReceivingFiles: true,
     openReceivedFolder: false,
     notifyTransferComplete: true,
+    allowOverwrite: false,
     defaultReceiveFolder: 'Desktop/LiveDeskFiles',
     maxFileSizeBytes: 1024 * 1024 * 1024,
     allowRemoteAudio: true,
@@ -84,6 +103,7 @@ export const DEFAULT_LIVEDESK_SETTINGS = Object.freeze({
     controlMaxHeight: 1080,
     controlQuality: 60,
     transport: 'auto',
+    allowPlainLanFallback: false,
     verboseLogs: false,
     frameStatistics: false
   }
@@ -95,7 +115,7 @@ const ENUMS = {
   permissionMode: new Set(['ask', 'safe-auto', 'full-access', 'custom']),
   wallFrameMode: new Set(['auto', 'mode2-lzo', 'mode3-h264-hw', 'mode4-h264-atlas']),
   controlFrameMode: new Set(['mode3-h264-hw', 'mode5-lzo-delta']),
-  transport: new Set(['auto', 'encrypted']),
+  transport: new Set(['auto', 'encrypted', 'plain-lan']),
   recordingQuality: new Set(['standard', 'high']),
   captureAutoDelete: new Set(['never', '7-days', '30-days'])
 };
@@ -136,11 +156,14 @@ const bools = keys => Object.fromEntries(keys.map(key => [key, { type: 'boolean'
 const numbers = (entries) => Object.fromEntries(entries.map(([key, min, max]) => [key, { type: 'number', min, max }]));
 
 const RULES = {
-  connection: {},
+  connection: {
+    ...bools(['usePinToAddDevices', 'rotatePinAfterPairing', 'allowNewDevices', 'approveNewDevices', 'startWithComputer', 'keepRunningInTray', 'showConnectionNotifications']),
+    ...numbers([['pinValidityMinutes', 10, 1440]])
+  },
   security: {
     accessMode: { type: 'enum', values: ENUMS.accessMode },
-    ...bools(['allowInternetConnections', 'allowLanConnections', 'lockOnControlEnd']),
-    ...numbers([['idleControlMinutes', 5, 1440]])
+    ...bools(['requireEncryptedConnections', 'allowInternetConnections', 'allowLanConnections', 'allowUnencryptedLanFallback', 'requireNewDeviceApproval', 'requireAdministratorForSecurityChanges', 'visibleControlIndicator', 'lockOnControlEnd', 'disconnectIdleControlSessions', 'keepSessionHistory']),
+    ...numbers([['idleControlMinutes', 5, 1440], ['sessionHistoryDays', 7, 365]])
   },
   control: {
     ...bools(['allowKeyboardMouse', 'allowSystemShortcuts', 'allowClipboardText', 'allowRemoteRestart', 'reconnectAfterRemoteRestart', 'allowSwitchingMonitors', 'showConnectionToolbar', 'showRemoteCursor', 'openControlOnDoubleClick', 'startRemoteAudioWithControl', 'fitRemoteScreen', 'rememberLastMonitor', 'keepControlReadyBetweenPages'])
@@ -150,7 +173,7 @@ const RULES = {
     ...bools(['autoStart', 'connectedOnly', 'keepEmptySlots', 'showDeviceStatus', 'showPerformanceDetails', 'pauseHiddenTiles', 'reduceWhenHidden', 'autoAdjustTileQuality', 'rememberDevicePositions'])
   },
   filesAudio: {
-    ...bools(['allowFileTransfer', 'allowFolderSync', 'openReceivedFolder', 'notifyTransferComplete', 'allowRemoteAudio', 'startAudioMuted', 'rememberVolume', 'automaticallyRecoverAudio', 'showAudioTroubleshooting', 'rollingBufferEnabled', 'includeRemoteCursor']),
+    ...bools(['allowFileTransfer', 'allowFolderSync', 'askBeforeReceivingFiles', 'openReceivedFolder', 'notifyTransferComplete', 'allowOverwrite', 'allowRemoteAudio', 'startAudioMuted', 'rememberVolume', 'automaticallyRecoverAudio', 'showAudioTroubleshooting', 'rollingBufferEnabled', 'includeRemoteCursor']),
     recordingQuality: { type: 'enum', values: ENUMS.recordingQuality },
     captureAutoDelete: { type: 'enum', values: ENUMS.captureAutoDelete },
     timelapseIntervalSeconds: { type: 'number', min: 5, max: 60 },
@@ -167,23 +190,11 @@ const RULES = {
     wallFrameMode: { type: 'enum', values: ENUMS.wallFrameMode },
     controlFrameMode: { type: 'enum', values: ENUMS.controlFrameMode },
     transport: { type: 'enum', values: ENUMS.transport },
-    ...bools(['verboseLogs', 'frameStatistics']),
+    ...bools(['allowPlainLanFallback', 'verboseLogs', 'frameStatistics']),
     ...numbers([['wallFps', 1, 60], ['wallMaxWidth', 320, 3840], ['wallMaxHeight', 180, 2160], ['wallQuality', 20, 95], ['controlFps', 20, 60], ['controlMaxWidth', 640, 3840], ['controlMaxHeight', 360, 2160], ['controlQuality', 20, 95]])
   }
 };
 
-export function migrateLiveDeskSettings(value = {}) {
-  const source = value && typeof value === 'object' && !Array.isArray(value) ? structuredClone(value) : {};
-  const sourceVersion = Math.max(0, Number(source.settingsSchemaVersion) || 0);
-  if (sourceVersion < 3) {
-    source.security = {
-      ...(source.security && typeof source.security === 'object' && !Array.isArray(source.security) ? source.security : {}),
-      allowInternetConnections: true
-    };
-  }
-  return normalizeLiveDeskSettings(source);
-}
-
 export function normalizeLiveDeskSettings(value = {}) {
   const source = value && typeof value === 'object' && !Array.isArray(value) ? value : {};
   const settings = {
@@ -196,6 +207,11 @@ export function normalizeLiveDeskSettings(value = {}) {
     agent: normalizeSection(source.agent, DEFAULT_LIVEDESK_SETTINGS.agent, RULES.agent),
     advanced: normalizeSection(source.advanced, DEFAULT_LIVEDESK_SETTINGS.advanced, RULES.advanced)
   };
+  // Security invariants are enforced at the authority boundary, not just in
+  // the browser. Internet access can never use an unencrypted transport.
+  if (settings.security.requireEncryptedConnections) {
+    settings.security.allowUnencryptedLanFallback = false;
+  }
   if (!settings.security.allowInternetConnections) {
     settings.advanced.transport = settings.advanced.transport === 'encrypted' ? 'encrypted' : 'auto';
   }
@@ -231,16 +247,8 @@ export function effectiveDevicePolicy(settings = DEFAULT_LIVEDESK_SETTINGS) {
     accessMode,
     allowInternetConnections: normalized.security.allowInternetConnections,
     allowLanConnections: normalized.security.allowLanConnections,
-    // Encryption and no-overwrite are structural invariants. They are not
-    // user preferences and cannot be disabled through a legacy settings file.
-    requireEncryptedConnections: true,
-    allowUnencryptedLanFallback: false,
-    visibleControlIndicator: true,
-    lockOnControlEnd: normalized.security.lockOnControlEnd,
-    disconnectIdleControlSessions: true,
-    idleControlMinutes: normalized.security.idleControlMinutes,
-    allowFileOverwrite: false,
-    maxFileSizeBytes: normalized.filesAudio.maxFileSizeBytes,
+    requireEncryptedConnections: normalized.security.requireEncryptedConnections,
+    allowUnencryptedLanFallback: normalized.security.allowUnencryptedLanFallback,
     allowControl: allowMutation && normalized.control.allowKeyboardMouse,
     allowClipboardText: allowMutation && normalized.control.allowClipboardText,
     allowPowerActions: allowMutation && normalized.control.allowRemoteRestart,

package/src/settings/settings-store.js

@@ -1,6 +1,6 @@
 import { mkdir, readFile, rename, writeFile } from 'node:fs/promises';
 import path from 'node:path';
-import { DEFAULT_LIVEDESK_SETTINGS, SETTINGS_SCHEMA_VERSION, defaultSettingsPath, migrateLiveDeskSettings, normalizeLiveDeskSettings, publicSettings } from './settings-schema.js';
+import { DEFAULT_LIVEDESK_SETTINGS, defaultSettingsPath, normalizeLiveDeskSettings, publicSettings } from './settings-schema.js';
 
 export class SettingsConflictError extends Error {
   constructor(settings) {
@@ -29,16 +29,11 @@ export class LiveDeskSettingsStore {
     if (this.record) return structuredClone(this.record);
     try {
       const raw = JSON.parse(await readFile(this.filePath, 'utf8'));
-      const sourceSettings = raw?.settings || raw;
-      const sourceSchemaVersion = Math.max(0, Number(sourceSettings?.settingsSchemaVersion) || 0);
       this.record = {
         revision: Math.max(0, Number(raw?.revision) || 0),
         updatedAt: String(raw?.updatedAt || ''),
-        settings: migrateLiveDeskSettings(sourceSettings)
+        settings: normalizeLiveDeskSettings(raw?.settings || raw)
       };
-      if (sourceSchemaVersion < SETTINGS_SCHEMA_VERSION) {
-        await writeJsonAtomic(this.filePath, this.record);
-      }
     } catch {
       this.record = { revision: 0, updatedAt: '', settings: normalizeLiveDeskSettings(DEFAULT_LIVEDESK_SETTINGS) };
     }