@livedesk/hub 0.1.21 → 0.1.23

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@livedesk/hub",
-  "version": "0.1.21",
+  "version": "0.1.23",
   "description": "LiveDesk local Hub API and browser frame bridge",
   "type": "module",
   "main": "src/server.js",

package/src/remote-hub.js

@@ -658,7 +658,8 @@ function getRetiredAgentTaskError(options = {}) {
     const approvalLevel = safeString(options?.approvalLevel, 80).toLowerCase();
     const hasModelSelection = options
         && typeof options === 'object'
-        && Object.prototype.hasOwnProperty.call(options, 'model');
+        && ['model', 'aiModel', 'aiProvider', 'provider']
+            .some(key => Object.prototype.hasOwnProperty.call(options, key));
     return approvalLevel === 'ai-assist' || hasModelSelection
         ? RETIRED_AGENT_TASK_ERROR
         : '';
@@ -5458,11 +5459,13 @@ export function createRemoteHub(options = {}) {
     }
 
     function sendCommand(deviceId, command) {
-        const device = devices.get(String(deviceId || ''));
+        const device = devices.get(String(deviceId || ''));
         const commandName = safeString(command?.command || 'ping', 80);
-        const requiredPermission = commandName === 'input.control'
-            ? 'allowControl'
-            : commandName.startsWith('file.transfer')
+        const requiredPermission = commandName === 'input.control'
+            ? 'allowControl'
+            : commandName === 'system.power'
+                ? 'allowPowerActions'
+            : commandName.startsWith('file.transfer')
                 ? 'allowFileTransfer'
                     : commandName === 'audio.start'
                         ? 'allowRemoteAudio'
@@ -5521,8 +5524,30 @@ export function createRemoteHub(options = {}) {
             command: payload.command,
             channel: dedicatedFileSocket ? 'file' : 'control'
         });
-        return { ok: true, commandId };
-    }
+        return { ok: true, commandId };
+    }
+
+    function refreshDevicePolicies(deviceIds = undefined) {
+        const requestedIds = Array.isArray(deviceIds) && deviceIds.length > 0
+            ? new Set(deviceIds.map(deviceId => safeString(deviceId, 160)).filter(Boolean))
+            : null;
+        let updated = 0;
+        let total = 0;
+        for (const device of devices.values()) {
+            if (requestedIds && !requestedIds.has(device.deviceId)) continue;
+            if (!device?.socket || device.socket.destroyed || !device.connected) continue;
+            total += 1;
+            const effectivePolicy = getDevicePolicy(device);
+            if (writeJsonLine(device.socket, {
+                type: 'policy.update',
+                effectivePolicy,
+                updatedAt: new Date().toISOString()
+            })) {
+                updated += 1;
+            }
+        }
+        return { ok: updated === total, updated, total };
+    }
 
     // Client updates are an explicit Hub maintenance action, not an Agent task.
     // This legacy path is kept for clients that predate the dedicated update command.
@@ -7396,6 +7421,7 @@ export function createRemoteHub(options = {}) {
         disconnectDevice,
         assignDeviceSlot,
         sendCommand,
+        refreshDevicePolicies,
         sendLegacyClientUpdate,
         sendInputControl,
         releaseInputOwner,

package/src/server.js

@@ -1229,11 +1229,12 @@ hubTransferJobs = createHubTransferJobs({
   maxConcurrent: Number(process.env.LIVEDESK_MAX_FILE_JOBS || 2),
   commandResultTimeoutMs: readPositiveIntegerEnv('LIVEDESK_FILE_CHUNK_ACK_TIMEOUT_MS', 30_000)
 });
-const hubSharedFolders = createHubSharedFolders({
-  filesystem: hubFilesystem,
-  transferJobs: hubTransferJobs,
-  remoteHub
-});
+const hubSharedFolders = createHubSharedFolders({
+  filesystem: hubFilesystem,
+  transferJobs: hubTransferJobs,
+  remoteHub,
+  dataDir: agentDataDir
+});
 
 const app = express();
 const httpServer = createServer(app);
@@ -1450,7 +1451,8 @@ function normalizeDeviceIds(value) {
 function rejectRetiredAgentTaskRequest(req, res) {
   const body = req.body && typeof req.body === 'object' ? req.body : {};
   const approvalLevel = String(body.approvalLevel || '').trim().toLowerCase();
-  const hasModelSelection = Object.prototype.hasOwnProperty.call(body, 'model');
+  const hasModelSelection = ['model', 'aiModel', 'aiProvider', 'provider']
+    .some(key => Object.prototype.hasOwnProperty.call(body, key));
   if (approvalLevel !== 'ai-assist' && !hasModelSelection) {
     return false;
   }
@@ -2715,6 +2717,7 @@ app.patch('/api/settings', async (req, res) => {
     if (patch.agent && Object.prototype.hasOwnProperty.call(patch.agent, 'enabled')) {
       await agentSettingsStore.update({ enabled: record.settings.agent?.enabled === true });
     }
+    remoteHub.refreshDevicePolicies();
     res.json({ ok: true, revision: record.revision, updatedAt: record.updatedAt, settings: record.settings });
   } catch (error) {
     if (error instanceof SettingsConflictError) {
@@ -2972,6 +2975,9 @@ app.post('/api/internal/agent-mcp/tool', async (req, res) => {
 
 app.post('/api/settings/agent/run', async (req, res) => {
   noStore(res);
+  if (rejectRetiredAgentTaskRequest(req, res)) {
+    return;
+  }
   try {
     if (!(await synchronizeAgentEnablement())) {
       throw new AgentRuntimeError('agent-disabled', 'Enable Codex Agent in Settings before running commands.', { status: 409 });
@@ -4006,11 +4012,12 @@ app.post('/api/remote/devices/:deviceId/quick-actions', requireHubFeatureAccess,
   }
 
   const settings = await liveDeskSettingsStore.get();
-  if (settings.agent?.enabled !== true) {
+  const policy = effectiveDevicePolicy(settings);
+  if (policy.accessMode !== 'trusted-only') {
     res.status(403).json({ ok: false, error: 'remote-actions-disabled' });
     return;
   }
-  if (settings.agent?.allowPowerActions !== true) {
+  if (policy.allowPowerActions !== true) {
     res.status(403).json({ ok: false, error: 'power-actions-disabled' });
     return;
   }
@@ -4027,14 +4034,18 @@ app.post('/api/remote/devices/:deviceId/quick-actions', requireHubFeatureAccess,
     return;
   }
 
-  const label = action === 'shutdown' ? 'Shut down' : `${action.slice(0, 1).toUpperCase()}${action.slice(1)}`;
-  const result = remoteHub.requestAgentTask(req.params.deviceId, {
-    instruction: `${label} this Client. This action was explicitly requested and confirmed from the LiveDesk Hub action panel.`,
-    title: `${label} Client`,
-    operation: 'system.power',
-    approvalLevel: 'task-only',
-    toolArguments: { action, delaySec: 0 },
-    permissionMode: 'ask'
+  // The Client enforces the same policy. Queue the current policy immediately
+  // before the command so enabling this visible setting works without forcing
+  // a reconnect, while TCP ordering keeps the command behind the policy update.
+  remoteHub.refreshDevicePolicies([req.params.deviceId]);
+  const result = remoteHub.sendCommand(req.params.deviceId, {
+    command: 'system.power',
+    payload: {
+      action,
+      delaySec: 0,
+      permissionMode: 'manual-confirmed',
+      requestSource: 'hub-action-dock'
+    }
   });
   recordAgentAudit({
     event: 'manual-action-dispatched',
@@ -4043,7 +4054,7 @@ app.post('/api/remote/devices/:deviceId/quick-actions', requireHubFeatureAccess,
     category: 'systemPower',
     decision: result.ok ? 'allow' : 'deny',
     status: result.ok ? 'queued' : 'failed',
-    details: { action, taskId: result.taskId || '', error: result.error || '' }
+    details: { action, commandId: result.commandId || '', error: result.error || '' }
   });
   if (!result.ok) {
     res.status(result.error === 'device-not-found' ? 404 : 409).json(result);

package/src/settings/settings-schema.js

@@ -251,6 +251,7 @@ export function effectiveDevicePolicy(settings = DEFAULT_LIVEDESK_SETTINGS) {
     allowUnencryptedLanFallback: normalized.security.allowUnencryptedLanFallback,
     allowControl: allowMutation && normalized.control.allowKeyboardMouse,
     allowClipboardText: allowMutation && normalized.control.allowClipboardText,
+    allowPowerActions: allowMutation && normalized.control.allowRemoteRestart,
     allowFileTransfer: allowMutation && normalized.filesAudio.allowFileTransfer,
     allowRemoteAudio: accessMode !== 'block-remote-access' && normalized.filesAudio.allowRemoteAudio,
     allowAgent: allowMutation && normalized.agent.enabled