@livedesk/client 0.1.4 → 0.1.6

package/README.md

@@ -16,6 +16,15 @@ On the manager computer, open the LiveDesk dashboard and sign in first. The
 dashboard keeps its local hub address and private pair token refreshed in the
 LiveDesk Supabase registry for the signed-in account.
 
+Supabase Auth must allow the CLI callback URL:
+
+```text
+http://127.0.0.1:5198/callback
+```
+
+If you use a custom port, run `npx @livedesk/client --auth-port 5200` and add
+the matching callback URL to Supabase Auth redirect URLs.
+
 For manual LAN fallback, start `@livedesk/hub` with an externally reachable
 RemoteHub host and pass the address/token explicitly:
 
@@ -43,5 +52,6 @@ npx @livedesk/client --no-thumbnail
 npx @livedesk/client --no-live
 npx @livedesk/client --engine node
 npx @livedesk/client --engine fast --trace-frames
+npx @livedesk/client --auth-port 5200
 npx @livedesk/client --logout
 ```

package/bin/livedesk-client-node.js

@@ -14,6 +14,8 @@ const DEFAULT_LIVE_FPS = 20;
 const MAX_LIVE_FPS = 24;
 const MAX_FRAME_BASE64_CHARS = 3 * 1024 * 1024;
 const MAX_AI_OUTPUT_CHARS = 6000;
+const MAX_FILE_TRANSFER_FILES = 24;
+const MAX_FILE_TRANSFER_BYTES = 24 * 1024 * 1024;
 
 function printHelp() {
     console.log(`
@@ -35,6 +37,7 @@ Options:
   --no-live              Disable focused live screen streaming.
   --tasks                Enable safe remote task inbox. Default on.
   --no-tasks             Disable remote task dispatch capability.
+  --files-dir <path>     Default folder for received files. Default: ~/Desktop/LiveDeskFiles.
   --ai                   Enable OpenAI-backed remote AI assist tasks.
   --no-ai                Disable OpenAI-backed remote AI assist tasks.
   --ai-model <model>     OpenAI model for AI assist. Default: ${DEFAULT_AI_MODEL}
@@ -68,6 +71,7 @@ function parseArgs(argv) {
         thumbnailEnabled: defaultDesktopCaptureEnabled && !isFalsy(process.env.LIVEDESK_CLIENT_THUMBNAIL ?? process.env.MINDEXEC_REMOTE_THUMBNAIL),
         liveEnabled: defaultDesktopCaptureEnabled && !isFalsy(process.env.LIVEDESK_CLIENT_LIVE ?? process.env.MINDEXEC_REMOTE_LIVE),
         taskEnabled: !isFalsy(process.env.LIVEDESK_CLIENT_TASKS ?? process.env.MINDEXEC_REMOTE_TASKS),
+        filesDir: process.env.LIVEDESK_CLIENT_FILES_DIR || process.env.MINDEXEC_REMOTE_FILES_DIR || '',
         aiEnabled: isTruthy(process.env.LIVEDESK_CLIENT_AI || process.env.MINDEXEC_REMOTE_AI),
         aiModel: process.env.LIVEDESK_CLIENT_AI_MODEL || process.env.MINDEXEC_REMOTE_AI_MODEL || process.env.OPENAI_MODEL || DEFAULT_AI_MODEL,
         openAiApiKey: process.env.OPENAI_API_KEY || '',
@@ -123,6 +127,9 @@ function parseArgs(argv) {
             case '--no-tasks':
                 result.taskEnabled = false;
                 break;
+            case '--files-dir':
+                result.filesDir = args[++index] || result.filesDir;
+                break;
             case '--ai':
                 result.aiEnabled = true;
                 result.taskEnabled = true;
@@ -255,6 +262,95 @@ function wait(ms) {
     return new Promise(resolve => setTimeout(resolve, ms));
 }
 
+function getDefaultFilesDir() {
+    return path.join(os.homedir(), 'Desktop', 'LiveDeskFiles');
+}
+
+function normalizeDirectoryPath(value, fallback = getDefaultFilesDir()) {
+    const text = String(value || '').replace(/\0/g, '').trim();
+    if (!text) {
+        return fallback;
+    }
+    if (path.isAbsolute(text)) {
+        return path.resolve(text);
+    }
+    return path.resolve(fallback, text);
+}
+
+function sanitizePathSegment(value, fallback = 'file') {
+    const text = String(value || '')
+        .replace(/\0/g, '')
+        .replace(/[<>:"|?*\x00-\x1f]/g, '_')
+        .replace(/[\\/]+/g, '_')
+        .trim();
+    const normalized = text && text !== '.' && text !== '..' ? text : fallback;
+    return normalized.slice(0, 160);
+}
+
+function sanitizeRelativeFilePath(value, fallbackName = 'file') {
+    const parts = String(value || '')
+        .replace(/\0/g, '')
+        .split(/[\\/]+/)
+        .map(part => sanitizePathSegment(part, ''))
+        .filter(Boolean)
+        .filter(part => part !== '.' && part !== '..');
+    if (parts.length === 0) {
+        return sanitizePathSegment(fallbackName, 'file');
+    }
+    return path.join(...parts.slice(-8));
+}
+
+async function handleFileTransferCommand(options, payload = {}) {
+    const files = Array.isArray(payload.files) ? payload.files.slice(0, MAX_FILE_TRANSFER_FILES) : [];
+    if (files.length === 0) {
+        throw new Error('No files were included in the transfer.');
+    }
+
+    const baseDir = normalizeDirectoryPath(payload.remoteDirectory || options.filesDir);
+    await fs.mkdir(baseDir, { recursive: true });
+
+    let totalBytes = 0;
+    const saved = [];
+    for (const file of files) {
+        const name = sanitizePathSegment(file?.name, 'file');
+        const relativePath = sanitizeRelativeFilePath(file?.relativePath || name, name);
+        const targetPath = path.resolve(baseDir, relativePath);
+        const relativeFromBase = path.relative(baseDir, targetPath);
+        if (relativeFromBase.startsWith('..') || path.isAbsolute(relativeFromBase)) {
+            throw new Error(`Unsafe file path: ${relativePath}`);
+        }
+
+        const dataBase64 = String(file?.dataBase64 || '').replace(/^data:[^,]*,/i, '').trim();
+        if (!dataBase64) {
+            throw new Error(`Missing file data: ${name}`);
+        }
+        const buffer = Buffer.from(dataBase64, 'base64');
+        totalBytes += buffer.length;
+        if (totalBytes > MAX_FILE_TRANSFER_BYTES) {
+            throw new Error('File transfer exceeded the local size limit.');
+        }
+
+        await fs.mkdir(path.dirname(targetPath), { recursive: true });
+        await fs.writeFile(targetPath, buffer);
+        saved.push({
+            name,
+            relativePath,
+            path: targetPath,
+            bytes: buffer.length
+        });
+    }
+
+    return {
+        kind: 'file.transfer',
+        transferId: String(payload.transferId || '').slice(0, 128),
+        status: 'completed',
+        directory: baseDir,
+        files: saved,
+        totalBytes,
+        completedAt: new Date().toISOString()
+    };
+}
+
 function clampNumber(value, min, max, fallback) {
     const number = Number(value);
     if (!Number.isFinite(number)) {
@@ -747,6 +843,24 @@ async function handleRemoteCommand(socket, options, message, nextFrameSeq, activ
         return;
     }
 
+    if (command === 'file.transfer') {
+        try {
+            const result = await handleFileTransferCommand(options, message.payload || {});
+            writeJsonLine(socket, {
+                type: 'command.result',
+                commandId: message.commandId,
+                result
+            });
+        } catch (error) {
+            writeJsonLine(socket, {
+                type: 'command.result',
+                commandId: message.commandId,
+                error: error?.message || String(error)
+            });
+        }
+        return;
+    }
+
     if (command === 'input.control') {
         writeJsonLine(socket, {
             type: 'command.result',
@@ -822,6 +936,9 @@ function connectOnce(options, deviceId) {
                     thumbnail: options.thumbnailEnabled,
                     liveStream: options.liveEnabled,
                     control: false,
+                    fileTransfer: true,
+                    remoteFiles: true,
+                    fileTransferMaxBytes: MAX_FILE_TRANSFER_BYTES,
                     computerAgent: options.taskEnabled,
                     taskDispatch: options.taskEnabled,
                     aiAssist: options.taskEnabled && options.aiEnabled && (options.fakeAi || !!options.openAiApiKey),

package/bin/livedesk-client.js

@@ -13,6 +13,8 @@ const packageRoot = resolve(__dirname, '..');
 const nodeAgentPath = join(__dirname, 'livedesk-client-node.js');
 const FAST_PREFLIGHT_TIMEOUT_MS = 5000;
 const DEFAULT_MANAGER = '127.0.0.1:5197';
+const DEFAULT_AUTH_CALLBACK_HOST = '127.0.0.1';
+const DEFAULT_AUTH_CALLBACK_PORT = 5198;
 const SUPABASE_URL = process.env.LIVEDESK_SUPABASE_URL || 'https://otbyfkjxrkngvjziawki.supabase.co';
 const SUPABASE_PUBLISHABLE_KEY = process.env.LIVEDESK_SUPABASE_PUBLISHABLE_KEY || 'sb_publishable_NpUs0RDJH2YnllsqTKO6TQ_1jTdSsNQ';
 const CLIENT_STATE_DIR = join(os.homedir(), '.livedesk-client');
@@ -47,6 +49,7 @@ Options:
   --no-tasks                      Disable remote task dispatch capability.
   --login                         Sign in with Google and auto-discover manager.
   --logout                        Forget saved Google session before connecting.
+  --auth-port <port>              Google sign-in callback port. Default: 5198.
   --version                       Show the agent version.
   --help                          Show this help.
 
@@ -80,6 +83,7 @@ function parseLauncherArgs(argv) {
     let manager = process.env.LIVEDESK_CLIENT_MANAGER || process.env.MINDEXEC_REMOTE_MANAGER || '';
     let pair = process.env.LIVEDESK_CLIENT_PAIR_TOKEN || process.env.MINDEXEC_REMOTE_PAIR_TOKEN || '';
     let slot = process.env.LIVEDESK_CLIENT_SLOT || process.env.MINDEXEC_REMOTE_SLOT || '';
+    let authPort = normalizePort(process.env.LIVEDESK_CLIENT_AUTH_PORT) || DEFAULT_AUTH_CALLBACK_PORT;
     let command = 'connect';
     let nodeOnlyFeature = false;
     let fakeThumbnail = false;
@@ -129,6 +133,11 @@ function parseLauncherArgs(argv) {
             logout = true;
             continue;
         }
+        if (arg === '--auth-port') {
+            authPort = normalizePort(argv[index + 1]) || authPort;
+            index += 1;
+            continue;
+        }
         if (arg === '--manager') {
             manager = argv[index + 1] || manager;
             forwarded.push(arg, argv[index + 1]);
@@ -178,11 +187,20 @@ function parseLauncherArgs(argv) {
         manager,
         pair,
         slot,
+        authPort,
         nodeOnlyFeature,
         fakeThumbnail
     };
 }
 
+function normalizePort(value) {
+    const port = Number(String(value || '').trim());
+    if (!Number.isInteger(port) || port < 1 || port > 65535) {
+        return 0;
+    }
+    return port;
+}
+
 function normalizeSlotNumber(value) {
     const number = Number(String(value || '').trim());
     if (!Number.isInteger(number) || number < 1 || number > 999) {
@@ -260,7 +278,9 @@ function openBrowser(url) {
     spawn(command, [url], { detached: true, stdio: 'ignore' }).unref();
 }
 
-async function startOAuthCallbackServer() {
+async function startOAuthCallbackServer(options = {}) {
+    const host = String(process.env.LIVEDESK_CLIENT_AUTH_HOST || DEFAULT_AUTH_CALLBACK_HOST).trim() || DEFAULT_AUTH_CALLBACK_HOST;
+    const port = normalizePort(options.authPort) || DEFAULT_AUTH_CALLBACK_PORT;
     let settleCode;
     let rejectCode;
     const waitForCode = new Promise((resolve, reject) => {
@@ -288,25 +308,32 @@ async function startOAuthCallbackServer() {
             settleCode(code);
             server.close();
     });
-    await new Promise((resolve, reject) => {
-        server.once('error', reject);
-        server.listen(0, '127.0.0.1', resolve);
-    });
+    try {
+        await new Promise((resolve, reject) => {
+            server.once('error', reject);
+            server.listen(port, host, resolve);
+        });
+    } catch (err) {
+        if (err?.code === 'EADDRINUSE') {
+            throw new Error(`LiveDesk Google sign-in callback port ${port} is already in use. Close the app using it or run with --auth-port <port> and add that callback URL in Supabase Auth redirect URLs.`);
+        }
+        throw err;
+    }
     return {
         get redirectTo() {
-            return `http://127.0.0.1:${server.address().port}/callback`;
+            return `http://${host}:${server.address().port}/callback`;
         },
         waitForCode
     };
 }
 
-async function signInWithGoogle(supabase) {
+async function signInWithGoogle(supabase, options = {}) {
     const { data: existing } = await supabase.auth.getSession();
     if (existing?.session?.access_token) {
         return existing.session;
     }
 
-    const callback = await startOAuthCallbackServer();
+    const callback = await startOAuthCallbackServer({ authPort: options.authPort });
     const { data, error } = await supabase.auth.signInWithOAuth({
         provider: 'google',
         options: {
@@ -428,7 +455,7 @@ async function prepareLoginConnection(parsed) {
 
     if (shouldLogin) {
         const supabase = await createSupabaseClient();
-        const session = await signInWithGoogle(supabase);
+        const session = await signInWithGoogle(supabase, { authPort: parsed.authPort });
         const email = session.user?.email ? ` as ${session.user.email}` : '';
         console.log(`Signed in to LiveDesk${email}.`);
         const resolved = await resolveManagerFromSupabase(supabase);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@livedesk/client",
-  "version": "0.1.4",
+  "version": "0.1.6",
   "description": "LiveDesk local remote client",
   "type": "module",
   "bin": {