@liveblocks/core 3.13.0-ack1 → 3.13.0-metadata1

package/dist/index.cjs

@@ -6,7 +6,7 @@ var __export = (target, all) => {
 
 // src/version.ts
 var PKG_NAME = "@liveblocks/core";
-var PKG_VERSION = "3.13.0-ack1";
+var PKG_VERSION = "3.13.0-metadata1";
 var PKG_FORMAT = "cjs";
 
 // src/dupe-detection.ts
@@ -1606,6 +1606,7 @@ function createApiClient({
         comment: {
           id: commentId,
           body: options.body,
+          metadata: options.commentMetadata,
           attachmentIds: options.attachmentIds
         },
         metadata: options.metadata
@@ -1659,6 +1660,16 @@ function createApiClient({
       options.metadata
     );
   }
+  async function editCommentMetadata(options) {
+    return await httpClient.post(
+      url`/v2/c/rooms/${options.roomId}/threads/${options.threadId}/comments/${options.commentId}/metadata`,
+      await authManager.getAuthValue({
+        requestedScope: "comments:read",
+        roomId: options.roomId
+      }),
+      options.metadata
+    );
+  }
   async function createComment(options) {
     const commentId = _nullishCoalesce(options.commentId, () => ( createCommentId()));
     const comment = await httpClient.post(
@@ -1670,6 +1681,7 @@ function createApiClient({
       {
         id: commentId,
         body: options.body,
+        metadata: options.metadata,
         attachmentIds: options.attachmentIds
       }
     );
@@ -1684,7 +1696,8 @@ function createApiClient({
       }),
       {
         body: options.body,
-        attachmentIds: options.attachmentIds
+        attachmentIds: options.attachmentIds,
+        metadata: options.metadata
       }
     );
     return convertToCommentData(comment);
@@ -2426,6 +2439,7 @@ function createApiClient({
     editThreadMetadata,
     createComment,
     editComment,
+    editCommentMetadata,
     deleteComment,
     addReaction,
     removeReaction,
@@ -3092,7 +3106,6 @@ var ServerMsgCode = Object.freeze({
   // For Storage
   INITIAL_STORAGE_STATE: 200,
   UPDATE_STORAGE: 201,
-  STORAGE_ACK: 202,
   // For Yjs Docs
   UPDATE_YDOC: 300,
   // For Comments
@@ -3105,6 +3118,7 @@ var ServerMsgCode = Object.freeze({
   COMMENT_DELETED: 404,
   COMMENT_REACTION_ADDED: 405,
   COMMENT_REACTION_REMOVED: 406,
+  COMMENT_METADATA_UPDATED: 409,
   // Error codes
   REJECT_STORAGE_OP: 299
   // Sent if a mutation was not allowed on the server (i.e. due to permissions, limit exceeded, etc)
@@ -5927,6 +5941,10 @@ var OpCode = Object.freeze({
   ACK: 9
   // Will only appear in v8+
 });
+function isAck(op) {
+  return op.type === OpCode.ACK || // >= v8
+  op.type === OpCode.DELETE_CRDT && op.id === "ACK";
+}
 
 // src/crdts/AbstractCrdt.ts
 function createManagedPool(roomId, options) {
@@ -6381,7 +6399,7 @@ var LiveList = class _LiveList extends AbstractCrdt {
       };
     }
   }
-  #applySetFixop(op) {
+  #applySetAck(op) {
     if (this._pool === void 0) {
       throw new Error("Can't attach child if managed pool is not present");
     }
@@ -6491,7 +6509,7 @@ var LiveList = class _LiveList extends AbstractCrdt {
       reverse: []
     };
   }
-  #applyInsertFixop(op) {
+  #applyInsertAck(op) {
     const existingItem = this.#items.find((item) => item._id === op.id);
     const key = asPos(op.parentKey);
     const itemIndexAtPosition = this._indexOfPosition(key);
@@ -6613,16 +6631,16 @@ var LiveList = class _LiveList extends AbstractCrdt {
     if (op.intent === "set") {
       if (source === 1 /* REMOTE */) {
         result = this.#applySetRemote(op);
-      } else if (source === 2 /* FIXOP */) {
-        result = this.#applySetFixop(op);
+      } else if (source === 2 /* ACK */) {
+        result = this.#applySetAck(op);
       } else {
         result = this.#applySetUndoRedo(op);
       }
     } else {
       if (source === 1 /* REMOTE */) {
         result = this.#applyRemoteInsert(op);
-      } else if (source === 2 /* FIXOP */) {
-        result = this.#applyInsertFixop(op);
+      } else if (source === 2 /* ACK */) {
+        result = this.#applyInsertAck(op);
       } else {
         result = this.#applyInsertUndoRedo(op);
       }
@@ -6705,7 +6723,7 @@ var LiveList = class _LiveList extends AbstractCrdt {
       };
     }
   }
-  #applySetChildKeyFixop(newKey, child) {
+  #applySetChildKeyAck(newKey, child) {
     const previousKey = nn(child._parentKey);
     if (this.#implicitlyDeletedItems.has(child)) {
       const existingItemIndex = this._indexOfPosition(newKey);
@@ -6786,8 +6804,8 @@ var LiveList = class _LiveList extends AbstractCrdt {
   _setChildKey(newKey, child, source) {
     if (source === 1 /* REMOTE */) {
       return this.#applySetChildKeyRemote(newKey, child);
-    } else if (source === 2 /* FIXOP */) {
-      return this.#applySetChildKeyFixop(newKey, child);
+    } else if (source === 2 /* ACK */) {
+      return this.#applySetChildKeyAck(newKey, child);
     } else {
       return this.#applySetChildKeyUndoRedo(newKey, child);
     }
@@ -7300,7 +7318,7 @@ var LiveMap = class _LiveMap extends AbstractCrdt {
     if (this._pool.getNode(id) !== void 0) {
       return { modified: false };
     }
-    if (source === 2 /* FIXOP */) {
+    if (source === 2 /* ACK */) {
       const lastUpdateOpId = this.#unacknowledgedSet.get(key);
       if (lastUpdateOpId === opId) {
         this.#unacknowledgedSet.delete(key);
@@ -7701,7 +7719,7 @@ var LiveObject = (_class2 = class _LiveObject extends AbstractCrdt {
       }
       return { modified: false };
     }
-    if (source === 0 /* LOCAL */) {
+    if (source === 0 /* UNDOREDO_RECONNECT */) {
       this.#propToLastUpdate.set(key, nn(opId));
     } else if (this.#propToLastUpdate.get(key) === void 0) {
     } else if (this.#propToLastUpdate.get(key) === opId) {
@@ -8660,6 +8678,8 @@ function defaultMessageFromContext(context) {
       return "Could not delete thread";
     case "EDIT_THREAD_METADATA_ERROR":
       return "Could not edit thread metadata";
+    case "EDIT_COMMENT_METADATA_ERROR":
+      return "Could not edit comment metadata";
     case "MARK_THREAD_AS_RESOLVED_ERROR":
       return "Could not mark thread as resolved";
     case "MARK_THREAD_AS_UNRESOLVED_ERROR":
@@ -9107,11 +9127,7 @@ function createRoom(options, config) {
       currentItems.set(id, node._serialize());
     }
     const ops = getTreesDiffOperations(currentItems, new Map(items));
-    const result = applyOps(
-      ops,
-      /* isLocal */
-      false
-    );
+    const result = applyOps(ops, false);
     notify(result.updates);
   }
   function _addToRealUndoStack(historyOps) {
@@ -9192,12 +9208,11 @@ function createRoom(options, config) {
       } else {
         let source;
         if (isLocal) {
-          source = 0 /* LOCAL */;
-        } else if (op.opId) {
-          context.unacknowledgedOps.delete(op.opId);
-          source = 2 /* FIXOP */;
+          source = 0 /* UNDOREDO_RECONNECT */;
         } else {
-          source = 1 /* REMOTE */;
+          const opId = nn(op.opId);
+          const deleted = context.unacknowledgedOps.delete(opId);
+          source = deleted ? 2 /* ACK */ : 1 /* REMOTE */;
         }
         const applyOpResult = applyOp(op, source);
         if (applyOpResult.modified) {
@@ -9228,6 +9243,9 @@ function createRoom(options, config) {
     };
   }
   function applyOp(op, source) {
+    if (isAck(op)) {
+      return { modified: false };
+    }
     switch (op.type) {
       case OpCode.DELETE_OBJECT_KEY:
       case OpCode.UPDATE_OBJECT:
@@ -9236,7 +9254,7 @@ function createRoom(options, config) {
         if (node === void 0) {
           return { modified: false };
         }
-        return node._apply(op, source === 0 /* LOCAL */);
+        return node._apply(op, source === 0 /* UNDOREDO_RECONNECT */);
       }
       case OpCode.SET_PARENT_KEY: {
         const node = context.pool.nodes.get(op.id);
@@ -9407,11 +9425,7 @@ function createRoom(options, config) {
     }
     const messages = [];
     const inOps = Array.from(offlineOps.values());
-    const result = applyOps(
-      inOps,
-      /* isLocal */
-      true
-    );
+    const result = applyOps(inOps, true);
     messages.push({
       type: ClientMsgCode.UPDATE_STORAGE,
       ops: result.ops
@@ -9475,12 +9489,9 @@ function createRoom(options, config) {
           processInitialStorage(message);
           break;
         }
+        // Write event
         case ServerMsgCode.UPDATE_STORAGE: {
-          const applyResult = applyOps(
-            message.ops,
-            /* isLocal */
-            false
-          );
+          const applyResult = applyOps(message.ops, false);
           for (const [key, value] of applyResult.updates.storageUpdates) {
             updates.storageUpdates.set(
               key,
@@ -9489,14 +9500,6 @@ function createRoom(options, config) {
           }
           break;
         }
-        // Since V8. On V7, acks were sent disguised as an Ops in UPDATE_STORAGE messages.
-        case ServerMsgCode.STORAGE_ACK: {
-          for (const opId of message.opIds) {
-            context.unacknowledgedOps.delete(opId);
-          }
-          notifyStorageStatus();
-          break;
-        }
         // Receiving a RejectedOps message in the client means that the server is no
         // longer in sync with the client. Trying to synchronize the client again by
         // rolling back particular Ops may be hard/impossible. It's fine to not try and
@@ -9521,7 +9524,8 @@ function createRoom(options, config) {
         case ServerMsgCode.COMMENT_REACTION_REMOVED:
         case ServerMsgCode.COMMENT_CREATED:
         case ServerMsgCode.COMMENT_EDITED:
-        case ServerMsgCode.COMMENT_DELETED: {
+        case ServerMsgCode.COMMENT_DELETED:
+        case ServerMsgCode.COMMENT_METADATA_UPDATED: {
           eventHub.comments.notify(message);
           break;
         }
@@ -9702,11 +9706,7 @@ function createRoom(options, config) {
       return;
     }
     context.pausedHistory = null;
-    const result = applyOps(
-      historyOps,
-      /* isLocal */
-      true
-    );
+    const result = applyOps(historyOps, true);
     notify(result.updates);
     context.redoStack.push(result.reverse);
     onHistoryChange();
@@ -9726,11 +9726,7 @@ function createRoom(options, config) {
       return;
     }
     context.pausedHistory = null;
-    const result = applyOps(
-      historyOps,
-      /* isLocal */
-      true
-    );
+    const result = applyOps(historyOps, true);
     notify(result.updates);
     context.undoStack.push(result.reverse);
     onHistoryChange();
@@ -9873,6 +9869,7 @@ function createRoom(options, config) {
       commentId: options2.commentId,
       metadata: options2.metadata,
       body: options2.body,
+      commentMetadata: options2.commentMetadata,
       attachmentIds: options2.attachmentIds
     });
   }
@@ -9885,6 +9882,18 @@ function createRoom(options, config) {
   }) {
     return httpClient.editThreadMetadata({ roomId, threadId, metadata });
   }
+  async function editCommentMetadata({
+    threadId,
+    commentId,
+    metadata
+  }) {
+    return httpClient.editCommentMetadata({
+      roomId,
+      threadId,
+      commentId,
+      metadata
+    });
+  }
   async function markThreadAsResolved(threadId) {
     return httpClient.markThreadAsResolved({ roomId, threadId });
   }
@@ -9906,6 +9915,7 @@ function createRoom(options, config) {
       threadId: options2.threadId,
       commentId: options2.commentId,
       body: options2.body,
+      metadata: options2.metadata,
       attachmentIds: options2.attachmentIds
     });
   }
@@ -9915,6 +9925,7 @@ function createRoom(options, config) {
       threadId: options2.threadId,
       commentId: options2.commentId,
       body: options2.body,
+      metadata: options2.metadata,
       attachmentIds: options2.attachmentIds
     });
   }
@@ -10102,6 +10113,7 @@ function createRoom(options, config) {
       unsubscribeFromThread,
       createComment,
       editComment,
+      editCommentMetadata,
       deleteComment,
       addReaction,
       removeReaction,
@@ -10234,7 +10246,7 @@ function makeCreateSocketDelegateForRoom(roomId, baseUrl, WebSocketPolyfill) {
     }
     const url2 = new URL(baseUrl);
     url2.protocol = url2.protocol === "http:" ? "ws" : "wss";
-    url2.pathname = "/v8";
+    url2.pathname = "/v7";
     url2.searchParams.set("roomId", roomId);
     if (authValue.type === "secret") {
       url2.searchParams.set("tok", authValue.token.raw);