@live-change/dao 0.3.13 → 0.3.17

package/lib/DaoProxy.js

@@ -56,11 +56,11 @@ class DaoProxy extends EventEmitter {
     observable.respawn = (...args) => {
       const newObservable = this.observables.get(spath)
       if(newObservable && newObservable !== observable) {
-        observable.target = newObservable
+        observable.observable = newObservable
       } else if(this.dao) {
-        observable.target = this.dao.observable(what)
+        observable.observable = this.dao.observable(what)
       } else {
-        observable.target = null
+        observable.observable = null
       }
       oldRespawn.call(observable, ...args)
     }

package/lib/ExtendedObservableList.js

@@ -30,11 +30,11 @@ class ExtendedObservableList extends ObservableList {
       }
       this.list = undefined
     }
-    ObservableList.dispose.apply(this)
+    super.dispose.apply(this)
   }
 
   respawn() {
-    ObservableList.respawn.apply(this)
+    super.respawn.apply(this)
     this.observableList.observe(this)
   }
 

package/lib/Observable.js

@@ -22,7 +22,10 @@ class Observable {
   fireObservers(signal, ...args) {
     if(this.disposed) return
     let handled = false
-    for(var observer of this.observers) handled = this.fireObserver(observer, signal, ...args) || handled
+    const observersToFire = this.observers.slice()
+    for(const observer of observersToFire) {
+      handled = this.fireObserver(observer, signal, ...args) || handled
+    }
     if(signal == 'error') {
       let error = args[0]
       handled = this.handleError(error) || handled
@@ -90,27 +93,38 @@ class Observable {
 
   wait() {
     let finished = false
+    let resultObserver
+    let errorObserver
 
     const waitPromise = new Promise((resolve, reject) => {
-      const resultObserver = (signal) => {
+      errorObserver = (error) => {
+        if(resultObserver) this.unobserve(resultObserver)
+        resultObserver = undefined
+        if(errorObserver) this.uncatch(errorObserver)
+        errorObserver = undefined
+        if(finished) return
         finished = true
-        this.unobserve(resultObserver)
-        this.uncatch(errorObserver)
-        resolve(signal)
-      }
-      const errorObserver = (error) => {
-        finished = true
-        this.unobserve(resultObserver)
-        this.uncatch(errorObserver)
         reject(error)
       }
       if(!finished) this.catch(errorObserver)
+      resultObserver = (signal) => {
+        if(resultObserver) this.unobserve(resultObserver)
+        resultObserver = undefined
+        if(errorObserver) this.uncatch(errorObserver)
+        errorObserver = undefined
+        if(finished) return
+        finished = true
+        resolve(signal)
+      }
       if(!finished) this.observe(resultObserver)
     })
     waitPromise.cancel = () => {
-      finished = true
       this.unobserve(resultObserver)
+      resultObserver = undefined
       this.uncatch(errorObserver)
+      errorObserver = undefined
+      if(finished) return
+      finished = true
       reject('canceled')
     }
     return waitPromise

package/lib/ObservableList.js

@@ -18,9 +18,9 @@ class ObservableList extends Observable {
   }
 
   set(list) {
-    if(list === this.list) return;
+    if(list === this.list) return
     try {
-      if (JSON.stringify(list) == JSON.stringify(this.list)) return;
+      if (JSON.stringify(list) == JSON.stringify(this.list)) return
     } catch(e) {}
     this.list = this.valueActivator ? this.valueActivator(list) : list
     this.fireObservers('set', list)
@@ -282,6 +282,9 @@ class ObservableList extends Observable {
   getValue() {
     return this.list
   }
+  getError() {
+    return this.savedError
+  }
 }
 
 module.exports = ObservableList

package/lib/ObservablePromiseProxy.js

@@ -10,7 +10,8 @@ class ObservablePromiseProxy extends Observable {
     this.observer = (signal, ...args) => {
       this.fireObservers(signal, ...args)
     }
-    promise.then((result) => {
+    this.promise = promise
+    this.promise.then((result) => {
       if(result.observe) {
         this.init(result)
       } else {
@@ -51,7 +52,9 @@ class ObservablePromiseProxy extends Observable {
     }
   }
   getValue() {
-    return promise.then(r => r.getValue())
+    if(!this.observable) return undefined
+    if(!this.observable.getValue) return undefined
+    return this.observable.getValue()
   }
 }
 

package/lib/ObservableProxy.js

@@ -17,6 +17,7 @@ class ObservableProxy extends Observable {
   setTarget(observable) {
     if(this === observable) throw new Error('infinite loop')
     if(!this.disposed && this.observable) {
+      //console.log("SET TARGET UNOBSERVE TARGET")
       this.observable.unobserve(this.observer)
       for(let [object, property] of this.properties) {
         this.observable.unbindProperty(object, property)
@@ -27,6 +28,7 @@ class ObservableProxy extends Observable {
     }
     this.observable = observable
     if(!this.disposed && this.observable) {
+      //console.log("SET TARGET OBSERVE TARGET")
       this.observable.observe(this.observer)
       for(let [object, property] of this.properties) {
         this.observable.bindProperty(object, property)
@@ -51,6 +53,7 @@ class ObservableProxy extends Observable {
 
   reobserveTarget() {
     if(!this.disposed && this.observable) {
+      //console.log("REOBSERVE TARGET!", this.observable)
       this.observable.unobserve(this.observer)
       this.observable.observe(this.observer)
     }
@@ -64,13 +67,27 @@ class ObservableProxy extends Observable {
   catch(...args) {
     let beenDisposed = this.disposed
     Observable.prototype.catch.apply(this, args)
-    if(!beenDisposed) this.reobserveTarget()
+    if(!beenDisposed) {
+      if(this.observable.getError) {
+        const error = this.observable.getError()
+        if(error) this.fireObserver(args[0], 'error', error)
+      } else {
+        this.reobserveTarget()
+      }
+    }
   }
 
   observe(...args) {
     let beenDisposed = this.disposed
     Observable.prototype.observe.apply(this, args)
-    if(!beenDisposed) this.reobserveTarget()
+    if(!beenDisposed) {
+      if(this.observable && this.observable.getValue) {
+        const value = this.observable.getValue()
+        if(value !== undefined) this.fireObserver(args[0], 'set', value)
+      } else {
+        this.reobserveTarget()
+      }
+    }
   }
 
   bindProperty(object, property) {

package/lib/ObservableValue.js

@@ -160,6 +160,10 @@ class ObservableValue extends Observable {
   getValue() {
     return this.value
   }
+
+  getError() {
+    return this.savedError
+  }
 }
 
 module.exports = ObservableValue

package/lib/ReactiveServerConnection.js

@@ -514,9 +514,11 @@ class ReactiveServerConnection extends EventEmitter {
   handleUnobserve(message) {
     const path = message.what
     const spath = JSON.stringify(path)
-    //debug('handle unobserve', spath)
+    debug('handle unobserve', spath)
     const observation = this.observations.get(spath)
-    if(!observation) throw new Error("Unobserve of not observed "+spath)
+    if(!observation) {
+      throw new Error("Unobserve of not observed "+spath)
+    }
     observation.unobserve(message.pushed)
   }
 

package/package.json

@@ -36,5 +36,5 @@
   "scripts": {
     "test": "NODE_ENV=test blue-tape tests/*"
   },
-  "version": "0.3.13"
+  "version": "0.3.17"
 }