@live-change/dao-vue3 0.2.0 → 0.2.1

package/lib/live.js

@@ -1,5 +1,7 @@
 import { ref, onUnmounted, getCurrentInstance, unref, reactive } from 'vue'
 import { collectPointers, ExtendedObservableList } from '@live-change/dao'
+import nodeDebug from "debug"
+const debug = nodeDebug('dao-vue3')
 
 const liveSymbol = Symbol('live')
 
@@ -18,7 +20,7 @@ async function live(api, path, onUnmountedCb) {
   const paths = [ path ]
   if(typeof window == 'undefined') {
     const preFetchPaths = await api.get({ paths })
-    console.log("PRE FETCH DATA", preFetchPaths)
+    debug("PRE FETCH DATA", preFetchPaths)
     const preFetchMap = new Map(preFetchPaths.map((res) => [JSON.stringify(res.what), res] ))
     function createObject(what, more) {
       const res = preFetchMap.get(JSON.stringify(what))
@@ -29,13 +31,13 @@ async function live(api, path, onUnmountedCb) {
           for(let i = 0; i < data.length; i ++) {
             for(const moreElement of more) {
               if(moreElement.to) {
-                console.log("COLLECT POINTERS FROM", data[i], "SC", moreElement.schema)
+                debug("COLLECT POINTERS FROM", data[i], "SC", moreElement.schema)
                 const pointers = collectPointers(data[i], moreElement.schema ,
                   (what) => preFetchMap.get(JSON.stringify(what)))
-                console.log("POINTERS COLLECTED", pointers)
+                debug("POINTERS COLLECTED", pointers)
                 const values = pointers.map(pointer => createObject(pointer, moreElement.more))
-                console.log("VALUES", values)
-                console.log("MANY", pointers.many)
+                debug("VALUES", values)
+                debug("MANY", pointers.many)
                 if(pointers.many) {
                   data[i][moreElement.to] = values
                 } else {
@@ -148,7 +150,8 @@ async function live(api, path, onUnmountedCb) {
               }
               const propSources = prop.sources
               for(const propSource of propSources) {
-                //console.log("PROP SOURCE DISPOSE", propSource)
+                debug("PROP SOURCE DISPOSE", propSource)
+                debug("UNOBSERVE PROPERTY", what, object, property)
                 propSource.observable.unobserve(propSource.observer)
               }
             }
@@ -166,6 +169,7 @@ async function live(api, path, onUnmountedCb) {
           what,
           property,
           dispose() {
+            debug("UNBIND PROPERTY", what, object, property)
             extendedObservable.unbindProperty(object, property)
           }
         }
@@ -174,14 +178,20 @@ async function live(api, path, onUnmountedCb) {
         return {
           what, property,
           dispose() {
+            debug("UNBIND PROPERTY", what, object, property)
             observable.unbindProperty(object, property)
           }
         }
       }
     }
     const resultRef = ref()
-    bindResult(path.what, path.more, resultRef, 'value')
-    /// TODO: unobserve on unmounted
+    const bound = bindResult(path.what, path.more, resultRef, 'value')
+    const pathsObserver = (signal, value) => {}
+    preFetchPaths.observe(pathsObserver)
+    onUnmountedCb(() => {
+      preFetchPaths.unobserve(pathsObserver)
+      bound.dispose()
+    })
     await preFetchPaths.wait()
     while(unref(resultRef) === undefined) { // wait for next tick
       await new Promise((resolve) => setTimeout(resolve, 0))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@live-change/dao-vue3",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "author": {
     "email": "m8@em8.pl",
     "name": "Michał Łaszczewski",
@@ -10,7 +10,7 @@
     "url": "https://github.com/live-change/dao-vue3/issues"
   },
   "dependencies": {
-    "@live-change/dao": "^0.3.9"
+    "@live-change/dao": "^0.3.15"
   },
   "devDependencies": {},
   "description": "Vue.js integration for live-change dao",