@live-change/access-control-service 0.8.33 → 0.8.35

package/access.js

@@ -17,7 +17,7 @@ export default (definition) => {
   } = config
 
   function testRoles(requiredRoles, clientRoles) {
-    if(!requiredRoles || requiredRoles.length == 0) return true
+    if(!requiredRoles || requiredRoles.length === 0) return true
     for(const requiredRolesOption of requiredRoles) {
       if(
         (Array.isArray(requiredRolesOption) ? requiredRolesOption : [requiredRolesOption])
@@ -104,6 +104,7 @@ export default (definition) => {
   async function checkRoles(client, { objectType, object, objects }, callback, ignorePublic) {
     const allObjects = ((objectType && object) ? [{ objectType, object }] : []).concat(objects || [])
     const roles = await getClientObjectsRoles(client, allObjects, ignorePublic)
+    console.log('checkRoles', allObjects, roles)
     return await callback(roles, client, { objectType, object })
   }
 
@@ -267,9 +268,9 @@ export default (definition) => {
               id: outputObjectId,
               roles: Array.from(new Set([...nodeRoles, ...client.roles]))
             }
-            const existingAccessIndex = accesses.findIndex(acc => acc.id == outputObjectId)
-            if(existingAccessIndex != -1) {
-              if(JSON.stringify(outputObject) != JSON.stringify(accesses[existingAccessIndex])) {
+            const existingAccessIndex = accesses.findIndex(acc => acc.id === outputObjectId)
+            if(existingAccessIndex !== -1) {
+              if(JSON.stringify(outputObject) !== JSON.stringify(accesses[existingAccessIndex])) {
                 output.change(outputObject, accesses[existingAccessIndex])
                 accesses[existingAccessIndex] = outputObject
               } /// else ignore
@@ -298,8 +299,8 @@ export default (definition) => {
   }
 
   function accessLimitedObservable(client, objects, path) {
-    if(path[0] != 'database') throw new Error("non database path "+ JSON.stringify(path))
-    const isObject = path[1] == 'queryObject' || path[1] == ''
+    if(path[0] !== 'database') throw new Error("non database path "+ JSON.stringify(path))
+    const isObject = path[1] === 'queryObject' || path[1] === ''
   }
 
   return {

package/accessControl.js

@@ -14,6 +14,7 @@ definition.processor({
       const action = service.actions[actionName]
       if(!action.accessControl) continue
       const config = action.accessControl
+      if(config.public) continue
 
       console.log("ACCESS CONTROL", service.name, "ACTION", action.name)
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@live-change/access-control-service",
-  "version": "0.8.33",
+  "version": "0.8.35",
   "description": "",
   "main": "index.js",
   "scripts": {
@@ -21,8 +21,8 @@
     "url": "https://www.viamage.com/"
   },
   "dependencies": {
-    "@live-change/framework": "^0.8.33"
+    "@live-change/framework": "^0.8.35"
   },
-  "gitHead": "98ff6f9c09e5fc1f408010df6cc8038eff571276",
+  "gitHead": "90fbb746dc7270895daf17b437ca48c0b0a01c01",
   "type": "module"
 }