@lion/ui 0.18.0-menu-system.6 → 0.18.0

package/collapsible.js

@@ -1,2 +1 @@
 export { LionCollapsible } from './components/collapsible/src/LionCollapsible.js';
-// export { DisclosureMixin } from '../components/collapsible/src/DisclosureMixin.js';

package/components/button/src/LionButton.js

@@ -220,8 +220,4 @@ export class LionButton extends DisabledWithTabIndexMixin(LitElement) {
       this.click();
     }
   }
-
-  // we want to be able to identify LionButtons w/o instanceof (for perf (loose dep) and dual version support),
-  // so we use a static property for that that doesn't get renamed by minifiers
-  static ['_$isLionButton$'] = true;
 }

package/components/button/test-suites/LionButton.suite.js

@@ -279,7 +279,6 @@ export function LionButtonSuite({ klass = LionButton } = {}) {
 
         sameProperties.forEach(property => {
           it(`has same value of the property "${property}" as in native button event`, () => {
-            // @ts-ignore - dynamic property access
             expect(lionButtonEvent[property]).to.equal(nativeButtonEvent[property]);
           });
         });

package/components/calendar/src/LionCalendar.js

@@ -257,7 +257,7 @@ export class LionCalendar extends LocalizeMixin(LitElement) {
       this.shadowRoot?.querySelector('#js-content-wrapper')
     );
     const button = /** @type {HTMLElement} */ (datesTable.querySelector('[tabindex="0"]'));
-    button.focus();
+    button?.focus();
     this.__focusedDate = this.centralDate;
   }
 
@@ -928,7 +928,6 @@ export class LionCalendar extends LocalizeMixin(LitElement) {
     if (type !== 'Date') {
       tmpDate.setDate(1);
     }
-    // @ts-ignore - dynamic method access
     tmpDate[`set${type}`](tmpDate[`get${type}`]() + modify);
     // if we've reset the day count,
     // restore day count as best we can
@@ -936,7 +935,6 @@ export class LionCalendar extends LocalizeMixin(LitElement) {
       const maxDays = new Date(tmpDate.getFullYear(), tmpDate.getMonth() + 1, 0).getDate();
       tmpDate.setDate(Math.min(this.centralDate.getDate(), maxDays));
     }
-    // @ts-ignore - dynamic property access
     this[dateType] = tmpDate;
   }
 

package/components/combobox/test/lion-combobox.test.js

@@ -3227,7 +3227,6 @@ describe('lion-combobox', () => {
         const [el, options] = await fruitFixture({ autocomplete: 'both', matchMode: 'all' });
         await mimicUserTyping(/** @type {LionCombobox} */ (el), 'choke');
         await el.updateComplete;
-        // @ts-ignore - array index access
         const labelledElement = options[0].querySelector('span[aria-label="Artichoke"]');
         expect(labelledElement).to.not.be.null;
         expect(labelledElement.innerText).to.equal('Artichoke');

package/components/form-core/src/form-group/FormGroupMixin.js

@@ -352,14 +352,11 @@ const FormGroupMixinImplementation = superclass =>
       this.formElements._keys().forEach(name => {
         const elem = this.formElements[name];
         if (elem instanceof FormControlsCollection) {
-          // @ts-ignore - dynamic property access
           result[name] = elem.filter(el => _filterFn(el, property)).map(el => el[property]);
         } else if (_filterFn(elem, property)) {
           if (typeof elem._getFromAllFormElements === 'function') {
-            // @ts-ignore - dynamic property access
             result[name] = elem._getFromAllFormElements(property);
           } else {
-            // @ts-ignore - dynamic property access
             result[name] = elem[property];
           }
         }
@@ -389,7 +386,6 @@ const FormGroupMixinImplementation = superclass =>
           if (Array.isArray(this.formElements[name])) {
             this.formElements[name].forEach(
               (/** @type {FormControl} */ el, /** @type {number} */ index) => {
-                // @ts-ignore - dynamic property access
                 el[property] = values[name][index]; // eslint-disable-line no-param-reassign
               },
             );
@@ -397,7 +393,6 @@ const FormGroupMixinImplementation = superclass =>
           if (this.formElements[name]) {
             this.formElements[name][property] = values[name];
           } else {
-            // @ts-ignore - dynamic property access
             this.__pendingValues[property][name] = values[name];
           }
         });
@@ -411,7 +406,6 @@ const FormGroupMixinImplementation = superclass =>
     _anyFormElementHas(property) {
       return Object.keys(this.formElements).some(name => {
         if (Array.isArray(this.formElements[name])) {
-          // @ts-ignore - dynamic property access
           return this.formElements[name].some((/** @type {FormControl} */ el) => !!el[property]);
         }
         return !!this.formElements[name][property];
@@ -442,7 +436,6 @@ const FormGroupMixinImplementation = superclass =>
     _everyFormElementHas(property) {
       return Object.keys(this.formElements).every(name => {
         if (Array.isArray(this.formElements[name])) {
-          // @ts-ignore - dynamic property access
           return this.formElements[name].every((/** @type {FormControl} */ el) => !!el[property]);
         }
         return !!this.formElements[name][property];

package/components/form-core/src/registration/FormRegistrarMixin.js

@@ -162,21 +162,15 @@ const FormRegistrarMixinImplementation = superclass =>
         }
 
         if (name.substr(-2) === '[]') {
-          // @ts-ignore - dynamic named access to form elements
           if (!Array.isArray(this.formElements[name])) {
-            // @ts-ignore
             this.formElements[name] = new FormControlsCollection();
           }
           if (indexToInsertAt > 0) {
-            // @ts-ignore
             this.formElements[name].splice(indexToInsertAt, 0, child);
           } else {
-            // @ts-ignore
             this.formElements[name].push(child);
           }
-          // @ts-ignore
         } else if (!this.formElements[name]) {
-          // @ts-ignore
           this.formElements[name] = child;
         } else {
           console.info('Error Node:', child); // eslint-disable-line no-console
@@ -200,17 +194,12 @@ const FormRegistrarMixinImplementation = superclass =>
       // 2. Handle name based object keys
       if (this._isFormOrFieldset) {
         const { name } = child; // FIXME: <-- ElementWithParentFormGroup should become LionFieldWithParentFormGroup so that "name" exists
-        // @ts-ignore - dynamic named access to form elements
         if (name.substr(-2) === '[]' && this.formElements[name]) {
-          // @ts-ignore
           const idx = this.formElements[name].indexOf(child);
           if (idx > -1) {
-            // @ts-ignore
             this.formElements[name].splice(idx, 1);
           }
-          // @ts-ignore
         } else if (this.formElements[name]) {
-          // @ts-ignore
           delete this.formElements[name];
         }
       }

package/components/form-core/test/FormControlMixin.test.js

@@ -153,7 +153,6 @@ describe('FormControlMixin', () => {
         el.shadowRoot?.querySelector('.form-field__label'),
       );
       Object.entries(expectedValues).forEach(([key, val]) => {
-        // @ts-ignore - dynamic style property access
         expect(labelStyle[key]).to.equal(val);
       });
     });

package/components/form-core/test/validate/Validator.test.js

@@ -191,9 +191,7 @@ describe('Validator', () => {
   it('adds static ["_$isValidator$"] property as a marker to identify the Validator class across different lion versions (as instanceof cannot be used)', async () => {
     const myValidator = new Validator();
 
-    // @ts-ignore - static property access
     expect(myValidator.constructor['_$isValidator$']).to.exist;
-    // @ts-ignore - static property access
     expect(myValidator.constructor['_$isValidator$']).to.be.true;
   });
 

package/components/form-core/test-suites/ValidateMixin.suite.js

@@ -1554,13 +1554,11 @@ export function runValidateMixinSuite(customConfig) {
           // eslint-disable-next-line no-restricted-syntax
           for (const state of ['dirty', 'touched', 'prefilled', 'submitted']) {
             counter += 1;
-            // @ts-ignore - test property access
             el[state] = false;
             // eslint-disable-next-line no-await-in-loop
             await el.updateComplete;
             expect(spy.callCount).to.equal(counter);
             counter += 1;
-            // @ts-ignore - test property access
             el[state] = true;
             // eslint-disable-next-line no-await-in-loop
             await el.updateComplete;

package/components/form-core/test-suites/ValidateMixinFeedbackPart.suite.js

@@ -714,7 +714,6 @@ export function runValidateMixinFeedbackPart() {
             const results = {
               'a-string-instead-of-bool': 'Msg based on enum output',
             };
-            // @ts-ignore - test data structure
             return results[/** @type {string} */ (outcome)];
           }
         }

package/components/input-datepicker/src/localizeNamespaceLoader.js

@@ -6,7 +6,6 @@ async function combineLocalizeImports(importPromises) {
   const combinedResult = localizeObjects[0];
   for (const localizeObject of localizeObjects.slice(1)) {
     Object.entries(localizeObject.default).forEach(([key, val]) => {
-      // @ts-ignore - dynamic property access
       combinedResult.default[key] = val;
     });
   }

package/components/input-datepicker/test/lion-input-datepicker.test.js

@@ -597,11 +597,12 @@ describe('<lion-input-datepicker>', () => {
         <lion-input-datepicker label="End date" name="endDate"></lion-input-datepicker>
       `);
 
-      const elements = el.parentElement?.children;
-      // @ts-ignore - accessing by name property
-      const startLabel = elements?.startDate?.querySelector('button')?.ariaLabel;
-      // @ts-ignore - accessing by name property
-      const endLabel = elements?.endDate?.querySelector('button')?.ariaLabel;
+      // @ts-expect-error
+      const elements = el.parentElement.children;
+      // @ts-expect-error
+      const startLabel = elements.startDate.querySelector('button').ariaLabel;
+      // @ts-expect-error
+      const endLabel = elements.endDate.querySelector('button').ariaLabel;
 
       expect(startLabel).to.not.equal(endLabel);
     });

package/components/listbox/test-suites/ListboxMixin.suite.js

@@ -17,7 +17,6 @@ import {
 import { sendKeys } from '@web/test-runner-commands';
 import sinon from 'sinon';
 import { getListboxMembers } from '../../../exports/listbox-test-helpers.js';
-import { browserDetection } from '../../core/src/browserDetection.js';
 import { getCachedFixture } from '../../core/test-helpers/getCachedFixture.js';
 
 /**
@@ -383,12 +382,7 @@ export function runListboxMixinSuite(customConfig = {}) {
         await aTimeout(1000);
 
         // top should be offset 2x40px (sticky header elems) instead of 0px
-        if (browserDetection.isChrome || browserDetection.isChromium) {
-          // TODO: find out why this is different in recent Chromium
-          expect(el.scrollTop).to.equal(160);
-        } else {
-          expect(el.scrollTop).to.equal(116);
-        }
+        expect(el.scrollTop).to.equal(116);
       });
     });
 

package/components/localize/src/date/utils/normalizeIntlDate.js

@@ -31,9 +31,8 @@ export function normalizeIntlDate(str, locale = '', { weekday, year, month, day
       'zh-Hans-HK',
       'zh-Hans-MO',
       'zh-Hans-SG',
-      // Skip 'zh-Hant' and 'zh-Hant-TW', since webkit/firefox/chromium are aligned.
-      // 'zh-Hant',
-      // 'zh-Hant-TW',
+      'zh-Hant',
+      'zh-Hant-TW',
       'zh-Hant-HK',
       'zh-Hant-MO',
     ];

package/components/localize/test/date/formatDate.test.js

@@ -194,10 +194,10 @@ describe('formatDate', () => {
       'zh-Hans-HK': '10月12日星期六',
       'zh-Hans-MO': '10月12日星期六',
       'zh-Hans-SG': '10月12日星期六',
-      'zh-Hant': '10月12日 星期六',
+      'zh-Hant': '10月12日星期六', // '10月12日 星期六',
       'zh-Hant-HK': '10月12日星期六',
       'zh-Hant-MO': '10月12日星期六',
-      'zh-Hant-TW': '10月12日 星期六',
+      'zh-Hant-TW': '10月12日星期六', // '10月12日 星期六',
     };
 
     Object.keys(SUPPORTED_LOCALES).forEach(locale => {
@@ -210,7 +210,6 @@ describe('formatDate', () => {
           locale,
         };
         const parsedDate = /** @type {Date} */ (parseDate('12.10.2019'));
-        // @ts-ignore - dynamic locale key access
         expect(formatDate(parsedDate, options)).to.equal(LOCALE_FORMATTED_DATE_MAP[locale]);
       });
     });