@lion/ui 0.16.0-alpha.0 → 0.16.1

package/components/overlays/src/OverlayController.js

@@ -911,7 +911,7 @@ export class OverlayController extends EventTarget {
       this.contentNode.getRootNode()
     ).activeElement;
 
-    if (this.manager) {
+    if (this.manager && this.#isRegisteredOnManager()) {
       this.manager.hide(this);
     }
 

package/components/overlays/src/OverlaysManager.js

@@ -46,8 +46,8 @@ export class OverlaysManager {
      * @private
      */
     this.__shownList = [];
-    /** @private */
-    this.__siblingsInert = false;
+    /** @protected */
+    this._siblingsInert = false;
     /**
      * @type {WeakMap<OverlayController, OverlayController[]>}
      * @private
@@ -118,7 +118,7 @@ export class OverlaysManager {
 
     this.__list = [];
     this.__shownList = [];
-    this.__siblingsInert = false;
+    this._siblingsInert = false;
 
     if (OverlaysManager.__globalStyleNode) {
       document.head.removeChild(
@@ -131,7 +131,7 @@ export class OverlaysManager {
   /** Features right now only for Global Overlay Manager */
 
   get siblingsInert() {
-    return this.__siblingsInert;
+    return this._siblingsInert;
   }
 
   /** PreventsScroll */

package/components/overlays/test/OverlayController.test.js

@@ -310,6 +310,42 @@ describe('OverlayController', () => {
 
       expect(isRegisteredOnManager(ctrl)).to.be.false;
     });
+
+    it('handles removal from DOM gracefully when overlay is open', async () => {
+      const contentNode = /** @type {HTMLElement} */ (fixtureSync(html`<div>my content</div>`));
+      const ctrl = new OverlayController({
+        placementMode: 'global',
+        contentNode,
+      });
+      await ctrl.show();
+      expect(ctrl.isShown).to.be.true;
+      expect(isRegisteredOnManager(ctrl)).to.be.true;
+
+      // Remove contentNode from DOM (simulates element being removed while open)
+      contentNode.parentElement?.removeChild(contentNode);
+
+      // Manually trigger teardown (normally happens via disconnectedCallback in OverlayMixin)
+      ctrl.teardown();
+
+      // Teardown should complete without errors
+      expect(isRegisteredOnManager(ctrl)).to.be.false;
+    });
+
+    it('does not throw when hide() is called after teardown() on a shown controller', async () => {
+      const ctrl = new OverlayController({
+        ...withGlobalTestConfig(),
+      });
+      await ctrl.show();
+      expect(ctrl.isShown).to.be.true;
+
+      // teardown removes the controller from the manager
+      ctrl.teardown();
+      expect(isRegisteredOnManager(ctrl)).to.be.false;
+
+      // hide() should handle gracefully that the controller is no longer on the manager
+      await ctrl.hide();
+      expect(ctrl.isShown).to.be.false;
+    });
   });
 
   describe('Node Configuration', () => {

package/components/overlays/test/OverlaysManager.test.js

@@ -46,7 +46,7 @@ describe('OverlaysManager', () => {
     // @ts-ignore [allow-private-in-test]
     expect(mngr.__shownList).to.be.empty;
     // @ts-ignore [allow-private-in-test]
-    expect(mngr.__siblingsInert).to.be.false;
+    expect(mngr._siblingsInert).to.be.false;
   });
 
   it('can add/remove controllers', () => {

package/components/overlays/test-suites/OverlayMixin.suite.js

@@ -597,6 +597,64 @@ export function runOverlayMixinSuite({ tagString, tag, suffix = '' }) {
         expect(isCtrlRegisteredAtOverlaysManager).to.equal(true);
       });
 
+      it('teardown completes successfully when open overlay is removed from DOM', async () => {
+        const el = /** @type {OverlayEl} */ (
+          await fixture(html`
+          <${tag}>
+            <div slot="content">content of the overlay</div>
+            <button slot="invoker">invoker button</button>
+          </${tag}>
+        `)
+        );
+
+        // 1. Open the overlay
+        el.opened = true;
+        await el.updateComplete;
+        await el._overlayCtrl._showComplete;
+        expect(el._overlayCtrl.isShown).to.be.true;
+
+        // 2. Remove element from DOM without closing
+        /** @type {HTMLElement} */ (el.parentNode).removeChild(el);
+
+        // 3. Wait for _isPermanentlyDisconnected to resolve and teardown to complete
+        await aTimeout(0);
+
+        // 4. Teardown should complete without errors
+        // The controller should no longer be registered
+        expect(el._overlayCtrl.manager.list.find(ctrl => ctrl === el._overlayCtrl)).to.be.undefined;
+      });
+
+      it('does not throw when element is removed from DOM while overlay is open', async () => {
+        const el = /** @type {OverlayEl} */ (
+          await fixture(html`
+          <${tag}>
+            <div slot="content">content of the overlay</div>
+            <button slot="invoker">invoker button</button>
+          </${tag}>
+        `)
+        );
+
+        // 1. Open the overlay
+        el.opened = true;
+        await el.updateComplete;
+        await el._overlayCtrl._showComplete;
+        expect(el._overlayCtrl.isShown).to.be.true;
+
+        // 2. Store reference to the controller before removal
+        const ctrl = el._overlayCtrl;
+
+        // 3. Remove element from DOM without closing the overlay
+        /** @type {HTMLElement} */ (el.parentNode).removeChild(el);
+
+        // 4. Wait for _isPermanentlyDisconnected to resolve and teardown to complete
+        await aTimeout(0);
+
+        // 5. Teardown removed the controller from the manager.
+        //    hide() should handle this gracefully without throwing.
+        await ctrl.hide();
+        expect(ctrl.isShown).to.be.false;
+      });
+
       it('correctly removes event listeners when disconnected from dom', async () => {
         const el = /** @type {OverlayEl} */ (
           await fixture(html`

package/custom-elements.json

@@ -2158,6 +2158,36 @@
         }
       ]
     },
+    {
+      "kind": "javascript-module",
+      "path": "exports/define-helpers/sb-action-logger.js",
+      "declarations": [],
+      "exports": [
+        {
+          "kind": "custom-element-definition",
+          "name": "sb-action-logger",
+          "declaration": {
+            "name": "SbActionLogger",
+            "module": "/exports/helpers.js"
+          }
+        }
+      ]
+    },
+    {
+      "kind": "javascript-module",
+      "path": "exports/define-helpers/sb-locale-switcher.js",
+      "declarations": [],
+      "exports": [
+        {
+          "kind": "custom-element-definition",
+          "name": "sb-locale-switcher",
+          "declaration": {
+            "name": "SbLocaleSwitcher",
+            "module": "/exports/helpers.js"
+          }
+        }
+      ]
+    },
     {
       "kind": "javascript-module",
       "path": "exports/define/lion-accordion.js",
@@ -2863,36 +2893,6 @@
         }
       ]
     },
-    {
-      "kind": "javascript-module",
-      "path": "exports/define-helpers/sb-action-logger.js",
-      "declarations": [],
-      "exports": [
-        {
-          "kind": "custom-element-definition",
-          "name": "sb-action-logger",
-          "declaration": {
-            "name": "SbActionLogger",
-            "module": "/exports/helpers.js"
-          }
-        }
-      ]
-    },
-    {
-      "kind": "javascript-module",
-      "path": "exports/define-helpers/sb-locale-switcher.js",
-      "declarations": [],
-      "exports": [
-        {
-          "kind": "custom-element-definition",
-          "name": "sb-locale-switcher",
-          "declaration": {
-            "name": "SbLocaleSwitcher",
-            "module": "/exports/helpers.js"
-          }
-        }
-      ]
-    },
     {
       "kind": "javascript-module",
       "path": "components/accordion/src/LionAccordion.js",
@@ -122788,6 +122788,15 @@
               "name": "teardown",
               "privacy": "public"
             },
+            {
+              "kind": "field",
+              "name": "_siblingsInert",
+              "type": {
+                "text": "boolean"
+              },
+              "privacy": "protected",
+              "default": "false"
+            },
             {
               "kind": "field",
               "name": "__blockingMap",
@@ -122820,15 +122829,6 @@
               },
               "privacy": "private",
               "default": "[]"
-            },
-            {
-              "kind": "field",
-              "name": "__siblingsInert",
-              "type": {
-                "text": "boolean"
-              },
-              "privacy": "private",
-              "default": "false"
             }
           ]
         }

package/dist-types/components/overlays/src/OverlaysManager.d.ts

@@ -23,8 +23,8 @@ export class OverlaysManager {
      * @private
      */
     private __shownList;
-    /** @private */
-    private __siblingsInert;
+    /** @protected */
+    protected _siblingsInert: boolean;
     /**
      * @type {WeakMap<OverlayController, OverlayController[]>}
      * @private

package/dist-types/components/overlays/src/OverlaysManager.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"OverlaysManager.d.ts","sourceRoot":"","sources":["../../../../components/overlays/src/OverlaysManager.js"],"names":[],"mappings":"AASA;;GAEG;AACH;IACE,mDAMC;IAED;;;OAGG;IACH,iEAEC;IAED;;;OAGG;IACH,sEAEC;IAGC;;;OAGG;IACH,eAAgB;IAChB;;;OAGG;IACH,oBAAqB;IACrB,eAAe;IACf,wBAA4B;IAC5B;;;OAGG;IACH,sBAAkC;IAOpC;;;;OAIG;IACH,eAHW,iBAAiB,GACf,iBAAiB,CAQ7B;IAED;;OAEG;IACH,qBAFW,iBAAiB,QAQ3B;IAED;;OAEG;IACH,iBAFW,iBAAiB,QAe3B;IAED;;OAEG;IACH,iBAFW,GAAG,QAOb;IAED,iBAeC;IAED,yDAAyD;IAEzD,6BAEC;IAED,qBAAqB;IAGrB,+BAYC;IAED;;OAEG;IACH,gHAoBC;IAED;;;OAGG;IACH,gCAFW,iBAAiB,QAM3B;IAED;;OAEG;IACH,uCAFW,iBAAiB,QAS3B;CACF;;6BAEU,gBAAgB,GAAG,SAAS;;wBAtM1B,OAAO,KAAK,EAAE,SAAS;gCACvB,OAAO,wBAAwB,EAAE,iBAAiB"}
+{"version":3,"file":"OverlaysManager.d.ts","sourceRoot":"","sources":["../../../../components/overlays/src/OverlaysManager.js"],"names":[],"mappings":"AASA;;GAEG;AACH;IACE,mDAMC;IAED;;;OAGG;IACH,iEAEC;IAED;;;OAGG;IACH,sEAEC;IAGC;;;OAGG;IACH,eAAgB;IAChB;;;OAGG;IACH,oBAAqB;IACrB,iBAAiB;IACjB,kCAA2B;IAC3B;;;OAGG;IACH,sBAAkC;IAOpC;;;;OAIG;IACH,eAHW,iBAAiB,GACf,iBAAiB,CAQ7B;IAED;;OAEG;IACH,qBAFW,iBAAiB,QAQ3B;IAED;;OAEG;IACH,iBAFW,iBAAiB,QAe3B;IAED;;OAEG;IACH,iBAFW,GAAG,QAOb;IAED,iBAeC;IAED,yDAAyD;IAEzD,6BAEC;IAED,qBAAqB;IAGrB,+BAYC;IAED;;OAEG;IACH,gHAoBC;IAED;;;OAGG;IACH,gCAFW,iBAAiB,QAM3B;IAED;;OAEG;IACH,uCAFW,iBAAiB,QAS3B;CACF;;6BAEU,gBAAgB,GAAG,SAAS;;wBAtM1B,OAAO,KAAK,EAAE,SAAS;gCACvB,OAAO,wBAAwB,EAAE,iBAAiB"}

package/dist-types/components/overlays/test-suites/OverlayMixin.suite.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"OverlayMixin.suite.d.ts","sourceRoot":"","sources":["../../../../components/overlays/test-suites/OverlayMixin.suite.js"],"names":[],"mappings":"AAwDA;;GAEG;AACH,iEAFW;IAAC,SAAS,EAAC,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,MAAM,CAAC,EAAC,MAAM,CAAA;CAAC,QAwqBzD;kCA9sBY,OAAO,+BAA+B,EAAE,mBAAmB;wBAC3D,UAAU,GAAG,WAAW,GAAG;IAAC,YAAY,EAAC,iBAAiB,CAAA;CAAC;2BAC3D,OAAO,+BAA+B,EAAE,YAAY;0BACpD,OAAO,+BAA+B,EAAE,WAAW;4BACnD,OAAO,2BAA2B,EAAE,aAAa"}
+{"version":3,"file":"OverlayMixin.suite.d.ts","sourceRoot":"","sources":["../../../../components/overlays/test-suites/OverlayMixin.suite.js"],"names":[],"mappings":"AAwDA;;GAEG;AACH,iEAFW;IAAC,SAAS,EAAC,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,MAAM,CAAC,EAAC,MAAM,CAAA;CAAC,QAkuBzD;kCAxwBY,OAAO,+BAA+B,EAAE,mBAAmB;wBAC3D,UAAU,GAAG,WAAW,GAAG;IAAC,YAAY,EAAC,iBAAiB,CAAA;CAAC;2BAC3D,OAAO,+BAA+B,EAAE,YAAY;0BACpD,OAAO,+BAA+B,EAAE,WAAW;4BACnD,OAAO,2BAA2B,EAAE,aAAa"}