@lion/ui 0.16.0-alpha.0 → 0.16.0

package/components/overlays/src/OverlayController.js

@@ -911,7 +911,7 @@ export class OverlayController extends EventTarget {
       this.contentNode.getRootNode()
     ).activeElement;
 
-    if (this.manager) {
+    if (this.manager && this.#isRegisteredOnManager()) {
       this.manager.hide(this);
     }
 

package/components/overlays/test/OverlayController.test.js

@@ -310,6 +310,42 @@ describe('OverlayController', () => {
 
       expect(isRegisteredOnManager(ctrl)).to.be.false;
     });
+
+    it('handles removal from DOM gracefully when overlay is open', async () => {
+      const contentNode = /** @type {HTMLElement} */ (fixtureSync(html`<div>my content</div>`));
+      const ctrl = new OverlayController({
+        placementMode: 'global',
+        contentNode,
+      });
+      await ctrl.show();
+      expect(ctrl.isShown).to.be.true;
+      expect(isRegisteredOnManager(ctrl)).to.be.true;
+
+      // Remove contentNode from DOM (simulates element being removed while open)
+      contentNode.parentElement?.removeChild(contentNode);
+
+      // Manually trigger teardown (normally happens via disconnectedCallback in OverlayMixin)
+      ctrl.teardown();
+
+      // Teardown should complete without errors
+      expect(isRegisteredOnManager(ctrl)).to.be.false;
+    });
+
+    it('does not throw when hide() is called after teardown() on a shown controller', async () => {
+      const ctrl = new OverlayController({
+        ...withGlobalTestConfig(),
+      });
+      await ctrl.show();
+      expect(ctrl.isShown).to.be.true;
+
+      // teardown removes the controller from the manager
+      ctrl.teardown();
+      expect(isRegisteredOnManager(ctrl)).to.be.false;
+
+      // hide() should handle gracefully that the controller is no longer on the manager
+      await ctrl.hide();
+      expect(ctrl.isShown).to.be.false;
+    });
   });
 
   describe('Node Configuration', () => {

package/components/overlays/test-suites/OverlayMixin.suite.js

@@ -597,6 +597,64 @@ export function runOverlayMixinSuite({ tagString, tag, suffix = '' }) {
         expect(isCtrlRegisteredAtOverlaysManager).to.equal(true);
       });
 
+      it('teardown completes successfully when open overlay is removed from DOM', async () => {
+        const el = /** @type {OverlayEl} */ (
+          await fixture(html`
+          <${tag}>
+            <div slot="content">content of the overlay</div>
+            <button slot="invoker">invoker button</button>
+          </${tag}>
+        `)
+        );
+
+        // 1. Open the overlay
+        el.opened = true;
+        await el.updateComplete;
+        await el._overlayCtrl._showComplete;
+        expect(el._overlayCtrl.isShown).to.be.true;
+
+        // 2. Remove element from DOM without closing
+        /** @type {HTMLElement} */ (el.parentNode).removeChild(el);
+
+        // 3. Wait for _isPermanentlyDisconnected to resolve and teardown to complete
+        await aTimeout(0);
+
+        // 4. Teardown should complete without errors
+        // The controller should no longer be registered
+        expect(el._overlayCtrl.manager.list.find(ctrl => ctrl === el._overlayCtrl)).to.be.undefined;
+      });
+
+      it('does not throw when element is removed from DOM while overlay is open', async () => {
+        const el = /** @type {OverlayEl} */ (
+          await fixture(html`
+          <${tag}>
+            <div slot="content">content of the overlay</div>
+            <button slot="invoker">invoker button</button>
+          </${tag}>
+        `)
+        );
+
+        // 1. Open the overlay
+        el.opened = true;
+        await el.updateComplete;
+        await el._overlayCtrl._showComplete;
+        expect(el._overlayCtrl.isShown).to.be.true;
+
+        // 2. Store reference to the controller before removal
+        const ctrl = el._overlayCtrl;
+
+        // 3. Remove element from DOM without closing the overlay
+        /** @type {HTMLElement} */ (el.parentNode).removeChild(el);
+
+        // 4. Wait for _isPermanentlyDisconnected to resolve and teardown to complete
+        await aTimeout(0);
+
+        // 5. Teardown removed the controller from the manager.
+        //    hide() should handle this gracefully without throwing.
+        await ctrl.hide();
+        expect(ctrl.isShown).to.be.false;
+      });
+
       it('correctly removes event listeners when disconnected from dom', async () => {
         const el = /** @type {OverlayEl} */ (
           await fixture(html`

package/dist-types/components/overlays/test-suites/OverlayMixin.suite.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"OverlayMixin.suite.d.ts","sourceRoot":"","sources":["../../../../components/overlays/test-suites/OverlayMixin.suite.js"],"names":[],"mappings":"AAwDA;;GAEG;AACH,iEAFW;IAAC,SAAS,EAAC,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,MAAM,CAAC,EAAC,MAAM,CAAA;CAAC,QAwqBzD;kCA9sBY,OAAO,+BAA+B,EAAE,mBAAmB;wBAC3D,UAAU,GAAG,WAAW,GAAG;IAAC,YAAY,EAAC,iBAAiB,CAAA;CAAC;2BAC3D,OAAO,+BAA+B,EAAE,YAAY;0BACpD,OAAO,+BAA+B,EAAE,WAAW;4BACnD,OAAO,2BAA2B,EAAE,aAAa"}
+{"version":3,"file":"OverlayMixin.suite.d.ts","sourceRoot":"","sources":["../../../../components/overlays/test-suites/OverlayMixin.suite.js"],"names":[],"mappings":"AAwDA;;GAEG;AACH,iEAFW;IAAC,SAAS,EAAC,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,MAAM,CAAC,EAAC,MAAM,CAAA;CAAC,QAkuBzD;kCAxwBY,OAAO,+BAA+B,EAAE,mBAAmB;wBAC3D,UAAU,GAAG,WAAW,GAAG;IAAC,YAAY,EAAC,iBAAiB,CAAA;CAAC;2BAC3D,OAAO,+BAA+B,EAAE,YAAY;0BACpD,OAAO,+BAA+B,EAAE,WAAW;4BACnD,OAAO,2BAA2B,EAAE,aAAa"}