@lion/ui 0.15.4 → 0.15.5

package/components/collapsible/src/LionCollapsible.js

@@ -54,12 +54,10 @@ export class LionCollapsible extends LitElement {
     if (this._invokerNode) {
       this._invokerNode.addEventListener('click', this.toggle);
       this._invokerNode.setAttribute('aria-expanded', `${this.opened}`);
-      this._invokerNode.setAttribute('id', `collapsible-invoker-${uid}`);
       this._invokerNode.setAttribute('aria-controls', `collapsible-content-${uid}`);
     }
 
     if (this._contentNode) {
-      this._contentNode.setAttribute('aria-labelledby', `collapsible-invoker-${uid}`);
       this._contentNode.setAttribute('id', `collapsible-content-${uid}`);
     }
 

package/components/collapsible/test/lion-collapsible.test.js

@@ -136,14 +136,5 @@ describe('<lion-collapsible>', () => {
         expect(invoker).to.have.attribute('aria-expanded', 'true');
       });
     });
-
-    describe('Contents', () => {
-      it('adds aria-labelledby referring to invoker id', async () => {
-        const collapsibleElement = await fixture(defaultCollapsible);
-        const invoker = collapsibleElement.querySelector('[slot=invoker]');
-        const content = collapsibleElement.querySelector('[slot=content]');
-        expect(content).to.have.attribute('aria-labelledby', invoker?.id);
-      });
-    });
   });
 });

package/components/core/test-helpers/ssr-definitions/ScopedElementsHost.define.js

@@ -0,0 +1 @@
+// ... empty file needed for '@lit-labs/testing/fixtures.js'

package/components/drawer/test/lion-drawer.test.js

@@ -96,14 +96,5 @@ describe('<lion-drawer>', () => {
         expect(invoker).to.have.attribute('aria-expanded', 'true');
       });
     });
-
-    describe('Contents', () => {
-      it('adds aria-labelledby referring to invoker id', async () => {
-        const drawerElement = await fixture(template);
-        const invoker = drawerElement.querySelector('[slot=invoker]');
-        const content = drawerElement.querySelector('[slot=content]');
-        expect(content).to.have.attribute('aria-labelledby', invoker?.id);
-      });
-    });
   });
 });

package/components/form-core/src/choice-group/ChoiceGroupMixin.js

@@ -1,6 +1,6 @@
 import { dedupeMixin } from '@open-wc/dedupe-mixin';
-import { FormRegistrarMixin } from '../registration/FormRegistrarMixin.js';
 import { InteractionStateMixin } from '../InteractionStateMixin.js';
+import { FormRegistrarMixin } from '../registration/FormRegistrarMixin.js';
 import { ValidateMixin } from '../validate/ValidateMixin.js';
 
 /**
@@ -260,7 +260,17 @@ const ChoiceGroupMixinImplementation = superclass =>
       ) {
         return this[property];
       }
-      return this.formElements.filter(el => _filterFn(el, property)).map(el => el.property);
+
+      // TODO: consider a shared approach for all value getters
+      const filteredFnElements = this.formElements.filter(el => _filterFn(el, property));
+
+      if (property === '_initialModelValue') {
+        return this.multipleChoice
+          ? filteredFnElements.filter(el => el[property].checked).map(el => el[property].value)
+          : filteredFnElements.find(el => el[property].checked)?.value;
+      }
+
+      return filteredFnElements.map(el => el[property]);
     }
 
     /**

package/components/form-core/test-suites/choice-group/ChoiceGroupMixin.suite.js

@@ -1,15 +1,15 @@
-import { LitElement } from 'lit';
-import '@lion/ui/define/lion-fieldset.js';
 import '@lion/ui/define/lion-checkbox-group.js';
 import '@lion/ui/define/lion-checkbox.js';
+import '@lion/ui/define/lion-fieldset.js';
 import {
-  FormGroupMixin,
-  Required,
   ChoiceGroupMixin,
   ChoiceInputMixin,
+  FormGroupMixin,
+  Required,
 } from '@lion/ui/form-core.js';
 import { LionInput } from '@lion/ui/input.js';
 import { expect, fixture, fixtureSync, html, unsafeStatic } from '@open-wc/testing';
+import { LitElement } from 'lit';
 import sinon from 'sinon';
 
 class ChoiceInputFoo extends ChoiceInputMixin(LionInput) {}
@@ -45,6 +45,28 @@ export function runChoiceGroupMixinSuite({ parentTagString, childTagString, choi
 
   describe(`ChoiceGroupMixin: ${cfg.parentTagString}`, () => {
     if (cfg.choiceType === 'single') {
+      it('has a single modelValue representing initial checked values', async () => {
+        const el = /** @type {ChoiceInputGroup} */ (
+          await fixture(html`
+          <${parentTag} name="gender[]">
+            <${childTag} .choiceValue=${'male'}></${childTag}>
+            <${childTag} .choiceValue=${'female'} checked></${childTag}>
+            <${childTag} .choiceValue=${'other'}></${childTag}>
+          </${parentTag}>
+        `)
+        );
+
+        // @ts-ignore protected members allowed in test
+        expect(el._initialModelValue).to.eql('female');
+        expect(el.modelValue).to.eql('female');
+
+        el.formElements[0].checked = true;
+
+        // @ts-ignore protected members allowed in test
+        expect(el._initialModelValue).to.eql('female');
+        expect(el.modelValue).to.eql('male');
+      });
+
       it('has a single modelValue representing the currently checked radio value', async () => {
         const el = /** @type {ChoiceInputGroup} */ (
           await fixture(html`
@@ -585,6 +607,28 @@ export function runChoiceGroupMixinSuite({ parentTagString, childTagString, choi
     });
 
     describe('multipleChoice', () => {
+      it('has multiple _initialModelValue representing initial checked values', async () => {
+        const el = /** @type {ChoiceInputGroup} */ (
+          await fixture(html`
+          <${parentTag} multiple-choice name="animals[]">
+            <${childTag} .choiceValue=${'dog'} checked></${childTag}>
+            <${childTag} .choiceValue=${'cat'} checked></${childTag}>
+            <${childTag} .choiceValue=${'lion'}></${childTag}>
+          </${parentTag}>
+        `)
+        );
+
+        // @ts-ignore protected members allowed in test
+        expect(el._initialModelValue).to.eql(['dog', 'cat']);
+        expect(el.modelValue).to.eql(['dog', 'cat']);
+
+        el.formElements[2].checked = true;
+
+        // @ts-ignore protected members allowed in test
+        expect(el._initialModelValue).to.eql(['dog', 'cat']);
+        expect(el.modelValue).to.eql(['dog', 'cat', 'lion']);
+      });
+
       it('has a single modelValue representing all currently checked values', async () => {
         const el = /** @type {ChoiceInputGroup} */ (
           await fixture(html`

package/components/input-tel/translations/es.js

@@ -1,5 +1,5 @@
 export default {
-  allCountries: 'Pays suggérés',
+  allCountries: 'Todos los países',
   phoneNumber: 'Número de teléfono',
   selectCountry: 'Seleccione país',
   suggestedCountries: 'Países sugeridos',

package/components/overlays/test/OverlayController.test.js

@@ -11,6 +11,7 @@ import {
   fixture,
   expect,
   html,
+  waitUntil,
 } from '@open-wc/testing';
 
 import { isActiveElement } from '../../core/test-helpers/isActiveElement.js';
@@ -815,8 +816,8 @@ describe('OverlayController', () => {
           // without this line, the test is unstable on FF sometimes
           await aTimeout(100);
 
-          expect(parentOverlay.isShown).to.be.false;
-          expect(childOverlay.isShown).to.be.true;
+          await waitUntil(() => !parentOverlay.isShown);
+          await waitUntil(() => childOverlay.isShown);
 
           await childOverlay.teardown();
           await parentOverlay.teardown();

package/dist-types/components/collapsible/src/LionCollapsible.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"LionCollapsible.d.ts","sourceRoot":"","sources":["../../../../components/collapsible/src/LionCollapsible.js"],"names":[],"mappings":"AAGA;;;;;;;GAOG;AACH;IACE,+CAYC;IAED;;;;;MAOC;IAED,+CAKC;IAIC,gBAAmB;IA8DrB;;;OAGG;IACH,sBAGC;IA3BD;;;OAGG;IACH,oBAIC;IAED;;;OAGG;IACH,oBAIC;IAWD;;;;OAIG;IAEH,+BAJW,MAAM,iBAIY;IAE7B;;;;OAIG;IAEH,+BAJW,MAAM,iBAIY;IAE7B;;OAEG;IACH,sDAIC;IAED;;OAEG;IACH,sDAIC;IAED;;OAEG;IACH,uCAGC;IAED;;;OAGG;IACH,wBAMC;IAED;;;OAGG;IACH,4BAUC;IAED;;;OAGG;IACH,0BAIC;CACF"}
+{"version":3,"file":"LionCollapsible.d.ts","sourceRoot":"","sources":["../../../../components/collapsible/src/LionCollapsible.js"],"names":[],"mappings":"AAGA;;;;;;;GAOG;AACH;IACE,+CAYC;IAED;;;;;MAOC;IAED,+CAKC;IAIC,gBAAmB;IA4DrB;;;OAGG;IACH,sBAGC;IA3BD;;;OAGG;IACH,oBAIC;IAED;;;OAGG;IACH,oBAIC;IAWD;;;;OAIG;IAEH,+BAJW,MAAM,iBAIY;IAE7B;;;;OAIG;IAEH,+BAJW,MAAM,iBAIY;IAE7B;;OAEG;IACH,sDAIC;IAED;;OAEG;IACH,sDAIC;IAED;;OAEG;IACH,uCAGC;IAED;;;OAGG;IACH,wBAMC;IAED;;;OAGG;IACH,4BAUC;IAED;;;OAGG;IACH,0BAIC;CACF"}

package/dist-types/components/core/test-helpers/ssr-definitions/ScopedElementsHost.define.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=ScopedElementsHost.define.d.ts.map

package/dist-types/components/core/test-helpers/ssr-definitions/ScopedElementsHost.define.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ScopedElementsHost.define.d.ts","sourceRoot":"","sources":["../../../../../components/core/test-helpers/ssr-definitions/ScopedElementsHost.define.js"],"names":[],"mappings":""}

package/dist-types/components/form-core/src/choice-group/ChoiceGroupMixin.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ChoiceGroupMixin.d.ts","sourceRoot":"","sources":["../../../../../components/form-core/src/choice-group/ChoiceGroupMixin.js"],"names":[],"mappings":"+BAMa,OAAO,mDAAmD,EAAE,gBAAgB;AAmZzF,4HAA4E;8BAlZ/D,OAAO,sCAAsC,EAAE,eAAe;yCAC9D,OAAO,qDAAqD,EAAE,0BAA0B;0BACxF,OAAO,+CAA+C,EAAE,WAAW;8BACnE,OAAO,mDAAmD,EAAE,eAAe;wBAC3E,OAAO,0BAA0B,EAAE,SAAS"}
+{"version":3,"file":"ChoiceGroupMixin.d.ts","sourceRoot":"","sources":["../../../../../components/form-core/src/choice-group/ChoiceGroupMixin.js"],"names":[],"mappings":"+BAMa,OAAO,mDAAmD,EAAE,gBAAgB;AA6ZzF,4HAA4E;8BA5Z/D,OAAO,sCAAsC,EAAE,eAAe;yCAC9D,OAAO,qDAAqD,EAAE,0BAA0B;0BACxF,OAAO,+CAA+C,EAAE,WAAW;8BACnE,OAAO,mDAAmD,EAAE,eAAe;wBAC3E,OAAO,0BAA0B,EAAE,SAAS"}

package/dist-types/components/form-core/test-suites/choice-group/ChoiceGroupMixin.suite.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ChoiceGroupMixin.suite.d.ts","sourceRoot":"","sources":["../../../../../components/form-core/test-suites/choice-group/ChoiceGroupMixin.suite.js"],"names":[],"mappings":"AA4BA;;GAEG;AACH,2FAFW;IAAE,eAAe,CAAC,EAAC,MAAM,CAAC;IAAC,cAAc,CAAC,EAAE,MAAM,CAAC;IAAC,UAAU,CAAC,EAAE,MAAM,CAAA;CAAC,QAktBlF"}
+{"version":3,"file":"ChoiceGroupMixin.suite.d.ts","sourceRoot":"","sources":["../../../../../components/form-core/test-suites/choice-group/ChoiceGroupMixin.suite.js"],"names":[],"mappings":"AA4BA;;GAEG;AACH,2FAFW;IAAE,eAAe,CAAC,EAAC,MAAM,CAAC;IAAC,cAAc,CAAC,EAAE,MAAM,CAAC;IAAC,UAAU,CAAC,EAAE,MAAM,CAAA;CAAC,QA8vBlF"}

package/dist-types/components/overlays/test/OverlayController.test.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"OverlayController.test.d.ts","sourceRoot":"","sources":["../../../../components/overlays/test/OverlayController.test.js"],"names":[],"mappings":"gCAsBa,OAAO,2BAA2B,EAAE,iBAAiB;4BACrD,OAAO,2BAA2B,EAAE,aAAa"}
+{"version":3,"file":"OverlayController.test.d.ts","sourceRoot":"","sources":["../../../../components/overlays/test/OverlayController.test.js"],"names":[],"mappings":"gCAuBa,OAAO,2BAA2B,EAAE,iBAAiB;4BACrD,OAAO,2BAA2B,EAAE,aAAa"}