@lion/ui 0.0.9 → 0.0.10

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (133) hide show
  1. package/components/core/src/SlotMixin.js +2 -1
  2. package/components/dialog/test/lion-dialog.test.js +3 -7
  3. package/components/form-integrations/test/form-group-methods.test.js +6 -4
  4. package/components/form-integrations/test/form-integrations.test.js +10 -5
  5. package/components/form-integrations/test/helpers/umbrella-form.js +10 -0
  6. package/components/form-integrations/test/model-value-consistency.test.js +29 -20
  7. package/components/input-datepicker/src/LionInputDatepicker.js +64 -100
  8. package/components/input-datepicker/src/localizeNamespaceLoader.js +188 -0
  9. package/components/input-datepicker/test/lion-input-datepicker.test.js +15 -20
  10. package/components/input-datepicker/test-helpers/DatepickerInputObject.js +3 -3
  11. package/components/input-tel/src/parsers.js +1 -1
  12. package/components/listbox/test-suites/ListboxMixin.suite.js +3 -3
  13. package/components/localize/test/number/formatNumber.test.js +2 -6
  14. package/components/overlays/src/OverlayController.js +236 -289
  15. package/components/overlays/src/OverlayMixin.js +17 -18
  16. package/components/overlays/src/OverlaysManager.js +28 -53
  17. package/components/overlays/src/overlayDocumentStyle.js +24 -0
  18. package/components/overlays/src/overlayShadowDomStyle.js +138 -0
  19. package/components/overlays/src/singleton.js +3 -1
  20. package/components/overlays/test/ArrowMixin.test.js +0 -1
  21. package/components/overlays/test/OverlayController.test.js +306 -273
  22. package/components/overlays/test/OverlaysManager.test.js +23 -32
  23. package/components/overlays/test/global-positioning.test.js +4 -15
  24. package/components/overlays/test/local-positioning.test.js +65 -38
  25. package/components/overlays/test-suites/OverlayMixin.suite.js +18 -26
  26. package/components/overlays/types/OverlayConfig.ts +32 -11
  27. package/components/overlays/types/OverlayMixinTypes.ts +2 -2
  28. package/components/select-rich/src/LionSelectInvoker.js +2 -3
  29. package/components/select-rich/src/LionSelectRich.js +22 -20
  30. package/components/select-rich/test/lion-select-rich.test.js +5 -7
  31. package/custom-elements.json +251 -362
  32. package/dist-types/components/core/src/SlotMixin.d.ts.map +1 -1
  33. package/dist-types/components/form-integrations/test/helpers/umbrella-form.d.ts +4 -0
  34. package/dist-types/components/form-integrations/test/helpers/umbrella-form.d.ts.map +1 -1
  35. package/dist-types/components/form-integrations/test/model-value-consistency.test.d.ts.map +1 -1
  36. package/dist-types/components/input-datepicker/src/LionInputDatepicker.d.ts +3 -3
  37. package/dist-types/components/input-datepicker/src/LionInputDatepicker.d.ts.map +1 -1
  38. package/dist-types/components/input-datepicker/src/localizeNamespaceLoader.d.ts +4 -0
  39. package/dist-types/components/input-datepicker/src/localizeNamespaceLoader.d.ts.map +1 -0
  40. package/dist-types/components/overlays/src/OverlayController.d.ts +46 -101
  41. package/dist-types/components/overlays/src/OverlayController.d.ts.map +1 -1
  42. package/dist-types/components/overlays/src/OverlayMixin.d.ts.map +1 -1
  43. package/dist-types/components/overlays/src/OverlaysManager.d.ts +0 -7
  44. package/dist-types/components/overlays/src/OverlaysManager.d.ts.map +1 -1
  45. package/dist-types/components/overlays/src/overlayDocumentStyle.d.ts +2 -0
  46. package/dist-types/components/overlays/src/overlayDocumentStyle.d.ts.map +1 -0
  47. package/dist-types/components/overlays/src/overlayShadowDomStyle.d.ts +2 -0
  48. package/dist-types/components/overlays/src/overlayShadowDomStyle.d.ts.map +1 -0
  49. package/dist-types/components/overlays/src/singleton.d.ts +2 -1
  50. package/dist-types/components/overlays/src/singleton.d.ts.map +1 -1
  51. package/dist-types/components/overlays/test-suites/OverlayMixin.suite.d.ts.map +1 -1
  52. package/dist-types/components/overlays/types/OverlayConfig.d.ts +14 -10
  53. package/dist-types/components/overlays/types/OverlayConfig.d.ts.map +1 -1
  54. package/dist-types/components/overlays/types/OverlayMixinTypes.d.ts +2 -2
  55. package/dist-types/components/overlays/types/OverlayMixinTypes.d.ts.map +1 -1
  56. package/dist-types/components/select-rich/src/LionSelectInvoker.d.ts +3 -27
  57. package/dist-types/components/select-rich/src/LionSelectInvoker.d.ts.map +1 -1
  58. package/dist-types/components/select-rich/src/LionSelectRich.d.ts.map +1 -1
  59. package/dist-types/components/select-rich/test/lion-select-rich.test.d.ts.map +1 -1
  60. package/dist-types/exports/input-datepicker.d.ts +0 -1
  61. package/dist-types/exports/overlays.d.ts +0 -1
  62. package/dist-types/exports/types/overlays.d.ts +1 -0
  63. package/dist-types/exports/types/overlays.d.ts.map +1 -1
  64. package/dist-types/tsconfig.tsbuildinfo +1 -1
  65. package/docs/components/checkbox-group/overview.md +2 -2
  66. package/docs/components/collapsible/overview.md +1 -1
  67. package/docs/components/combobox/overview.md +1 -1
  68. package/docs/components/combobox/use-cases.md +1 -1
  69. package/docs/components/dialog/overview.md +5 -9
  70. package/docs/components/dialog/use-cases.md +43 -87
  71. package/docs/components/fieldset/overview.md +5 -5
  72. package/docs/components/form/overview.md +3 -3
  73. package/docs/components/icon/use-cases.md +1 -1
  74. package/docs/components/input/overview.md +1 -1
  75. package/docs/components/input-amount/overview.md +3 -3
  76. package/docs/components/input-date/overview.md +3 -3
  77. package/docs/components/input-datepicker/overview.md +5 -5
  78. package/docs/components/input-email/overview.md +2 -2
  79. package/docs/components/input-iban/overview.md +2 -2
  80. package/docs/components/input-range/overview.md +2 -2
  81. package/docs/components/input-stepper/overview.md +1 -1
  82. package/docs/components/input-tel/overview.md +1 -1
  83. package/docs/components/input-tel/use-cases.md +6 -6
  84. package/docs/components/input-tel-dropdown/overview.md +1 -1
  85. package/docs/components/radio-group/overview.md +3 -3
  86. package/docs/components/select-rich/use-cases.md +1 -1
  87. package/docs/components/tabs/examples.md +1 -1
  88. package/docs/fundamentals/index.md +4 -4
  89. package/docs/fundamentals/node-tools/providence-analytics/LocalConfiguration.md +1 -1
  90. package/docs/fundamentals/node-tools/providence-analytics/QueryResult.md +1 -1
  91. package/docs/fundamentals/node-tools/providence-analytics/analyzer.md +1 -1
  92. package/docs/fundamentals/node-tools/providence-analytics/dashboard.md +1 -1
  93. package/docs/fundamentals/node-tools/providence-analytics/overview.md +3 -3
  94. package/docs/fundamentals/node-tools/publish-docs/overview.md +3 -3
  95. package/docs/fundamentals/node-tools/rocket-preset-extend-lion-docs/overview.md +2 -2
  96. package/docs/fundamentals/systems/core/overview.md +1 -1
  97. package/docs/fundamentals/systems/form/formatting-and-parsing.md +4 -4
  98. package/docs/fundamentals/systems/form/model-value.md +1 -1
  99. package/docs/fundamentals/systems/form/overview.md +28 -28
  100. package/docs/fundamentals/systems/form/use-cases.md +4 -0
  101. package/docs/fundamentals/systems/form/validate.md +1 -1
  102. package/docs/fundamentals/systems/localize/overview.md +4 -4
  103. package/docs/fundamentals/systems/overlays/assets/{applyDemoOverlayStyles.js → applyDemoOverlayStyles.mjs} +2 -1
  104. package/docs/fundamentals/systems/overlays/assets/demo-el-using-overlaymixin.mjs +119 -0
  105. package/docs/fundamentals/systems/overlays/assets/{demo-overlay-backdrop.js → demo-overlay-backdrop.mjs} +3 -4
  106. package/docs/fundamentals/systems/overlays/assets/demo-overlay-positioning.mjs +537 -0
  107. package/docs/fundamentals/systems/overlays/assets/umbrella-form.js +9 -2
  108. package/docs/fundamentals/systems/overlays/configuration.md +56 -54
  109. package/docs/fundamentals/systems/overlays/overview.md +5 -5
  110. package/docs/fundamentals/systems/overlays/use-cases.md +83 -77
  111. package/docs/fundamentals/tools/helpers/overview.md +1 -1
  112. package/docs/fundamentals/tools/singleton-manager/overview.md +4 -4
  113. package/docs/guides/how-to/create-a-custom-field.md +6 -6
  114. package/docs/guides/how-to/extend-a-native-input.md +3 -3
  115. package/docs/guides/index.md +8 -8
  116. package/docs/guides/principles/index.md +5 -5
  117. package/docs/guides/principles/styling.md +1 -1
  118. package/exports/input-datepicker.js +0 -1
  119. package/exports/overlays.js +0 -1
  120. package/exports/types/overlays.ts +1 -0
  121. package/package.json +2 -1
  122. package/components/input-datepicker/src/LionCalendarOverlayFrame.js +0 -125
  123. package/components/overlays/src/globalOverlaysStyle.js +0 -139
  124. package/dist-types/components/input-datepicker/src/LionCalendarOverlayFrame.d.ts +0 -10
  125. package/dist-types/components/input-datepicker/src/LionCalendarOverlayFrame.d.ts.map +0 -1
  126. package/dist-types/components/overlays/src/globalOverlaysStyle.d.ts +0 -2
  127. package/dist-types/components/overlays/src/globalOverlaysStyle.d.ts.map +0 -1
  128. package/dist-types/exports/define/lion-calendar-overlay-frame.d.ts +0 -2
  129. package/dist-types/exports/define/lion-calendar-overlay-frame.d.ts.map +0 -1
  130. package/docs/fundamentals/systems/overlays/assets/demo-overlay-system.js +0 -42
  131. package/docs/fundamentals/systems/overlays/form-integration.md +0 -65
  132. package/docs/fundamentals/systems/overlays/scope.md +0 -176
  133. package/exports/define/lion-calendar-overlay-frame.js +0 -3
@@ -0,0 +1,188 @@
1
+ /**
2
+ * @param {Promise<{default:object}>[]} importPromises
3
+ */
4
+ async function combineLocalizeImports(importPromises) {
5
+ const localizeObjects = await Promise.all(importPromises);
6
+ const combinedResult = localizeObjects[0];
7
+ for (const localizeObject of localizeObjects.slice(1)) {
8
+ Object.entries(localizeObject.default).forEach(([key, val]) => {
9
+ combinedResult.default[key] = val;
10
+ });
11
+ }
12
+ return combinedResult;
13
+ }
14
+
15
+ export const localizeNamespaceLoader = /** @param {string} locale */ locale => {
16
+ switch (locale) {
17
+ case 'bg-BG':
18
+ return combineLocalizeImports([
19
+ import('@lion/ui/overlays-translations/bg-BG.js'),
20
+ import('@lion/ui/input-datepicker-translations/bg-BG.js'),
21
+ ]);
22
+ case 'bg':
23
+ return combineLocalizeImports([
24
+ import('@lion/ui/overlays-translations/bg.js'),
25
+ import('@lion/ui/input-datepicker-translations/bg.js'),
26
+ ]);
27
+ case 'cs-CZ':
28
+ return combineLocalizeImports([
29
+ import('@lion/ui/overlays-translations/cs-CZ.js'),
30
+ import('@lion/ui/input-datepicker-translations/cs-CZ.js'),
31
+ ]);
32
+ case 'cs':
33
+ return combineLocalizeImports([
34
+ import('@lion/ui/overlays-translations/cs.js'),
35
+ import('@lion/ui/input-datepicker-translations/cs.js'),
36
+ ]);
37
+ case 'de-DE':
38
+ return combineLocalizeImports([
39
+ import('@lion/ui/overlays-translations/de-DE.js'),
40
+ import('@lion/ui/input-datepicker-translations/de-DE.js'),
41
+ ]);
42
+ case 'de':
43
+ return combineLocalizeImports([
44
+ import('@lion/ui/overlays-translations/de.js'),
45
+ import('@lion/ui/input-datepicker-translations/de.js'),
46
+ ]);
47
+ case 'en-AU':
48
+ return combineLocalizeImports([
49
+ import('@lion/ui/overlays-translations/en-AU.js'),
50
+ import('@lion/ui/input-datepicker-translations/en-AU.js'),
51
+ ]);
52
+ case 'en-GB':
53
+ return combineLocalizeImports([
54
+ import('@lion/ui/overlays-translations/en-GB.js'),
55
+ import('@lion/ui/input-datepicker-translations/en-GB.js'),
56
+ ]);
57
+ case 'en-US':
58
+ return import('@lion/ui/input-datepicker-translations/en-US.js');
59
+ case 'en-PH':
60
+ case 'en':
61
+ return combineLocalizeImports([
62
+ import('@lion/ui/overlays-translations/en.js'),
63
+ import('@lion/ui/input-datepicker-translations/en.js'),
64
+ ]);
65
+
66
+ case 'es-ES':
67
+ return combineLocalizeImports([
68
+ import('@lion/ui/overlays-translations/es-ES.js'),
69
+ import('@lion/ui/input-datepicker-translations/es-ES.js'),
70
+ ]);
71
+ case 'es':
72
+ return combineLocalizeImports([
73
+ import('@lion/ui/overlays-translations/es.js'),
74
+ import('@lion/ui/input-datepicker-translations/es.js'),
75
+ ]);
76
+ case 'fr-FR':
77
+ return combineLocalizeImports([
78
+ import('@lion/ui/overlays-translations/fr-FR.js'),
79
+ import('@lion/ui/input-datepicker-translations/fr-FR.js'),
80
+ ]);
81
+ case 'fr-BE':
82
+ return combineLocalizeImports([
83
+ import('@lion/ui/overlays-translations/fr-BE.js'),
84
+ import('@lion/ui/input-datepicker-translations/fr-BE.js'),
85
+ ]);
86
+ case 'fr':
87
+ return combineLocalizeImports([
88
+ import('@lion/ui/overlays-translations/fr.js'),
89
+ import('@lion/ui/input-datepicker-translations/fr.js'),
90
+ ]);
91
+ case 'hu-HU':
92
+ return combineLocalizeImports([
93
+ import('@lion/ui/overlays-translations/hu-HU.js'),
94
+ import('@lion/ui/input-datepicker-translations/hu-HU.js'),
95
+ ]);
96
+ case 'hu':
97
+ return combineLocalizeImports([
98
+ import('@lion/ui/overlays-translations/hu.js'),
99
+ import('@lion/ui/input-datepicker-translations/hu.js'),
100
+ ]);
101
+ case 'it-IT':
102
+ return combineLocalizeImports([
103
+ import('@lion/ui/overlays-translations/it-IT.js'),
104
+ import('@lion/ui/input-datepicker-translations/it-IT.js'),
105
+ ]);
106
+ case 'it':
107
+ return combineLocalizeImports([
108
+ import('@lion/ui/overlays-translations/it.js'),
109
+ import('@lion/ui/input-datepicker-translations/it.js'),
110
+ ]);
111
+ case 'nl-BE':
112
+ return combineLocalizeImports([
113
+ import('@lion/ui/overlays-translations/nl-BE.js'),
114
+ import('@lion/ui/input-datepicker-translations/nl-BE.js'),
115
+ ]);
116
+ case 'nl-NL':
117
+ return combineLocalizeImports([
118
+ import('@lion/ui/overlays-translations/nl-NL.js'),
119
+ import('@lion/ui/input-datepicker-translations/nl-NL.js'),
120
+ ]);
121
+ case 'nl':
122
+ return combineLocalizeImports([
123
+ import('@lion/ui/overlays-translations/nl.js'),
124
+ import('@lion/ui/input-datepicker-translations/nl.js'),
125
+ ]);
126
+ case 'pl-PL':
127
+ return combineLocalizeImports([
128
+ import('@lion/ui/overlays-translations/pl-PL.js'),
129
+ import('@lion/ui/input-datepicker-translations/pl-PL.js'),
130
+ ]);
131
+ case 'pl':
132
+ return combineLocalizeImports([
133
+ import('@lion/ui/overlays-translations/pl.js'),
134
+ import('@lion/ui/input-datepicker-translations/pl.js'),
135
+ ]);
136
+ case 'ro-RO':
137
+ return combineLocalizeImports([
138
+ import('@lion/ui/overlays-translations/ro-RO.js'),
139
+ import('@lion/ui/input-datepicker-translations/ro-RO.js'),
140
+ ]);
141
+ case 'ro':
142
+ return combineLocalizeImports([
143
+ import('@lion/ui/overlays-translations/ro.js'),
144
+ import('@lion/ui/input-datepicker-translations/ro.js'),
145
+ ]);
146
+ case 'ru-RU':
147
+ return combineLocalizeImports([
148
+ import('@lion/ui/overlays-translations/ru-RU.js'),
149
+ import('@lion/ui/input-datepicker-translations/ru-RU.js'),
150
+ ]);
151
+ case 'ru':
152
+ return combineLocalizeImports([
153
+ import('@lion/ui/overlays-translations/ru.js'),
154
+ import('@lion/ui/input-datepicker-translations/ru.js'),
155
+ ]);
156
+ case 'sk-SK':
157
+ return combineLocalizeImports([
158
+ import('@lion/ui/overlays-translations/sk-SK.js'),
159
+ import('@lion/ui/input-datepicker-translations/sk-SK.js'),
160
+ ]);
161
+ case 'sk':
162
+ return combineLocalizeImports([
163
+ import('@lion/ui/overlays-translations/sk.js'),
164
+ import('@lion/ui/input-datepicker-translations/sk.js'),
165
+ ]);
166
+ case 'uk-UA':
167
+ return combineLocalizeImports([
168
+ import('@lion/ui/overlays-translations/uk-UA.js'),
169
+ import('@lion/ui/input-datepicker-translations/uk-UA.js'),
170
+ ]);
171
+ case 'uk':
172
+ return combineLocalizeImports([
173
+ import('@lion/ui/overlays-translations/uk.js'),
174
+ import('@lion/ui/input-datepicker-translations/uk.js'),
175
+ ]);
176
+ case 'zh-CN':
177
+ case 'zh':
178
+ return combineLocalizeImports([
179
+ import('@lion/ui/overlays-translations/zh.js'),
180
+ import('@lion/ui/input-datepicker-translations/zh.js'),
181
+ ]);
182
+ default:
183
+ return combineLocalizeImports([
184
+ import('@lion/ui/overlays-translations/en.js'),
185
+ import('@lion/ui/input-datepicker-translations/en.js'),
186
+ ]);
187
+ }
188
+ };
@@ -44,15 +44,17 @@ describe('<lion-input-datepicker>', () => {
44
44
  const elObj = new DatepickerInputObject(el);
45
45
  await elObj.openCalendar();
46
46
 
47
- expect(elObj.overlayEl.shadowRoot.querySelector('.calendar-overlay')).not.to.equal(null);
48
- expect(elObj.overlayEl.shadowRoot.querySelector('.calendar-overlay__header')).not.to.equal(
49
- null,
50
- );
51
- expect(elObj.overlayEl.shadowRoot.querySelector('.calendar-overlay__heading')).not.to.equal(
52
- null,
53
- );
54
47
  expect(
55
- elObj.overlayEl.shadowRoot.querySelector('.calendar-overlay__close-button'),
48
+ /** @type {ShadowRoot} */ (el.shadowRoot).querySelector('.calendar-overlay'),
49
+ ).not.to.equal(null);
50
+ expect(
51
+ /** @type {ShadowRoot} */ (el.shadowRoot).querySelector('.calendar-overlay__header'),
52
+ ).not.to.equal(null);
53
+ expect(
54
+ /** @type {ShadowRoot} */ (el.shadowRoot).querySelector('.calendar-overlay__heading'),
55
+ ).not.to.equal(null);
56
+ expect(
57
+ /** @type {ShadowRoot} */ (el.shadowRoot).querySelector('.calendar-overlay__close-button'),
56
58
  ).not.to.equal(null);
57
59
  });
58
60
 
@@ -74,11 +76,7 @@ describe('<lion-input-datepicker>', () => {
74
76
  `);
75
77
  const elObj = new DatepickerInputObject(el);
76
78
  await elObj.openCalendar();
77
- expect(
78
- /** @type {HTMLSlotElement} */ (
79
- elObj.overlayHeadingEl.querySelector('slot[name="heading"]')
80
- ).assignedNodes()[0],
81
- ).lightDom.to.equal('Pick your date');
79
+ expect(elObj.overlayHeadingEl.textContent).to.equal('Pick your date');
82
80
  });
83
81
 
84
82
  it('can have a custom heading', async () => {
@@ -90,11 +88,7 @@ describe('<lion-input-datepicker>', () => {
90
88
  `);
91
89
  const elObj = new DatepickerInputObject(el);
92
90
  await elObj.openCalendar();
93
- expect(
94
- /** @type {HTMLSlotElement} */ (
95
- elObj.overlayHeadingEl.querySelector('slot[name="heading"]')
96
- ).assignedNodes()[0],
97
- ).lightDom.to.equal('foo');
91
+ expect(elObj.overlayHeadingEl.innerText).to.equal('foo');
98
92
  });
99
93
 
100
94
  it('closes the calendar on [esc] key', async () => {
@@ -670,7 +664,8 @@ describe('<lion-input-datepicker>', () => {
670
664
  expect(submitSpy.callCount).to.equal(0);
671
665
  });
672
666
 
673
- it('is hidden when attribute hidden is true', async () => {
667
+ // TODO: remove: became irrelevant after we don't need dialog-frame
668
+ it.skip('is hidden when attribute hidden is true', async () => {
674
669
  const el = await fixture(html`<lion-input-datepicker></lion-input-datepicker>`);
675
670
 
676
671
  await el.updateComplete;
@@ -690,7 +685,7 @@ describe('<lion-input-datepicker>', () => {
690
685
  await myElObj.openCalendar();
691
686
  expect(el.hasArrow).to.be.false;
692
687
  expect(
693
- el?.shadowRoot?.contains(myElObj.overlayController.contentNode),
688
+ myElObj.overlayController.contentNode.classList.contains('overlays__overlay--bottom-sheet'),
694
689
  'Datepicker does not get rendered as bottom sheet',
695
690
  ).to.be.false;
696
691
  });
@@ -29,7 +29,7 @@ export class DatepickerInputObject {
29
29
 
30
30
  async closeCalendar() {
31
31
  this.overlayCloseButtonEl.click();
32
- await this.overlayEl.updateComplete;
32
+ await this.el.updateComplete;
33
33
  }
34
34
 
35
35
  /**
@@ -58,13 +58,13 @@ export class DatepickerInputObject {
58
58
 
59
59
  get overlayHeadingEl() {
60
60
  return /** @type {HTMLElement} */ (
61
- this.overlayEl && this.overlayEl.shadowRoot?.querySelector('.calendar-overlay__heading')
61
+ this.overlayEl && this.el.shadowRoot?.querySelector('.calendar-overlay__heading')
62
62
  );
63
63
  }
64
64
 
65
65
  get overlayCloseButtonEl() {
66
66
  return /** @type {HTMLElement} */ (
67
- this.calendarEl && this.overlayEl.shadowRoot?.querySelector('#close-button')
67
+ this.calendarEl && this.el.shadowRoot?.querySelector('#close-button')
68
68
  );
69
69
  }
70
70
 
@@ -25,7 +25,7 @@ export function parsePhoneNumber(viewValue, { regionCode }) {
25
25
  // eslint-disable-next-line no-empty
26
26
  } catch (_) {}
27
27
 
28
- if (pn) {
28
+ if (pn?.number) {
29
29
  return pn.number.e164;
30
30
  }
31
31
 
@@ -394,7 +394,7 @@ export function runListboxMixinSuite(customConfig = {}) {
394
394
  await el.updateComplete;
395
395
  await el.updateComplete; // need 2 awaits as overlay.show is an async function
396
396
 
397
- await expect(el).to.be.accessible();
397
+ await expect(el).to.be.accessible({ ignoredRules: ['aria-allowed-role'] });
398
398
  });
399
399
 
400
400
  // NB: regular listbox is always 'opened', but needed for combobox and select-rich
@@ -405,7 +405,7 @@ export function runListboxMixinSuite(customConfig = {}) {
405
405
  <${optionTag} .choiceValue=${20}>Item 2</${optionTag}>
406
406
  </${tag}>
407
407
  `);
408
- await expect(el).to.be.accessible();
408
+ await expect(el).to.be.accessible({ ignoredRules: ['aria-allowed-role'] });
409
409
  });
410
410
 
411
411
  it('does not have a tabindex', async () => {
@@ -430,7 +430,7 @@ export function runListboxMixinSuite(customConfig = {}) {
430
430
  const el = await fixture(html`
431
431
  <${tag} opened has-no-default-selected autocomplete="none" show-all-on-empty>
432
432
  <${optionTag} .choiceValue=${'10'} id="first">Item 1</${optionTag}>
433
- <${optionTag} .choiceValue=${'20'} checked id="second">Item 2</${optionTag}>
433
+ <${optionTag} .choiceValue=${'20'} id="second">Item 2</${optionTag}>
434
434
  </${tag}>
435
435
  `);
436
436
  const { _activeDescendantOwnerNode } = getListboxMembers(el);
@@ -294,17 +294,13 @@ Please specify .groupSeparator / .decimalSeparator on the formatOptions object t
294
294
 
295
295
  describe('en-PH', () => {
296
296
  it('supports basics', () => {
297
- // TODO: This test is broken on Firefox and Chromium, check and fix when the intl change is permanent
298
- if (!isSafari) {
299
- return;
300
- }
301
297
  localize.locale = 'en-PH';
302
298
  expect(formatNumber(123456.789, currencyCode('EUR'))).to.equal('EUR 123,456.79');
303
299
  expect(formatNumber(123456.789, currencyCode('USD'))).to.equal('USD 123,456.79');
304
300
  expect(formatNumber(123456.789, currencyCode('JPY'))).to.equal('JPY 123,457');
305
301
  expect(formatNumber(123456.789, currencySymbol('EUR'))).to.equal('€123,456.79');
306
- expect(formatNumber(123456.789, currencySymbol('USD'))).to.equal('US$123,456.79');
307
- expect(formatNumber(123456.789, currencySymbol('JPY'))).to.equal('JP¥123,457');
302
+ expect(formatNumber(123456.789, currencySymbol('USD'))).to.equal('$123,456.79');
303
+ expect(formatNumber(123456.789, currencySymbol('JPY'))).to.equal('¥123,457');
308
304
  });
309
305
  });
310
306