@lion/ui 0.0.3 → 0.0.5

package/components/form-core/test-suites/ValidateMixin.suite.js

@@ -64,7 +64,7 @@ export function runValidateMixinSuite(customConfig) {
      * - *feedback-node*
      *   The 'this._feedbackNode' property (usually a getter) that returns/contains a reference to
      *   the output container for validation feedback. Messages will be written to this element
-     *   based on user defined or default validity feedback visibility conditions.
+     *   based on user-defined or default validity feedback visibility conditions.
      *
      * - *show-{type}-feedback-condition*
      *   The 'this.hasErrorVisible value that stores whether the

package/components/form-core/test-suites/form-group/FormGroupMixin.suite.js

@@ -1234,7 +1234,7 @@ export function runFormGroupMixinSuite(cfg = {}) {
           </${tag}>
         `)
           );
-          const childFieldsetEl = el.querySelector(tagString);
+          const childFieldsetEl = /** @type {FormGroup} */ (el.querySelector(tagString));
           const resetGroupSpy = sinon.spy(childFieldsetEl, 'resetGroup');
           el.resetGroup();
           expect(resetGroupSpy.callCount).to.equal(1);
@@ -1270,7 +1270,7 @@ export function runFormGroupMixinSuite(cfg = {}) {
           </${tag}>
         `)
           );
-          const childFieldsetEl = el.querySelector(tagString);
+          const childFieldsetEl = /** @type {FormGroup} */ (el.querySelector(tagString));
           const clearGroupSpy = sinon.spy(childFieldsetEl, 'clearGroup');
           el.clearGroup();
           expect(clearGroupSpy.callCount).to.equal(1);

package/components/input/src/LionInput.js

@@ -64,11 +64,13 @@ export class LionInput extends NativeTextFieldMixin(LionField) {
   }
 
   /**
-   * @param {PropertyKey} [name]
-   * @param {?} [oldValue]
+   * @param {string} [name]
+   * @param {unknown} [oldValue]
+   * @param {import('lit').PropertyDeclaration} [options]
+   * @returns {void}
    */
-  requestUpdate(name, oldValue) {
-    super.requestUpdate(name, oldValue);
+  requestUpdate(name, oldValue, options) {
+    super.requestUpdate(name, oldValue, options);
     if (name === 'readOnly') {
       this.__delegateReadOnly();
     }

package/components/input-datepicker/src/LionInputDatepicker.js

@@ -211,11 +211,13 @@ export class LionInputDatepicker extends ScopedElementsMixin(
   }
 
   /**
-   * @param {PropertyKey} name
-   * @param {?} oldValue
+   * @param {string} [name]
+   * @param {unknown} [oldValue]
+   * @param {import('lit').PropertyDeclaration} [options]
+   * @returns {void}
    */
-  requestUpdate(name, oldValue) {
-    super.requestUpdate(name, oldValue);
+  requestUpdate(name, oldValue, options) {
+    super.requestUpdate(name, oldValue, options);
 
     if (name === 'disabled' || name === 'readOnly') {
       this.__toggleInvokerDisabled();

package/components/input-tel/src/LionInputTel.js

@@ -14,7 +14,7 @@ import { localizeNamespaceLoader } from './localizeNamespaceLoader.js';
  * @typedef {import('awesome-phonenumber').PhoneNumberFormat} PhoneNumberFormat
  * @typedef {import('awesome-phonenumber').PhoneNumberTypes} PhoneNumberTypes
  * @typedef {import('../../form-core/types/FormatMixinTypes.js').FormatOptions} FormatOptions
- * @typedef {* & import('awesome-phonenumber').default} AwesomePhoneNumber
+ * @typedef {* & import('awesome-phonenumber')} AwesomePhoneNumber
  * @typedef {FormatOptions & {regionCode: RegionCode; formatStrategy: PhoneNumberFormat; formatCountryCodeStyle: string;}} FormatOptionsTel
  */
 
@@ -28,7 +28,6 @@ export class LionInputTel extends LocalizeMixin(LionInput) {
     formatCountryCodeStyle: { type: String, attribute: 'format-country-code-style' },
     activeRegion: { type: String },
     _phoneUtil: { type: Object, state: true },
-    _needsLightDomRender: { type: Number, state: true },
   };
 
   static localizeNamespaces = [
@@ -72,10 +71,12 @@ export class LionInputTel extends LocalizeMixin(LionInput) {
   get activePhoneNumberType() {
     let pn;
     try {
-      pn = this._phoneUtil && this._phoneUtil(this.modelValue, this.activeRegion);
+      pn =
+        this._phoneUtil &&
+        this._phoneUtil.parsePhoneNumber(this.modelValue, { regionCode: this.activeRegion });
       // eslint-disable-next-line no-empty
     } catch (_) {}
-    return pn?.g?.type || 'unknown';
+    return pn?.type || 'unknown';
   }
 
   // @ts-ignore read only
@@ -169,14 +170,6 @@ export class LionInputTel extends LocalizeMixin(LionInput) {
       ? /** @type {AwesomePhoneNumber} */ (PhoneUtilManager.PhoneUtil)
       : null;
 
-    /**
-     * Helper that triggers a light dom render aligned with update loop.
-     * TODO: combine with render fn of SlotMixin
-     * @protected
-     * @type {number}
-     */
-    this._needsLightDomRender = 0;
-
     if (!PhoneUtilManager.isLoaded) {
       PhoneUtilManager.loadComplete.then(() => {
         this._onPhoneNumberUtilReady();
@@ -305,20 +298,11 @@ export class LionInputTel extends LocalizeMixin(LionInput) {
     // This should trigger a rerender in shadow dom
     this._phoneUtil = /** @type {AwesomePhoneNumber} */ (PhoneUtilManager.PhoneUtil);
     // This should trigger a rerender in light dom
-    this._scheduleLightDomRender();
     // Format when libPhoneNumber is loaded
     this._calculateValues({ source: null });
     this.__calculateActiveRegion();
   }
 
-  /**
-   * This allows to hook into the update hook
-   * @protected
-   */
-  _scheduleLightDomRender() {
-    this._needsLightDomRender += 1;
-  }
-
   /**
    * @private
    */
@@ -334,7 +318,8 @@ export class LionInputTel extends LocalizeMixin(LionInput) {
     const value = !(this.modelValue instanceof Unparseable)
       ? this.modelValue
       : this.value.match(regex)?.join('');
-    const regionDerivedFromValue = value && this._phoneUtil && this._phoneUtil(value).g?.regionCode;
+    const regionDerivedFromValue =
+      value && this._phoneUtil && this._phoneUtil.parsePhoneNumber(value).regionCode;
 
     if (regionDerivedFromValue && this._allowedOrAllRegions.includes(regionDerivedFromValue)) {
       this._setActiveRegion(regionDerivedFromValue);

package/components/input-tel/src/PhoneUtilManager.js

@@ -2,21 +2,25 @@
 let resolveLoaded;
 
 /**
- * - Handles lazy loading of the (relatively large) google-libphonenumber library, allowing
+ * @typedef {* & import('awesome-phonenumber')} AwesomePhoneNumber
+ */
+
+/**
+ * - Handles lazy loading of the awesome-phonenumber library (relatively large, but way lighter than google-libphonenumber), allowing
  * for quick first paints
  * - Maintains one instance of phoneNumberUtil that can be shared across multiple places
  * - Allows for easy mocking in unit tests
  */
 export class PhoneUtilManager {
   static async loadLibPhoneNumber() {
-    const PhoneUtil = (await import('awesome-phonenumber')).default;
-    this.PhoneUtil = PhoneUtil;
+    const PhoneUtil = /** @type {AwesomePhoneNumber} */ (await import('awesome-phonenumber'));
+    this.PhoneUtil = { ...PhoneUtil };
     resolveLoaded(undefined);
     return PhoneUtil;
   }
 
   /**
-   * Check if google-libphonenumber has been loaded
+   * Check if awesome-phonenumber has been loaded
    */
   static get isLoaded() {
     return Boolean(this.PhoneUtil);
@@ -24,7 +28,7 @@ export class PhoneUtilManager {
 }
 
 /**
- * Wait till google-libphonenumber has been loaded
+ * Wait till awesome-phonenumber has been loaded
  * @example
  * ```js
  * await PhoneUtilManager.loadComplete;

package/components/input-tel/src/formatters.js

@@ -3,7 +3,6 @@ import { PhoneUtilManager } from './PhoneUtilManager.js';
 /**
  * @typedef {import('awesome-phonenumber').PhoneNumberFormat} PhoneNumberFormat
  * @typedef {import('../types/index.js').RegionCode} RegionCode
- * @typedef {* & import('awesome-phonenumber').default} AwesomePhoneNumber
  */
 
 /**
@@ -42,33 +41,32 @@ export function formatPhoneNumber(
     return modelValue;
   }
 
-  // eslint-disable-next-line prefer-destructuring
-  const PhoneUtil = /** @type {AwesomePhoneNumber} */ (PhoneUtilManager.PhoneUtil);
+  const AwesomePhoneNumber = PhoneUtilManager.PhoneUtil;
 
   let pn;
   try {
-    pn = new PhoneUtil(modelValue, regionCode);
+    pn = AwesomePhoneNumber.parsePhoneNumber(modelValue, { regionCode });
     // eslint-disable-next-line no-empty
   } catch (_) {}
 
-  if (modelValue?.length >= 4 && modelValue?.length <= 16 && pn?.isValid()) {
+  if (modelValue?.length >= 4 && modelValue?.length <= 16 && pn?.valid) {
     let formattedValue;
 
     switch (formatStrategy) {
       case 'e164':
-        formattedValue = pn.getNumber('e164'); // -> '+46707123456' (default)
+        formattedValue = pn.number.e164; // -> '+46707123456' (default)
         break;
       case 'international':
-        formattedValue = pn.getNumber('international'); // -> '+46 70 712 34 56'
+        formattedValue = pn.number.international; // -> '+46 70 712 34 56'
         break;
       case 'national':
-        formattedValue = pn.getNumber('national'); // -> '070-712 34 56'
+        formattedValue = pn.number.national; // -> '070-712 34 56'
         break;
       case 'rfc3966':
-        formattedValue = pn.getNumber('rfc3966'); // -> 'tel:+46-70-712-34-56'
+        formattedValue = pn.number.rfc3966; // -> 'tel:+46-70-712-34-56'
         break;
       case 'significant':
-        formattedValue = pn.getNumber('significant'); // -> '707123456'
+        formattedValue = pn.number.significant; // -> '707123456'
         break;
       default:
         break;

package/components/input-tel/src/parsers.js

@@ -2,7 +2,6 @@ import { PhoneUtilManager } from './PhoneUtilManager.js';
 
 /**
  * @typedef {import('../types/index.js').RegionCode} RegionCode
- * @typedef {* & import('awesome-phonenumber').default} AwesomePhoneNumber
  */
 
 /**
@@ -17,17 +16,17 @@ export function parsePhoneNumber(viewValue, { regionCode }) {
   }
 
   // eslint-disable-next-line prefer-destructuring
-  const PhoneNumber = /** @type {AwesomePhoneNumber} */ (PhoneUtilManager.PhoneUtil);
+  const AwesomePhoneNumber = PhoneUtilManager.PhoneUtil;
   const regex = /[+0-9]+/gi;
   const strippedViewValue = viewValue.match(regex)?.join('');
   let pn;
   try {
-    pn = PhoneNumber(strippedViewValue, regionCode);
+    pn = AwesomePhoneNumber.parsePhoneNumber(strippedViewValue, { regionCode });
     // eslint-disable-next-line no-empty
   } catch (_) {}
 
   if (pn) {
-    return pn.getNumber('e164');
+    return pn.number.e164;
   }
 
   return viewValue;

package/components/input-tel/src/preprocessors.js

@@ -4,7 +4,6 @@ import { PhoneUtilManager } from './PhoneUtilManager.js';
 /**
  * @typedef {import('../types/index.js').RegionCode} RegionCode
  * @typedef {import('awesome-phonenumber').PhoneNumberFormat} PhoneNumberFormat
- * @typedef {* & import('awesome-phonenumber').default} AwesomePhoneNumber
  */
 
 /**
@@ -27,9 +26,8 @@ export function liveFormatPhoneNumber(
     return undefined;
   }
 
-  // eslint-disable-next-line prefer-destructuring
-  const PhoneNumber = /** @type {AwesomePhoneNumber} */ (PhoneUtilManager.PhoneUtil);
-  const ayt = PhoneNumber.getAsYouType(regionCode);
+  const AwesomePhoneNumber = PhoneUtilManager.PhoneUtil;
+  const ayt = AwesomePhoneNumber.getAsYouType(regionCode);
 
   for (const char of viewValue) {
     if (char !== '') {

package/components/input-tel/src/validators.js

@@ -3,7 +3,6 @@ import { PhoneUtilManager } from './PhoneUtilManager.js';
 
 /**
  * @typedef {import('../types/index.js').RegionCode} RegionCode
- * @typedef {* & import('awesome-phonenumber').default} AwesomePhoneNumber
  * @typedef {import('../../form-core/types/validate/validate.js').FeedbackMessageData} FeedbackMessageData
  */
 
@@ -13,22 +12,21 @@ import { PhoneUtilManager } from './PhoneUtilManager.js';
  * @returns {false|'invalid-country-code'|'unknown'|'too-long'|'too-short'}
  */
 function hasFeedback(modelValue, regionCode) {
-  // eslint-disable-next-line prefer-destructuring
-  const PhoneNumber = /** @type {AwesomePhoneNumber} */ (PhoneUtilManager.PhoneUtil);
+  const AwesomePhoneNumber = PhoneUtilManager.PhoneUtil;
   let invalidCountryCode = false;
 
   if (regionCode && modelValue?.length >= 4 && modelValue?.length <= 16) {
     let pn;
     try {
-      pn = PhoneNumber(modelValue, regionCode);
-      invalidCountryCode = pn.g.regionCode !== regionCode;
+      pn = AwesomePhoneNumber.parsePhoneNumber(modelValue, { regionCode });
+      invalidCountryCode = pn.regionCode !== regionCode;
       if (invalidCountryCode) {
         return 'invalid-country-code';
       }
       // eslint-disable-next-line no-empty
     } catch (_) {}
     // too-short/too-long info seems to be not there (we get 'is-possible'?)
-    const enumValue = !pn.isValid() ? pn.g.possibility : false;
+    const enumValue = !pn.valid ? pn.possibility : false;
     if (enumValue === 'is-possible') {
       return 'unknown';
     }

package/components/input-tel/test/validators.test.js

@@ -4,7 +4,7 @@ import { PhoneNumber, PhoneUtilManager } from '@lion/ui/input-tel.js';
 import { mockPhoneUtilManager, restorePhoneUtilManager } from '@lion/ui/input-tel-test-helpers.js';
 
 /**
- * @typedef {* & import('awesome-phonenumber').default} AwesomePhoneNumber
+ * @typedef {* & import('awesome-phonenumber')} AwesomePhoneNumber
  */
 
 // For enum output, see: https://www.npmjs.com/package/awesome-phonenumber
@@ -24,6 +24,7 @@ describe('PhoneNumber validation', () => {
     expect(validator.execute('foo', 'NL')).to.equal('unknown');
   });
 
+  // TODO: this changed after awesome-phonenumber v4. Skip for now, look into this later
   it('is invalid when wrong country code is entered, returns "invalid-country-code"', () => {
     const validator = new PhoneNumber();
     // 32 is BE region code
@@ -47,12 +48,13 @@ describe('PhoneNumber validation', () => {
 
   it('handles validation via awesome-phonenumber', () => {
     const validator = new PhoneNumber();
-    const spy = sinon.spy(PhoneUtilManager, 'PhoneUtil');
+    // @ts-ignore
+    const spy = sinon.spy(PhoneUtilManager.PhoneUtil, 'parsePhoneNumber');
     validator.execute('0123456789', 'NL');
     expect(spy).to.have.been.calledOnce;
-    expect(spy.lastCall.args[1]).to.equal('NL');
+    expect(spy.lastCall.args[1]).to.eql({ regionCode: 'NL' });
     validator.execute('0123456789', 'DE');
-    expect(spy.lastCall.args[1]).to.equal('DE');
+    expect(spy.lastCall.args[1]).to.eql({ regionCode: 'DE' });
     spy.restore();
   });
 
@@ -75,7 +77,8 @@ describe('PhoneNumber validation', () => {
 
     it('waits for the lib to be loaded before execution completes when still in async mode', async () => {
       const validator = new PhoneNumber();
-      const spy = sinon.spy(PhoneUtilManager, 'PhoneUtil');
+      // @ts-ignore
+      const spy = sinon.spy(PhoneUtilManager.PhoneUtil, 'parsePhoneNumber');
       const validationResult = validator.execute('061234', 'NL');
       expect(validationResult).to.be.instanceOf(Promise);
       expect(spy).to.not.have.been.called;

package/components/input-tel-dropdown/src/LionInputTelDropdown.js

@@ -1,4 +1,4 @@
-import { html, render, css } from 'lit';
+import { html, css } from 'lit';
 import { ref, createRef } from 'lit/directives/ref.js';
 
 import { LionInputTel } from '@lion/ui/input-tel.js';
@@ -27,7 +27,6 @@ import { getFlagSymbol } from './getFlagSymbol.js';
  * @typedef {import('../types/index.js').OnDropdownChangeEvent} OnDropdownChangeEvent
  * @typedef {import('../types/index.js').DropdownRef} DropdownRef
  * @typedef {import('../types/index.js').RegionMeta} RegionMeta
- * @typedef {* & import('awesome-phonenumber').default} AwesomePhoneNumber
  * @typedef {import('../../select-rich/src/LionSelectRich.js').LionSelectRich} LionSelectRich
  * @typedef {import('../../overlays/src/OverlayController.js').OverlayController} OverlayController
  * @typedef {TemplateDataForDropdownInputTel & {data: {regionMetaList:RegionMeta[]}}} TemplateDataForIntlInputTel
@@ -99,6 +98,7 @@ export class LionInputTelDropdown extends LionInputTel {
         },
       },
     };
+
     return {
       refs,
       data: {
@@ -155,7 +155,7 @@ export class LionInputTelDropdown extends LionInputTel {
     css`
       /**
            * We need to align the height of the dropdown with the height of the text field.
-           * We target the HTMLDivElement 'this.__dropdownRenderParent' here. Its child,
+           * We target the HTMLDivElement (render wrapper from SlotMixin) here. Its child,
            * [data-ref=dropdown], recieves a 100% height as well via inline styles (since we
            * can't target from shadow styles).
            */
@@ -171,7 +171,15 @@ export class LionInputTelDropdown extends LionInputTel {
   get slots() {
     return {
       ...super.slots,
-      prefix: () => this.__dropdownRenderParent,
+      prefix: () => {
+        const ctor = /** @type {typeof LionInputTelDropdown} */ (this.constructor);
+        const { templates } = ctor;
+
+        return {
+          template: templates.dropdown(this._templateDataDropdown),
+          afterRender: this.__syncRegionWithDropdown,
+        };
+      },
     };
   }
 
@@ -186,7 +194,6 @@ export class LionInputTelDropdown extends LionInputTel {
       type: 'region',
     });
     this.__createRegionMeta();
-    this._scheduleLightDomRender();
   }
 
   /**
@@ -219,25 +226,30 @@ export class LionInputTelDropdown extends LionInputTel {
      */
     this._preferredCountriesLabel = '';
 
-    /** @type {HTMLDivElement} */
-    this.__dropdownRenderParent = document.createElement('div');
-
     /**
      * Contains everything needed for rendering region options:
      * region code, country code, display name according to locale, display name
+     * @private
      * @type {RegionMeta[]}
      */
     this.__regionMetaList = [];
 
     /**
      * A filtered `this.__regionMetaList`, containing all regions provided in `preferredRegions`
+     * @private
      * @type {RegionMeta[]}
      */
     this.__regionMetaListPreferred = [];
 
-    /** @type {EventListener} */
+    /**
+     * @protected
+     * @type {EventListener}
+     */
     this._onDropdownValueChange = this._onDropdownValueChange.bind(this);
-    /** @type {EventListener} */
+    /**
+     * @private
+     * @type {EventListener}
+     */
     this.__syncRegionWithDropdown = this.__syncRegionWithDropdown.bind(this);
   }
 
@@ -259,9 +271,6 @@ export class LionInputTelDropdown extends LionInputTel {
   updated(changedProperties) {
     super.updated(changedProperties);
 
-    if (changedProperties.has('_needsLightDomRender')) {
-      this.__renderDropdown();
-    }
     if (changedProperties.has('activeRegion')) {
       this.__syncRegionWithDropdown();
     }
@@ -279,6 +288,9 @@ export class LionInputTelDropdown extends LionInputTel {
     }
   }
 
+  /**
+   * @protected
+   */
   _initModelValueBasedOnDropdown() {
     if (!this._initialModelValue && !this.dirty && this._phoneUtil) {
       const countryCode = this._phoneUtil.getCountryCodeForRegionCode(this.activeRegion);
@@ -326,6 +338,7 @@ export class LionInputTelDropdown extends LionInputTel {
     if (prevActiveRegion !== this.activeRegion && !this.focused && this._phoneUtil) {
       const prevCountryCode = this._phoneUtil.getCountryCodeForRegionCode(prevActiveRegion);
       const countryCode = this._phoneUtil.getCountryCodeForRegionCode(this.activeRegion);
+
       if (this.value.includes(`+${prevCountryCode}`)) {
         this.modelValue = this._callParser(
           this.value.replace(`+${prevCountryCode}`, `+${countryCode}`),
@@ -350,25 +363,6 @@ export class LionInputTelDropdown extends LionInputTel {
     }
   }
 
-  /**
-   * Abstract away rendering to light dom, so that we can rerender when needed
-   * @private
-   */
-  __renderDropdown() {
-    const ctor = /** @type {typeof LionInputTelDropdown} */ (this.constructor);
-    // If the user locally overrode the templates, get those on the instance
-    const templates = this.templates || ctor.templates;
-    render(
-      templates.dropdown(this._templateDataDropdown),
-      this.__dropdownRenderParent,
-      /** @type {RenderOptions} */ ({
-        scopeName: this.localName,
-        eventContext: this,
-      }),
-    );
-    this.__syncRegionWithDropdown();
-  }
-
   /**
    * @private
    */
@@ -411,6 +405,7 @@ export class LionInputTelDropdown extends LionInputTel {
     if (!this._allowedOrAllRegions?.length || !this.__namesForLocale) {
       return;
     }
+
     this.__regionMetaList = [];
     this.__regionMetaListPreferred = [];
     this._allowedOrAllRegions.forEach(regionCode => {
@@ -436,4 +431,18 @@ export class LionInputTelDropdown extends LionInputTel {
       });
     });
   }
+
+  /**
+   * Usually, we don't use composition in regular LionFields (non choice-groups). Here we use a LionSelect(Rich) inside.
+   * We don't want to repropagate any children, since an Application Developer is not concerned with these internals (see repropate logic in FormControlMixin)
+   * Also, we don't want to give (wrong) info to InteractionStateMixin, that will set the wrong interaction states based on child info.
+   * TODO: Make "this._repropagationRole !== 'child'" the default for FormControlMixin
+   * (so that FormControls used within are never repropagated for LionFields)
+   * @protected
+   * @configure FormControlMixin: don't repropagate any children
+   */
+  // eslint-disable-next-line class-methods-use-this
+  _repropagationCondition() {
+    return false;
+  }
 }

package/components/input-tel-dropdown/test-suites/LionInputTelDropdown.suite.js

@@ -91,8 +91,7 @@ export function runInputTelDropdownSuite({ klass } = { klass: LionInputTelDropdo
 
     it('syncs value of dropdown on init if input has no value does not influence interaction states', async () => {
       const el = await fixture(html` <${tag}></${tag}> `);
-      // TODO find out why its get dirty again
-      // expect(el.dirty).to.be.false;
+      expect(el.dirty).to.be.false;
       expect(el.prefilled).to.be.false;
     });
 
@@ -111,8 +110,7 @@ export function runInputTelDropdownSuite({ klass } = { klass: LionInputTelDropdo
 
     it('sets correct interaction states on init if input has a value', async () => {
       const el = await fixture(html` <${tag} .modelValue="${'+31612345678'}"></${tag}> `);
-      // TODO find out why its get dirty again
-      // expect(el.dirty).to.be.false;
+      expect(el.dirty).to.be.false;
       expect(el.prefilled).to.be.true;
     });
 
@@ -245,10 +243,10 @@ export function runInputTelDropdownSuite({ klass } = { klass: LionInputTelDropdo
         const { resolveLoaded } = mockPhoneUtilManager();
         const el = await fixture(html` <${tag} .allowedRegions="${['DE']}"></${tag}> `);
         // @ts-ignore
-        const spy = sinon.spy(el, '_scheduleLightDomRender');
+        const spy = sinon.spy(el, '__rerenderSlot');
         resolveLoaded(undefined);
         await aTimeout(0);
-        expect(spy).to.have.been.calledOnce;
+        expect(spy).to.have.been.calledWith('prefix');
         restorePhoneUtilManager();
         spy.restore();
       });
@@ -323,6 +321,7 @@ export function runInputTelDropdownSuite({ klass } = { klass: LionInputTelDropdo
         mimicUserChangingDropdown(el.refs.dropdown.value, 'BE');
         await el.updateComplete;
         await el.updateComplete;
+
         expect(el.value).to.equal('+32 612345678');
       });
 

package/components/listbox/src/LionOption.js

@@ -78,11 +78,13 @@ export class LionOption extends DisabledMixin(
   }
 
   /**
-   * @param {string} name
-   * @param {unknown} oldValue
+   * @param {string} [name]
+   * @param {unknown} [oldValue]
+   * @param {import('lit').PropertyDeclaration} [options]
+   * @returns {void}
    */
-  requestUpdate(name, oldValue) {
-    super.requestUpdate(name, oldValue);
+  requestUpdate(name, oldValue, options) {
+    super.requestUpdate(name, oldValue, options);
 
     if (name === 'active' && this.active !== oldValue) {
       this.dispatchEvent(new Event('active-changed', { bubbles: true }));

package/components/localize/types/LocalizeMixinTypes.ts

@@ -58,7 +58,7 @@ export interface msgOptions {
   locale?: string;
 }
 
-declare class LocalizeMixinHost {
+export declare class LocalizeMixinHost {
   static get localizeNamespaces(): StringToFunctionMap[];
 
   static get waitForLocalizeNamespaces(): boolean;

package/components/overlays/src/OverlayMixin.js

@@ -58,12 +58,13 @@ export const OverlayMixinImplementation = superclass =>
     }
 
     /**
-     * @override
-     * @param {string} name
-     * @param {any} oldValue
+     * @param {string} [name]
+     * @param {unknown} [oldValue]
+     * @param {import('lit').PropertyDeclaration} [options]
+     * @returns {void}
      */
-    requestUpdate(name, oldValue) {
-      super.requestUpdate(name, oldValue);
+    requestUpdate(name, oldValue, options) {
+      super.requestUpdate(name, oldValue, options);
       if (name === 'opened' && this.opened !== oldValue) {
         this.dispatchEvent(new Event('opened-changed'));
       }