@linzjs/step-ag-grid 28.1.0 → 28.1.2

package/dist/src/utils/__tests__/testUtil.ts

@@ -135,8 +135,13 @@ export const findCellContains = async (
 };
 
 export const selectCell = async (rowId: string | number, colId: string, within?: HTMLElement): Promise<void> => {
-  const cell = await findCell(rowId, colId, within);
-  await user.click(cell);
+  await waitFor(
+    async () => {
+      const cell = await findCell(rowId, colId, within);
+      await user.click(cell);
+    },
+    { timeout: 10000 },
+  );
 };
 
 export const editCell = async (rowId: number | string, colId: string, within?: HTMLElement): Promise<void> => {
@@ -200,7 +205,7 @@ export const openAndClickMenuOption = async (
   menuOptionText: string | RegExp,
   within?: HTMLElement,
 ): Promise<void> => {
-  await editCell(rowId, colId, within);
+  await selectCell(rowId, colId, within);
   await clickMenuOption(menuOptionText);
 };
 

package/dist/step-ag-grid.cjs

@@ -2756,6 +2756,30 @@ const usePostSortRowsHook = ({ setStaleGrid }) => {
 };
 
 agGridCommunity.ModuleRegistry.registerModules([agGridCommunity.AllCommunityModule]);
+let timeOfLastSingleClick = 0;
+let lastClickColId;
+let lastClickRowIndex;
+const resetClickDebounce = () => {
+    timeOfLastSingleClick = 0;
+    lastClickColId = '';
+    lastClickRowIndex = -1;
+};
+/**
+ * If click is more than 200ms since last click return true.
+ */
+const clickDebounceSkipClick = (colId, rowIndex) => {
+    const doubleClickMs = 200;
+    if (Date.now() - timeOfLastSingleClick < doubleClickMs &&
+        lastClickColId === colId &&
+        lastClickRowIndex === rowIndex) {
+        // Skipping double click due to single click edit
+        return true;
+    }
+    timeOfLastSingleClick = Date.now();
+    lastClickColId = colId;
+    lastClickRowIndex = rowIndex;
+    return false;
+};
 /**
  * Wrapper for AgGrid to add commonly used functionality.
  */
@@ -2994,6 +3018,11 @@ const Grid = ({ 'data-testid': dataTestId, defaultPostSort = true, rowSelection
      * Handle double click edit
      */
     const onCellDoubleClick = React.useCallback((event) => {
+        if (clickDebounceSkipClick(event.colDef.colId, event.rowIndex)) {
+            // the next click will be a single click, we want it to pass
+            resetClickDebounce();
+            return;
+        }
         const editable = fnOrVar(event.colDef?.editable, event);
         if (editable && !invokeEditAction(event)) {
             void startCellEditing({ rowId: event.data.id, colId: event.column.getColId() });
@@ -3005,6 +3034,9 @@ const Grid = ({ 'data-testid': dataTestId, defaultPostSort = true, rowSelection
     const onCellClicked = React.useCallback((event) => {
         const editable = fnOrVar(event.colDef?.editable, event);
         if ((editable && event.colDef.singleClickEdit) ?? singleClickEdit) {
+            if (clickDebounceSkipClick(event.colDef.colId, event.rowIndex)) {
+                return;
+            }
             void startCellEditing({ rowId: event.data.id, colId: event.column.getColId() });
         }
     }, [singleClickEdit, startCellEditing]);