@linzjs/step-ag-grid 26.1.0 → 27.1.0

package/dist/step-ag-grid.esm.js

@@ -2064,7 +2064,7 @@ const ControlledMenuFr = ({ 'aria-label': ariaLabel, className, containerProps,
                 }
                 break;
         }
-    }, [anchorRef, saveButtonRef]);
+    }, [anchorRef, onClose, saveButtonRef]);
     const handleKeydownTabAndEnter = useMemo(() => handleKeyboardTabAndEnter(true), [handleKeyboardTabAndEnter]);
     const handleKeyupTabAndEnter = useMemo(() => handleKeyboardTabAndEnter(false), [handleKeyboardTabAndEnter]);
     useEffect(() => {
@@ -2937,14 +2937,15 @@ const Grid = ({ 'data-testid': dataTestId, defaultPostSort = true, rowSelection
             };
         });
     }, [params.columnDefs, params.loading, params.readOnly, params.defaultColDef?.editable]);
+    const hasExternallySelectedItems = !!params.setExternalSelectedItems;
     /**
      * When grid is ready set the apis to the grid context and sync selected items to grid.
      */
     const onGridReady = useCallback((event) => {
-        setApis(event.api, dataTestId);
+        setApis(event.api, hasExternallySelectedItems, dataTestId);
         event.api.showNoRowsOverlay();
         synchroniseExternallySelectedItemsToGrid();
-    }, [dataTestId, setApis, synchroniseExternallySelectedItemsToGrid]);
+    }, [dataTestId, hasExternallySelectedItems, setApis, synchroniseExternallySelectedItemsToGrid]);
     /**
      * When the grid is being initialized the data may be empty.
      * This will resize columns when we have at least one row.
@@ -2997,7 +2998,7 @@ const Grid = ({ 'data-testid': dataTestId, defaultPostSort = true, rowSelection
      * Handle single click edits
      */
     const onCellClicked = useCallback((event) => {
-        if (event.colDef?.cellRendererParams?.singleClickEdit ?? singleClickEdit) {
+        if (event.colDef.singleClickEdit ?? singleClickEdit) {
             void startCellEditing({ rowId: event.data.id, colId: event.column.getColId() });
         }
     }, [singleClickEdit, startCellEditing]);
@@ -4986,11 +4987,9 @@ const GridPopoverMenu = (colDef, custom) => GridCell({
     exportable: false,
     cellStyle: { flex: 1, justifyContent: 'center' },
     cellRenderer: GridRenderPopoutMenuCell,
+    // Menus open on single click, this parameter is picked up in Grid.tsx
+    singleClickEdit: true,
     ...colDef,
-    cellRendererParams: {
-        // Menus open on single click, this parameter is picked up in Grid.tsx
-        singleClickEdit: true,
-    },
 }, {
     editor: GridFormPopoverMenu,
     preventAutoEdit: true,
@@ -5000,10 +4999,7 @@ const GridPopoverMenu = (colDef, custom) => GridCell({
 const GridPopoverMessage = (colDef, props) => GridCell({
     resizable: true,
     ...colDef,
-    cellRendererParams: {
-        singleClickEdit: true,
-        ...colDef.cellRendererParams,
-    },
+    singleClickEdit: true,
 }, {
     editor: GridFormMessage,
     ...props,
@@ -5033,6 +5029,7 @@ const GridContextProvider = (props) => {
     const [quickFilter, _setQuickFilter] = useState('');
     const [invisibleColumnIds, _setInvisibleColumnIds] = useState();
     const testId = useRef();
+    const hasExternallySelectedItemsRef = useRef(false);
     const idsBeforeUpdate = useRef([]);
     const prePopupFocusedCell = useRef();
     const [externallySelectedItemsAreInSync, setExternallySelectedItemsAreInSync] = useState(false);
@@ -5096,7 +5093,8 @@ const GridContextProvider = (props) => {
     /**
      * Set the grid api when the grid is ready.
      */
-    const setApis = useCallback((gridApi, dataTestId) => {
+    const setApis = useCallback((gridApi, hasExternallySelectedItems, dataTestId) => {
+        hasExternallySelectedItemsRef.current = hasExternallySelectedItems;
         testId.current = dataTestId;
         setGridApi(gridApi);
         gridApi?.setGridOption('quickFilterText', quickFilter);
@@ -5350,10 +5348,17 @@ const GridContextProvider = (props) => {
         externallySelectedItemsAreInSyncRef.current = externallySelectedItemsAreInSync;
     }, [externallySelectedItemsAreInSync]);
     const waitForExternallySelectedItemsToBeInSync = useCallback(async () => {
+        if (!hasExternallySelectedItemsRef.current) {
+            externallySelectedItemsAreInSyncRef.current = true;
+            return;
+        }
         // Wait for up to 5 seconds
         for (let i = 0; i < 5000 / 200 && !externallySelectedItemsAreInSyncRef.current; i++) {
             await wait(200);
         }
+        if (!externallySelectedItemsAreInSyncRef.current) {
+            console.error('externallySelectedItems did not sync with ag-grid selection');
+        }
     }, []);
     const startCellEditing = useCallback(async ({ rowId, colId }) => {
         if (!gridApi)