@linzjs/step-ag-grid 14.3.0 → 14.3.2

package/package.json

@@ -2,7 +2,7 @@
   "name": "@linzjs/step-ag-grid",
   "repository": "github:linz/step-ag-grid.git",
   "license": "MIT",
-  "version": "14.3.0",
+  "version": "14.3.2",
   "keywords": [
     "aggrid",
     "ag-grid",

package/src/components/Grid.tsx

@@ -82,7 +82,7 @@ export const Grid = ({
   suppressColumnVirtualization = true,
   theme = "ag-theme-alpine",
   sizeColumns = "auto",
-  selectColumnPinned = "left",
+  selectColumnPinned = null,
   ...params
 }: GridProps): JSX.Element => {
   const {

package/src/contexts/GridContextProvider.tsx

@@ -411,36 +411,29 @@ export const GridContextProvider = <RowType extends GridBaseRow>(props: GridCont
         );
       };
 
-      let foundEditableCell = false;
-
       // Just in case I've missed something, we don't want the loop to hang everything
-      let maxIterations = 50;
-      let preRow: CellPosition | null = null;
-      let postRow: CellPosition | null = null;
-      do {
-        preRow = gridApi.getFocusedCell();
+      for (let maxIterations = 0; maxIterations < 50; maxIterations++) {
+        const preRow = gridApi.getFocusedCell();
         tabDirection === 1 ? gridApi.tabToNextCell() : gridApi.tabToPreviousCell();
-        postRow = gridApi.getFocusedCell();
-        foundEditableCell = focusedCellIsEditable();
-      } while (
-        preRow?.rowIndex === postRow?.rowIndex &&
-        preRow?.column !== postRow?.column &&
-        !foundEditableCell &&
-        maxIterations-- > 0
-      );
-
-      if (foundEditableCell) {
-        prePopupOps();
-        const focusedCell = gridApi?.getFocusedCell();
-        if (focusedCell) {
-          gridApi.startEditingCell({
-            rowIndex: focusedCell.rowIndex,
-            colKey: focusedCell.column.getColId(),
-          });
-          return false;
+        const postRow = gridApi.getFocusedCell();
+        if (preRow?.rowIndex !== postRow?.rowIndex || preRow?.column === postRow?.column) {
+          // We didn't find an editable cell in the same row, or the cell column didn't change
+          // implying it was start/end of grid
+          break;
+        }
+        if (focusedCellIsEditable()) {
+          const focusedCell = gridApi?.getFocusedCell();
+          if (focusedCell) {
+            prePopupOps();
+            gridApi.startEditingCell({
+              rowIndex: focusedCell.rowIndex,
+              colKey: focusedCell.column.getColId(),
+            });
+            return true;
+          }
         }
       }
-      return true;
+      return false;
     },
     [gridApi, prePopupOps],
   );
@@ -494,7 +487,7 @@ export const GridContextProvider = <RowType extends GridBaseRow>(props: GridCont
           prePopupFocusedCell.current.rowIndex == postPopupFocusedCell.rowIndex &&
           prePopupFocusedCell.current.column.getColId() == postPopupFocusedCell.column.getColId()
         ) {
-          if (!tabDirection || selectNextEditableCell(tabDirection)) {
+          if (!tabDirection || !selectNextEditableCell(tabDirection)) {
             cellEditingCompleteCallbackRef.current && cellEditingCompleteCallbackRef.current();
           }
         }