@linxin666/dsh-pet 0.3.25 → 0.4.3

package/lib/types/mount-once.js

@@ -5,38 +5,122 @@
  * the loader accepts a standalone install of the same package side by side;
  * without this guard the second instance would still re-register the same
  * webserver routes, tools, settings namespaces, and system-prompt sections
- * and fail the boot. mountOnce makes the second host apply a no-op for the
- * lifetime of the first instance (the browser half is already deduped by
- * package name in the client module host).
+ * and fail the boot. mountOnce makes a mount of an already-mounted package a
+ * no-op for as long as the first instance lives (the browser half is already
+ * deduped by package name in the client module host).
+ *
+ * A no-op is only safe while the holder is ALIVE. The holder can be disposed
+ * long after the refused mount ran its course: the Host reloads a profile by
+ * creating the new loader entries before the old ones are torn down (a
+ * plugin-manager enable/disable/install write, a settings-driven row reload,
+ * HMR), so the new aggregate shell entry mounts its family plugin while the
+ * previous entry still owns the name. Dropping that refused mount lost the
+ * plugin for good - the previous entry then disposed its own mount, releasing
+ * the name with nobody left to take it, and the family row stayed listed as
+ * active while its host routes 404ed (the task-board panel showed
+ * "board.hostError.notMounted", no degraded record appeared, and only a Host
+ * restart recovered it).
+ *
+ * The refused mount is therefore QUEUED, not dropped, and replayed the moment
+ * the holder releases the name - if the waiting fiber is still alive then. The
+ * single-instance guarantee is unchanged: exactly one mount is live per
+ * package name, and the replay re-enters the guard so a later mount still
+ * dedupes against it.
  *
  * The registry rides a global symbol so two module instances of the same
- * package (npm copy vs repository link) still share one verdict. cordis
- * `ctx.effect` runs its callback immediately and treats the callback's
+ * package (npm copy vs repository link) still share one verdict. That symbol
+ * is a CROSS-REPOSITORY contract, not this file's private state: the four
+ * satellite packages (dsh-skins / dsh-pet / dsh-presets /
+ * dsh-community-plugins) are separate repositories carrying their own copy of
+ * this guard, rebuilt on their own schedule, so the value under `MOUNTED`
+ * must keep the shape every published copy reads (a `Set` of package names
+ * with `has`/`add`/`delete`). The wait queues this guard added therefore live
+ * under their own additive key, and the registry reads back a `Set` even when
+ * some other build left a different value there. Changing `MOUNTED`'s shape
+ * in place broke that contract once: a satellite's legacy copy created a
+ * `Set`, the family's new copy read it as a `Map`, and every family row
+ * mounted after it failed with "claims.get is not a function".
+ *
+ * cordis `ctx.effect` runs its callback immediately and treats the callback's
  * return value as the fiber disposer, so the unmarker is returned, not run.
  */
+/** Published cross-repository contract: package names currently mounted. */
 const MOUNTED = Symbol.for('dsh-web.mounted-plugins');
+/** Additive key this guard owns: refused mounts waiting for the name. */
+const WAITERS = Symbol.for('dsh-web.mounted-plugins.waiters');
+/**
+ * The shared name registry, always a `Set` whatever another build stored here:
+ * a foreign value (an interim shape, a hand-written global) must not take every
+ * family plugin down with it.
+ * @returns the process-wide set of mounted package names.
+ */
 function mountedSet() {
     const registry = globalThis;
-    return (registry[MOUNTED] ??= new Set());
+    const existing = registry[MOUNTED];
+    if (existing instanceof Set)
+        return existing;
+    const created = new Set();
+    registry[MOUNTED] = created;
+    return created;
+}
+/** Queue per package name for mounts refused while a holder was alive. */
+function mountWaiters() {
+    const registry = globalThis;
+    return (registry[WAITERS] ??= new Map());
 }
 /**
  * Wrap a cordis plugin apply so the package runs at most once per process.
- * The first mount registers normally and unmarks when its fiber disposes;
- * any later mount of the same package name is a no-op.
+ * The first mount registers normally and releases the name when its fiber
+ * disposes; a mount refused while that name is held waits for the release and
+ * then runs, unless its own fiber disposes first.
  * @param packageName - npm package identity shared by every install source.
  * @param fn - the original plugin apply.
  * @returns an apply of the same shape.
  */
 export function mountOnce(packageName, fn) {
-    return ((...args) => {
+    const mount = (...args) => {
         const mounted = mountedSet();
-        if (mounted.has(packageName))
+        const ctx = args[0];
+        if (mounted.has(packageName)) {
+            // Another fiber (the aggregate row, a standalone install, or a copy built
+            // from an older revision of this guard) owns the name. Queue instead of
+            // dropping: dropping lost the plugin for the rest of the process when the
+            // holder was disposed by a reload.
+            const waiters = mountWaiters();
+            const queue = waiters.get(packageName) ?? [];
+            let alive = true;
+            const pending = {
+                run: () => {
+                    if (alive)
+                        mount(...args);
+                },
+            };
+            // A fiber that dies while it waits must not be replayed afterwards: its
+            // context is disposed and registering effects on it would throw.
+            ctx?.effect?.(() => () => {
+                alive = false;
+                const index = queue.indexOf(pending);
+                if (index >= 0)
+                    queue.splice(index, 1);
+            });
+            queue.push(pending);
+            waiters.set(packageName, queue);
             return;
+        }
         mounted.add(packageName);
-        const ctx = args[0];
         ctx?.effect?.(() => () => {
             mounted.delete(packageName);
+            const waiters = mountWaiters();
+            const queue = waiters.get(packageName);
+            if (queue === undefined)
+                return;
+            waiters.delete(packageName);
+            // Defer the handover one microtask so the disposing mount's own effects
+            // (routes, ledger, timers) are torn down before the next one registers.
+            for (const waiter of queue.splice(0))
+                queueMicrotask(() => { waiter.run(); });
         });
         return fn(...args);
-    });
+    };
+    return mount;
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@linxin666/dsh-pet",
   "description": "Multi-pet companion plugin for the dsh web GUI: a registry-driven floating pet that reacts to model activity, with per-pet naming, petting/feeding interactions and an affinity score",
-  "version": "0.3.25",
+  "version": "0.4.3",
   "publishConfig": {
     "access": "public"
   },

package/src/client/PetSettingsCard.test.tsx

@@ -1,7 +1,16 @@
 // @vitest-environment jsdom
-import { afterEach, describe, expect, it, vi } from 'vitest'
+/**
+ * The pet settings card under the aggregate shell, which serves no Host
+ * settings form for the 'pet' namespace: the pet choice and its visibility
+ * switch both write through the pet API, so the pet can still be turned off
+ * when the Host form is absent.
+ */
+import { afterEach, beforeAll, describe, expect, it, vi } from 'vitest'
+import { cleanup, render, screen } from '@testing-library/react'
+import { useSyncExternalStore } from 'react'
 import type { ConfigForm } from '@deepseek-ai/dsh-client-ui-settings/client'
-import { PetSettingsCardController, type PetSettings } from './PetSettingsCard.tsx'
+import { PetSettingsCard, PetSettingsCardController, type PetSettings } from './PetSettingsCard.tsx'
+import { t } from './locales.ts'
 
 vi.mock('@deepseek-ai/dsh-client-store', () => ({ // test-standards-allow: the SDK client bundle is a browser module factory and cannot be imported by Vitest
   createSnapshotStore: (initial: unknown) => {
@@ -32,7 +41,12 @@ function response(value: unknown, ok = true): Response {
   return { ok, status: ok ? 200 : 500, json: async () => value } as Response
 }
 
+beforeAll(() => {
+  document.documentElement.lang = 'zh'
+})
+
 afterEach(() => {
+  cleanup()
   vi.useRealTimers()
   vi.unstubAllGlobals()
 })
@@ -46,7 +60,6 @@ describe('pet selection without a Host settings form', () => {
     const fetch = vi.fn(async (input: RequestInfo | URL, init?: RequestInit) => {
       const path = String(input)
       if (path === '/api/pet/pets') return response([{ id: 'whale-girl', displayName: '鲸鱼娘' }, { id: 'jyn', displayName: '女仆鲸鱼娘' }])
-      if (path === '/api/pet/diagnostics') return response({ diagnostics: [] })
       if (path === '/api/pet/state') return response({ pet: { id: selected } })
       if (path === '/api/pet/set-pet') {
         selected = JSON.parse(String(init?.body)).petId as string
@@ -84,7 +97,6 @@ describe('pet selection without a Host settings form', () => {
     vi.stubGlobal('fetch', vi.fn(async (input: RequestInfo | URL) => {
       const path = String(input)
       if (path === '/api/pet/pets') return response([{ id: 'whale-girl', displayName: '鲸鱼娘' }, { id: 'jyn', displayName: '女仆鲸鱼娘' }])
-      if (path === '/api/pet/diagnostics') return response({ diagnostics: [] })
       if (path === '/api/pet/state') return response({ pet: { id: 'whale-girl' } })
       if (path === '/api/pet/set-pet') return response({ ok: false, error: 'unknown-pet' })
       throw new Error('unexpected request: ' + path)
@@ -101,3 +113,102 @@ describe('pet selection without a Host settings form', () => {
     controller.dispose()
   })
 })
+
+describe('pet visibility without a Host settings form', () => {
+  it('user turns the pet off through its persisted API and confirms the read-back', async () => {
+    // Given the aggregate shell exposes no pet configuration form and the pet is showing
+    vi.useFakeTimers()
+    const { scope, mutate } = unavailableForm()
+    let visible = true
+    const fetch = vi.fn(async (input: RequestInfo | URL, init?: RequestInit) => {
+      const path = String(input)
+      if (path === '/api/pet/pets') return response([{ id: 'whale-girl', displayName: '鲸鱼娘' }])
+      if (path === '/api/pet/state') return response({ pet: { id: 'whale-girl' }, display: { visible } })
+      if (path === '/api/pet/set-visible') {
+        visible = JSON.parse(String(init?.body)).visible as boolean
+        return response({ ok: true, display: { visible } })
+      }
+      throw new Error('unexpected request: ' + path)
+    })
+    vi.stubGlobal('fetch', fetch)
+    const controller = new PetSettingsCardController(scope)
+    await vi.advanceTimersByTimeAsync(0)
+    const face = controller.inject()
+    const state = () => face.hooks.petSettingsCard.getSnapshot()
+
+    // When the user switches the pet off and clicks Save
+    expect(state()).toMatchObject({ petSelectionFallback: true, visible: { text: 'true' }, dirty: false })
+    face.edit('visible', 'false')
+    expect(state()).toMatchObject({ dirty: true, visible: { text: 'false' } })
+    face.save()
+    await vi.waitFor(() => { expect(state().saving).toBe(false) })
+
+    // Then the pet service holds it, the draft clears, and the absent Host form is untouched
+    expect(visible).toBe(false)
+    expect(state()).toMatchObject({ dirty: false, failed: false, visible: { text: 'false' } })
+    expect(mutate).not.toHaveBeenCalled()
+    expect(fetch).toHaveBeenCalledWith('/api/pet/set-visible', expect.objectContaining({ body: JSON.stringify({ visible: false }) }))
+    controller.dispose()
+  })
+
+  it('user keeps the draft when the pet API refuses the visibility write', async () => {
+    // Given the Host has no pet form and the pet API refuses visibility writes
+    vi.useFakeTimers()
+    const { scope } = unavailableForm()
+    vi.stubGlobal('fetch', vi.fn(async (input: RequestInfo | URL) => {
+      const path = String(input)
+      if (path === '/api/pet/pets') return response([{ id: 'whale-girl', displayName: '鲸鱼娘' }])
+      if (path === '/api/pet/state') return response({ pet: { id: 'whale-girl' }, display: { visible: true } })
+      if (path === '/api/pet/set-visible') return response({ ok: false }, false)
+      throw new Error('unexpected request: ' + path)
+    }))
+    const controller = new PetSettingsCardController(scope)
+    await vi.advanceTimersByTimeAsync(0)
+    const face = controller.inject()
+    // When the user saves a visibility the pet API refuses
+    face.edit('visible', 'false')
+    face.save()
+    await vi.waitFor(() => { expect(face.hooks.petSettingsCard.getSnapshot().saving).toBe(false) })
+    // Then the switch keeps the draft and the failure is visible
+    expect(face.hooks.petSettingsCard.getSnapshot()).toMatchObject({ dirty: true, failed: true, visible: { text: 'false' } })
+    controller.dispose()
+  })
+})
+
+describe('pet settings card rendered without a Host settings form', () => {
+  it('shows the visibility switch beside the pet choice and hides the Host-only fields', async () => {
+    // Given the aggregate shell exposes no pet configuration form
+    vi.useFakeTimers()
+    const { scope } = unavailableForm()
+    vi.stubGlobal('fetch', vi.fn(async (input: RequestInfo | URL) => {
+      const path = String(input)
+      if (path === '/api/pet/pets') return response([{ id: 'whale-girl', displayName: '鲸鱼娘' }])
+      if (path === '/api/pet/state') return response({ pet: { id: 'whale-girl' }, display: { visible: true } })
+      throw new Error('unexpected request: ' + path)
+    }))
+    const controller = new PetSettingsCardController(scope)
+    await vi.advanceTimersByTimeAsync(0)
+    const face = controller.inject()
+    const store = face.hooks.petSettingsCard
+
+    // When the card renders
+    render(
+      <PetSettingsCard
+        t={t}
+        usePetSettingsCard={select => useSyncExternalStore(store.subscribe, () => select(store.getSnapshot()))}
+        save={face.save}
+        discard={face.discard}
+        edit={face.edit}
+        resetField={face.resetField}
+      />,
+    )
+
+    // Then the pet choice and the switch that turns the pet off are both on screen
+    expect(screen.getByLabelText(t('settings.pet'))).toBeTruthy()
+    expect(screen.getByLabelText(t('settings.visible'))).toBeTruthy()
+    // ...while the fields only the absent Host form owns stay hidden
+    expect(screen.queryByLabelText(t('settings.enabled'))).toBeNull()
+    expect(screen.queryByLabelText(t('settings.size'))).toBeNull()
+    controller.dispose()
+  })
+})

package/src/client/PetSettingsCard.tsx

@@ -61,8 +61,6 @@ export interface PetSettingsCardState extends CardShell {
   decorationEnabled: CardFieldState
   /** Pet choices (registry ids + display names), loaded from the host. */
   petChoices: readonly { value: string; label: string }[]
-  /** Registry diagnostics (v1 migration hints, invalid entries), host-served. */
-  petDiagnostics: readonly PetDiagnosticView[]
 }
 
 /** The registration-side face the card's slot entry injects. */
@@ -79,12 +77,6 @@ interface PetChoice {
   displayName: string
 }
 
-/** One registry diagnostic as served by '/api/pet/diagnostics' (#623). */
-export interface PetDiagnosticView {
-  level: 'error' | 'warning'
-  message: string
-}
-
 /** Fetch the registry list (the same data the sprite renders from). */
 async function fetchPetChoices(): Promise<PetChoice[]> {
   const response = await fetch('/api/pet/pets')
@@ -92,21 +84,22 @@ async function fetchPetChoices(): Promise<PetChoice[]> {
   return (await response.json()) as PetChoice[]
 }
 
-/** Fetch the registry diagnostics (v1 migration hints, invalid entries). */
-async function fetchPetDiagnostics(): Promise<PetDiagnosticView[]> {
-  const response = await fetch('/api/pet/diagnostics')
-  if (!response.ok) throw new Error('pet diagnostics failed: ' + response.status)
-  const body = (await response.json()) as { diagnostics?: PetDiagnosticView[] }
-  return body.diagnostics ?? []
+/** The persisted state the fallback mirrors: the selection and its visibility. */
+interface PetState {
+  /** Selected registry id. */
+  petId: string
+  /** Whether the pet is currently rendered. */
+  visible: boolean
 }
 
-/** Read the selection from the same persisted state the pet renders. */
-async function fetchSelectedPetId(): Promise<string> {
+/** Read the selection and visibility from the same persisted state the pet renders. */
+async function fetchPetState(): Promise<PetState> {
   const response = await fetch('/api/pet/state')
   if (!response.ok) throw new Error('pet state failed: ' + response.status)
-  const body = (await response.json()) as { pet?: { id?: unknown } }
+  const body = (await response.json()) as { pet?: { id?: unknown }; display?: { visible?: unknown } }
   if (typeof body.pet?.id !== 'string') throw new Error('pet state has no selected pet')
-  return body.pet.id
+  // A Host without the display block predates the visibility switch; the pet shows.
+  return { petId: body.pet.id, visible: body.display?.visible !== false }
 }
 
 /** Bridges the 'pet' scope onto the card's staged form. */
@@ -118,9 +111,10 @@ export class PetSettingsCardController {
   // without rebuilding the form.
   private readonly petChoices: string[] = []
   private readonly petLabels = new Map<string, string>()
-  private diagnostics: PetDiagnosticView[] = []
   private selectedPetId: string | undefined
+  private selectedVisible: boolean | undefined
   private stagedPetId: string | undefined
+  private stagedVisible: boolean | undefined
   private savingPet = false
   private petSaveFailed = false
   private loaded = false
@@ -150,22 +144,10 @@ export class PetSettingsCardController {
       this.pendingTimer = undefined
       if (this.disposed) return
       void this.loadPets()
-      void this.loadDiagnostics()
-      void this.loadSelectedPet()
+      void this.loadPetState()
     }, 0)
   }
 
-  /** Fetch registry diagnostics once (soft-fail: an empty list on error). */
-  private async loadDiagnostics(): Promise<void> {
-    try {
-      this.diagnostics = await fetchPetDiagnostics()
-      if (this.disposed) return
-      this.store.set(this.projection())
-    } catch {
-      this.diagnostics = []
-    }
-  }
-
   /** Resolve the registry choices once (retried a few times on failure). */
   private async loadPets(): Promise<void> {
     if (this.loaded || this.disposed) return
@@ -189,11 +171,12 @@ export class PetSettingsCardController {
     }
   }
 
-  private async loadSelectedPet(): Promise<void> {
+  private async loadPetState(): Promise<void> {
     try {
-      const petId = await fetchSelectedPetId()
+      const state = await fetchPetState()
       if (this.disposed) return
-      this.selectedPetId = petId
+      this.selectedPetId = state.petId
+      this.selectedVisible = state.visible
       this.store.set(this.projection())
     } catch {
       // The Host form remains the authority when it is available. An absent
@@ -206,24 +189,58 @@ export class PetSettingsCardController {
     return shell.available && !shell.exposed && this.selectedPetId !== undefined
   }
 
-  private async savePetSelection(): Promise<void> {
+  /**
+   * The visibility the fallback switch renders: the staged draft when the user
+   * moved it, the persisted value otherwise. There is no user layer to override
+   * here, so the field is never marked overridden.
+   */
+  private fallbackVisible(): CardFieldState {
+    const value = this.stagedVisible ?? this.selectedVisible
+    return { text: value === undefined ? '' : String(value), overridden: false, invalid: false }
+  }
+
+  /**
+   * Persist the staged selection and visibility through the pet API — the only
+   * writer available when the aggregate shell serves this card, since there is
+   * no Host settings form to mutate — then confirm the read-back before the
+   * drafts are cleared.
+   */
+  private async saveFallback(): Promise<void> {
     const petId = this.stagedPetId
-    if (petId === undefined || this.savingPet || !this.petChoices.includes(petId)) return
+    const visible = this.stagedVisible
+    if (this.savingPet) return
+    if (petId === undefined && visible === undefined) return
+    if (petId !== undefined && !this.petChoices.includes(petId)) return
     this.savingPet = true
     this.petSaveFailed = false
     this.store.set(this.projection())
     try {
-      const response = await fetch('/api/pet/set-pet', {
-        method: 'POST',
-        headers: { 'content-type': 'application/json' },
-        body: JSON.stringify({ petId }),
-      })
-      const result = (await response.json()) as { ok?: boolean; petId?: string }
-      if (!response.ok || result.ok !== true || result.petId !== petId || await fetchSelectedPetId() !== petId) {
-        throw new Error('pet selection was not persisted')
+      if (petId !== undefined) {
+        const response = await fetch('/api/pet/set-pet', {
+          method: 'POST',
+          headers: { 'content-type': 'application/json' },
+          body: JSON.stringify({ petId }),
+        })
+        const result = (await response.json()) as { ok?: boolean; petId?: string }
+        if (!response.ok || result.ok !== true || result.petId !== petId) {
+          throw new Error('pet selection was not persisted')
+        }
       }
-      this.selectedPetId = petId
+      if (visible !== undefined) {
+        const response = await fetch('/api/pet/set-visible', {
+          method: 'POST',
+          headers: { 'content-type': 'application/json' },
+          body: JSON.stringify({ visible }),
+        })
+        if (!response.ok) throw new Error('pet visibility was not persisted')
+      }
+      const persisted = await fetchPetState()
+      if (petId !== undefined && persisted.petId !== petId) throw new Error('pet selection was not persisted')
+      if (visible !== undefined && persisted.visible !== visible) throw new Error('pet visibility was not persisted')
+      this.selectedPetId = persisted.petId
+      this.selectedVisible = persisted.visible
       if (this.stagedPetId === petId) this.stagedPetId = undefined
+      if (this.stagedVisible === visible) this.stagedVisible = undefined
     } catch {
       this.petSaveFailed = true
     } finally {
@@ -241,7 +258,8 @@ export class PetSettingsCardController {
       ...(fallback ? {
         exposed: true,
         writable: true,
-        dirty: this.stagedPetId !== undefined && this.stagedPetId !== this.selectedPetId,
+        dirty: this.stagedPetId !== undefined && this.stagedPetId !== this.selectedPetId
+          || this.stagedVisible !== undefined && this.stagedVisible !== this.selectedVisible,
         invalid: this.stagedPetId !== undefined && !this.petChoices.includes(this.stagedPetId),
         saving: this.savingPet,
         failed: this.petSaveFailed,
@@ -250,7 +268,7 @@ export class PetSettingsCardController {
       petSelectionFallback: fallback,
       enabled: this.form.field('enabled'),
       decorationEnabled: this.form.field('decorationEnabled'),
-      visible: this.form.field('visible'),
+      visible: fallback ? this.fallbackVisible() : this.form.field('visible'),
       size: this.form.field('size'),
       right: this.form.field('right'),
       bottom: this.form.field('bottom'),
@@ -261,7 +279,6 @@ export class PetSettingsCardController {
           ? { ...configuredPet, text: this.selectedPetId }
           : configuredPet,
       petChoices: this.petChoices.map(id => ({ value: id, label: this.petLabels.get(id) ?? id })),
-      petDiagnostics: this.diagnostics,
     }
   }
 
@@ -275,22 +292,25 @@ export class PetSettingsCardController {
       hooks: { petSettingsCard: this.store },
       edit: (field, value) => {
         if (!this.fallback()) return actions.edit(field, value)
-        if (field !== 'petId') return
-        this.stagedPetId = value === '' ? undefined : value
+        if (field === 'petId') this.stagedPetId = value === '' ? undefined : value
+        else if (field === 'visible') this.stagedVisible = value === '' ? undefined : value === 'true'
+        else return
         this.petSaveFailed = false
         this.store.set(this.projection())
       },
       resetField: (field) => {
         if (!this.fallback()) return actions.resetField(field)
-        if (field !== 'petId') return
-        this.stagedPetId = undefined
+        if (field === 'petId') this.stagedPetId = undefined
+        else if (field === 'visible') this.stagedVisible = undefined
+        else return
         this.petSaveFailed = false
         this.store.set(this.projection())
       },
-      save: () => { if (this.fallback()) void this.savePetSelection(); else actions.save() },
+      save: () => { if (this.fallback()) void this.saveFallback(); else actions.save() },
       discard: () => {
         if (!this.fallback()) return actions.discard()
         this.stagedPetId = undefined
+        this.stagedVisible = undefined
         this.petSaveFailed = false
         this.store.set(this.projection())
       },
@@ -378,17 +398,7 @@ export function PetSettingsCard(props: PetSettingsCardProps) {
         onEdit={(text) => { props.edit('petId', text) }}
         onReset={() => { props.resetField('petId') }}
       />
-      {state.petDiagnostics.length === 0 ? null : (
-        <li className={sectionCss.diagnostics} data-dsh-part="diagnostics">
-          <span className={sectionCss.diagnosticsTitle}>{t('settings.diagnosticsTitle')}</span>
-          <ul>
-            {state.petDiagnostics.map((diagnostic, index) => (
-              <li key={index} data-level={diagnostic.level}>{diagnostic.message}</li>
-            ))}
-          </ul>
-        </li>
-      )}
-      {state.petSelectionFallback ? null : <BooleanField
+      <BooleanField
         id="settings-pet-visible"
         label={t('settings.visible')}
         hint={t('settings.visibleHint')}
@@ -399,7 +409,7 @@ export function PetSettingsCard(props: PetSettingsCardProps) {
         {...state.visible}
         onEdit={(text) => { props.edit('visible', text) }}
         onReset={() => { props.resetField('visible') }}
-      />}
+      />
       {state.petSelectionFallback ? null : <ValueField
         id="settings-pet-size"
         label={t('settings.size')}

package/src/client/locales.ts

@@ -57,7 +57,6 @@ export const zh = {
   'pet.collapseSessions': '收起会话气泡',
   // 一级设置页（settings.section 席位）。
   'settings.title': '宠物',
-  'settings.diagnosticsTitle': '宠物目录诊断',
   'settings.description': '选择宠物并调整它的显示布局。',
   'settings.pet': '宠物',
   'settings.petHint': '选择显示哪只宠物；每只宠物独立命名，可在宠物悬浮面板改名。',
@@ -143,7 +142,6 @@ export const en = {
   'pet.collapseSessions': 'Collapse session bubbles',
   // First-level settings section (the `settings.section` seat).
   'settings.title': 'Pet',
-  'settings.diagnosticsTitle': 'Pet directory diagnostics',
   'settings.description': 'Pick a pet and tune its display layout.',
   'settings.pet': 'Pet',
   'settings.petHint': 'Choose which pet shows. Names are stored per pet; rename from the pet hover panel.',

package/src/client/pet-css.test.ts

@@ -2,6 +2,14 @@ import { readFileSync } from 'node:fs'
 import { describe, expect, it } from 'vitest'
 
 const css = readFileSync(new URL('./pet.module.css', import.meta.url), 'utf8')
+const settingsCss = readFileSync(new URL('./settings-section.module.css', import.meta.url), 'utf8')
+
+describe('pet settings section css', () => {
+  it('carries no leftover registry diagnostics block after its removal', () => {
+    expect(settingsCss).not.toContain('.diagnostics')
+    expect(settingsCss).toContain('.sectionList')
+  })
+})
 
 describe('pet bubble typography (#1549)', () => {
   it('scales the bubble text and padding from the sprite-supplied variable', () => {

package/src/client/settings-section.module.css

@@ -3,26 +3,3 @@
   margin: 0;
   padding: 0;
 }
-
-/* Registry diagnostics block (pet-center M2 P7, issue #623). */
-.diagnostics {
-  margin: 8px 0;
-  padding: 8px 12px;
-  border: 1px dashed var(--dsw-alias-border-l2);
-  border-radius: 8px;
-  font-size: 12px;
-  color: var(--dsw-alias-label-tertiary);
-}
-.diagnosticsTitle {
-  display: block;
-  font-weight: 600;
-  margin-bottom: 4px;
-  color: var(--dsw-alias-label-primary);
-}
-.diagnostics ul {
-  margin: 0;
-  padding-left: 16px;
-}
-.diagnostics li[data-level="error"] {
-  color: var(--dsw-alias-label-error, #c04848);
-}